2020-04-08 14:13:33 +05:30
|
|
|
import { mount } from '@vue/test-utils';
|
|
|
|
import { TEST_HOST } from 'helpers/test_constants';
|
|
|
|
import { trimText } from 'helpers/text_helper';
|
|
|
|
import Component from '~/diffs/components/commit_item.vue';
|
2021-03-11 19:13:27 +05:30
|
|
|
import { getTimeago } from '~/lib/utils/datetime_utility';
|
2020-04-08 14:13:33 +05:30
|
|
|
import CommitPipelineStatus from '~/projects/tree/components/commit_pipeline_status_component.vue';
|
|
|
|
import getDiffWithCommit from '../mock_data/diff_with_commit';
|
|
|
|
|
|
|
|
jest.mock('~/user_popovers');
|
|
|
|
|
|
|
|
const TEST_AUTHOR_NAME = 'test';
|
|
|
|
const TEST_AUTHOR_EMAIL = 'test+test@gitlab.com';
|
|
|
|
const TEST_AUTHOR_GRAVATAR = `${TEST_HOST}/avatar/test?s=40`;
|
|
|
|
const TEST_SIGNATURE_HTML = '<a>Legit commit</a>';
|
|
|
|
const TEST_PIPELINE_STATUS_PATH = `${TEST_HOST}/pipeline/status`;
|
2020-05-24 23:13:21 +05:30
|
|
|
const NEXT_COMMIT_URL = `${TEST_HOST}/?commit_id=next`;
|
|
|
|
const PREV_COMMIT_URL = `${TEST_HOST}/?commit_id=prev`;
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
describe('diffs/components/commit_item', () => {
|
|
|
|
let wrapper;
|
|
|
|
|
|
|
|
const timeago = getTimeago();
|
|
|
|
const { commit } = getDiffWithCommit();
|
|
|
|
|
|
|
|
const getTitleElement = () => wrapper.find('.commit-row-message.item-title');
|
|
|
|
const getDescElement = () => wrapper.find('pre.commit-row-description');
|
2020-11-24 15:15:51 +05:30
|
|
|
const getDescExpandElement = () => wrapper.find('.commit-content .js-toggle-button');
|
2021-01-03 14:25:43 +05:30
|
|
|
const getShaElement = () => wrapper.find('[data-testid="commit-sha-group"]');
|
2020-04-08 14:13:33 +05:30
|
|
|
const getAvatarElement = () => wrapper.find('.user-avatar-link');
|
|
|
|
const getCommitterElement = () => wrapper.find('.committer');
|
|
|
|
const getCommitActionsElement = () => wrapper.find('.commit-actions');
|
|
|
|
const getCommitPipelineStatus = () => wrapper.find(CommitPipelineStatus);
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
const getCommitNavButtonsElement = () => wrapper.find('.commit-nav-buttons');
|
|
|
|
const getNextCommitNavElement = () =>
|
|
|
|
getCommitNavButtonsElement().find('.btn-group > *:last-child');
|
|
|
|
const getPrevCommitNavElement = () =>
|
|
|
|
getCommitNavButtonsElement().find('.btn-group > *:first-child');
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
const mountComponent = (propsData) => {
|
2020-04-08 14:13:33 +05:30
|
|
|
wrapper = mount(Component, {
|
2020-04-22 19:07:51 +05:30
|
|
|
propsData: {
|
|
|
|
commit,
|
|
|
|
...propsData,
|
|
|
|
},
|
2020-04-08 14:13:33 +05:30
|
|
|
stubs: {
|
|
|
|
CommitPipelineStatus: true,
|
|
|
|
},
|
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
wrapper.destroy();
|
|
|
|
wrapper = null;
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('default state', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
mountComponent();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders commit title', () => {
|
|
|
|
const titleElement = getTitleElement();
|
|
|
|
|
|
|
|
expect(titleElement.attributes('href')).toBe(commit.commit_url);
|
|
|
|
expect(titleElement.text()).toBe(commit.title_html);
|
|
|
|
});
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
it('renders commit description', () => {
|
2020-04-08 14:13:33 +05:30
|
|
|
const descElement = getDescElement();
|
|
|
|
const descExpandElement = getDescExpandElement();
|
|
|
|
|
|
|
|
const expected = commit.description_html.replace(/
/g, '');
|
|
|
|
|
|
|
|
expect(trimText(descElement.text())).toEqual(trimText(expected));
|
|
|
|
expect(descExpandElement.exists()).toBe(true);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders commit sha', () => {
|
|
|
|
const shaElement = getShaElement();
|
2021-02-22 17:27:13 +05:30
|
|
|
const labelElement = shaElement.find('[data-testid="commit-sha-short-id"]');
|
2021-01-03 14:25:43 +05:30
|
|
|
const buttonElement = shaElement.find('button.input-group-text');
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
expect(labelElement.text()).toEqual(commit.short_id);
|
|
|
|
expect(buttonElement.props('text')).toBe(commit.id);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders author avatar', () => {
|
|
|
|
const avatarElement = getAvatarElement();
|
|
|
|
const imgElement = avatarElement.find('img');
|
|
|
|
|
|
|
|
expect(avatarElement.attributes('href')).toBe(commit.author.web_url);
|
|
|
|
expect(imgElement.classes()).toContain('s40');
|
|
|
|
expect(imgElement.attributes('alt')).toBe(commit.author.name);
|
|
|
|
expect(imgElement.attributes('src')).toBe(commit.author.avatar_url);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders committer text', () => {
|
|
|
|
const committerElement = getCommitterElement();
|
|
|
|
const nameElement = committerElement.find('a');
|
|
|
|
|
|
|
|
const expectTimeText = timeago.format(commit.authored_date);
|
|
|
|
const expectedText = `${commit.author.name} authored ${expectTimeText}`;
|
|
|
|
|
|
|
|
expect(trimText(committerElement.text())).toEqual(expectedText);
|
|
|
|
expect(nameElement.attributes('href')).toBe(commit.author.web_url);
|
|
|
|
expect(nameElement.text()).toBe(commit.author.name);
|
|
|
|
expect(nameElement.classes()).toContain('js-user-link');
|
|
|
|
expect(nameElement.attributes('data-user-id')).toEqual(commit.author.id.toString());
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('without commit description', () => {
|
|
|
|
beforeEach(() => {
|
2020-04-22 19:07:51 +05:30
|
|
|
mountComponent({ commit: { ...commit, description_html: '' } });
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
it('hides description', () => {
|
|
|
|
const descElement = getDescElement();
|
|
|
|
const descExpandElement = getDescExpandElement();
|
|
|
|
|
|
|
|
expect(descElement.exists()).toBeFalsy();
|
|
|
|
expect(descExpandElement.exists()).toBeFalsy();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('with no matching user', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
mountComponent({
|
|
|
|
commit: {
|
2020-04-22 19:07:51 +05:30
|
|
|
...commit,
|
2020-04-08 14:13:33 +05:30
|
|
|
author: null,
|
|
|
|
author_email: TEST_AUTHOR_EMAIL,
|
|
|
|
author_name: TEST_AUTHOR_NAME,
|
|
|
|
author_gravatar_url: TEST_AUTHOR_GRAVATAR,
|
|
|
|
},
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders author avatar', () => {
|
|
|
|
const avatarElement = getAvatarElement();
|
|
|
|
const imgElement = avatarElement.find('img');
|
|
|
|
|
|
|
|
expect(avatarElement.attributes('href')).toBe(`mailto:${TEST_AUTHOR_EMAIL}`);
|
|
|
|
expect(imgElement.attributes('alt')).toBe(TEST_AUTHOR_NAME);
|
|
|
|
expect(imgElement.attributes('src')).toBe(TEST_AUTHOR_GRAVATAR);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders committer text', () => {
|
|
|
|
const committerElement = getCommitterElement();
|
|
|
|
const nameElement = committerElement.find('a');
|
|
|
|
|
|
|
|
expect(nameElement.attributes('href')).toBe(`mailto:${TEST_AUTHOR_EMAIL}`);
|
|
|
|
expect(nameElement.text()).toBe(TEST_AUTHOR_NAME);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('with signature', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
mountComponent({
|
2020-04-22 19:07:51 +05:30
|
|
|
commit: { ...commit, signature_html: TEST_SIGNATURE_HTML },
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders signature html', () => {
|
|
|
|
const actionsElement = getCommitActionsElement();
|
|
|
|
|
|
|
|
expect(actionsElement.html()).toContain(TEST_SIGNATURE_HTML);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('with pipeline status', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
mountComponent({
|
2020-04-22 19:07:51 +05:30
|
|
|
commit: { ...commit, pipeline_status_path: TEST_PIPELINE_STATUS_PATH },
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders pipeline status', () => {
|
|
|
|
expect(getCommitPipelineStatus().exists()).toBe(true);
|
|
|
|
});
|
|
|
|
});
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
describe('without neighbor commits', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
mountComponent({ commit: { ...commit, prev_commit_id: null, next_commit_id: null } });
|
|
|
|
});
|
|
|
|
|
|
|
|
it('does not render any navigation buttons', () => {
|
|
|
|
expect(getCommitNavButtonsElement().exists()).toEqual(false);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('with neighbor commits', () => {
|
|
|
|
let mrCommit;
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
mrCommit = {
|
|
|
|
...commit,
|
|
|
|
next_commit_id: 'next',
|
|
|
|
prev_commit_id: 'prev',
|
|
|
|
};
|
|
|
|
|
|
|
|
mountComponent({ commit: mrCommit });
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders the commit navigation buttons', () => {
|
|
|
|
expect(getCommitNavButtonsElement().exists()).toEqual(true);
|
|
|
|
|
|
|
|
mountComponent({
|
|
|
|
commit: { ...mrCommit, next_commit_id: null },
|
|
|
|
});
|
|
|
|
expect(getCommitNavButtonsElement().exists()).toEqual(true);
|
|
|
|
|
|
|
|
mountComponent({
|
|
|
|
commit: { ...mrCommit, prev_commit_id: null },
|
|
|
|
});
|
|
|
|
expect(getCommitNavButtonsElement().exists()).toEqual(true);
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('prev commit', () => {
|
|
|
|
const { location } = window;
|
|
|
|
|
|
|
|
beforeAll(() => {
|
|
|
|
delete window.location;
|
|
|
|
window.location = { href: `${TEST_HOST}?commit_id=${mrCommit.id}` };
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
jest.spyOn(wrapper.vm, 'moveToNeighboringCommit').mockImplementation(() => {});
|
|
|
|
});
|
|
|
|
|
|
|
|
afterAll(() => {
|
|
|
|
window.location = location;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('uses the correct href', () => {
|
|
|
|
const link = getPrevCommitNavElement();
|
|
|
|
|
|
|
|
expect(link.element.getAttribute('href')).toEqual(PREV_COMMIT_URL);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('triggers the correct Vuex action on click', () => {
|
|
|
|
const link = getPrevCommitNavElement();
|
|
|
|
|
|
|
|
link.trigger('click');
|
|
|
|
return wrapper.vm.$nextTick().then(() => {
|
|
|
|
expect(wrapper.vm.moveToNeighboringCommit).toHaveBeenCalledWith({
|
|
|
|
direction: 'previous',
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders a disabled button when there is no prev commit', () => {
|
|
|
|
mountComponent({ commit: { ...mrCommit, prev_commit_id: null } });
|
|
|
|
|
|
|
|
const button = getPrevCommitNavElement();
|
|
|
|
|
|
|
|
expect(button.element.tagName).toEqual('BUTTON');
|
|
|
|
expect(button.element.hasAttribute('disabled')).toEqual(true);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('next commit', () => {
|
|
|
|
const { location } = window;
|
|
|
|
|
|
|
|
beforeAll(() => {
|
|
|
|
delete window.location;
|
|
|
|
window.location = { href: `${TEST_HOST}?commit_id=${mrCommit.id}` };
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
jest.spyOn(wrapper.vm, 'moveToNeighboringCommit').mockImplementation(() => {});
|
|
|
|
});
|
|
|
|
|
|
|
|
afterAll(() => {
|
|
|
|
window.location = location;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('uses the correct href', () => {
|
|
|
|
const link = getNextCommitNavElement();
|
|
|
|
|
|
|
|
expect(link.element.getAttribute('href')).toEqual(NEXT_COMMIT_URL);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('triggers the correct Vuex action on click', () => {
|
|
|
|
const link = getNextCommitNavElement();
|
|
|
|
|
|
|
|
link.trigger('click');
|
|
|
|
return wrapper.vm.$nextTick().then(() => {
|
|
|
|
expect(wrapper.vm.moveToNeighboringCommit).toHaveBeenCalledWith({ direction: 'next' });
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('renders a disabled button when there is no next commit', () => {
|
|
|
|
mountComponent({ commit: { ...mrCommit, next_commit_id: null } });
|
|
|
|
|
|
|
|
const button = getNextCommitNavElement();
|
|
|
|
|
|
|
|
expect(button.element.tagName).toEqual('BUTTON');
|
|
|
|
expect(button.element.hasAttribute('disabled')).toEqual(true);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|