2020-05-24 23:13:21 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Ci::InstanceVariable do
|
|
|
|
subject { build(:ci_instance_variable) }
|
|
|
|
|
|
|
|
it_behaves_like "CI variable"
|
|
|
|
|
|
|
|
it { is_expected.to include_module(Ci::Maskable) }
|
|
|
|
it { is_expected.to validate_uniqueness_of(:key).with_message(/\(\w+\) has already been taken/) }
|
2020-06-23 00:09:42 +05:30
|
|
|
it { is_expected.to validate_length_of(:encrypted_value).is_at_most(1024).with_message(/Variables over 700 characters risk exceeding the limit/) }
|
|
|
|
|
|
|
|
it_behaves_like 'includes Limitable concern' do
|
|
|
|
subject { build(:ci_instance_variable) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with instance level variable feature flag disabled' do
|
|
|
|
let(:plan_limits) { create(:plan_limits, :default_plan) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_instance_level_variables_limit: false)
|
|
|
|
plan_limits.update(described_class.limit_name => 1)
|
|
|
|
create(:ci_instance_variable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can create new models exceeding the plan limits', :aggregate_failures do
|
|
|
|
expect { subject.save }.to change { described_class.count }
|
|
|
|
expect(subject.errors[:base]).to be_empty
|
|
|
|
end
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
describe '.unprotected' do
|
|
|
|
subject { described_class.unprotected }
|
|
|
|
|
|
|
|
context 'when variable is protected' do
|
|
|
|
before do
|
|
|
|
create(:ci_instance_variable, :protected)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nothing' do
|
|
|
|
is_expected.to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when variable is not protected' do
|
|
|
|
let(:variable) { create(:ci_instance_variable, protected: false) }
|
|
|
|
|
|
|
|
it 'returns the variable' do
|
|
|
|
is_expected.to contain_exactly(variable)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.all_cached', :use_clean_rails_memory_store_caching do
|
|
|
|
let_it_be(:unprotected_variable) { create(:ci_instance_variable, protected: false) }
|
|
|
|
let_it_be(:protected_variable) { create(:ci_instance_variable, protected: true) }
|
|
|
|
|
|
|
|
it { expect(described_class.all_cached).to contain_exactly(protected_variable, unprotected_variable) }
|
|
|
|
|
|
|
|
it 'memoizes the result' do
|
2020-06-23 00:09:42 +05:30
|
|
|
expect(described_class).to receive(:unscoped).once.and_call_original
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
2.times do
|
|
|
|
expect(described_class.all_cached).to contain_exactly(protected_variable, unprotected_variable)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes scopes' do
|
|
|
|
expect(described_class.unprotected.all_cached).to contain_exactly(protected_variable, unprotected_variable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'resets the cache when records are deleted' do
|
|
|
|
expect(described_class.all_cached).to contain_exactly(protected_variable, unprotected_variable)
|
|
|
|
|
|
|
|
protected_variable.destroy
|
|
|
|
|
|
|
|
expect(described_class.all_cached).to contain_exactly(unprotected_variable)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'resets the cache when records are inserted' do
|
|
|
|
expect(described_class.all_cached).to contain_exactly(protected_variable, unprotected_variable)
|
|
|
|
|
|
|
|
variable = create(:ci_instance_variable, protected: true)
|
|
|
|
|
|
|
|
expect(described_class.all_cached).to contain_exactly(protected_variable, unprotected_variable, variable)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.unprotected_cached', :use_clean_rails_memory_store_caching do
|
|
|
|
let_it_be(:unprotected_variable) { create(:ci_instance_variable, protected: false) }
|
|
|
|
let_it_be(:protected_variable) { create(:ci_instance_variable, protected: true) }
|
|
|
|
|
|
|
|
it { expect(described_class.unprotected_cached).to contain_exactly(unprotected_variable) }
|
|
|
|
|
|
|
|
it 'memoizes the result' do
|
2020-06-23 00:09:42 +05:30
|
|
|
expect(described_class).to receive(:unscoped).once.and_call_original
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
2.times do
|
|
|
|
expect(described_class.unprotected_cached).to contain_exactly(unprotected_variable)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|