2019-05-05 18:10:48 +05:30
|
|
|
## What does this MR do?
|
|
|
|
|
|
|
|
|
|
<!--
|
|
|
|
|
Describe in detail what your merge request does, why it does that, etc. Merge
|
|
|
|
|
requests without an adequate description will not be reviewed until one is
|
|
|
|
|
added.
|
|
|
|
|
|
|
|
|
|
Please also keep this description up-to-date with any discussion that takes
|
|
|
|
|
place so that reviewers can understand your intent. This is especially
|
|
|
|
|
important if they didn't participate in the discussion.
|
|
|
|
|
|
|
|
|
|
Make sure to remove this comment when you are done.
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
Add a description of your merge request here.
|
|
|
|
|
|
|
|
|
|
## Database checklist
|
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
- [ ] Conforms to the [database guides](https://docs.gitlab.com/ee/development/README.html#database-guides)
|
2019-05-05 18:10:48 +05:30
|
|
|
|
|
|
|
|
When adding migrations:
|
|
|
|
|
|
|
|
|
|
- [ ] Updated `db/schema.rb`
|
|
|
|
|
- [ ] Added a `down` method so the migration can be reverted
|
|
|
|
|
- [ ] Added the output of the migration(s) to the MR body
|
|
|
|
|
- [ ] Added tests for the migration in `spec/migrations` if necessary (e.g. when migrating data)
|
2019-12-21 20:55:43 +05:30
|
|
|
- [ ] Added rollback procedure. Include either a rollback procedure or description how to rollback changes
|
2019-05-05 18:10:48 +05:30
|
|
|
|
|
|
|
|
When adding or modifying queries to improve performance:
|
|
|
|
|
|
|
|
|
|
- [ ] Included data that shows the performance improvement, preferably in the form of a benchmark
|
|
|
|
|
- [ ] Included the output of `EXPLAIN (ANALYZE, BUFFERS)` of the relevant queries
|
|
|
|
|
|
|
|
|
|
When adding foreign keys to existing tables:
|
|
|
|
|
|
|
|
|
|
- [ ] Included a migration to remove orphaned rows in the source table before adding the foreign key
|
|
|
|
|
- [ ] Removed any instances of `dependent: ...` that may no longer be necessary
|
|
|
|
|
|
|
|
|
|
When adding tables:
|
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
- [ ] Ordered columns based on the [Ordering Table Columns](https://docs.gitlab.com/ee/development/ordering_table_columns.html) guidelines
|
2019-05-05 18:10:48 +05:30
|
|
|
- [ ] Added foreign keys to any columns pointing to data in other tables
|
2019-10-12 21:52:04 +05:30
|
|
|
- [ ] Added indexes for fields that are used in statements such as `WHERE`, `ORDER BY`, `GROUP BY`, and `JOIN`s
|
2019-05-05 18:10:48 +05:30
|
|
|
|
|
|
|
|
When removing columns, tables, indexes or other structures:
|
|
|
|
|
|
|
|
|
|
- [ ] Removed these in a post-deployment migration
|
|
|
|
|
- [ ] Made sure the application no longer uses (or ignores) these structures
|
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
/label ~database ~"database::review pending"
|
