debian-mirror-gitlab/spec/models/milestone_spec.rb

601 lines
20 KiB
Ruby
Raw Normal View History

2019-07-07 11:18:12 +05:30
# frozen_string_literal: true
2014-09-02 18:07:02 +05:30
require 'spec_helper'
2017-09-10 17:25:29 +05:30
describe Milestone do
2018-10-15 14:42:47 +05:30
describe 'modules' do
context 'with a project' do
it_behaves_like 'AtomicInternalId' do
let(:internal_id_attribute) { :iid }
let(:instance) { build(:milestone, project: build(:project), group: nil) }
2018-11-08 19:23:39 +05:30
let(:scope) { :project }
2018-10-15 14:42:47 +05:30
let(:scope_attrs) { { project: instance.project } }
let(:usage) { :milestones }
end
end
context 'with a group' do
it_behaves_like 'AtomicInternalId' do
let(:internal_id_attribute) { :iid }
let(:instance) { build(:milestone, project: nil, group: build(:group)) }
2018-11-08 19:23:39 +05:30
let(:scope) { :group }
2018-10-15 14:42:47 +05:30
let(:scope_attrs) { { namespace: instance.group } }
let(:usage) { :milestones }
end
end
end
2014-09-02 18:07:02 +05:30
describe "Validation" do
2015-09-11 14:41:01 +05:30
before do
allow(subject).to receive(:set_iid).and_return(false)
end
2017-08-17 22:00:37 +05:30
describe 'start_date' do
2019-09-04 21:01:54 +05:30
it 'adds an error when start_date is greater then due_date' do
2017-08-17 22:00:37 +05:30
milestone = build(:milestone, start_date: Date.tomorrow, due_date: Date.yesterday)
expect(milestone).not_to be_valid
2018-03-17 18:26:18 +05:30
expect(milestone.errors[:due_date]).to include("must be greater than start date")
2017-08-17 22:00:37 +05:30
end
2019-09-04 21:01:54 +05:30
it 'adds an error when start_date is greater than 9999-12-31' do
milestone = build(:milestone, start_date: Date.new(10000, 1, 1))
expect(milestone).not_to be_valid
expect(milestone.errors[:start_date]).to include("date must not be after 9999-12-31")
end
end
describe 'due_date' do
it 'adds an error when due_date is greater than 9999-12-31' do
milestone = build(:milestone, due_date: Date.new(10000, 1, 1))
expect(milestone).not_to be_valid
expect(milestone.errors[:due_date]).to include("date must not be after 9999-12-31")
end
2017-08-17 22:00:37 +05:30
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
describe 'title' do
it { is_expected.to validate_presence_of(:title) }
it 'is invalid if title would be empty after sanitation' do
milestone = build(:milestone, project: project, title: '<img src=x onerror=prompt(1)>')
expect(milestone).not_to be_valid
expect(milestone.errors[:title]).to include("can't be blank")
end
end
2019-12-04 20:38:33 +05:30
describe 'milestone_releases' do
let(:milestone) { build(:milestone, project: project) }
context 'when it is tied to a release for another project' do
it 'creates a validation error' do
other_project = create(:project)
milestone.releases << build(:release, project: other_project)
expect(milestone).not_to be_valid
end
end
context 'when it is tied to a release for the same project' do
it 'is valid' do
milestone.releases << build(:release, project: project)
expect(milestone).to be_valid
end
end
end
2017-08-17 22:00:37 +05:30
end
describe "Associations" do
it { is_expected.to belong_to(:project) }
it { is_expected.to have_many(:issues) }
2019-12-04 20:38:33 +05:30
it { is_expected.to have_many(:releases) }
it { is_expected.to have_many(:milestone_releases) }
2014-09-02 18:07:02 +05:30
end
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, :public) }
2017-01-15 13:20:01 +05:30
let(:milestone) { create(:milestone, project: project) }
let(:issue) { create(:issue, project: project) }
2016-06-02 11:05:42 +05:30
let(:user) { create(:user) }
describe "#title" do
2016-11-03 12:29:30 +05:30
let(:milestone) { create(:milestone, title: "<b>foo & bar -> 2.2</b>") }
2016-06-02 11:05:42 +05:30
it "sanitizes title" do
2016-11-03 12:29:30 +05:30
expect(milestone.title).to eq("foo & bar -> 2.2")
2016-06-02 11:05:42 +05:30
end
end
2014-09-02 18:07:02 +05:30
2020-01-01 13:55:28 +05:30
describe '#merge_requests_enabled?' do
context "per project" do
it "is true for projects with MRs enabled" do
project = create(:project, :merge_requests_enabled)
milestone = create(:milestone, project: project)
expect(milestone.merge_requests_enabled?).to be(true)
end
it "is false for projects with MRs disabled" do
project = create(:project, :repository_enabled, :merge_requests_disabled)
milestone = create(:milestone, project: project)
expect(milestone.merge_requests_enabled?).to be(false)
end
it "is false for projects with repository disabled" do
project = create(:project, :repository_disabled)
milestone = create(:milestone, project: project)
expect(milestone.merge_requests_enabled?).to be(false)
end
end
context "per group" do
let(:group) { create(:group) }
let(:milestone) { create(:milestone, group: group) }
it "is always true for groups, for performance reasons" do
expect(milestone.merge_requests_enabled?).to be(true)
end
end
end
2017-09-10 17:25:29 +05:30
describe "unique milestone title" do
context "per project" do
it "does not accept the same title in a project twice" do
new_milestone = described_class.new(project: milestone.project, title: milestone.title)
expect(new_milestone).not_to be_valid
end
it "accepts the same title in another project" do
project = create(:project)
new_milestone = described_class.new(project: project, title: milestone.title)
expect(new_milestone).to be_valid
end
2016-04-02 18:10:28 +05:30
end
2017-09-10 17:25:29 +05:30
context "per group" do
let(:group) { create(:group) }
let(:milestone) { create(:milestone, group: group) }
2016-04-02 18:10:28 +05:30
2017-09-10 17:25:29 +05:30
before do
project.update(group: group)
end
it "does not accept the same title in a group twice" do
new_milestone = described_class.new(group: group, title: milestone.title)
expect(new_milestone).not_to be_valid
end
it "does not accept the same title of a child project milestone" do
create(:milestone, project: group.projects.first)
new_milestone = described_class.new(group: group, title: milestone.title)
expect(new_milestone).not_to be_valid
end
2016-04-02 18:10:28 +05:30
end
end
2018-12-05 23:21:45 +05:30
describe '.order_by_name_asc' do
it 'sorts by name ascending' do
milestone1 = create(:milestone, title: 'Foo')
milestone2 = create(:milestone, title: 'Bar')
expect(described_class.order_by_name_asc).to eq([milestone2, milestone1])
end
end
describe '.reorder_by_due_date_asc' do
it 'reorders the input relation' do
milestone1 = create(:milestone, due_date: Date.new(2018, 9, 30))
milestone2 = create(:milestone, due_date: Date.new(2018, 10, 20))
expect(described_class.reorder_by_due_date_asc).to eq([milestone1, milestone2])
end
end
2020-03-09 13:42:32 +05:30
it_behaves_like 'within_timeframe scope' do
let_it_be(:now) { Time.now }
let_it_be(:project) { create(:project, :empty_repo) }
let_it_be(:resource_1) { create(:milestone, project: project, start_date: now - 1.day, due_date: now + 1.day) }
let_it_be(:resource_2) { create(:milestone, project: project, start_date: now + 2.days, due_date: now + 3.days) }
let_it_be(:resource_3) { create(:milestone, project: project, due_date: now) }
let_it_be(:resource_4) { create(:milestone, project: project, start_date: now) }
end
2014-09-02 18:07:02 +05:30
describe "#percent_complete" do
2016-09-13 17:45:13 +05:30
it "does not count open issues" do
2014-09-02 18:07:02 +05:30
milestone.issues << issue
2016-06-02 11:05:42 +05:30
expect(milestone.percent_complete(user)).to eq(0)
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it "counts closed issues" do
2014-09-02 18:07:02 +05:30
issue.close
milestone.issues << issue
2016-06-02 11:05:42 +05:30
expect(milestone.percent_complete(user)).to eq(100)
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it "recovers from dividing by zero" do
2016-06-02 11:05:42 +05:30
expect(milestone.percent_complete(user)).to eq(0)
2014-09-02 18:07:02 +05:30
end
end
2016-08-24 12:49:21 +05:30
describe '#expired?' do
2014-09-02 18:07:02 +05:30
context "expired" do
before do
2015-09-11 14:41:01 +05:30
allow(milestone).to receive(:due_date).and_return(Date.today.prev_year)
2014-09-02 18:07:02 +05:30
end
2018-10-15 14:42:47 +05:30
it 'returns true when due_date is in the past' do
expect(milestone.expired?).to be_truthy
end
2014-09-02 18:07:02 +05:30
end
context "not expired" do
before do
2015-09-11 14:41:01 +05:30
allow(milestone).to receive(:due_date).and_return(Date.today.next_year)
2014-09-02 18:07:02 +05:30
end
2018-10-15 14:42:47 +05:30
it 'returns false when due_date is in the future' do
expect(milestone.expired?).to be_falsey
end
2014-09-02 18:07:02 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe '#upcoming?' do
2018-10-15 14:42:47 +05:30
it 'returns true when start_date is in the future' do
2017-08-17 22:00:37 +05:30
milestone = build(:milestone, start_date: Time.now + 1.month)
expect(milestone.upcoming?).to be_truthy
end
2018-10-15 14:42:47 +05:30
it 'returns false when start_date is in the past' do
2017-08-17 22:00:37 +05:30
milestone = build(:milestone, start_date: Date.today.prev_year)
expect(milestone.upcoming?).to be_falsey
end
end
2016-08-24 12:49:21 +05:30
describe '#can_be_closed?' do
2015-04-26 12:48:37 +05:30
it { expect(milestone.can_be_closed?).to be_truthy }
2014-09-02 18:07:02 +05:30
end
2016-08-24 12:49:21 +05:30
describe '#can_be_closed?' do
2014-09-02 18:07:02 +05:30
before do
2019-03-13 22:55:13 +05:30
milestone = create :milestone, project: project
create :closed_issue, milestone: milestone, project: project
2014-09-02 18:07:02 +05:30
2019-03-13 22:55:13 +05:30
create :issue, project: project
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it 'returns true if milestone active and all nested issues closed' do
2015-04-26 12:48:37 +05:30
expect(milestone.can_be_closed?).to be_truthy
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it 'returns false if milestone active and not all nested issues closed' do
2014-09-02 18:07:02 +05:30
issue.milestone = milestone
issue.save
2015-04-26 12:48:37 +05:30
expect(milestone.can_be_closed?).to be_falsey
2014-09-02 18:07:02 +05:30
end
end
2019-10-31 01:37:42 +05:30
describe '#to_ability_name' do
it 'returns milestone' do
milestone = build(:milestone)
expect(milestone.to_ability_name).to eq('milestone')
end
end
2016-06-02 11:05:42 +05:30
describe '.search' do
let(:milestone) { create(:milestone, title: 'foo', description: 'bar') }
it 'returns milestones with a matching title' do
expect(described_class.search(milestone.title)).to eq([milestone])
end
it 'returns milestones with a partially matching title' do
expect(described_class.search(milestone.title[0..2])).to eq([milestone])
end
it 'returns milestones with a matching title regardless of the casing' do
expect(described_class.search(milestone.title.upcase)).to eq([milestone])
end
it 'returns milestones with a matching description' do
expect(described_class.search(milestone.description)).to eq([milestone])
end
it 'returns milestones with a partially matching description' do
2017-09-10 17:25:29 +05:30
expect(described_class.search(milestone.description[0..2]))
.to eq([milestone])
2016-06-02 11:05:42 +05:30
end
it 'returns milestones with a matching description regardless of the casing' do
2017-09-10 17:25:29 +05:30
expect(described_class.search(milestone.description.upcase))
.to eq([milestone])
2016-06-02 11:05:42 +05:30
end
end
2019-03-02 22:35:43 +05:30
describe '#search_title' do
let(:milestone) { create(:milestone, title: 'foo', description: 'bar') }
it 'returns milestones with a matching title' do
expect(described_class.search_title(milestone.title)) .to eq([milestone])
end
it 'returns milestones with a partially matching title' do
expect(described_class.search_title(milestone.title[0..2])).to eq([milestone])
end
it 'returns milestones with a matching title regardless of the casing' do
expect(described_class.search_title(milestone.title.upcase))
.to eq([milestone])
end
it 'searches only on the title and ignores milestones with a matching description' do
create(:milestone, title: 'bar', description: 'foo')
expect(described_class.search_title(milestone.title)) .to eq([milestone])
end
end
describe '#for_projects_and_groups' do
let(:project) { create(:project) }
let(:project_other) { create(:project) }
let(:group) { create(:group) }
let(:group_other) { create(:group) }
before do
create(:milestone, project: project)
create(:milestone, project: project_other)
create(:milestone, group: group)
create(:milestone, group: group_other)
end
subject { described_class.for_projects_and_groups(projects, groups) }
shared_examples 'filters by projects and groups' do
it 'returns milestones filtered by project' do
milestones = described_class.for_projects_and_groups(projects, [])
expect(milestones.count).to eq(1)
expect(milestones.first.project_id).to eq(project.id)
end
it 'returns milestones filtered by group' do
milestones = described_class.for_projects_and_groups([], groups)
expect(milestones.count).to eq(1)
expect(milestones.first.group_id).to eq(group.id)
end
it 'returns milestones filtered by both project and group' do
milestones = described_class.for_projects_and_groups(projects, groups)
expect(milestones.count).to eq(2)
expect(milestones).to contain_exactly(project.milestones.first, group.milestones.first)
end
end
context 'ids as params' do
let(:projects) { [project.id] }
let(:groups) { [group.id] }
it_behaves_like 'filters by projects and groups'
end
context 'relations as params' do
let(:projects) { Project.where(id: project.id).select(:id) }
let(:groups) { Group.where(id: group.id).select(:id) }
it_behaves_like 'filters by projects and groups'
end
context 'objects as params' do
let(:projects) { [project] }
let(:groups) { [group] }
it_behaves_like 'filters by projects and groups'
end
it 'returns no records if projects and groups are nil' do
milestones = described_class.for_projects_and_groups(nil, nil)
expect(milestones).to be_empty
end
end
describe '.upcoming_ids' do
let(:group_1) { create(:group) }
let(:group_2) { create(:group) }
let(:group_3) { create(:group) }
let(:groups) { [group_1, group_2, group_3] }
let!(:past_milestone_group_1) { create(:milestone, group: group_1, due_date: Time.now - 1.day) }
let!(:current_milestone_group_1) { create(:milestone, group: group_1, due_date: Time.now + 1.day) }
let!(:future_milestone_group_1) { create(:milestone, group: group_1, due_date: Time.now + 2.days) }
let!(:past_milestone_group_2) { create(:milestone, group: group_2, due_date: Time.now - 1.day) }
let!(:closed_milestone_group_2) { create(:milestone, :closed, group: group_2, due_date: Time.now + 1.day) }
let!(:current_milestone_group_2) { create(:milestone, group: group_2, due_date: Time.now + 2.days) }
let!(:past_milestone_group_3) { create(:milestone, group: group_3, due_date: Time.now - 1.day) }
2017-09-10 17:25:29 +05:30
let(:project_1) { create(:project) }
let(:project_2) { create(:project) }
let(:project_3) { create(:project) }
2016-06-02 11:05:42 +05:30
let(:projects) { [project_1, project_2, project_3] }
let!(:past_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now - 1.day) }
let!(:current_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now + 1.day) }
let!(:future_milestone_project_1) { create(:milestone, project: project_1, due_date: Time.now + 2.days) }
let!(:past_milestone_project_2) { create(:milestone, project: project_2, due_date: Time.now - 1.day) }
let!(:closed_milestone_project_2) { create(:milestone, :closed, project: project_2, due_date: Time.now + 1.day) }
let!(:current_milestone_project_2) { create(:milestone, project: project_2, due_date: Time.now + 2.days) }
let!(:past_milestone_project_3) { create(:milestone, project: project_3, due_date: Time.now - 1.day) }
2019-03-02 22:35:43 +05:30
let(:milestone_ids) { described_class.upcoming_ids(projects, groups).map(&:id) }
2016-06-02 11:05:42 +05:30
2019-03-02 22:35:43 +05:30
it 'returns the next upcoming open milestone ID for each project and group' do
expect(milestone_ids).to contain_exactly(
current_milestone_project_1.id,
current_milestone_project_2.id,
current_milestone_group_1.id,
current_milestone_group_2.id
)
2016-06-02 11:05:42 +05:30
end
2019-03-02 22:35:43 +05:30
context 'when the projects and groups have no open upcoming milestones' do
2016-06-02 11:05:42 +05:30
let(:projects) { [project_3] }
2019-03-02 22:35:43 +05:30
let(:groups) { [group_3] }
2016-06-02 11:05:42 +05:30
it 'returns no results' do
expect(milestone_ids).to be_empty
end
end
end
2017-08-17 22:00:37 +05:30
describe '#to_reference' do
2017-09-10 17:25:29 +05:30
let(:group) { build_stubbed(:group) }
let(:project) { build_stubbed(:project, name: 'sample-project') }
let(:another_project) { build_stubbed(:project, name: 'another-project', namespace: project.namespace) }
context 'for a project milestone' do
let(:milestone) { build_stubbed(:milestone, iid: 1, project: project, name: 'milestone') }
it 'returns a String reference to the object' do
2018-03-17 18:26:18 +05:30
expect(milestone.to_reference).to eq '%"milestone"'
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it 'returns a reference by name when the format is set to :name' do
expect(milestone.to_reference(format: :name)).to eq '%"milestone"'
end
it 'supports a cross-project reference' do
2018-03-17 18:26:18 +05:30
expect(milestone.to_reference(another_project)).to eq 'sample-project%"milestone"'
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'for a group milestone' do
let(:milestone) { build_stubbed(:milestone, iid: 1, group: group, name: 'milestone') }
2018-03-17 18:26:18 +05:30
it 'returns a group milestone reference with a default format' do
expect(milestone.to_reference).to eq '%"milestone"'
2017-09-10 17:25:29 +05:30
end
it 'returns a reference by name when the format is set to :name' do
expect(milestone.to_reference(format: :name)).to eq '%"milestone"'
end
2018-03-17 18:26:18 +05:30
it 'does supports cross-project references within a group' do
2017-09-10 17:25:29 +05:30
expect(milestone.to_reference(another_project, format: :name)).to eq '%"milestone"'
end
2018-03-17 18:26:18 +05:30
it 'raises an error when using iid format' do
expect { milestone.to_reference(format: :iid) }
.to raise_error(ArgumentError, 'Cannot refer to a group milestone by an internal id!')
end
2017-08-17 22:00:37 +05:30
end
end
2019-02-15 15:39:39 +05:30
describe '#reference_link_text' do
let(:project) { build_stubbed(:project, name: 'sample-project') }
let(:milestone) { build_stubbed(:milestone, iid: 1, project: project, name: 'milestone') }
it 'returns the title with the reference prefix' do
expect(milestone.reference_link_text).to eq '%milestone'
end
end
2017-08-17 22:00:37 +05:30
describe '#participants' do
2017-09-10 17:25:29 +05:30
let(:project) { build(:project, name: 'sample-project') }
2017-08-17 22:00:37 +05:30
let(:milestone) { build(:milestone, iid: 1, project: project) }
it 'returns participants without duplicates' do
user = create :user
create :issue, project: project, milestone: milestone, assignees: [user]
create :issue, project: project, milestone: milestone, assignees: [user]
expect(milestone.participants).to eq [user]
end
end
2018-11-18 11:00:15 +05:30
describe '.sort_by_attribute' do
2020-03-09 13:42:32 +05:30
let_it_be(:milestone_1) { create(:milestone, title: 'Foo') }
let_it_be(:milestone_2) { create(:milestone, title: 'Bar') }
let_it_be(:milestone_3) { create(:milestone, title: 'Zoo') }
2018-11-18 11:00:15 +05:30
context 'ordering by name ascending' do
it 'sorts by title ascending' do
expect(described_class.sort_by_attribute('name_asc'))
.to eq([milestone_2, milestone_1, milestone_3])
end
end
context 'ordering by name descending' do
it 'sorts by title descending' do
expect(described_class.sort_by_attribute('name_desc'))
.to eq([milestone_3, milestone_1, milestone_2])
end
end
end
2018-12-13 13:39:08 +05:30
describe '.states_count' do
context 'when the projects have milestones' do
before do
project_1 = create(:project)
project_2 = create(:project)
group_1 = create(:group)
group_2 = create(:group)
create(:active_milestone, title: 'Active Group Milestone', project: project_1)
create(:closed_milestone, title: 'Closed Group Milestone', project: project_1)
create(:active_milestone, title: 'Active Group Milestone', project: project_2)
create(:closed_milestone, title: 'Closed Group Milestone', project: project_2)
create(:closed_milestone, title: 'Active Group Milestone', group: group_1)
create(:closed_milestone, title: 'Closed Group Milestone', group: group_1)
create(:closed_milestone, title: 'Active Group Milestone', group: group_2)
create(:closed_milestone, title: 'Closed Group Milestone', group: group_2)
end
it 'returns the quantity of milestones in each possible state' do
2020-03-09 13:42:32 +05:30
expected_count = { opened: 2, closed: 6, all: 8 }
2018-12-13 13:39:08 +05:30
count = described_class.states_count(Project.all, Group.all)
expect(count).to eq(expected_count)
end
end
context 'when the projects do not have milestones' do
it 'returns 0 as the quantity of global milestones in each state' do
expected_count = { opened: 0, closed: 0, all: 0 }
count = described_class.states_count([project])
expect(count).to eq(expected_count)
end
end
end
2019-09-04 21:01:54 +05:30
describe '.reference_pattern' do
subject { described_class.reference_pattern }
it { is_expected.to match('gitlab-org/gitlab-ce%123') }
it { is_expected.to match('gitlab-org/gitlab-ce%"my-milestone"') }
end
describe '.link_reference_pattern' do
subject { described_class.link_reference_pattern }
2019-12-04 20:38:33 +05:30
it { is_expected.to match("#{Gitlab.config.gitlab.url}/gitlab-org/gitlab-foss/milestones/123") }
it { is_expected.to match("#{Gitlab.config.gitlab.url}/gitlab-org/gitlab-foss/-/milestones/123") }
it { is_expected.not_to match("#{Gitlab.config.gitlab.url}/gitlab-org/gitlab-foss/issues/123") }
2019-09-04 21:01:54 +05:30
it { is_expected.not_to match("gitlab-org/gitlab-ce/milestones/123") }
end
2014-09-02 18:07:02 +05:30
end