debian-mirror-gitlab/spec/controllers/commit_controller_spec.rb

247 lines
7.5 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
require 'spec_helper'
describe Projects::CommitController do
let(:project) { create(:project) }
let(:user) { create(:user) }
2015-09-11 14:41:01 +05:30
let(:commit) { project.commit("master") }
2016-06-02 11:05:42 +05:30
let(:master_pickable_sha) { '7d3b0f7cff5f37573aea97cebfd5692ea1689924' }
let(:master_pickable_commit) { project.commit(master_pickable_sha) }
2014-09-02 18:07:02 +05:30
before do
sign_in(user)
project.team << [user, :master]
end
describe "#show" do
shared_examples "export as" do |format|
it "should generally work" do
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id,
format: format)
2014-09-02 18:07:02 +05:30
expect(response).to be_success
end
it "should generate it" do
2015-04-26 12:48:37 +05:30
expect_any_instance_of(Commit).to receive(:"to_#{format}")
2014-09-02 18:07:02 +05:30
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id, format: format)
2014-09-02 18:07:02 +05:30
end
it "should render it" do
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id, format: format)
2014-09-02 18:07:02 +05:30
expect(response.body).to eq(commit.send(:"to_#{format}"))
end
it "should not escape Html" do
2015-04-26 12:48:37 +05:30
allow_any_instance_of(Commit).to receive(:"to_#{format}").
and_return('HTML entities &<>" ')
2014-09-02 18:07:02 +05:30
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id, format: format)
2014-09-02 18:07:02 +05:30
2015-09-11 14:41:01 +05:30
expect(response.body).not_to include('&amp;')
expect(response.body).not_to include('&gt;')
expect(response.body).not_to include('&lt;')
expect(response.body).not_to include('&quot;')
2014-09-02 18:07:02 +05:30
end
end
describe "as diff" do
include_examples "export as", :diff
let(:format) { :diff }
it "should really only be a git diff" do
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id,
format: format)
2014-09-02 18:07:02 +05:30
expect(response.body).to start_with("diff --git")
end
2015-12-23 02:04:40 +05:30
it "should really only be a git diff without whitespace changes" do
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: '66eceea0db202bb39c4e445e8ca28689645366c5',
# id: commit.id,
format: format,
w: 1)
expect(response.body).to start_with("diff --git")
# without whitespace option, there are more than 2 diff_splits
2016-06-02 11:05:42 +05:30
diff_splits = assigns(:diffs).first.diff.split("\n")
2015-12-23 02:04:40 +05:30
expect(diff_splits.length).to be <= 2
end
2014-09-02 18:07:02 +05:30
end
describe "as patch" do
include_examples "export as", :patch
let(:format) { :patch }
it "should really be a git email patch" do
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id,
format: format)
2014-09-02 18:07:02 +05:30
expect(response.body).to start_with("From #{commit.id}")
end
it "should contain a git diff" do
2015-09-11 14:41:01 +05:30
get(:show,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id,
format: format)
2014-09-02 18:07:02 +05:30
expect(response.body).to match(/^diff --git/)
end
end
2015-12-23 02:04:40 +05:30
context 'commit that removes a submodule' do
render_views
let(:fork_project) { create(:forked_project_with_submodules) }
let(:commit) { fork_project.commit('remove-submodule') }
before do
fork_project.team << [user, :master]
end
it 'renders it' do
get(:show,
namespace_id: fork_project.namespace.to_param,
project_id: fork_project.to_param,
id: commit.id)
expect(response).to be_success
end
end
2014-09-02 18:07:02 +05:30
end
2015-04-26 12:48:37 +05:30
describe "#branches" do
it "contains branch and tags information" do
2015-09-11 14:41:01 +05:30
get(:branches,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id)
2015-04-26 12:48:37 +05:30
expect(assigns(:branches)).to include("master", "feature_conflict")
expect(assigns(:tags)).to include("v1.1.0")
end
end
2016-04-02 18:10:28 +05:30
describe '#revert' do
context 'when target branch is not provided' do
it 'should render the 404 page' do
post(:revert,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: commit.id)
expect(response).not_to be_success
expect(response.status).to eq(404)
end
end
context 'when the revert was successful' do
it 'should redirect to the commits page' do
post(:revert,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: commit.id)
expect(response).to redirect_to namespace_project_commits_path(project.namespace, project, 'master')
expect(flash[:notice]).to eq('The commit has been successfully reverted.')
end
end
context 'when the revert failed' do
before do
post(:revert,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: commit.id)
end
it 'should redirect to the commit page' do
# Reverting a commit that has been already reverted.
post(:revert,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: commit.id)
expect(response).to redirect_to namespace_project_commit_path(project.namespace, project, commit.id)
expect(flash[:alert]).to match('Sorry, we cannot revert this commit automatically.')
end
end
end
2016-06-02 11:05:42 +05:30
describe '#cherry_pick' do
context 'when target branch is not provided' do
it 'should render the 404 page' do
post(:cherry_pick,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: master_pickable_commit.id)
expect(response).not_to be_success
expect(response.status).to eq(404)
end
end
context 'when the cherry-pick was successful' do
it 'should redirect to the commits page' do
post(:cherry_pick,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: master_pickable_commit.id)
expect(response).to redirect_to namespace_project_commits_path(project.namespace, project, 'master')
expect(flash[:notice]).to eq('The commit has been successfully cherry-picked.')
end
end
context 'when the cherry_pick failed' do
before do
post(:cherry_pick,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: master_pickable_commit.id)
end
it 'should redirect to the commit page' do
# Cherry-picking a commit that has been already cherry-picked.
post(:cherry_pick,
namespace_id: project.namespace.to_param,
project_id: project.to_param,
target_branch: 'master',
id: master_pickable_commit.id)
expect(response).to redirect_to namespace_project_commit_path(project.namespace, project, master_pickable_commit.id)
expect(flash[:alert]).to match('Sorry, we cannot cherry-pick this commit automatically.')
end
end
end
2014-09-02 18:07:02 +05:30
end