debian-mirror-gitlab/spec/policies/group_policy_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1348 lines
38 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe GroupPolicy do
2019-07-07 11:18:12 +05:30
include_context 'GroupPolicy context'
2017-08-17 22:00:37 +05:30
2019-12-21 20:55:43 +05:30
context 'public group with no user' do
2022-03-02 08:16:31 +05:30
let(:group) { create(:group, :public, :crm_enabled) }
2017-08-17 22:00:37 +05:30
let(:current_user) { nil }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(:upload_file)
2017-09-10 17:25:29 +05:30
expect_disallowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(:read_namespace)
2017-08-17 22:00:37 +05:30
end
end
2022-03-02 08:16:31 +05:30
context 'public group with user who is not a member' do
let(:group) { create(:group, :public, :crm_enabled) }
let(:current_user) { create(:user) }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
expect_disallowed(:upload_file)
expect_disallowed(*reporter_permissions)
expect_disallowed(*developer_permissions)
expect_disallowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
expect_disallowed(:read_namespace)
end
end
context 'private group that has been invited to a public project and with no user' do
let(:project) { create(:project, :public, group: create(:group, :crm_enabled)) }
2019-03-13 22:55:13 +05:30
let(:current_user) { nil }
before do
2019-07-07 11:18:12 +05:30
create(:project_group_link, project: project, group: group)
2019-03-13 22:55:13 +05:30
end
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_disallowed(*public_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*owner_permissions)
end
2019-03-13 22:55:13 +05:30
end
2022-03-02 08:16:31 +05:30
context 'private group that has been invited to a public project and with a foreign user' do
let(:project) { create(:project, :public, group: create(:group, :crm_enabled)) }
2019-03-13 22:55:13 +05:30
let(:current_user) { create(:user) }
before do
2019-07-07 11:18:12 +05:30
create(:project_group_link, project: project, group: group)
2019-03-13 22:55:13 +05:30
end
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_disallowed(*public_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*owner_permissions)
end
2019-03-13 22:55:13 +05:30
end
2018-05-09 12:01:36 +05:30
context 'has projects' do
let(:current_user) { create(:user) }
let(:project) { create(:project, namespace: group) }
before do
project.add_developer(current_user)
end
2022-03-02 08:16:31 +05:30
it { expect_allowed(*(public_permissions - [:read_counts])) }
2018-05-09 12:01:36 +05:30
2019-10-12 21:52:04 +05:30
context 'in subgroups' do
2022-03-02 08:16:31 +05:30
let(:subgroup) { create(:group, :private, :crm_enabled, parent: group) }
2018-05-09 12:01:36 +05:30
let(:project) { create(:project, namespace: subgroup) }
2022-03-02 08:16:31 +05:30
it { expect_allowed(*(public_permissions - [:read_counts])) }
2018-05-09 12:01:36 +05:30
end
end
2020-08-19 02:56:42 +05:30
shared_examples 'deploy token does not get confused with user' do
before do
deploy_token.update!(id: user_id)
end
let(:deploy_token) { create(:deploy_token) }
let(:current_user) { deploy_token }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_disallowed(*public_permissions)
2020-08-19 02:56:42 +05:30
expect_disallowed(*guest_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*developer_permissions)
expect_disallowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
end
end
2017-08-17 22:00:37 +05:30
context 'guests' do
let(:current_user) { guest }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { guest.id }
end
2017-08-17 22:00:37 +05:30
end
context 'reporter' do
let(:current_user) { reporter }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { reporter.id }
end
2017-08-17 22:00:37 +05:30
end
context 'developer' do
let(:current_user) { developer }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { developer.id }
end
2017-08-17 22:00:37 +05:30
end
2018-11-18 11:00:15 +05:30
context 'maintainer' do
let(:current_user) { maintainer }
2017-08-17 22:00:37 +05:30
2019-10-12 21:52:04 +05:30
context 'with subgroup_creation level set to maintainer' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS)
2019-10-12 21:52:04 +05:30
end
it 'allows every maintainer permission plus creating subgroups' do
create_subgroup_permission = [:create_subgroup]
updated_maintainer_permissions =
maintainer_permissions + create_subgroup_permission
updated_owner_permissions =
owner_permissions - create_subgroup_permission
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2019-10-12 21:52:04 +05:30
expect_allowed(*guest_permissions)
expect_allowed(*reporter_permissions)
expect_allowed(*developer_permissions)
expect_allowed(*updated_maintainer_permissions)
expect_disallowed(*updated_owner_permissions)
end
end
context 'with subgroup_creation_level set to owner' do
it 'allows every maintainer permission' do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2019-10-12 21:52:04 +05:30
expect_allowed(*guest_permissions)
expect_allowed(*reporter_permissions)
expect_allowed(*developer_permissions)
expect_allowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
end
2017-08-17 22:00:37 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { maintainer.id }
end
2017-08-17 22:00:37 +05:30
end
context 'owner' do
let(:current_user) { owner }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_allowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { owner.id }
end
2017-08-17 22:00:37 +05:30
end
context 'admin' do
let(:current_user) { admin }
2020-07-28 23:09:34 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_disallowed(*public_permissions)
2021-04-17 20:07:23 +05:30
expect_disallowed(*guest_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*developer_permissions)
expect_disallowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
2020-07-28 23:09:34 +05:30
context 'with admin mode', :enable_admin_mode do
2021-04-17 20:07:23 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2021-04-17 20:07:23 +05:30
expect_allowed(*guest_permissions)
expect_allowed(*reporter_permissions)
expect_allowed(*developer_permissions)
expect_allowed(*maintainer_permissions)
expect_allowed(*owner_permissions)
expect_allowed(*admin_permissions)
end
2020-07-28 23:09:34 +05:30
end
2020-08-19 02:56:42 +05:30
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { admin.id }
context 'with admin mode', :enable_admin_mode do
it { expect_disallowed(*admin_permissions) }
end
end
2017-08-17 22:00:37 +05:30
end
2022-07-16 23:28:13 +05:30
context 'migration bot' do
let_it_be(:migration_bot) { User.migration_bot }
let_it_be(:current_user) { migration_bot }
it :aggregate_failures do
expect_allowed(:read_resource_access_tokens, :destroy_resource_access_tokens)
expect_disallowed(*guest_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*developer_permissions)
expect_disallowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
end
it_behaves_like 'deploy token does not get confused with user' do
let(:user_id) { migration_bot.id }
end
2023-01-13 00:05:48 +05:30
context 'with no user' do
let(:current_user) { nil }
it :aggregate_failures do
expect_disallowed(:read_resource_access_tokens, :destroy_resource_access_tokens)
expect_disallowed(*guest_permissions)
expect_disallowed(*reporter_permissions)
expect_disallowed(*developer_permissions)
expect_disallowed(*maintainer_permissions)
expect_disallowed(*owner_permissions)
end
end
2022-07-16 23:28:13 +05:30
end
2019-10-12 21:52:04 +05:30
describe 'private nested group use the highest access level from the group and inherited permissions' do
2019-12-21 20:55:43 +05:30
let_it_be(:nested_group) do
2022-03-02 08:16:31 +05:30
create(:group, :private, :owner_subgroup_creation_only, :crm_enabled, parent: group)
2018-03-17 18:26:18 +05:30
end
2017-08-17 22:00:37 +05:30
2019-12-21 20:55:43 +05:30
before_all do
2017-09-10 17:25:29 +05:30
nested_group.add_guest(guest)
nested_group.add_guest(reporter)
nested_group.add_guest(developer)
2018-11-18 11:00:15 +05:30
nested_group.add_guest(maintainer)
2017-09-10 17:25:29 +05:30
2020-06-23 00:09:42 +05:30
group.owners.destroy_all # rubocop: disable Cop/DestroyAll
2017-09-10 17:25:29 +05:30
group.add_guest(owner)
nested_group.add_owner(owner)
end
subject { described_class.new(current_user, nested_group) }
2017-08-17 22:00:37 +05:30
context 'with no user' do
let(:current_user) { nil }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_disallowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
context 'guests' do
let(:current_user) { guest }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
context 'reporter' do
let(:current_user) { reporter }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_disallowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
context 'developer' do
let(:current_user) { developer }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_disallowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
2018-11-18 11:00:15 +05:30
context 'maintainer' do
let(:current_user) { maintainer }
2017-08-17 22:00:37 +05:30
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_allowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_disallowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
context 'owner' do
let(:current_user) { owner }
2022-10-11 01:57:18 +05:30
specify do
2022-03-02 08:16:31 +05:30
expect_allowed(*public_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*guest_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*reporter_permissions)
2018-03-17 18:26:18 +05:30
expect_allowed(*developer_permissions)
2018-11-18 11:00:15 +05:30
expect_allowed(*maintainer_permissions)
2017-09-10 17:25:29 +05:30
expect_allowed(*owner_permissions)
2017-08-17 22:00:37 +05:30
end
end
end
2018-03-17 18:26:18 +05:30
describe 'change_share_with_group_lock' do
context 'when the current_user owns the group' do
let(:current_user) { owner }
context 'when the group share_with_group_lock is enabled' do
2022-03-02 08:16:31 +05:30
let(:group) { create(:group, :crm_enabled, share_with_group_lock: true, parent: parent) }
2018-03-17 18:26:18 +05:30
2019-12-21 20:55:43 +05:30
before do
group.add_owner(owner)
end
2018-03-17 18:26:18 +05:30
context 'when the parent group share_with_group_lock is enabled' do
context 'when the group has a grandparent' do
2022-03-02 08:16:31 +05:30
let(:parent) { create(:group, :crm_enabled, share_with_group_lock: true, parent: grandparent) }
2018-03-17 18:26:18 +05:30
context 'when the grandparent share_with_group_lock is enabled' do
2022-03-02 08:16:31 +05:30
let(:grandparent) { create(:group, :crm_enabled, share_with_group_lock: true) }
2018-03-17 18:26:18 +05:30
context 'when the current_user owns the parent' do
before do
parent.add_owner(current_user)
end
context 'when the current_user owns the grandparent' do
before do
grandparent.add_owner(current_user)
end
it { expect_allowed(:change_share_with_group_lock) }
end
context 'when the current_user does not own the grandparent' do
it { expect_disallowed(:change_share_with_group_lock) }
end
end
context 'when the current_user does not own the parent' do
it { expect_disallowed(:change_share_with_group_lock) }
end
end
context 'when the grandparent share_with_group_lock is disabled' do
2022-03-02 08:16:31 +05:30
let(:grandparent) { create(:group, :crm_enabled) }
2018-03-17 18:26:18 +05:30
context 'when the current_user owns the parent' do
before do
parent.add_owner(current_user)
end
it { expect_allowed(:change_share_with_group_lock) }
end
context 'when the current_user does not own the parent' do
it { expect_disallowed(:change_share_with_group_lock) }
end
end
end
context 'when the group does not have a grandparent' do
2022-03-02 08:16:31 +05:30
let(:parent) { create(:group, :crm_enabled, share_with_group_lock: true) }
2018-03-17 18:26:18 +05:30
context 'when the current_user owns the parent' do
before do
parent.add_owner(current_user)
end
it { expect_allowed(:change_share_with_group_lock) }
end
context 'when the current_user does not own the parent' do
it { expect_disallowed(:change_share_with_group_lock) }
end
end
end
context 'when the parent group share_with_group_lock is disabled' do
2022-03-02 08:16:31 +05:30
let(:parent) { create(:group, :crm_enabled) }
2018-03-17 18:26:18 +05:30
it { expect_allowed(:change_share_with_group_lock) }
end
end
context 'when the group share_with_group_lock is disabled' do
it { expect_allowed(:change_share_with_group_lock) }
end
end
context 'when the current_user does not own the group' do
let(:current_user) { create(:user) }
it { expect_disallowed(:change_share_with_group_lock) }
end
end
2019-02-15 15:39:39 +05:30
2019-10-31 01:37:42 +05:30
context 'transfer_projects' do
shared_examples_for 'allowed to transfer projects' do
before do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: project_creation_level)
2019-10-31 01:37:42 +05:30
end
it { is_expected.to be_allowed(:transfer_projects) }
end
shared_examples_for 'not allowed to transfer projects' do
before do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: project_creation_level)
2019-10-31 01:37:42 +05:30
end
it { is_expected.to be_disallowed(:transfer_projects) }
end
context 'reporter' do
let(:current_user) { reporter }
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::NO_ONE_PROJECT_ACCESS }
end
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS }
end
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS }
end
end
context 'developer' do
let(:current_user) { developer }
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::NO_ONE_PROJECT_ACCESS }
end
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS }
end
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS }
end
end
context 'maintainer' do
let(:current_user) { maintainer }
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::NO_ONE_PROJECT_ACCESS }
end
it_behaves_like 'allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS }
end
it_behaves_like 'allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS }
end
end
context 'owner' do
let(:current_user) { owner }
it_behaves_like 'not allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::NO_ONE_PROJECT_ACCESS }
end
it_behaves_like 'allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS }
end
it_behaves_like 'allowed to transfer projects' do
let(:project_creation_level) { ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS }
end
end
end
2020-03-13 15:44:24 +05:30
context 'create_projects' do
2019-07-07 11:18:12 +05:30
context 'when group has no project creation level set' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: nil)
2019-12-21 20:55:43 +05:30
end
2019-07-07 11:18:12 +05:30
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_allowed(:create_projects) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:create_projects) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_projects) }
end
end
context 'when group has project creation level set to no one' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: ::Gitlab::Access::NO_ONE_PROJECT_ACCESS)
2019-12-21 20:55:43 +05:30
end
2019-07-07 11:18:12 +05:30
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_disallowed(:create_projects) }
end
end
context 'when group has project creation level set to maintainer only' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: ::Gitlab::Access::MAINTAINER_PROJECT_ACCESS)
2019-12-21 20:55:43 +05:30
end
2019-07-07 11:18:12 +05:30
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:create_projects) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_projects) }
end
end
context 'when group has project creation level set to developers + maintainer' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(project_creation_level: ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS)
2019-12-21 20:55:43 +05:30
end
2019-07-07 11:18:12 +05:30
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_projects) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_allowed(:create_projects) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:create_projects) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_projects) }
end
end
end
2020-03-13 15:44:24 +05:30
context 'create_subgroup' do
2019-10-12 21:52:04 +05:30
context 'when group has subgroup creation level set to owner' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(subgroup_creation_level: ::Gitlab::Access::OWNER_SUBGROUP_ACCESS)
2019-10-12 21:52:04 +05:30
end
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_subgroup) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_disallowed(:create_subgroup) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_disallowed(:create_subgroup) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_subgroup) }
end
end
context 'when group has subgroup creation level set to maintainer' do
2019-12-21 20:55:43 +05:30
before_all do
2020-10-24 23:57:45 +05:30
group.update!(subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS)
2019-10-12 21:52:04 +05:30
end
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_subgroup) }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to be_disallowed(:create_subgroup) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:create_subgroup) }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_subgroup) }
end
end
end
2019-02-15 15:39:39 +05:30
it_behaves_like 'clusterable policies' do
2022-03-02 08:16:31 +05:30
let(:clusterable) { create(:group, :crm_enabled) }
2019-02-15 15:39:39 +05:30
let(:cluster) do
create(:cluster,
:provided_by_gcp,
:group,
groups: [clusterable])
end
end
2019-12-21 20:55:43 +05:30
describe 'update_max_artifacts_size' do
2022-03-02 08:16:31 +05:30
let(:group) { create(:group, :public, :crm_enabled) }
2019-12-21 20:55:43 +05:30
context 'when no user' do
let(:current_user) { nil }
it { expect_disallowed(:update_max_artifacts_size) }
end
context 'admin' do
let(:current_user) { admin }
2020-05-24 23:13:21 +05:30
context 'when admin mode is enabled', :enable_admin_mode do
it { expect_allowed(:update_max_artifacts_size) }
end
context 'when admin mode is enabled' do
it { expect_disallowed(:update_max_artifacts_size) }
end
2019-12-21 20:55:43 +05:30
end
%w(guest reporter developer maintainer owner).each do |role|
context role do
let(:current_user) { send(role) }
it { expect_disallowed(:update_max_artifacts_size) }
end
end
end
2020-07-28 23:09:34 +05:30
describe 'design activity' do
2022-03-02 08:16:31 +05:30
let_it_be(:group) { create(:group, :public, :crm_enabled) }
2021-04-29 21:17:54 +05:30
2020-07-28 23:09:34 +05:30
let(:current_user) { nil }
subject { described_class.new(current_user, group) }
context 'when design management is not available' do
it { is_expected.not_to be_allowed(:read_design_activity) }
context 'even when there are projects in the group' do
before do
create_list(:project_group_link, 2, group: group)
end
it { is_expected.not_to be_allowed(:read_design_activity) }
end
end
context 'when design management is available globally' do
include DesignManagementTestHelpers
before do
enable_design_management
end
context 'the group has no projects' do
it { is_expected.not_to be_allowed(:read_design_activity) }
end
context 'the group has a project' do
let(:project) { create(:project, :public) }
before do
create(:project_group_link, project: project, group: group)
end
it { is_expected.to be_allowed(:read_design_activity) }
context 'which does not have design management enabled' do
before do
2020-10-24 23:57:45 +05:30
project.update!(lfs_enabled: false)
2020-07-28 23:09:34 +05:30
end
it { is_expected.not_to be_allowed(:read_design_activity) }
context 'but another project does' do
before do
create(:project_group_link, project: create(:project, :public), group: group)
end
it { is_expected.to be_allowed(:read_design_activity) }
end
end
end
end
end
2020-11-24 15:15:51 +05:30
describe 'create_jira_connect_subscription' do
context 'admin' do
let(:current_user) { admin }
2021-04-17 20:07:23 +05:30
context 'when admin mode is enabled', :enable_admin_mode do
it { is_expected.to be_allowed(:create_jira_connect_subscription) }
end
context 'when admin mode is disabled' do
it { is_expected.to be_disallowed(:create_jira_connect_subscription) }
end
2020-11-24 15:15:51 +05:30
end
context 'with owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:create_jira_connect_subscription) }
end
context 'with maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:create_jira_connect_subscription) }
end
context 'with reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:create_jira_connect_subscription) }
end
context 'with guest' do
let(:current_user) { guest }
it { is_expected.to be_disallowed(:create_jira_connect_subscription) }
end
context 'with non member' do
let(:current_user) { create(:user) }
it { is_expected.to be_disallowed(:create_jira_connect_subscription) }
end
context 'with anonymous' do
let(:current_user) { nil }
it { is_expected.to be_disallowed(:create_jira_connect_subscription) }
end
end
2021-01-03 14:25:43 +05:30
describe 'read_package' do
context 'admin' do
let(:current_user) { admin }
2021-04-17 20:07:23 +05:30
context 'when admin mode is enabled', :enable_admin_mode do
it { is_expected.to be_allowed(:read_package) }
end
context 'when admin mode is disabled' do
it { is_expected.to be_disallowed(:read_package) }
end
2021-01-03 14:25:43 +05:30
end
context 'with owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:read_package) }
end
context 'with maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:read_package) }
end
context 'with reporter' do
let(:current_user) { reporter }
it { is_expected.to be_allowed(:read_package) }
end
context 'with guest' do
let(:current_user) { guest }
it { is_expected.to be_disallowed(:read_package) }
end
context 'with non member' do
let(:current_user) { create(:user) }
it { is_expected.to be_disallowed(:read_package) }
end
context 'with anonymous' do
let(:current_user) { nil }
it { is_expected.to be_disallowed(:read_package) }
end
end
2022-10-11 01:57:18 +05:30
describe 'observability' do
using RSpec::Parameterized::TableSyntax
let(:allowed) { be_allowed(:read_observability) }
let(:disallowed) { be_disallowed(:read_observability) }
# rubocop:disable Layout/LineLength
where(:feature_enabled, :admin_matcher, :owner_matcher, :maintainer_matcher, :developer_matcher, :reporter_matcher, :guest_matcher, :non_member_matcher, :anonymous_matcher) do
false | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed)
true | ref(:allowed) | ref(:allowed) | ref(:allowed) | ref(:allowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed) | ref(:disallowed)
end
# rubocop:enable Layout/LineLength
with_them do
before do
stub_feature_flags(observability_group_tab: feature_enabled)
end
context 'admin', :enable_admin_mode do
let(:current_user) { admin }
it { is_expected.to admin_matcher }
end
context 'owner' do
let(:current_user) { owner }
it { is_expected.to owner_matcher }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to maintainer_matcher }
end
context 'developer' do
let(:current_user) { developer }
it { is_expected.to developer_matcher }
end
context 'reporter' do
let(:current_user) { reporter }
it { is_expected.to reporter_matcher }
end
context 'with guest' do
let(:current_user) { guest }
it { is_expected.to guest_matcher }
end
context 'with non member' do
let(:current_user) { create(:user) }
it { is_expected.to non_member_matcher }
end
context 'with anonymous' do
let(:current_user) { nil }
it { is_expected.to anonymous_matcher }
end
end
end
2021-11-11 11:23:49 +05:30
describe 'dependency proxy' do
context 'feature disabled' do
let(:current_user) { owner }
it { is_expected.to be_disallowed(:read_dependency_proxy) }
it { is_expected.to be_disallowed(:admin_dependency_proxy) }
end
context 'feature enabled' do
before do
stub_config(dependency_proxy: { enabled: true })
end
context 'reporter' do
let(:current_user) { reporter }
2022-07-16 23:28:13 +05:30
it { is_expected.to be_allowed(:read_dependency_proxy) }
2021-11-11 11:23:49 +05:30
it { is_expected.to be_disallowed(:admin_dependency_proxy) }
end
context 'developer' do
let(:current_user) { developer }
2022-07-16 23:28:13 +05:30
it { is_expected.to be_allowed(:read_dependency_proxy) }
it { is_expected.to be_disallowed(:admin_dependency_proxy) }
end
context 'maintainer' do
let(:current_user) { maintainer }
it { is_expected.to be_allowed(:read_dependency_proxy) }
2021-11-11 11:23:49 +05:30
it { is_expected.to be_allowed(:admin_dependency_proxy) }
end
end
end
2021-01-03 14:25:43 +05:30
context 'deploy token access' do
let!(:group_deploy_token) do
create(:group_deploy_token, group: group, deploy_token: deploy_token)
end
subject { described_class.new(deploy_token, group) }
context 'a deploy token with read_package_registry scope' do
let(:deploy_token) { create(:deploy_token, :group, read_package_registry: true) }
it { is_expected.to be_allowed(:read_package) }
it { is_expected.to be_allowed(:read_group) }
it { is_expected.to be_disallowed(:create_package) }
end
context 'a deploy token with write_package_registry scope' do
let(:deploy_token) { create(:deploy_token, :group, write_package_registry: true) }
it { is_expected.to be_allowed(:create_package) }
2021-01-29 00:20:46 +05:30
it { is_expected.to be_allowed(:read_package) }
2021-01-03 14:25:43 +05:30
it { is_expected.to be_allowed(:read_group) }
it { is_expected.to be_disallowed(:destroy_package) }
end
2021-11-11 11:23:49 +05:30
context 'a deploy token with dependency proxy scopes' do
let_it_be(:deploy_token) { create(:deploy_token, :group, :dependency_proxy_scopes) }
before do
stub_config(dependency_proxy: { enabled: true })
end
it { is_expected.to be_allowed(:read_dependency_proxy) }
it { is_expected.to be_disallowed(:admin_dependency_proxy) }
end
2021-01-03 14:25:43 +05:30
end
it_behaves_like 'Self-managed Core resource access tokens'
2021-01-29 00:20:46 +05:30
context 'support bot' do
2022-03-02 08:16:31 +05:30
let_it_be(:group) { create(:group, :private, :crm_enabled) }
2021-01-29 00:20:46 +05:30
let_it_be(:current_user) { User.support_bot }
before do
allow(Gitlab::ServiceDesk).to receive(:supported?).and_return(true)
end
it { expect_disallowed(:read_label) }
context 'when group hierarchy has a project with service desk enabled' do
2022-03-02 08:16:31 +05:30
let_it_be(:subgroup) { create(:group, :private, :crm_enabled, parent: group) }
2021-01-29 00:20:46 +05:30
let_it_be(:project) { create(:project, group: subgroup, service_desk_enabled: true) }
it { expect_allowed(:read_label) }
it { expect(described_class.new(current_user, subgroup)).to be_allowed(:read_label) }
end
end
2021-04-29 21:17:54 +05:30
2022-03-02 08:16:31 +05:30
context "project bots" do
let(:project_bot) { create(:user, :project_bot) }
let(:user) { create(:user) }
context "project_bot_access" do
context "when regular user and part of the group" do
let(:current_user) { user }
before do
group.add_developer(user)
end
it { is_expected.not_to be_allowed(:project_bot_access) }
end
context "when project bot and not part of the project" do
let(:current_user) { project_bot }
it { is_expected.not_to be_allowed(:project_bot_access) }
end
context "when project bot and part of the project" do
let(:current_user) { project_bot }
before do
group.add_developer(project_bot)
end
it { is_expected.to be_allowed(:project_bot_access) }
end
end
context 'with resource access tokens' do
let(:current_user) { project_bot }
before do
group.add_maintainer(project_bot)
end
it { is_expected.not_to be_allowed(:create_resource_access_tokens) }
end
end
2021-09-04 01:27:46 +05:30
describe 'update_runners_registration_token' do
context 'admin' do
2021-04-29 21:17:54 +05:30
let(:current_user) { admin }
context 'when admin mode is enabled', :enable_admin_mode do
2021-09-04 01:27:46 +05:30
it { is_expected.to be_allowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'when admin mode is disabled' do
2021-09-04 01:27:46 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
end
context 'with owner' do
let(:current_user) { owner }
2021-09-04 01:27:46 +05:30
it { is_expected.to be_allowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'with maintainer' do
let(:current_user) { maintainer }
2021-11-18 22:05:49 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'with reporter' do
let(:current_user) { reporter }
2021-09-04 01:27:46 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'with guest' do
let(:current_user) { guest }
2021-09-04 01:27:46 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'with non member' do
let(:current_user) { create(:user) }
2021-09-04 01:27:46 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
context 'with anonymous' do
let(:current_user) { nil }
2021-09-04 01:27:46 +05:30
it { is_expected.to be_disallowed(:update_runners_registration_token) }
2021-04-29 21:17:54 +05:30
end
end
2021-12-11 22:18:48 +05:30
2022-01-26 12:08:38 +05:30
describe 'register_group_runners' do
2022-05-07 20:08:51 +05:30
context 'admin' do
let(:current_user) { admin }
2022-01-26 12:08:38 +05:30
2022-05-07 20:08:51 +05:30
context 'when admin mode is enabled', :enable_admin_mode do
2022-11-25 23:54:43 +05:30
it { is_expected.to be_allowed(:register_group_runners) }
2022-01-26 12:08:38 +05:30
2022-11-25 23:54:43 +05:30
context 'with group runner registration disabled' do
2022-01-26 12:08:38 +05:30
before do
2022-11-25 23:54:43 +05:30
stub_application_setting(valid_runner_registrars: ['project'])
2022-01-26 12:08:38 +05:30
end
2022-05-07 20:08:51 +05:30
it { is_expected.to be_allowed(:register_group_runners) }
end
2022-01-26 12:08:38 +05:30
end
context 'when admin mode is disabled' do
it { is_expected.to be_disallowed(:register_group_runners) }
end
end
context 'with owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:register_group_runners) }
2022-11-25 23:54:43 +05:30
context 'with group runner registration disabled' do
2022-05-07 20:08:51 +05:30
before do
2022-11-25 23:54:43 +05:30
stub_application_setting(valid_runner_registrars: ['project'])
2022-05-07 20:08:51 +05:30
end
2022-11-25 23:54:43 +05:30
it { is_expected.to be_disallowed(:register_group_runners) }
2022-05-07 20:08:51 +05:30
end
2022-01-26 12:08:38 +05:30
end
context 'with maintainer' do
let(:current_user) { maintainer }
2022-03-02 08:16:31 +05:30
it { is_expected.to be_disallowed(:register_group_runners) }
2022-01-26 12:08:38 +05:30
end
context 'with reporter' do
let(:current_user) { reporter }
it { is_expected.to be_disallowed(:register_group_runners) }
end
context 'with guest' do
let(:current_user) { guest }
it { is_expected.to be_disallowed(:register_group_runners) }
end
context 'with non member' do
let(:current_user) { create(:user) }
it { is_expected.to be_disallowed(:register_group_runners) }
end
context 'with anonymous' do
let(:current_user) { nil }
it { is_expected.to be_disallowed(:register_group_runners) }
end
end
2022-11-25 23:54:43 +05:30
describe 'read_group_all_available_runners' do
context 'admin' do
let(:current_user) { admin }
context 'when admin mode is enabled', :enable_admin_mode do
specify { is_expected.to be_allowed(:read_group_all_available_runners) }
end
context 'when admin mode is disabled' do
specify { is_expected.to be_disallowed(:read_group_all_available_runners) }
end
end
context 'with owner' do
let(:current_user) { owner }
specify { is_expected.to be_allowed(:read_group_all_available_runners) }
end
context 'with maintainer' do
let(:current_user) { maintainer }
specify { is_expected.to be_allowed(:read_group_all_available_runners) }
end
context 'with developer' do
let(:current_user) { developer }
specify { is_expected.to be_allowed(:read_group_all_available_runners) }
end
context 'with reporter' do
let(:current_user) { reporter }
specify { is_expected.to be_disallowed(:read_group_all_available_runners) }
end
context 'with guest' do
let(:current_user) { guest }
specify { is_expected.to be_disallowed(:read_group_all_available_runners) }
end
context 'with non member' do
let(:current_user) { create(:user) }
specify { is_expected.to be_disallowed(:read_group_all_available_runners) }
end
context 'with anonymous' do
let(:current_user) { nil }
specify { is_expected.to be_disallowed(:read_group_all_available_runners) }
end
end
2022-07-16 23:28:13 +05:30
describe 'change_prevent_sharing_groups_outside_hierarchy' do
context 'with owner' do
let(:current_user) { owner }
it { is_expected.to be_allowed(:change_prevent_sharing_groups_outside_hierarchy) }
end
context 'with non-owner roles' do
where(role: %w[admin maintainer reporter developer guest])
with_them do
let(:current_user) { public_send role }
it { is_expected.to be_disallowed(:change_prevent_sharing_groups_outside_hierarchy) }
end
end
end
2022-03-02 08:16:31 +05:30
context 'when crm_enabled is false' do
let(:current_user) { owner }
before_all do
group.crm_settings.enabled = false
group.crm_settings.save!
end
it { is_expected.to be_disallowed(:read_crm_contact) }
it { is_expected.to be_disallowed(:read_crm_organization) }
it { is_expected.to be_disallowed(:admin_crm_contact) }
it { is_expected.to be_disallowed(:admin_crm_organization) }
end
2022-08-13 15:12:31 +05:30
2022-08-27 11:52:29 +05:30
it_behaves_like 'checks timelog categories permissions' do
let(:group) { create(:group) }
let(:namespace) { group }
let(:users_container) { group }
2022-08-13 15:12:31 +05:30
2022-08-27 11:52:29 +05:30
subject { described_class.new(current_user, group) }
2022-08-13 15:12:31 +05:30
end
2017-08-17 22:00:37 +05:30
end