debian-mirror-gitlab/spec/services/notes/quick_actions_service_spec.rb

204 lines
6.2 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2016-09-13 17:45:13 +05:30
require 'spec_helper'
2017-09-10 17:25:29 +05:30
describe Notes::QuickActionsService do
2016-09-13 17:45:13 +05:30
shared_context 'note on noteable' do
2018-12-13 13:39:08 +05:30
let(:project) { create(:project, :repository) }
2018-11-18 11:00:15 +05:30
let(:maintainer) { create(:user).tap { |u| project.add_maintainer(u) } }
2016-09-13 17:45:13 +05:30
let(:assignee) { create(:user) }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(assignee)
2017-09-10 17:25:29 +05:30
end
2016-09-13 17:45:13 +05:30
end
2017-09-10 17:25:29 +05:30
shared_examples 'note on noteable that supports quick actions' do
2016-09-13 17:45:13 +05:30
include_context 'note on noteable'
before do
note.note = note_text
end
let!(:milestone) { create(:milestone, project: project) }
let!(:labels) { create_pair(:label, project: project) }
describe 'note with only command' do
describe '/close, /label, /assign & /milestone' do
let(:note_text) do
%(/close\n/label ~#{labels.first.name} ~#{labels.last.name}\n/assign @#{assignee.username}\n/milestone %"#{milestone.name}")
end
it 'closes noteable, sets labels, assigns, and sets milestone to noteable, and leave no note' do
2019-07-07 11:18:12 +05:30
content, update_params = service.execute(note)
service.apply_updates(update_params, note)
2016-09-13 17:45:13 +05:30
expect(content).to eq ''
expect(note.noteable).to be_closed
expect(note.noteable.labels).to match_array(labels)
2017-08-17 22:00:37 +05:30
expect(note.noteable.assignees).to eq([assignee])
2016-09-13 17:45:13 +05:30
expect(note.noteable.milestone).to eq(milestone)
end
end
describe '/reopen' do
before do
note.noteable.close!
expect(note.noteable).to be_closed
end
let(:note_text) { '/reopen' }
it 'opens the noteable, and leave no note' do
2019-07-07 11:18:12 +05:30
content, update_params = service.execute(note)
service.apply_updates(update_params, note)
2016-09-13 17:45:13 +05:30
expect(content).to eq ''
expect(note.noteable).to be_open
end
end
2017-08-17 22:00:37 +05:30
describe '/spend' do
let(:note_text) { '/spend 1h' }
it 'updates the spent time on the noteable' do
2019-07-07 11:18:12 +05:30
content, update_params = service.execute(note)
service.apply_updates(update_params, note)
2017-08-17 22:00:37 +05:30
expect(content).to eq ''
expect(note.noteable.time_spent).to eq(3600)
end
end
2016-09-13 17:45:13 +05:30
end
describe 'note with command & text' do
describe '/close, /label, /assign & /milestone' do
let(:note_text) do
%(HELLO\n/close\n/label ~#{labels.first.name} ~#{labels.last.name}\n/assign @#{assignee.username}\n/milestone %"#{milestone.name}"\nWORLD)
end
it 'closes noteable, sets labels, assigns, and sets milestone to noteable' do
2019-07-07 11:18:12 +05:30
content, update_params = service.execute(note)
service.apply_updates(update_params, note)
2016-09-13 17:45:13 +05:30
expect(content).to eq "HELLO\nWORLD"
expect(note.noteable).to be_closed
expect(note.noteable.labels).to match_array(labels)
2017-08-17 22:00:37 +05:30
expect(note.noteable.assignees).to eq([assignee])
2016-09-13 17:45:13 +05:30
expect(note.noteable.milestone).to eq(milestone)
end
end
describe '/reopen' do
before do
note.noteable.close
expect(note.noteable).to be_closed
end
let(:note_text) { "HELLO\n/reopen\nWORLD" }
it 'opens the noteable' do
2019-07-07 11:18:12 +05:30
content, update_params = service.execute(note)
service.apply_updates(update_params, note)
2016-09-13 17:45:13 +05:30
expect(content).to eq "HELLO\nWORLD"
expect(note.noteable).to be_open
end
end
end
end
2016-09-29 09:46:39 +05:30
describe '.noteable_update_service' do
include_context 'note on noteable'
it 'returns Issues::UpdateService for a note on an issue' do
note = create(:note_on_issue, project: project)
expect(described_class.noteable_update_service(note)).to eq(Issues::UpdateService)
end
2018-11-20 20:47:30 +05:30
it 'returns MergeRequests::UpdateService for a note on a merge request' do
2016-09-29 09:46:39 +05:30
note = create(:note_on_merge_request, project: project)
expect(described_class.noteable_update_service(note)).to eq(MergeRequests::UpdateService)
end
2018-11-20 20:47:30 +05:30
it 'returns Commits::TagService for a note on a commit' do
2016-09-29 09:46:39 +05:30
note = create(:note_on_commit, project: project)
2018-11-20 20:47:30 +05:30
expect(described_class.noteable_update_service(note)).to eq(Commits::TagService)
2016-09-29 09:46:39 +05:30
end
end
describe '.supported?' do
include_context 'note on noteable'
let(:note) { create(:note_on_issue, project: project) }
2018-03-27 19:54:05 +05:30
context 'with a note on an issue' do
2016-09-29 09:46:39 +05:30
it 'returns true' do
2018-03-27 19:54:05 +05:30
expect(described_class.supported?(note)).to be_truthy
2016-09-29 09:46:39 +05:30
end
2018-03-27 19:54:05 +05:30
end
2016-09-29 09:46:39 +05:30
2018-03-27 19:54:05 +05:30
context 'with a note on a commit' do
let(:note) { create(:note_on_commit, project: project) }
2016-09-29 09:46:39 +05:30
2018-03-27 19:54:05 +05:30
it 'returns false' do
2018-11-20 20:47:30 +05:30
expect(described_class.supported?(note)).to be_truthy
2016-09-29 09:46:39 +05:30
end
end
end
describe '#supported?' do
include_context 'note on noteable'
it 'delegates to the class method' do
2018-11-18 11:00:15 +05:30
service = described_class.new(project, maintainer)
2016-09-29 09:46:39 +05:30
note = create(:note_on_issue, project: project)
2018-03-27 19:54:05 +05:30
expect(described_class).to receive(:supported?).with(note)
2016-09-29 09:46:39 +05:30
service.supported?(note)
end
end
2016-09-13 17:45:13 +05:30
describe '#execute' do
2018-11-18 11:00:15 +05:30
let(:service) { described_class.new(project, maintainer) }
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'note on noteable that supports quick actions' do
2016-09-13 17:45:13 +05:30
let(:note) { build(:note_on_issue, project: project) }
end
2017-09-10 17:25:29 +05:30
it_behaves_like 'note on noteable that supports quick actions' do
2016-09-13 17:45:13 +05:30
let(:note) { build(:note_on_merge_request, project: project) }
end
end
2017-08-17 22:00:37 +05:30
context 'CE restriction for issue assignees' do
describe '/assign' do
2017-09-10 17:25:29 +05:30
let(:project) { create(:project) }
2018-11-18 11:00:15 +05:30
let(:maintainer) { create(:user).tap { |u| project.add_maintainer(u) } }
2017-08-17 22:00:37 +05:30
let(:assignee) { create(:user) }
2018-11-18 11:00:15 +05:30
let(:maintainer) { create(:user) }
let(:service) { described_class.new(project, maintainer) }
2017-08-17 22:00:37 +05:30
let(:note) { create(:note_on_issue, note: note_text, project: project) }
let(:note_text) do
2018-11-18 11:00:15 +05:30
%(/assign @#{assignee.username} @#{maintainer.username}\n")
2017-08-17 22:00:37 +05:30
end
before do
2019-07-07 11:18:12 +05:30
stub_licensed_features(multiple_issue_assignees: false)
2018-11-18 11:00:15 +05:30
project.add_maintainer(maintainer)
project.add_maintainer(assignee)
2017-08-17 22:00:37 +05:30
end
it 'adds only one assignee from the list' do
2019-07-07 11:18:12 +05:30
_, update_params = service.execute(note)
service.apply_updates(update_params, note)
2017-08-17 22:00:37 +05:30
expect(note.noteable.assignees.count).to eq(1)
end
end
end
2016-09-13 17:45:13 +05:30
end