debian-mirror-gitlab/spec/tooling/danger/feature_flag_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

165 lines
4.8 KiB
Ruby
Raw Normal View History

2021-03-11 19:13:27 +05:30
# frozen_string_literal: true
2021-04-17 20:07:23 +05:30
require 'gitlab-dangerfiles'
require 'gitlab/dangerfiles/spec_helper'
2021-03-11 19:13:27 +05:30
require_relative '../../../tooling/danger/feature_flag'
RSpec.describe Tooling::Danger::FeatureFlag do
2021-04-17 20:07:23 +05:30
include_context "with dangerfile"
2021-03-11 19:13:27 +05:30
2021-04-17 20:07:23 +05:30
let(:fake_danger) { DangerSpecHelper.fake_danger.include(described_class) }
2021-03-11 19:13:27 +05:30
2021-09-30 23:02:18 +05:30
subject(:feature_flag) { fake_danger.new(helper: fake_helper) }
2021-03-11 19:13:27 +05:30
describe '#feature_flag_files' do
let(:feature_flag_files) do
[
'config/feature_flags/development/entry.yml',
'ee/config/feature_flags/ops/entry.yml'
]
end
let(:other_files) do
[
'app/models/model.rb',
'app/assets/javascripts/file.js'
]
end
shared_examples 'an array of Found objects' do |change_type|
it 'returns an array of Found objects' do
expect(feature_flag.feature_flag_files(change_type: change_type)).to contain_exactly(an_instance_of(described_class::Found), an_instance_of(described_class::Found))
expect(feature_flag.feature_flag_files(change_type: change_type).map(&:path)).to eq(feature_flag_files)
end
end
shared_examples 'an empty array' do |change_type|
it 'returns an array of Found objects' do
expect(feature_flag.feature_flag_files(change_type: change_type)).to be_empty
end
end
describe 'retrieves added feature flag files' do
context 'with added added feature flag files' do
let(:added_files) { feature_flag_files }
include_examples 'an array of Found objects', :added
end
context 'without added added feature flag files' do
let(:added_files) { other_files }
include_examples 'an empty array', :added
end
end
describe 'retrieves modified feature flag files' do
context 'with modified modified feature flag files' do
let(:modified_files) { feature_flag_files }
include_examples 'an array of Found objects', :modified
end
context 'without modified modified feature flag files' do
let(:modified_files) { other_files }
include_examples 'an empty array', :modified
end
end
describe 'retrieves deleted feature flag files' do
context 'with deleted deleted feature flag files' do
let(:deleted_files) { feature_flag_files }
include_examples 'an array of Found objects', :deleted
end
context 'without deleted deleted feature flag files' do
let(:deleted_files) { other_files }
include_examples 'an empty array', :deleted
end
end
end
2023-06-20 00:43:36 +05:30
describe '#stage_label' do
before do
allow(fake_helper).to receive(:mr_labels).and_return(labels)
end
context 'when there is no stage label' do
let(:labels) { [] }
it 'returns nil' do
expect(feature_flag.stage_label).to be_nil
end
end
context 'when there is a stage label' do
let(:labels) { ['devops::verify', 'group::pipeline execution'] }
it 'returns the stage label' do
expect(feature_flag.stage_label).to eq(labels.first)
end
end
end
2021-03-11 19:13:27 +05:30
describe described_class::Found do
let(:feature_flag_path) { 'config/feature_flags/development/entry.yml' }
let(:group) { 'group::source code' }
2023-04-23 21:23:45 +05:30
let(:yaml) do
{
2021-09-30 23:02:18 +05:30
'group' => group,
'default_enabled' => true,
2023-04-23 21:23:45 +05:30
'rollout_issue_url' => 'https://gitlab.com/gitlab-org/gitlab/-/issues/1',
'introduced_by_url' => 'https://gitlab.com/gitlab-org/gitlab/-/issues/2',
'milestone' => '15.9',
'type' => 'development',
'name' => 'entry'
}
2021-03-11 19:13:27 +05:30
end
2023-04-23 21:23:45 +05:30
let(:raw_yaml) { YAML.dump(yaml) }
2021-03-11 19:13:27 +05:30
subject(:found) { described_class.new(feature_flag_path) }
before do
allow(File).to receive(:read).and_call_original
expect(File).to receive(:read).with(feature_flag_path).and_return(raw_yaml)
end
2023-04-23 21:23:45 +05:30
described_class::ATTRIBUTES.each do |attribute|
describe "##{attribute}" do
it 'returns value from the YAML' do
expect(found.public_send(attribute)).to eq(yaml[attribute])
end
2021-09-30 23:02:18 +05:30
end
end
2023-04-23 21:23:45 +05:30
describe '#raw' do
it 'returns the raw YAML' do
expect(found.raw).to eq(raw_yaml)
2021-09-30 23:02:18 +05:30
end
end
2021-03-11 19:13:27 +05:30
describe '#group_match_mr_label?' do
context 'when group is nil' do
let(:group) { nil }
2023-04-23 21:23:45 +05:30
it 'is true only if MR has no group label' do
expect(found.group_match_mr_label?(nil)).to eq true
expect(found.group_match_mr_label?('group::source code')).to eq false
2021-03-11 19:13:27 +05:30
end
2023-04-23 21:23:45 +05:30
end
2021-03-11 19:13:27 +05:30
2023-04-23 21:23:45 +05:30
context 'when group is not nil' do
it 'is true only if MR has the same group label' do
expect(found.group_match_mr_label?(group)).to eq true
expect(found.group_match_mr_label?('group::authentication and authorization')).to eq false
2021-03-11 19:13:27 +05:30
end
end
end
end
end