2021-10-27 15:23:28 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-05-27 22:25:52 +05:30
|
|
|
RSpec.describe Users::UnbanService, feature_category: :user_management do
|
2021-10-27 15:23:28 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
let_it_be(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
shared_examples 'does not modify the BannedUser record or user state' do
|
|
|
|
it 'does not modify the BannedUser record or user state' do
|
|
|
|
expect { unban_user }.not_to change { Users::BannedUser.count }
|
|
|
|
expect { unban_user }.not_to change { user.state }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'unban', :aggregate_failures do
|
|
|
|
subject(:unban_user) { described_class.new(current_user).execute(user) }
|
|
|
|
|
|
|
|
context 'when successful', :enable_admin_mode do
|
|
|
|
before do
|
|
|
|
user.ban!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns success status' do
|
|
|
|
response = unban_user
|
|
|
|
|
|
|
|
expect(response[:status]).to eq(:success)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'unbans the user' do
|
|
|
|
expect { unban_user }.to change { user.state }.from('banned').to('active')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes the BannedUser' do
|
|
|
|
expect { unban_user }.to change { Users::BannedUser.count }.by(-1)
|
|
|
|
expect(user.reload.banned_user).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'logs unban in application logs' do
|
2023-01-13 00:05:48 +05:30
|
|
|
expect(Gitlab::AppLogger).to receive(:info).with(message: "User unban", user: user.username.to_s, email: user.email.to_s, unban_by: current_user.username.to_s, ip_address: current_user.current_sign_in_ip.to_s)
|
2021-10-27 15:23:28 +05:30
|
|
|
|
|
|
|
unban_user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when failed' do
|
|
|
|
context 'when user is already active', :enable_admin_mode do
|
|
|
|
it 'returns state error message' do
|
|
|
|
response = unban_user
|
|
|
|
|
|
|
|
expect(response[:status]).to eq(:error)
|
2021-11-11 11:23:49 +05:30
|
|
|
expect(response[:message]).to match('You cannot unban active users.')
|
2021-10-27 15:23:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'does not modify the BannedUser record or user state'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not an admin' do
|
|
|
|
before do
|
|
|
|
user.ban!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns permissions error message' do
|
|
|
|
response = unban_user
|
|
|
|
|
|
|
|
expect(response[:status]).to eq(:error)
|
|
|
|
expect(response[:message]).to match(/You are not allowed to unban a user/)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'does not modify the BannedUser record or user state'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|