debian-mirror-gitlab/spec/services/git/base_hooks_service_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

365 lines
9.6 KiB
Ruby
Raw Normal View History

2019-09-04 21:01:54 +05:30
# frozen_string_literal: true
require 'spec_helper'
2023-05-27 22:25:52 +05:30
RSpec.describe Git::BaseHooksService, feature_category: :source_code_management do
2019-09-04 21:01:54 +05:30
include RepoHelpers
2023-01-13 00:05:48 +05:30
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository) }
2019-09-04 21:01:54 +05:30
let(:oldrev) { Gitlab::Git::BLANK_SHA }
let(:newrev) { "8a2a6eb295bb170b34c24c76c49ed0e9b2eaf34b" } # gitlab-test: git rev-parse refs/tags/v1.1.0
let(:ref) { 'refs/tags/v1.1.0' }
2020-01-01 13:55:28 +05:30
let(:checkout_sha) { '5937ac0a7beb003549fc5fd26fc247adbce4a52e' }
2019-09-04 21:01:54 +05:30
2019-12-21 20:55:43 +05:30
let(:test_service) do
Class.new(described_class) do
2019-10-12 21:52:04 +05:30
def hook_name
:push_hooks
end
2021-11-11 11:23:49 +05:30
def limited_commits
2019-10-12 21:52:04 +05:30
[]
end
2021-11-11 11:23:49 +05:30
def commits_count
0
end
2019-10-12 21:52:04 +05:30
end
2019-12-21 20:55:43 +05:30
end
2019-10-12 21:52:04 +05:30
2019-12-21 20:55:43 +05:30
subject { test_service.new(project, user, params) }
let(:params) do
{
change: {
oldrev: oldrev,
newrev: newrev,
ref: ref
}
}
end
2019-10-12 21:52:04 +05:30
2019-12-21 20:55:43 +05:30
describe 'push event' do
it 'creates push event' do
expect_next_instance_of(EventCreateService) do |service|
expect(service).to receive(:push)
end
subject.execute
end
2019-10-12 21:52:04 +05:30
2019-12-21 20:55:43 +05:30
context 'create_push_event is set to false' do
before do
params[:create_push_event] = false
end
it 'does not create push event' do
expect(EventCreateService).not_to receive(:new)
subject.execute
end
end
end
2021-09-30 23:02:18 +05:30
describe 'project hooks and integrations' do
2019-12-21 20:55:43 +05:30
context 'hooks' do
2019-10-12 21:52:04 +05:30
before do
expect(project).to receive(:has_active_hooks?).and_return(active)
end
context 'active hooks' do
let(:active) { true }
it 'executes the hooks' do
expect(subject).to receive(:push_data).at_least(:once).and_call_original
expect(project).to receive(:execute_hooks)
subject.execute
end
end
context 'inactive hooks' do
let(:active) { false }
it 'does not execute the hooks' do
expect(subject).not_to receive(:push_data)
expect(project).not_to receive(:execute_hooks)
subject.execute
end
end
end
2021-09-30 23:02:18 +05:30
context 'with integrations' do
2019-10-12 21:52:04 +05:30
before do
2021-09-30 23:02:18 +05:30
expect(project).to receive(:has_active_integrations?).and_return(active)
2019-10-12 21:52:04 +05:30
end
2021-09-30 23:02:18 +05:30
context 'with active integrations' do
2019-10-12 21:52:04 +05:30
let(:active) { true }
it 'executes the services' do
expect(subject).to receive(:push_data).at_least(:once).and_call_original
2021-09-30 23:02:18 +05:30
expect(project).to receive(:execute_integrations)
2019-10-12 21:52:04 +05:30
subject.execute
end
end
2021-09-30 23:02:18 +05:30
context 'with inactive integrations' do
2019-10-12 21:52:04 +05:30
let(:active) { false }
it 'does not execute the services' do
expect(subject).not_to receive(:push_data)
2021-09-30 23:02:18 +05:30
expect(project).not_to receive(:execute_integrations)
2019-10-12 21:52:04 +05:30
subject.execute
end
end
end
2019-09-04 21:01:54 +05:30
2021-09-30 23:02:18 +05:30
context 'when execute_project_hooks param is set to false' do
2019-09-04 21:01:54 +05:30
before do
2019-12-21 20:55:43 +05:30
params[:execute_project_hooks] = false
2019-09-04 21:01:54 +05:30
2019-12-21 20:55:43 +05:30
allow(project).to receive(:has_active_hooks?).and_return(true)
2021-09-30 23:02:18 +05:30
allow(project).to receive(:has_active_integrations?).and_return(true)
2019-09-04 21:01:54 +05:30
end
2021-09-30 23:02:18 +05:30
it 'does not execute hooks and integrations' do
2019-12-21 20:55:43 +05:30
expect(project).not_to receive(:execute_hooks)
2021-09-30 23:02:18 +05:30
expect(project).not_to receive(:execute_integrations)
2019-09-04 21:01:54 +05:30
2019-12-21 20:55:43 +05:30
subject.execute
2019-09-04 21:01:54 +05:30
end
end
end
2020-01-01 13:55:28 +05:30
describe 'Generating CI variables from push options' do
let(:pipeline_params) do
{
after: newrev,
before: oldrev,
checkout_sha: checkout_sha,
push_options: push_options, # defined in each context
ref: ref,
variables_attributes: variables_attributes # defined in each context
}
end
shared_examples 'creates pipeline with params and expected variables' do
2023-01-13 00:05:48 +05:30
let(:pipeline_service) { double(execute: service_response) }
let(:service_response) { double(error?: false, payload: pipeline, message: "Error") }
let(:pipeline) { double(persisted?: true) }
2020-01-01 13:55:28 +05:30
it 'calls the create pipeline service' do
expect(Ci::CreatePipelineService)
.to receive(:new)
.with(project, user, pipeline_params)
2023-01-13 00:05:48 +05:30
.and_return(pipeline_service)
expect(subject).not_to receive(:log_pipeline_errors)
2020-01-01 13:55:28 +05:30
subject.execute
end
end
context 'with empty push options' do
let(:push_options) { {} }
let(:variables_attributes) { [] }
it_behaves_like 'creates pipeline with params and expected variables'
end
context 'with push options not specifying variables' do
let(:push_options) do
{
mr: {
create: true
}
}
end
2020-10-24 23:57:45 +05:30
2020-01-01 13:55:28 +05:30
let(:variables_attributes) { [] }
before do
params[:push_options] = push_options
end
it_behaves_like 'creates pipeline with params and expected variables'
end
context 'with push options specifying variables' do
let(:push_options) do
{
ci: {
variable: {
"FOO=123": 1,
"BAR=456": 1,
"MNO=890=ABC": 1
}
}
}
end
2020-10-24 23:57:45 +05:30
2020-01-01 13:55:28 +05:30
let(:variables_attributes) do
[
{ "key" => "FOO", "variable_type" => "env_var", "secret_value" => "123" },
{ "key" => "BAR", "variable_type" => "env_var", "secret_value" => "456" },
{ "key" => "MNO", "variable_type" => "env_var", "secret_value" => "890=ABC" }
]
end
before do
params[:push_options] = push_options
end
it_behaves_like 'creates pipeline with params and expected variables'
end
context 'with push options not specifying variables in correct format' do
let(:push_options) do
{
ci: {
variable: {
"FOO=123": 1,
"BAR": 1,
"=MNO": 1
}
}
}
end
2020-10-24 23:57:45 +05:30
2020-01-01 13:55:28 +05:30
let(:variables_attributes) do
[
{ "key" => "FOO", "variable_type" => "env_var", "secret_value" => "123" }
]
end
before do
params[:push_options] = push_options
end
it_behaves_like 'creates pipeline with params and expected variables'
end
end
2023-01-13 00:05:48 +05:30
describe "Pipeline creation" do
let(:pipeline_params) do
{
after: newrev,
before: oldrev,
checkout_sha: checkout_sha,
push_options: push_options,
ref: ref,
variables_attributes: variables_attributes
}
end
let(:pipeline_service) { double(execute: service_response) }
let(:push_options) { {} }
let(:variables_attributes) { [] }
context "when the pipeline is persisted" do
let(:pipeline) { double(persisted?: true) }
context "and there are no errors" do
let(:service_response) { double(error?: false, payload: pipeline, message: "Error") }
it "returns success" do
expect(Ci::CreatePipelineService)
.to receive(:new)
.with(project, user, pipeline_params)
.and_return(pipeline_service)
expect(subject.execute[:status]).to eq(:success)
end
end
context "and there are errors" do
let(:service_response) { double(error?: true, payload: pipeline, message: "Error") }
it "does not log errors and returns success" do
# This behaviour is due to the save_on_errors: true setting that is the default in the execute method.
expect(Ci::CreatePipelineService)
.to receive(:new)
.with(project, user, pipeline_params)
.and_return(pipeline_service)
expect(subject).not_to receive(:log_pipeline_errors).with(service_response.message)
expect(subject.execute[:status]).to eq(:success)
end
end
end
context "when the pipeline wasn't persisted" do
let(:pipeline) { double(persisted?: false) }
context "and there are no errors" do
let(:service_response) { double(error?: false, payload: pipeline, message: nil) }
it "returns success" do
expect(Ci::CreatePipelineService)
.to receive(:new)
.with(project, user, pipeline_params)
.and_return(pipeline_service)
expect(subject).to receive(:log_pipeline_errors).with(service_response.message)
expect(subject.execute[:status]).to eq(:success)
end
end
context "and there are errors" do
let(:service_response) { double(error?: true, payload: pipeline, message: "Error") }
it "logs errors and returns success" do
expect(Ci::CreatePipelineService)
.to receive(:new)
.with(project, user, pipeline_params)
.and_return(pipeline_service)
expect(subject).to receive(:log_pipeline_errors).with(service_response.message)
expect(subject.execute[:status]).to eq(:success)
end
end
end
end
2023-07-09 08:55:56 +05:30
describe 'notifying KAS' do
let(:kas_enabled) { true }
before do
allow(Gitlab::Kas).to receive(:enabled?).and_return(kas_enabled)
end
it 'enqueues the notification worker' do
expect(Clusters::Agents::NotifyGitPushWorker).to receive(:perform_async).with(project.id).once
subject.execute
end
context 'when KAS is disabled' do
let(:kas_enabled) { false }
it do
expect(Clusters::Agents::NotifyGitPushWorker).not_to receive(:perform_async)
subject.execute
end
end
context 'when :notify_kas_on_git_push feature flag is disabled' do
before do
stub_feature_flags(notify_kas_on_git_push: false)
end
it do
expect(Clusters::Agents::NotifyGitPushWorker).not_to receive(:perform_async)
subject.execute
end
end
end
2019-09-04 21:01:54 +05:30
end