2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe GroupMember do
|
2023-01-13 00:05:48 +05:30
|
|
|
describe 'default values' do
|
|
|
|
subject(:goup_member) { build(:group_member) }
|
|
|
|
|
|
|
|
it { expect(goup_member.source_type).to eq(described_class::SOURCE_TYPE) }
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'scopes' do
|
2021-01-29 00:20:46 +05:30
|
|
|
let_it_be(:user_1) { create(:user) }
|
|
|
|
let_it_be(:user_2) { create(:user) }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'counts users by group ID' do
|
|
|
|
group_1 = create(:group)
|
|
|
|
group_2 = create(:group)
|
|
|
|
|
|
|
|
group_1.add_owner(user_1)
|
|
|
|
group_1.add_owner(user_2)
|
|
|
|
group_2.add_owner(user_1)
|
|
|
|
|
|
|
|
expect(described_class.count_users_by_group_id).to eq(group_1.id => 2,
|
|
|
|
group_2.id => 1)
|
2020-06-23 00:09:42 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
describe '.of_ldap_type' do
|
|
|
|
it 'returns ldap type users' do
|
|
|
|
group_member = create(:group_member, :ldap)
|
|
|
|
|
|
|
|
expect(described_class.of_ldap_type).to eq([group_member])
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
describe '.with_user' do
|
|
|
|
it 'returns requested user' do
|
|
|
|
group_member = create(:group_member, user: user_2)
|
|
|
|
create(:group_member, user: user_1)
|
|
|
|
|
|
|
|
expect(described_class.with_user(user_2)).to eq([group_member])
|
|
|
|
end
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
|
2021-09-04 01:27:46 +05:30
|
|
|
describe 'delegations' do
|
|
|
|
it { is_expected.to delegate_method(:update_two_factor_requirement).to(:user).allow_nil }
|
|
|
|
end
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
describe '.access_level_roles' do
|
|
|
|
it 'returns Gitlab::Access.options_with_owner' do
|
|
|
|
expect(described_class.access_level_roles).to eq(Gitlab::Access.options_with_owner)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
describe '#permissible_access_level_roles' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
|
|
|
|
it 'returns Gitlab::Access.options_with_owner' do
|
|
|
|
result = described_class.permissible_access_level_roles(group.first_owner, group)
|
|
|
|
|
|
|
|
expect(result).to eq(Gitlab::Access.options_with_owner)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
it_behaves_like 'members notifications', :group
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
describe '#namespace_id' do
|
|
|
|
subject { build(:group_member, source_id: 1).namespace_id }
|
|
|
|
|
|
|
|
it { is_expected.to eq 1 }
|
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
describe '#real_source_type' do
|
|
|
|
subject { create(:group_member).real_source_type }
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
it { is_expected.to eq 'Group' }
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
describe '#update_two_factor_requirement' do
|
|
|
|
it 'is called after creation and deletion' do
|
2020-03-07 23:17:34 +05:30
|
|
|
user = build :user
|
2022-10-11 01:57:18 +05:30
|
|
|
group = create :group
|
|
|
|
group_member = build :group_member, user: user, group: group
|
2020-03-07 23:17:34 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(user).to receive(:update_two_factor_requirement)
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
group_member.save!
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
expect(user).to receive(:update_two_factor_requirement)
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
group_member.destroy!
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2021-09-04 01:27:46 +05:30
|
|
|
describe '#destroy' do
|
|
|
|
context 'for an orphaned member' do
|
|
|
|
let!(:orphaned_group_member) do
|
|
|
|
create(:group_member).tap { |member| member.update_column(:user_id, nil) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not raise an error' do
|
|
|
|
expect { orphaned_group_member.destroy! }.not_to raise_error
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-07 23:17:34 +05:30
|
|
|
describe '#after_accept_invite' do
|
|
|
|
it 'calls #update_two_factor_requirement' do
|
|
|
|
email = 'foo@email.com'
|
|
|
|
user = build(:user, email: email)
|
|
|
|
group = create(:group, require_two_factor_authentication: true)
|
|
|
|
group_member = create(:group_member, group: group, invite_token: '1234', invite_email: email)
|
|
|
|
|
|
|
|
expect(user).to receive(:require_two_factor_authentication_from_group).and_call_original
|
|
|
|
|
|
|
|
group_member.accept_invite!(user)
|
|
|
|
|
|
|
|
expect(user.require_two_factor_authentication_from_group).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
describe '#last_owner_of_the_group?' do
|
|
|
|
context 'when member is an owner' do
|
|
|
|
let_it_be(:group_member) { build(:group_member, :owner) }
|
|
|
|
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(:member_last_owner?, :member_last_blocked_owner?, :expected) do
|
|
|
|
false | false | false
|
|
|
|
true | false | true
|
|
|
|
false | true | true
|
|
|
|
true | true | true
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it "returns expected" do
|
|
|
|
allow(group_member.group).to receive(:member_last_owner?).with(group_member).and_return(member_last_owner?)
|
|
|
|
allow(group_member.group).to receive(:member_last_blocked_owner?)
|
|
|
|
.with(group_member)
|
|
|
|
.and_return(member_last_blocked_owner?)
|
|
|
|
|
|
|
|
expect(group_member.last_owner_of_the_group?).to be(expected)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member is not an owner' do
|
|
|
|
let_it_be(:group_member) { build(:group_member, :guest) }
|
|
|
|
|
|
|
|
subject { group_member.last_owner_of_the_group? }
|
|
|
|
|
|
|
|
it { is_expected.to be(false) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'access levels' do
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'with parent group' do
|
|
|
|
it_behaves_like 'inherited access level as a member of entity' do
|
|
|
|
let(:entity) { create(:group, parent: parent_entity) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with parent group and a sub subgroup' do
|
|
|
|
it_behaves_like 'inherited access level as a member of entity' do
|
|
|
|
let(:subgroup) { create(:group, parent: parent_entity) }
|
|
|
|
let(:entity) { create(:group, parent: subgroup) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when only the subgroup has the member' do
|
|
|
|
it_behaves_like 'inherited access level as a member of entity' do
|
|
|
|
let(:parent_entity) { create(:group, parent: create(:group)) }
|
|
|
|
let(:entity) { create(:group, parent: parent_entity) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-03-08 18:12:59 +05:30
|
|
|
|
|
|
|
context 'when group member expiration date is updated' do
|
|
|
|
let_it_be(:group_member) { create(:group_member) }
|
|
|
|
|
|
|
|
it 'emails the user that their group membership expiry has changed' do
|
|
|
|
expect_next_instance_of(NotificationService) do |notification|
|
|
|
|
allow(notification).to receive(:updated_group_member_expiration).with(group_member)
|
|
|
|
end
|
|
|
|
|
|
|
|
group_member.update!(expires_at: 5.days.from_now)
|
|
|
|
end
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
|
|
|
|
describe 'refresh_member_authorized_projects' do
|
|
|
|
context 'when importing' do
|
|
|
|
it 'does not refresh' do
|
|
|
|
expect(UserProjectAccessChangedService).not_to receive(:new)
|
2022-10-11 01:57:18 +05:30
|
|
|
group = create(:group)
|
|
|
|
member = build(:group_member, group: group)
|
2021-10-27 15:23:28 +05:30
|
|
|
member.importing = true
|
|
|
|
member.save!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-07-23 23:45:48 +05:30
|
|
|
|
|
|
|
context 'authorization refresh on addition/updation/deletion' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:project_a) { create(:project, group: group) }
|
|
|
|
let_it_be(:project_b) { create(:project, group: group) }
|
|
|
|
let_it_be(:project_c) { create(:project, group: group) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
shared_examples_for 'calls AuthorizedProjectsWorker inline to recalculate authorizations' do
|
|
|
|
# this is inline with the overridden behaviour in stubbed_member.rb
|
|
|
|
it 'calls AuthorizedProjectsWorker inline to recalculate authorizations' do
|
|
|
|
worker_instance = AuthorizedProjectsWorker.new
|
|
|
|
expect(AuthorizedProjectsWorker).to receive(:new).and_return(worker_instance)
|
|
|
|
expect(worker_instance).to receive(:perform).with(user.id)
|
2022-07-23 23:45:48 +05:30
|
|
|
|
|
|
|
action
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on create' do
|
2022-08-13 15:12:31 +05:30
|
|
|
let(:action) { group.add_member(user, Gitlab::Access::GUEST) }
|
2022-07-23 23:45:48 +05:30
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
it 'changes access level' do
|
2022-07-23 23:45:48 +05:30
|
|
|
expect { action }.to change { user.can?(:guest_access, project_a) }.from(false).to(true)
|
|
|
|
.and change { user.can?(:guest_access, project_b) }.from(false).to(true)
|
|
|
|
.and change { user.can?(:guest_access, project_c) }.from(false).to(true)
|
|
|
|
end
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
it_behaves_like 'calls AuthorizedProjectsWorker inline to recalculate authorizations'
|
2022-07-23 23:45:48 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'on update' do
|
|
|
|
before do
|
2022-08-13 15:12:31 +05:30
|
|
|
group.add_member(user, Gitlab::Access::GUEST)
|
2022-07-23 23:45:48 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
let(:action) { group.members.find_by(user: user).update!(access_level: Gitlab::Access::DEVELOPER) }
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
it 'changes access level' do
|
2022-07-23 23:45:48 +05:30
|
|
|
expect { action }.to change { user.can?(:developer_access, project_a) }.from(false).to(true)
|
|
|
|
.and change { user.can?(:developer_access, project_b) }.from(false).to(true)
|
|
|
|
.and change { user.can?(:developer_access, project_c) }.from(false).to(true)
|
|
|
|
end
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
it_behaves_like 'calls AuthorizedProjectsWorker inline to recalculate authorizations'
|
2022-07-23 23:45:48 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'on destroy' do
|
|
|
|
before do
|
2022-08-13 15:12:31 +05:30
|
|
|
group.add_member(user, Gitlab::Access::GUEST)
|
2022-07-23 23:45:48 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
let(:action) { group.members.find_by(user: user).destroy! }
|
|
|
|
|
2023-04-23 21:23:45 +05:30
|
|
|
it 'changes access level' do
|
2022-07-23 23:45:48 +05:30
|
|
|
expect { action }.to change { user.can?(:guest_access, project_a) }.from(true).to(false)
|
|
|
|
.and change { user.can?(:guest_access, project_b) }.from(true).to(false)
|
|
|
|
.and change { user.can?(:guest_access, project_c) }.from(true).to(false)
|
|
|
|
end
|
|
|
|
|
2023-04-23 21:23:45 +05:30
|
|
|
it_behaves_like 'calls AuthorizedProjectsWorker inline to recalculate authorizations'
|
2022-07-23 23:45:48 +05:30
|
|
|
end
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|