2019-12-21 20:55:43 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-09-25 12:07:36 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
RSpec.describe Ci::RunnersHelper, feature_category: :runner_fleet do
|
2021-12-11 22:18:48 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
2021-09-30 23:02:18 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
|
|
end
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
describe '#runner_status_icon', :clean_gitlab_redis_cache do
|
2022-06-21 17:19:12 +05:30
|
|
|
it "returns online text" do
|
|
|
|
runner = create(:ci_runner, contacted_at: 1.second.ago)
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("is online")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns never contacted" do
|
2021-04-29 21:17:54 +05:30
|
|
|
runner = create(:ci_runner)
|
2022-06-21 17:19:12 +05:30
|
|
|
expect(helper.runner_status_icon(runner)).to include("never contacted")
|
2021-04-29 21:17:54 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
it "returns offline text" do
|
2022-06-21 17:19:12 +05:30
|
|
|
runner = create(:ci_runner, contacted_at: 1.day.ago)
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("is offline")
|
2021-04-29 21:17:54 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
it "returns stale text" do
|
|
|
|
runner = create(:ci_runner, created_at: 4.months.ago, contacted_at: 4.months.ago)
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("is stale")
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("last contact was")
|
2021-04-29 21:17:54 +05:30
|
|
|
end
|
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
it "returns stale text, when runner never contacted" do
|
|
|
|
runner = create(:ci_runner, created_at: 4.months.ago)
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("is stale")
|
|
|
|
expect(helper.runner_status_icon(runner)).to include("never contacted")
|
2021-04-29 21:17:54 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
describe '#runner_short_name' do
|
|
|
|
it 'shows runner short name' do
|
|
|
|
runner = build_stubbed(:ci_runner, id: non_existing_record_id)
|
|
|
|
|
|
|
|
expect(helper.runner_short_name(runner)).to eq("##{runner.id} (#{runner.short_sha})")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
describe '#runner_contacted_at' do
|
|
|
|
let(:contacted_at_stored) { 1.hour.ago.change(usec: 0) }
|
|
|
|
let(:contacted_at_cached) { 1.second.ago.change(usec: 0) }
|
|
|
|
let(:runner) { create(:ci_runner, contacted_at: contacted_at_stored) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
runner.cache_attributes(contacted_at: contacted_at_cached)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without sorting' do
|
|
|
|
it 'returns cached value' do
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(helper.runner_contacted_at(runner)).to eq(contacted_at_cached)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with sorting set to created_date' do
|
|
|
|
before do
|
|
|
|
controller.params[:sort] = 'created_date'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns cached value' do
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(helper.runner_contacted_at(runner)).to eq(contacted_at_cached)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with sorting set to contacted_asc' do
|
|
|
|
before do
|
|
|
|
controller.params[:sort] = 'contacted_asc'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns stored value' do
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(helper.runner_contacted_at(runner)).to eq(contacted_at_stored)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
describe '#admin_runners_data_attributes' do
|
|
|
|
let_it_be(:admin) { create(:user, :admin) }
|
|
|
|
let_it_be(:instance_runner) { create(:ci_runner, :instance) }
|
2023-07-09 08:55:56 +05:30
|
|
|
let_it_be(:project_runner) { create(:ci_runner, :project) }
|
2021-12-11 22:18:48 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(admin)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the data in format' do
|
2022-07-23 23:45:48 +05:30
|
|
|
expect(helper.admin_runners_data_attributes).to include(
|
2021-12-11 22:18:48 +05:30
|
|
|
runner_install_help_page: 'https://docs.gitlab.com/runner/install/',
|
2022-06-21 17:19:12 +05:30
|
|
|
registration_token: Gitlab::CurrentSettings.runners_registration_token,
|
|
|
|
online_contact_timeout_secs: 7200,
|
2023-07-09 08:55:56 +05:30
|
|
|
stale_timeout_secs: 7889238
|
2022-07-23 23:45:48 +05:30
|
|
|
)
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-01-03 14:25:43 +05:30
|
|
|
describe '#group_shared_runners_settings_data' do
|
2021-12-11 22:18:48 +05:30
|
|
|
let_it_be(:parent) { create(:group) }
|
|
|
|
let_it_be(:group) { create(:group, parent: parent, shared_runners_enabled: false) }
|
2023-07-09 08:55:56 +05:30
|
|
|
let_it_be(:group_with_project) { create(:group, parent: parent) }
|
|
|
|
let_it_be(:project) { create(:project, group: group_with_project) }
|
2021-12-11 22:18:48 +05:30
|
|
|
|
|
|
|
let(:runner_constants) do
|
|
|
|
{
|
2022-07-16 23:28:13 +05:30
|
|
|
runner_enabled_value: Namespace::SR_ENABLED,
|
|
|
|
runner_disabled_value: Namespace::SR_DISABLED_AND_UNOVERRIDABLE,
|
2023-03-17 16:20:25 +05:30
|
|
|
runner_allow_override_value: Namespace::SR_DISABLED_AND_OVERRIDABLE
|
2021-12-11 22:18:48 +05:30
|
|
|
}
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
|
|
|
it 'returns group data for top level group' do
|
2021-12-11 22:18:48 +05:30
|
|
|
result = {
|
2022-08-27 11:52:29 +05:30
|
|
|
group_id: parent.id,
|
2023-07-09 08:55:56 +05:30
|
|
|
group_name: parent.name,
|
|
|
|
group_is_empty: 'false',
|
2022-07-16 23:28:13 +05:30
|
|
|
shared_runners_setting: Namespace::SR_ENABLED,
|
|
|
|
parent_shared_runners_setting: nil
|
2021-12-11 22:18:48 +05:30
|
|
|
}.merge(runner_constants)
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(helper.group_shared_runners_settings_data(parent)).to eq result
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns group data for child group' do
|
2021-12-11 22:18:48 +05:30
|
|
|
result = {
|
2022-08-27 11:52:29 +05:30
|
|
|
group_id: group.id,
|
2023-07-09 08:55:56 +05:30
|
|
|
group_name: group.name,
|
|
|
|
group_is_empty: 'true',
|
2022-07-16 23:28:13 +05:30
|
|
|
shared_runners_setting: Namespace::SR_DISABLED_AND_UNOVERRIDABLE,
|
|
|
|
parent_shared_runners_setting: Namespace::SR_ENABLED
|
2021-12-11 22:18:48 +05:30
|
|
|
}.merge(runner_constants)
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(helper.group_shared_runners_settings_data(group)).to eq result
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
2023-07-09 08:55:56 +05:30
|
|
|
|
|
|
|
it 'returns group data for child group with project' do
|
|
|
|
result = {
|
|
|
|
group_id: group_with_project.id,
|
|
|
|
group_name: group_with_project.name,
|
|
|
|
group_is_empty: 'false',
|
|
|
|
shared_runners_setting: Namespace::SR_ENABLED,
|
|
|
|
parent_shared_runners_setting: Namespace::SR_ENABLED
|
|
|
|
}.merge(runner_constants)
|
|
|
|
|
|
|
|
expect(helper.group_shared_runners_settings_data(group_with_project)).to eq result
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
2021-02-22 17:27:13 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
describe '#group_runners_data_attributes' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
context 'when user can register group runners' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:can?).with(user, :register_group_runners, group).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns group data to render a runner list' do
|
|
|
|
expect(helper.group_runners_data_attributes(group)).to include(
|
|
|
|
group_id: group.id,
|
|
|
|
group_full_path: group.full_path,
|
|
|
|
runner_install_help_page: 'https://docs.gitlab.com/runner/install/',
|
|
|
|
online_contact_timeout_secs: 7200,
|
2023-07-09 08:55:56 +05:30
|
|
|
stale_timeout_secs: 7889238
|
2022-10-11 01:57:18 +05:30
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user cannot register group runners' do
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:can?).with(user, :register_group_runners, group).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns empty registration token' do
|
|
|
|
expect(helper.group_runners_data_attributes(group)).not_to include(registration_token: group.runners_token)
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
describe '#toggle_shared_runners_settings_data' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
2021-04-29 21:17:54 +05:30
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
let(:project_with_runners) { create(:project, namespace: group, shared_runners_enabled: true) }
|
|
|
|
let(:project_without_runners) { create(:project, namespace: group, shared_runners_enabled: false) }
|
|
|
|
|
|
|
|
context 'when project has runners' do
|
|
|
|
it 'returns the correct value for is_enabled' do
|
2021-09-30 23:02:18 +05:30
|
|
|
data = helper.toggle_shared_runners_settings_data(project_with_runners)
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(data[:is_enabled]).to eq("true")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project does not have runners' do
|
|
|
|
it 'returns the correct value for is_enabled' do
|
2021-09-30 23:02:18 +05:30
|
|
|
data = helper.toggle_shared_runners_settings_data(project_without_runners)
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(data[:is_enabled]).to eq("false")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for all projects' do
|
|
|
|
it 'returns the update path for toggling the shared runners setting' do
|
2021-09-30 23:02:18 +05:30
|
|
|
data = helper.toggle_shared_runners_settings_data(project_with_runners)
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(data[:update_path]).to eq(toggle_shared_runners_project_runners_path(project_with_runners))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for is_disabled_and_unoverridable when project has no group' do
|
|
|
|
project = create(:project)
|
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
data = helper.toggle_shared_runners_settings_data(project)
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(data[:is_disabled_and_unoverridable]).to eq("false")
|
|
|
|
end
|
|
|
|
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(:shared_runners_setting, :is_disabled_and_unoverridable) do
|
2021-11-18 22:05:49 +05:30
|
|
|
:shared_runners_enabled | "false"
|
2023-03-17 16:20:25 +05:30
|
|
|
:disabled_and_overridable | "false"
|
2021-11-18 22:05:49 +05:30
|
|
|
:disabled_and_unoverridable | "true"
|
2021-02-22 17:27:13 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it 'returns the override runner status for project with group' do
|
2021-11-18 22:05:49 +05:30
|
|
|
group = create(:group, shared_runners_setting)
|
|
|
|
project = create(:project, group: group, shared_runners_enabled: false)
|
2021-02-22 17:27:13 +05:30
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
data = helper.toggle_shared_runners_settings_data(project)
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(data[:is_disabled_and_unoverridable]).to eq(is_disabled_and_unoverridable)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|