2019-02-15 15:39:39 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe ApplicationSettingsHelper do
|
2023-04-23 21:23:45 +05:30
|
|
|
include Devise::Test::ControllerHelpers
|
|
|
|
|
|
|
|
let_it_be(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(helper).to receive(:current_user).and_return(current_user)
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'when all protocols in use' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(enabled_git_access_protocol: '')
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(all_protocols_enabled?).to be_truthy }
|
|
|
|
it { expect(http_enabled?).to be_truthy }
|
|
|
|
it { expect(ssh_enabled?).to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when SSH is only in use' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(enabled_git_access_protocol: 'ssh')
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(all_protocols_enabled?).to be_falsey }
|
|
|
|
it { expect(http_enabled?).to be_falsey }
|
|
|
|
it { expect(ssh_enabled?).to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'when HTTP protocol is in use' do |protocol|
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.gitlab).to receive(:protocol).and_return(protocol)
|
|
|
|
stub_application_setting(enabled_git_access_protocol: 'http')
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(all_protocols_enabled?).to be_falsey }
|
|
|
|
it { expect(http_enabled?).to be_truthy }
|
|
|
|
it { expect(ssh_enabled?).to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'when HTTP protocol is in use', 'https'
|
|
|
|
it_behaves_like 'when HTTP protocol is in use', 'http'
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2021-09-04 01:27:46 +05:30
|
|
|
describe '.visible_attributes' do
|
|
|
|
it 'contains tracking parameters' do
|
|
|
|
expect(helper.visible_attributes).to include(*%i(snowplow_collector_hostname snowplow_cookie_domain snowplow_enabled snowplow_app_id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains :deactivate_dormant_users' do
|
|
|
|
expect(helper.visible_attributes).to include(:deactivate_dormant_users)
|
|
|
|
end
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
it 'contains :deactivate_dormant_users_period' do
|
|
|
|
expect(helper.visible_attributes).to include(:deactivate_dormant_users_period)
|
|
|
|
end
|
|
|
|
|
2022-04-04 11:22:00 +05:30
|
|
|
it 'contains rate limit parameters' do
|
2022-11-25 23:54:43 +05:30
|
|
|
expect(helper.visible_attributes).to include(
|
|
|
|
*%i(
|
|
|
|
issues_create_limit notes_create_limit project_export_limit
|
|
|
|
project_download_export_limit project_export_limit project_import_limit
|
|
|
|
raw_blob_request_limit group_export_limit group_download_export_limit
|
|
|
|
group_import_limit users_get_by_id_limit search_rate_limit search_rate_limit_unauthenticated
|
|
|
|
))
|
2022-04-04 11:22:00 +05:30
|
|
|
end
|
|
|
|
|
2023-07-09 08:55:56 +05:30
|
|
|
it 'contains GitLab for Slack app parameters' do
|
|
|
|
params = %i(slack_app_enabled slack_app_id slack_app_secret slack_app_signing_secret slack_app_verification_token)
|
|
|
|
|
|
|
|
expect(helper.visible_attributes).to include(*params)
|
|
|
|
end
|
|
|
|
|
2023-05-27 22:25:52 +05:30
|
|
|
context 'when on SaaS', :saas do
|
2021-09-04 01:27:46 +05:30
|
|
|
it 'does not contain :deactivate_dormant_users' do
|
|
|
|
expect(helper.visible_attributes).not_to include(:deactivate_dormant_users)
|
|
|
|
end
|
2022-10-11 01:57:18 +05:30
|
|
|
|
|
|
|
it 'does not contain :deactivate_dormant_users_period' do
|
|
|
|
expect(helper.visible_attributes).not_to include(:deactivate_dormant_users_period)
|
|
|
|
end
|
2021-09-04 01:27:46 +05:30
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe '.integration_expanded?' do
|
|
|
|
let(:application_setting) { build(:application_setting) }
|
|
|
|
|
|
|
|
it 'is expanded' do
|
|
|
|
application_setting.plantuml_enabled = true
|
|
|
|
application_setting.valid?
|
|
|
|
helper.instance_variable_set(:@application_setting, application_setting)
|
|
|
|
|
|
|
|
expect(helper.integration_expanded?('plantuml_')).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not expanded' do
|
|
|
|
application_setting.valid?
|
|
|
|
helper.instance_variable_set(:@application_setting, application_setting)
|
|
|
|
|
|
|
|
expect(helper.integration_expanded?('plantuml_')).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
2020-03-13 15:44:24 +05:30
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
describe '#storage_weights' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:application_setting) { build(:application_setting) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
helper.instance_variable_set(:@application_setting, application_setting)
|
|
|
|
stub_storage_settings({ 'default': {}, 'storage_1': {}, 'storage_2': {} })
|
|
|
|
stub_application_setting(repository_storages_weighted: { 'default' => 100, 'storage_1' => 50, 'storage_2' => nil })
|
|
|
|
end
|
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
it 'returns storage objects with assigned weights' do
|
|
|
|
expect(helper.storage_weights)
|
|
|
|
.to have_attributes(
|
|
|
|
default: 100,
|
|
|
|
storage_1: 50,
|
|
|
|
storage_2: 0
|
|
|
|
)
|
2020-06-23 00:09:42 +05:30
|
|
|
end
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
describe '.valid_runner_registrars' do
|
|
|
|
subject { helper.valid_runner_registrars }
|
|
|
|
|
|
|
|
context 'when only admins are permitted to register runners' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(valid_runner_registrars: [])
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq [] }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when group and project users are permitted to register runners' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(valid_runner_registrars: ApplicationSetting::VALID_RUNNER_REGISTRAR_TYPES)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq ApplicationSetting::VALID_RUNNER_REGISTRAR_TYPES }
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
describe '.signup_enabled?' do
|
|
|
|
subject { helper.signup_enabled? }
|
|
|
|
|
|
|
|
context 'when signup is enabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(signup_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when signup is disabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(signup_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when `signup_enabled` is nil' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(signup_enabled: nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
2021-03-11 19:13:27 +05:30
|
|
|
|
|
|
|
describe '.kroki_available_formats' do
|
|
|
|
let(:application_setting) { build(:application_setting) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
helper.instance_variable_set(:@application_setting, application_setting)
|
|
|
|
stub_application_setting(kroki_formats: { 'blockdiag' => true, 'bpmn' => false, 'excalidraw' => false })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns available formats correctly' do
|
2022-11-25 23:54:43 +05:30
|
|
|
expect(helper.kroki_available_formats).to eq(
|
|
|
|
[
|
|
|
|
{
|
|
|
|
name: 'kroki_formats_blockdiag',
|
|
|
|
label: 'BlockDiag (includes BlockDiag, SeqDiag, ActDiag, NwDiag, PacketDiag, and RackDiag)',
|
|
|
|
value: true
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'kroki_formats_bpmn',
|
|
|
|
label: 'BPMN',
|
|
|
|
value: false
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'kroki_formats_excalidraw',
|
|
|
|
label: 'Excalidraw',
|
|
|
|
value: false
|
|
|
|
}
|
|
|
|
])
|
2021-03-11 19:13:27 +05:30
|
|
|
end
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
|
|
|
|
describe '.pending_user_count' do
|
|
|
|
let(:user_cap) { 200 }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_application_setting(new_user_signups_cap: user_cap)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject(:pending_user_count) { helper.pending_user_count }
|
|
|
|
|
|
|
|
context 'when new_user_signups_cap is present' do
|
|
|
|
it 'returns the number of blocked pending users' do
|
|
|
|
create(:user, state: :blocked_pending_approval)
|
|
|
|
|
|
|
|
expect(pending_user_count).to eq 1
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
describe '.registration_features_can_be_prompted?', :without_license do
|
2022-03-02 08:16:31 +05:30
|
|
|
subject { helper.registration_features_can_be_prompted? }
|
|
|
|
|
|
|
|
context 'when service ping is enabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(usage_ping_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service ping is disabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(usage_ping_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
describe '.spam_check_endpoint_enabled?' do
|
|
|
|
subject { helper.spam_check_endpoint_enabled? }
|
|
|
|
|
|
|
|
context 'when spam check endpoint is enabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when spam check endpoint is disabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.anti_spam_service_enabled?' do
|
|
|
|
subject { helper.anti_spam_service_enabled? }
|
|
|
|
|
|
|
|
context 'when akismet is enabled and spam check endpoint is disabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: false)
|
|
|
|
stub_application_setting(akismet_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when akismet is disabled and spam check endpoint is enabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: true)
|
|
|
|
stub_application_setting(akismet_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when akismet and spam check endpoint are both enabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: true)
|
|
|
|
stub_application_setting(akismet_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when akismet and spam check endpoint are both disabled' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(spam_check_endpoint_enabled: false)
|
|
|
|
stub_application_setting(akismet_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
describe '#sidekiq_job_limiter_modes_for_select' do
|
|
|
|
subject { helper.sidekiq_job_limiter_modes_for_select }
|
|
|
|
|
|
|
|
it { is_expected.to eq([%w(Track track), %w(Compress compress)]) }
|
|
|
|
end
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
describe '#instance_clusters_enabled?', :request_store do
|
2022-05-07 20:08:51 +05:30
|
|
|
subject { helper.instance_clusters_enabled? }
|
|
|
|
|
|
|
|
before do
|
2023-04-23 21:23:45 +05:30
|
|
|
allow(helper).to receive(:can?).with(current_user, :read_cluster, instance_of(Clusters::Instance)).and_return(true)
|
2022-05-07 20:08:51 +05:30
|
|
|
end
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
it { is_expected.to be_truthy }
|
2022-05-07 20:08:51 +05:30
|
|
|
|
|
|
|
context ':certificate_based_clusters feature flag is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(certificate_based_clusters: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
end
|
2023-04-23 21:23:45 +05:30
|
|
|
|
|
|
|
describe '#restricted_level_checkboxes' do
|
|
|
|
let_it_be(:application_setting) { create(:application_setting) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(current_user).to receive(:can_admin_all_resources?).and_return(true)
|
|
|
|
stub_application_setting(
|
|
|
|
restricted_visibility_levels: [
|
|
|
|
Gitlab::VisibilityLevel::PUBLIC,
|
|
|
|
Gitlab::VisibilityLevel::INTERNAL,
|
|
|
|
Gitlab::VisibilityLevel::PRIVATE
|
|
|
|
]
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns restricted level checkboxes with correct label, description, and HTML attributes' do
|
|
|
|
helper.gitlab_ui_form_for(application_setting, url: '/admin/application_settings/general') do |form|
|
|
|
|
result = helper.restricted_level_checkboxes(form)
|
|
|
|
|
|
|
|
expect(result[0]).to have_checked_field(s_('VisibilityLevel|Private'), with: Gitlab::VisibilityLevel::PRIVATE)
|
|
|
|
expect(result[0]).to have_selector('[data-testid="lock-icon"]')
|
|
|
|
expect(result[0]).to have_content(
|
|
|
|
s_(
|
|
|
|
'AdminSettings|If selected, only administrators are able to create private groups, projects, and ' \
|
|
|
|
'snippets.'
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(result[1]).to have_checked_field(s_('VisibilityLevel|Internal'), with: Gitlab::VisibilityLevel::INTERNAL)
|
|
|
|
expect(result[1]).to have_selector('[data-testid="shield-icon"]')
|
|
|
|
expect(result[1]).to have_content(
|
|
|
|
s_(
|
|
|
|
'AdminSettings|If selected, only administrators are able to create internal groups, projects, and ' \
|
|
|
|
'snippets.'
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(result[2]).to have_checked_field(s_('VisibilityLevel|Public'), with: Gitlab::VisibilityLevel::PUBLIC)
|
|
|
|
expect(result[2]).to have_selector('[data-testid="earth-icon"]')
|
|
|
|
expect(result[2]).to have_content(
|
|
|
|
s_(
|
|
|
|
'AdminSettings|If selected, only administrators are able to create public groups, projects, ' \
|
|
|
|
'and snippets. Also, profiles are only visible to authenticated users.'
|
|
|
|
)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|