2021-09-30 23:02:18 +05:30
|
|
|
import { escape } from 'lodash';
|
|
|
|
import UsersSelect from '~/users_select/index';
|
2021-06-08 01:23:25 +05:30
|
|
|
import {
|
|
|
|
createInputsModelExpectation,
|
|
|
|
createUnassignedExpectation,
|
|
|
|
createAssignedExpectation,
|
|
|
|
createTestContext,
|
|
|
|
findDropdownItemsModel,
|
|
|
|
findDropdownItem,
|
|
|
|
findAssigneesInputsModel,
|
|
|
|
getUsersFixtureAt,
|
|
|
|
setAssignees,
|
|
|
|
toggleDropdown,
|
|
|
|
waitForDropdownItems,
|
|
|
|
} from './test_helper';
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
describe('~/users_select/index', () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
const context = createTestContext({
|
|
|
|
fixturePath: 'merge_requests/merge_request_with_single_assignee_feature.html',
|
|
|
|
});
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
beforeEach(() => {
|
2021-06-08 01:23:25 +05:30
|
|
|
context.setup();
|
2021-04-29 21:17:54 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(() => {
|
2021-06-08 01:23:25 +05:30
|
|
|
context.teardown();
|
2021-04-29 21:17:54 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
describe('when opened', () => {
|
|
|
|
beforeEach(async () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
context.createSubject();
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
toggleDropdown();
|
|
|
|
await waitForDropdownItems();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows users', () => {
|
|
|
|
expect(findDropdownItemsModel()).toEqual(createUnassignedExpectation());
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('when users are selected', () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
const selectedUsers = [getUsersFixtureAt(2), getUsersFixtureAt(4)];
|
|
|
|
const lastSelected = selectedUsers[selectedUsers.length - 1];
|
|
|
|
const expectation = createAssignedExpectation({
|
|
|
|
header: 'Assignee',
|
|
|
|
assigned: [lastSelected],
|
|
|
|
});
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
selectedUsers.forEach((user) => {
|
|
|
|
findDropdownItem(user).click();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows assignee', () => {
|
|
|
|
expect(findDropdownItemsModel()).toEqual(expectation);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('updates field', () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(findAssigneesInputsModel()).toEqual(createInputsModelExpectation([lastSelected]));
|
2021-04-29 21:17:54 +05:30
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('with preselected user and opened', () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
const expectation = createAssignedExpectation({
|
|
|
|
header: 'Assignee',
|
|
|
|
assigned: [getUsersFixtureAt(0)],
|
|
|
|
});
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
beforeEach(async () => {
|
2021-06-08 01:23:25 +05:30
|
|
|
setAssignees(getUsersFixtureAt(0));
|
2021-04-29 21:17:54 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
context.createSubject();
|
2021-04-29 21:17:54 +05:30
|
|
|
|
|
|
|
toggleDropdown();
|
|
|
|
await waitForDropdownItems();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows users', () => {
|
|
|
|
expect(findDropdownItemsModel()).toEqual(expectation);
|
|
|
|
});
|
|
|
|
|
|
|
|
// Regression test for https://gitlab.com/gitlab-org/gitlab/-/issues/325991
|
|
|
|
describe('when closed and reopened', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
toggleDropdown();
|
|
|
|
toggleDropdown();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows users', () => {
|
|
|
|
expect(findDropdownItemsModel()).toEqual(expectation);
|
|
|
|
});
|
|
|
|
});
|
2021-09-30 23:02:18 +05:30
|
|
|
|
|
|
|
describe('renderApprovalRules', () => {
|
|
|
|
const ruleNames = ['simple-name', '"\'<>&', '"><script>alert(1)<script>'];
|
|
|
|
|
|
|
|
it.each(ruleNames)('escapes rule name correctly for %s', (name) => {
|
|
|
|
const escapedName = escape(name);
|
|
|
|
|
|
|
|
expect(
|
|
|
|
UsersSelect.prototype.renderApprovalRules('reviewer', [{ name }]),
|
|
|
|
).toMatchInterpolatedText(
|
|
|
|
`<div class="gl-display-flex gl-font-sm"> <span class="gl-text-truncate" title="${escapedName}">${escapedName}</span> </div>`,
|
|
|
|
);
|
|
|
|
});
|
|
|
|
});
|
2021-04-29 21:17:54 +05:30
|
|
|
});
|
2022-05-07 20:08:51 +05:30
|
|
|
|
|
|
|
describe('XSS', () => {
|
|
|
|
const escaped = '><script>alert(1)</script>';
|
|
|
|
const issuableType = 'merge_request';
|
|
|
|
const user = {
|
|
|
|
availability: 'not_set',
|
|
|
|
can_merge: true,
|
|
|
|
name: 'name',
|
|
|
|
};
|
|
|
|
const selected = true;
|
|
|
|
const username = 'username';
|
|
|
|
const img = '<img user-avatar />';
|
|
|
|
const elsClassName = 'elsclass';
|
|
|
|
|
|
|
|
it.each`
|
|
|
|
prop | val | element
|
|
|
|
${'username'} | ${'><script>alert(1)</script>'} | ${'.dropdown-menu-user-username'}
|
|
|
|
${'name'} | ${'><script>alert(1)</script>'} | ${'.dropdown-menu-user-full-name'}
|
|
|
|
`('properly escapes the $prop $val', ({ prop, val, element }) => {
|
|
|
|
const u = prop === 'username' ? val : username;
|
|
|
|
const n = prop === 'name' ? val : user.name;
|
|
|
|
const row = UsersSelect.prototype.renderRow(
|
|
|
|
issuableType,
|
|
|
|
{ ...user, name: n },
|
|
|
|
selected,
|
|
|
|
u,
|
|
|
|
img,
|
|
|
|
elsClassName,
|
|
|
|
);
|
|
|
|
const fragment = document.createRange().createContextualFragment(row);
|
|
|
|
const output = fragment.querySelector(element).innerHTML.trim();
|
|
|
|
|
|
|
|
expect(output).toBe(escaped);
|
|
|
|
});
|
|
|
|
});
|
2021-04-29 21:17:54 +05:30
|
|
|
});
|