debian-mirror-gitlab/spec/controllers/snippets_controller_spec.rb

459 lines
12 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2015-11-26 14:37:03 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe SnippetsController do
2020-04-08 14:13:33 +05:30
let_it_be(:user) { create(:user) }
2021-01-03 14:25:43 +05:30
let_it_be(:other_user) { create(:user) }
let_it_be(:public_snippet) { create(:personal_snippet, :public, :repository, author: user) }
2015-11-26 14:37:03 +05:30
2017-08-17 22:00:37 +05:30
describe 'GET #index' do
2020-07-28 23:09:34 +05:30
let(:base_params) { { username: user.username } }
2017-08-17 22:00:37 +05:30
context 'when username parameter is present' do
2019-12-04 20:38:33 +05:30
it_behaves_like 'paginated collection' do
let(:collection) { Snippet.all }
let(:params) { { username: user.username } }
end
2017-08-17 22:00:37 +05:30
it 'renders snippets of a user when username is present' do
2019-02-15 15:39:39 +05:30
get :index, params: { username: user.username }
2017-08-17 22:00:37 +05:30
expect(response).to render_template(:index)
end
end
context 'when username parameter is not present' do
it 'redirects to explore snippets page when user is not logged in' do
get :index
expect(response).to redirect_to(explore_snippets_path)
end
it 'redirects to snippets dashboard page when user is logged in' do
sign_in(user)
get :index
expect(response).to redirect_to(dashboard_snippets_path)
end
end
2020-07-28 23:09:34 +05:30
it_behaves_like 'snippets sort order' do
let(:params) { base_params }
end
2017-08-17 22:00:37 +05:30
end
describe 'GET #new' do
context 'when signed in' do
before do
sign_in(user)
end
it 'responds with status 200' do
get :new
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
end
2020-01-01 13:55:28 +05:30
context 'when user is not allowed to create a personal snippet' do
let(:user) { create(:user, :external) }
it 'responds with status 404' do
get :new
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2020-01-01 13:55:28 +05:30
end
end
2017-08-17 22:00:37 +05:30
end
context 'when not signed in' do
it 'redirects to the sign in page' do
get :new
expect(response).to redirect_to(new_user_session_path)
end
end
end
2016-09-29 09:46:39 +05:30
describe 'GET #show' do
2020-04-08 14:13:33 +05:30
shared_examples 'successful response' do
it 'renders the snippet' do
subject
expect(assigns(:snippet)).to eq(personal_snippet)
expect(response).to have_gitlab_http_status(:ok)
end
end
2015-11-26 14:37:03 +05:30
context 'when the personal snippet is private' do
2020-04-08 14:13:33 +05:30
let_it_be(:personal_snippet) { create(:personal_snippet, :private, :repository, author: user) }
2015-11-26 14:37:03 +05:30
context 'when signed in' do
before do
sign_in(user)
end
context 'when signed in user is not the author' do
2021-01-03 14:25:43 +05:30
let(:other_personal_snippet) { create(:personal_snippet, :private, author: other_user) }
2015-11-26 14:37:03 +05:30
it 'responds with status 404' do
2019-02-15 15:39:39 +05:30
get :show, params: { id: other_personal_snippet.to_param }
2015-11-26 14:37:03 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2015-11-26 14:37:03 +05:30
end
end
context 'when signed in user is the author' do
2020-04-08 14:13:33 +05:30
it_behaves_like 'successful response' do
subject { get :show, params: { id: personal_snippet.to_param } }
2015-11-26 14:37:03 +05:30
end
2019-01-03 12:48:30 +05:30
it 'responds with status 404 when embeddable content is requested' do
2019-02-15 15:39:39 +05:30
get :show, params: { id: personal_snippet.to_param }, format: :js
2019-01-03 12:48:30 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2019-01-03 12:48:30 +05:30
end
2015-11-26 14:37:03 +05:30
end
end
context 'when not signed in' do
it 'redirects to the sign in page' do
2019-02-15 15:39:39 +05:30
get :show, params: { id: personal_snippet.to_param }
2015-11-26 14:37:03 +05:30
expect(response).to redirect_to(new_user_session_path)
end
end
end
context 'when the personal snippet is internal' do
2020-04-08 14:13:33 +05:30
let_it_be(:personal_snippet) { create(:personal_snippet, :internal, :repository, author: user) }
2015-11-26 14:37:03 +05:30
context 'when signed in' do
before do
sign_in(user)
end
2020-04-08 14:13:33 +05:30
it_behaves_like 'successful response' do
subject { get :show, params: { id: personal_snippet.to_param } }
2015-11-26 14:37:03 +05:30
end
2019-01-03 12:48:30 +05:30
it 'responds with status 404 when embeddable content is requested' do
2019-02-15 15:39:39 +05:30
get :show, params: { id: personal_snippet.to_param }, format: :js
2019-01-03 12:48:30 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2019-01-03 12:48:30 +05:30
end
2015-11-26 14:37:03 +05:30
end
context 'when not signed in' do
it 'redirects to the sign in page' do
2019-02-15 15:39:39 +05:30
get :show, params: { id: personal_snippet.to_param }
2015-11-26 14:37:03 +05:30
expect(response).to redirect_to(new_user_session_path)
end
end
end
context 'when the personal snippet is public' do
2021-01-03 14:25:43 +05:30
let(:personal_snippet) { public_snippet }
2015-11-26 14:37:03 +05:30
context 'when signed in' do
before do
sign_in(user)
end
2020-04-08 14:13:33 +05:30
it_behaves_like 'successful response' do
2021-01-03 14:25:43 +05:30
subject { get :show, params: { id: public_snippet.to_param } }
2015-11-26 14:37:03 +05:30
end
2019-01-03 12:48:30 +05:30
it 'responds with status 200 when embeddable content is requested' do
2021-01-03 14:25:43 +05:30
get :show, params: { id: public_snippet.to_param }, format: :js
2019-01-03 12:48:30 +05:30
2021-01-03 14:25:43 +05:30
expect(assigns(:snippet)).to eq(public_snippet)
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-01-03 12:48:30 +05:30
end
2021-02-22 17:27:13 +05:30
it_behaves_like 'tracking unique hll events', :usage_data_i_snippets_show do
subject(:request) { get :show, params: { id: public_snippet.to_param } }
let(:target_id) { 'i_snippets_show' }
let(:expected_type) { instance_of(String) }
end
2015-11-26 14:37:03 +05:30
end
context 'when not signed in' do
it 'renders the snippet' do
2021-01-03 14:25:43 +05:30
get :show, params: { id: public_snippet.to_param }
2015-11-26 14:37:03 +05:30
2021-01-03 14:25:43 +05:30
expect(assigns(:snippet)).to eq(public_snippet)
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2015-11-26 14:37:03 +05:30
end
end
end
context 'when the personal snippet does not exist' do
context 'when signed in' do
before do
sign_in(user)
end
it 'responds with status 404' do
2021-01-03 14:25:43 +05:30
get :show, params: { id: non_existing_record_id }
2015-11-26 14:37:03 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2015-11-26 14:37:03 +05:30
end
end
context 'when not signed in' do
it 'responds with status 404' do
2021-01-03 14:25:43 +05:30
get :show, params: { id: non_existing_record_id }
2015-11-26 14:37:03 +05:30
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(new_user_session_path)
2015-11-26 14:37:03 +05:30
end
end
end
2017-08-17 22:00:37 +05:30
end
describe 'POST #mark_as_spam' do
before do
2020-03-13 15:44:24 +05:30
allow_next_instance_of(Spam::AkismetService) do |instance|
2019-12-26 22:10:19 +05:30
allow(instance).to receive_messages(submit_spam: true)
end
2021-01-03 14:25:43 +05:30
2017-08-17 22:00:37 +05:30
stub_application_setting(akismet_enabled: true)
end
def mark_as_spam
admin = create(:admin)
2021-01-03 14:25:43 +05:30
create(:user_agent_detail, subject: public_snippet)
2017-08-17 22:00:37 +05:30
sign_in(admin)
2021-01-03 14:25:43 +05:30
post :mark_as_spam, params: { id: public_snippet.id }
2017-08-17 22:00:37 +05:30
end
it 'updates the snippet' do
mark_as_spam
2021-01-03 14:25:43 +05:30
expect(public_snippet.reload).not_to be_submittable_as_spam
2017-08-17 22:00:37 +05:30
end
end
describe "GET #raw" do
2020-04-22 19:07:51 +05:30
let(:inline) { nil }
let(:params) { { id: snippet.to_param, inline: inline } }
subject { get :raw, params: params }
2020-04-08 14:13:33 +05:30
shared_examples '200 status' do
before do
subject
end
it 'responds with status 200' do
expect(assigns(:snippet)).to eq(snippet)
expect(response).to have_gitlab_http_status(:ok)
end
it "sets #{Gitlab::Workhorse::DETECT_HEADER} header" do
expect(response.header[Gitlab::Workhorse::DETECT_HEADER]).to eq 'true'
end
end
shared_examples 'CRLF line ending' do
let(:content) { "first line\r\nsecond line\r\nthird line" }
let(:formatted_content) { content.gsub(/\r\n/, "\n") }
2021-01-03 14:25:43 +05:30
let(:snippet) { public_snippet }
2020-04-08 14:13:33 +05:30
before do
allow_next_instance_of(Blob) do |instance|
allow(instance).to receive(:data).and_return(content)
end
subject
end
it 'returns LF line endings by default' do
expect(response.body).to eq(formatted_content)
end
context 'when parameter present' do
let(:params) { { id: snippet.to_param, line_ending: :raw } }
it 'does not convert line endings when parameter present' do
expect(response.body).to eq(content)
end
end
end
shared_examples 'successful response' do
it_behaves_like '200 status'
2020-04-22 19:07:51 +05:30
it 'has expected blob headers' do
2020-04-08 14:13:33 +05:30
subject
2020-04-22 19:07:51 +05:30
expect(response.header[Gitlab::Workhorse::SEND_DATA_HEADER]).to start_with('git-blob:')
expect(response.header[Gitlab::Workhorse::DETECT_HEADER]).to eq 'true'
end
it_behaves_like 'content disposition headers'
it 'sets cache_control public header based on snippet visibility' do
subject
expect(response.cache_control[:public]).to eq snippet.public?
2020-04-08 14:13:33 +05:30
end
2020-04-22 19:07:51 +05:30
context 'when snippet repository is empty' do
before do
allow_any_instance_of(Repository).to receive(:empty?).and_return(true)
end
it_behaves_like '200 status'
it_behaves_like 'CRLF line ending'
it 'returns snippet database content' do
subject
expect(response.body).to eq snippet.content
expect(response.header['Content-Type']).to eq('text/plain; charset=utf-8')
end
it_behaves_like 'content disposition headers'
2020-04-08 14:13:33 +05:30
end
end
2015-12-23 02:04:40 +05:30
context 'when the personal snippet is private' do
2020-04-22 19:07:51 +05:30
let_it_be(:snippet) { create(:personal_snippet, :private, :repository, author: user) }
2015-12-23 02:04:40 +05:30
context 'when signed in' do
before do
sign_in(user)
end
context 'when signed in user is not the author' do
2021-01-03 14:25:43 +05:30
let(:other_personal_snippet) { create(:personal_snippet, :private, author: other_user) }
2015-12-23 02:04:40 +05:30
it 'responds with status 404' do
2019-02-15 15:39:39 +05:30
get :raw, params: { id: other_personal_snippet.to_param }
2015-12-23 02:04:40 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2015-12-23 02:04:40 +05:30
end
end
context 'when signed in user is the author' do
2020-04-22 19:07:51 +05:30
it_behaves_like 'successful response'
2015-12-23 02:04:40 +05:30
end
end
context 'when not signed in' do
it 'redirects to the sign in page' do
2020-04-22 19:07:51 +05:30
subject
2015-12-23 02:04:40 +05:30
expect(response).to redirect_to(new_user_session_path)
end
end
end
context 'when the personal snippet is internal' do
2020-04-22 19:07:51 +05:30
let_it_be(:snippet) { create(:personal_snippet, :internal, :repository, author: user) }
2015-12-23 02:04:40 +05:30
context 'when signed in' do
before do
sign_in(user)
end
2020-04-22 19:07:51 +05:30
it_behaves_like 'successful response'
2015-12-23 02:04:40 +05:30
end
context 'when not signed in' do
it 'redirects to the sign in page' do
2020-04-22 19:07:51 +05:30
subject
2015-12-23 02:04:40 +05:30
expect(response).to redirect_to(new_user_session_path)
end
end
end
context 'when the personal snippet is public' do
2021-01-03 14:25:43 +05:30
let(:snippet) { public_snippet }
2015-12-23 02:04:40 +05:30
context 'when signed in' do
before do
sign_in(user)
end
2020-04-22 19:07:51 +05:30
it_behaves_like 'successful response'
2015-12-23 02:04:40 +05:30
end
context 'when not signed in' do
2017-08-17 22:00:37 +05:30
it 'responds with status 200' do
2020-04-22 19:07:51 +05:30
subject
2015-12-23 02:04:40 +05:30
2020-04-22 19:07:51 +05:30
expect(assigns(:snippet)).to eq(snippet)
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2015-12-23 02:04:40 +05:30
end
end
end
context 'when the personal snippet does not exist' do
context 'when signed in' do
before do
sign_in(user)
end
it 'responds with status 404' do
2021-01-03 14:25:43 +05:30
get :raw, params: { id: non_existing_record_id }
2015-12-23 02:04:40 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2015-12-23 02:04:40 +05:30
end
end
context 'when not signed in' do
2017-08-17 22:00:37 +05:30
it 'redirects to the sign in path' do
2021-01-03 14:25:43 +05:30
get :raw, params: { id: non_existing_record_id }
2015-12-23 02:04:40 +05:30
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(new_user_session_path)
2015-12-23 02:04:40 +05:30
end
end
end
end
2016-09-29 09:46:39 +05:30
context 'award emoji on snippets' do
2021-01-03 14:25:43 +05:30
let(:personal_snippet) { public_snippet }
2016-09-29 09:46:39 +05:30
before do
2021-01-03 14:25:43 +05:30
sign_in(other_user)
2016-09-29 09:46:39 +05:30
end
describe 'POST #toggle_award_emoji' do
it "toggles the award emoji" do
expect do
2019-02-15 15:39:39 +05:30
post(:toggle_award_emoji, params: { id: personal_snippet.to_param, name: "thumbsup" })
2016-09-29 09:46:39 +05:30
end.to change { personal_snippet.award_emoji.count }.from(0).to(1)
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2016-09-29 09:46:39 +05:30
end
it "removes the already awarded emoji" do
2019-02-15 15:39:39 +05:30
post(:toggle_award_emoji, params: { id: personal_snippet.to_param, name: "thumbsup" })
2016-09-29 09:46:39 +05:30
expect do
2019-02-15 15:39:39 +05:30
post(:toggle_award_emoji, params: { id: personal_snippet.to_param, name: "thumbsup" })
2016-09-29 09:46:39 +05:30
end.to change { personal_snippet.award_emoji.count }.from(1).to(0)
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2016-09-29 09:46:39 +05:30
end
end
end
2017-08-17 22:00:37 +05:30
describe 'POST #preview_markdown' do
it 'renders json in a correct format' do
sign_in(user)
2021-01-03 14:25:43 +05:30
post :preview_markdown, params: { id: public_snippet, text: '*Markdown* text' }
2017-08-17 22:00:37 +05:30
2019-09-30 21:07:59 +05:30
expect(json_response.keys).to match_array(%w(body references))
2017-08-17 22:00:37 +05:30
end
end
2015-11-26 14:37:03 +05:30
end