debian-mirror-gitlab/spec/services/issues/zoom_link_service_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

301 lines
8.1 KiB
Ruby
Raw Normal View History

2019-12-04 20:38:33 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Issues::ZoomLinkService do
2020-03-13 15:44:24 +05:30
let_it_be(:user) { create(:user) }
let_it_be(:issue) { create(:issue) }
2019-12-04 20:38:33 +05:30
let(:project) { issue.project }
2021-06-08 01:23:25 +05:30
let(:service) { described_class.new(project: project, current_user: user, params: { issue: issue }) }
2019-12-04 20:38:33 +05:30
let(:zoom_link) { 'https://zoom.us/j/123456789' }
before do
project.add_reporter(user)
end
2019-12-26 22:10:19 +05:30
shared_context '"added" Zoom meeting' do
2019-12-04 20:38:33 +05:30
before do
2019-12-26 22:10:19 +05:30
create(:zoom_meeting, issue: issue)
2019-12-04 20:38:33 +05:30
end
end
2019-12-26 22:10:19 +05:30
shared_context '"removed" zoom meetings' do
2019-12-04 20:38:33 +05:30
before do
2019-12-26 22:10:19 +05:30
create(:zoom_meeting, issue: issue, issue_status: :removed)
create(:zoom_meeting, issue: issue, issue_status: :removed)
2019-12-04 20:38:33 +05:30
end
end
2020-01-01 13:55:28 +05:30
shared_context 'insufficient issue update permissions' do
2019-12-04 20:38:33 +05:30
before do
project.add_guest(user)
end
end
2020-01-01 13:55:28 +05:30
shared_context 'insufficient issue create permissions' do
before do
expect(service).to receive(:can?).with(user, :create_issue, project).and_return(false)
end
end
2019-12-04 20:38:33 +05:30
describe '#add_link' do
2019-12-26 22:10:19 +05:30
shared_examples 'can add meeting' do
it 'appends the new meeting to zoom_meetings' do
2019-12-04 20:38:33 +05:30
expect(result).to be_success
2019-12-26 22:10:19 +05:30
expect(ZoomMeeting.canonical_meeting_url(issue)).to eq(zoom_link)
2019-12-04 20:38:33 +05:30
end
2019-12-21 20:55:43 +05:30
2021-01-29 00:20:46 +05:30
it 'tracks the add event', :snowplow do
2019-12-21 20:55:43 +05:30
result
2021-01-29 00:20:46 +05:30
expect_snowplow_event(
category: 'IncidentManagement::ZoomIntegration',
action: 'add_zoom_meeting',
label: 'Issue ID',
2021-09-04 01:27:46 +05:30
value: issue.id,
user: user,
project: project,
namespace: project.namespace
2021-01-29 00:20:46 +05:30
)
2019-12-21 20:55:43 +05:30
end
2019-12-26 22:10:19 +05:30
it 'creates a zoom_link_added notification' do
expect(SystemNoteService).to receive(:zoom_link_added).with(issue, project, user)
expect(SystemNoteService).not_to receive(:zoom_link_removed)
result
end
2019-12-04 20:38:33 +05:30
end
2019-12-26 22:10:19 +05:30
shared_examples 'cannot add meeting' do
it 'cannot add the meeting' do
2019-12-04 20:38:33 +05:30
expect(result).to be_error
expect(result.message).to eq('Failed to add a Zoom meeting')
end
2019-12-26 22:10:19 +05:30
it 'creates no notification' do
expect(SystemNoteService).not_to receive(:zoom_link_added)
expect(SystemNoteService).not_to receive(:zoom_link_removed)
result
end
2019-12-04 20:38:33 +05:30
end
subject(:result) { service.add_link(zoom_link) }
2019-12-26 22:10:19 +05:30
context 'without existing Zoom meeting' do
2020-01-01 13:55:28 +05:30
context 'when updating an issue' do
before do
allow(issue).to receive(:persisted?).and_return(true)
end
2019-12-04 20:38:33 +05:30
2020-01-01 13:55:28 +05:30
include_examples 'can add meeting'
2019-12-04 20:38:33 +05:30
2020-11-24 15:15:51 +05:30
context 'issue is incident type' do
let(:issue) { create(:incident) }
let(:current_user) { user }
it_behaves_like 'an incident management tracked event', :incident_management_incident_zoom_meeting
end
2020-01-01 13:55:28 +05:30
context 'with insufficient issue update permissions' do
include_context 'insufficient issue update permissions'
include_examples 'cannot add meeting'
end
2019-12-04 20:38:33 +05:30
end
2020-01-01 13:55:28 +05:30
context 'when creating an issue' do
before do
allow(issue).to receive(:persisted?).and_return(false)
end
it 'creates a new zoom meeting' do
expect(result).to be_success
expect(result.payload[:zoom_meetings][0].url).to eq(zoom_link)
end
context 'with insufficient issue create permissions' do
include_context 'insufficient issue create permissions'
include_examples 'cannot add meeting'
end
end
context 'with invalid Zoom url' do
let(:zoom_link) { 'https://not-zoom.link' }
2019-12-26 22:10:19 +05:30
include_examples 'cannot add meeting'
2019-12-04 20:38:33 +05:30
end
end
2019-12-26 22:10:19 +05:30
context 'with "added" Zoom meeting' do
include_context '"added" Zoom meeting'
include_examples 'cannot add meeting'
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
context 'with "added" Zoom meeting and race condition' do
include_context '"added" Zoom meeting'
before do
allow(service).to receive(:can_add_link?).and_return(true)
2020-01-01 13:55:28 +05:30
allow(issue).to receive(:persisted?).and_return(true)
2019-12-04 20:38:33 +05:30
end
2019-12-26 22:10:19 +05:30
include_examples 'cannot add meeting'
2019-12-04 20:38:33 +05:30
end
end
describe '#can_add_link?' do
subject { service.can_add_link? }
2019-12-26 22:10:19 +05:30
context 'without "added" zoom meeting' do
2019-12-04 20:38:33 +05:30
it { is_expected.to eq(true) }
2020-01-01 13:55:28 +05:30
context 'with insufficient issue update permissions' do
include_context 'insufficient issue update permissions'
2019-12-04 20:38:33 +05:30
it { is_expected.to eq(false) }
end
end
2019-12-26 22:10:19 +05:30
context 'with Zoom meeting in the issue description' do
include_context '"added" Zoom meeting'
2019-12-04 20:38:33 +05:30
it { is_expected.to eq(false) }
end
end
describe '#remove_link' do
2019-12-26 22:10:19 +05:30
shared_examples 'cannot remove meeting' do
it 'cannot remove the meeting' do
2019-12-04 20:38:33 +05:30
expect(result).to be_error
expect(result.message).to eq('Failed to remove a Zoom meeting')
end
2019-12-26 22:10:19 +05:30
it 'creates no notification' do
expect(SystemNoteService).not_to receive(:zoom_link_added)
expect(SystemNoteService).not_to receive(:zoom_link_removed)
result
end
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
shared_examples 'can remove meeting' do
it 'creates no notification' do
expect(SystemNoteService).not_to receive(:zoom_link_added).with(issue, project, user)
expect(SystemNoteService).to receive(:zoom_link_removed)
result
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
it 'can remove the meeting' do
2019-12-04 20:38:33 +05:30
expect(result).to be_success
2019-12-26 22:10:19 +05:30
expect(ZoomMeeting.canonical_meeting_url(issue)).to eq(nil)
2019-12-04 20:38:33 +05:30
end
2021-01-29 00:20:46 +05:30
it 'tracks the remove event', :snowplow do
2019-12-21 20:55:43 +05:30
result
2021-01-29 00:20:46 +05:30
expect_snowplow_event(
category: 'IncidentManagement::ZoomIntegration',
action: 'remove_zoom_meeting',
label: 'Issue ID',
2021-09-04 01:27:46 +05:30
value: issue.id,
user: user,
project: project,
namespace: project.namespace
2021-01-29 00:20:46 +05:30
)
2019-12-04 20:38:33 +05:30
end
2019-12-26 22:10:19 +05:30
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
subject(:result) { service.remove_link }
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
context 'with Zoom meeting' do
include_context '"added" Zoom meeting'
2020-01-01 13:55:28 +05:30
context 'with existing issue' do
before do
allow(issue).to receive(:persisted?).and_return(true)
end
2019-12-26 22:10:19 +05:30
include_examples 'can remove meeting'
2019-12-04 20:38:33 +05:30
end
2020-01-01 13:55:28 +05:30
context 'without existing issue' do
before do
allow(issue).to receive(:persisted?).and_return(false)
end
include_examples 'cannot remove meeting'
end
context 'with insufficient issue update permissions' do
include_context 'insufficient issue update permissions'
2019-12-26 22:10:19 +05:30
include_examples 'cannot remove meeting'
end
2019-12-04 20:38:33 +05:30
end
2019-12-26 22:10:19 +05:30
context 'without "added" Zoom meeting' do
include_context '"removed" zoom meetings'
include_examples 'cannot remove meeting'
2019-12-04 20:38:33 +05:30
end
end
describe '#can_remove_link?' do
subject { service.can_remove_link? }
2019-12-26 22:10:19 +05:30
context 'without Zoom meeting' do
it { is_expected.to eq(false) }
end
context 'with only "removed" zoom meetings' do
include_context '"removed" zoom meetings'
it { is_expected.to eq(false) }
end
2019-12-04 20:38:33 +05:30
2019-12-26 22:10:19 +05:30
context 'with "added" Zoom meeting' do
include_context '"added" Zoom meeting'
2019-12-04 20:38:33 +05:30
it { is_expected.to eq(true) }
2019-12-26 22:10:19 +05:30
context 'with "removed" zoom meetings' do
include_context '"removed" zoom meetings'
it { is_expected.to eq(true) }
end
2020-01-01 13:55:28 +05:30
context 'with insufficient issue update permissions' do
include_context 'insufficient issue update permissions'
2019-12-04 20:38:33 +05:30
it { is_expected.to eq(false) }
end
end
end
describe '#parse_link' do
subject { service.parse_link(description) }
context 'with valid Zoom links' do
where(:description) do
[
'Some text https://zoom.us/j/123456789 more text',
'Mixed https://zoom.us/j/123456789 http://example.com',
'Multiple link https://zoom.us/my/name https://zoom.us/j/123456789'
]
end
with_them do
it { is_expected.to eq('https://zoom.us/j/123456789') }
end
end
context 'with invalid Zoom links' do
where(:description) do
[
nil,
'',
'Text only',
'Non-Zoom http://example.com',
'Almost Zoom http://zoom.us'
]
end
with_them do
it { is_expected.to eq(nil) }
end
end
end
end