2014-09-02 18:07:02 +05:30
|
|
|
# == Schema Information
|
|
|
|
#
|
|
|
|
# Table name: notes
|
|
|
|
#
|
|
|
|
# id :integer not null, primary key
|
|
|
|
# note :text
|
|
|
|
# noteable_type :string(255)
|
|
|
|
# author_id :integer
|
|
|
|
# created_at :datetime
|
|
|
|
# updated_at :datetime
|
|
|
|
# project_id :integer
|
|
|
|
# attachment :string(255)
|
|
|
|
# line_code :string(255)
|
|
|
|
# commit_id :string(255)
|
|
|
|
# noteable_id :integer
|
|
|
|
# system :boolean default(FALSE), not null
|
|
|
|
# st_diff :text
|
2015-09-25 12:07:36 +05:30
|
|
|
# updated_by_id :integer
|
2014-09-02 18:07:02 +05:30
|
|
|
#
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Note do
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'associations' do
|
2015-04-26 12:48:37 +05:30
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
it { is_expected.to belong_to(:noteable) }
|
|
|
|
it { is_expected.to belong_to(:author).class_name('User') }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'validation' do
|
2015-04-26 12:48:37 +05:30
|
|
|
it { is_expected.to validate_presence_of(:note) }
|
|
|
|
it { is_expected.to validate_presence_of(:project) }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "Commit notes" do
|
|
|
|
let!(:note) { create(:note_on_commit, note: "+1 from me") }
|
|
|
|
let!(:commit) { note.noteable }
|
|
|
|
|
|
|
|
it "should be accessible through #noteable" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note.commit_id).to eq(commit.id)
|
|
|
|
expect(note.noteable).to be_a(Commit)
|
|
|
|
expect(note.noteable).to eq(commit)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "should save a valid note" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note.commit_id).to eq(commit.id)
|
2014-09-02 18:07:02 +05:30
|
|
|
note.noteable == commit
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_commit?" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note).to be_for_commit
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Commit diff line notes" do
|
|
|
|
let!(:note) { create(:note_on_commit_diff, note: "+1 from me") }
|
|
|
|
let!(:commit) { note.noteable }
|
|
|
|
|
|
|
|
it "should save a valid note" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note.commit_id).to eq(commit.id)
|
|
|
|
expect(note.noteable.id).to eq(commit.id)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_diff_line?" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note).to be_for_diff_line
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_commit_diff_line?" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(note).to be_for_commit_diff_line
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'authorization' do
|
2014-09-02 18:07:02 +05:30
|
|
|
before do
|
|
|
|
@p1 = create(:project)
|
|
|
|
@p2 = create(:project)
|
|
|
|
@u1 = create(:user)
|
|
|
|
@u2 = create(:user)
|
|
|
|
@u3 = create(:user)
|
|
|
|
@abilities = Six.new
|
|
|
|
@abilities << Ability
|
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'read' do
|
2014-09-02 18:07:02 +05:30
|
|
|
before do
|
2015-04-26 12:48:37 +05:30
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::GUEST)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::GUEST)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
it { expect(@abilities.allowed?(@u1, :read_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :read_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :read_note, @p1)).to be_falsey }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'write' do
|
2014-09-02 18:07:02 +05:30
|
|
|
before do
|
2015-04-26 12:48:37 +05:30
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::DEVELOPER)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::DEVELOPER)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
it { expect(@abilities.allowed?(@u1, :create_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :create_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :create_note, @p1)).to be_falsey }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'admin' do
|
2014-09-02 18:07:02 +05:30
|
|
|
before do
|
2015-04-26 12:48:37 +05:30
|
|
|
@p1.project_members.create(user: @u1, access_level: ProjectMember::REPORTER)
|
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::MASTER)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::MASTER)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
it { expect(@abilities.allowed?(@u1, :admin_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :admin_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :admin_note, @p1)).to be_falsey }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'an editable mentionable' do
|
2015-10-24 18:46:33 +05:30
|
|
|
subject { create :note, noteable: issue, project: issue.project }
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2015-10-24 18:46:33 +05:30
|
|
|
let(:issue) { create :issue }
|
2014-09-02 18:07:02 +05:30
|
|
|
let(:backref_text) { issue.gfm_reference }
|
|
|
|
let(:set_mentionable_text) { ->(txt) { subject.note = txt } }
|
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
|
|
|
describe :search do
|
|
|
|
let!(:note) { create(:note, note: "WoW") }
|
|
|
|
|
|
|
|
it { expect(Note.search('wow')).to include(note) }
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
|
|
|
describe :grouped_awards do
|
|
|
|
before do
|
|
|
|
create :note, note: "smile", is_award: true
|
|
|
|
create :note, note: "smile", is_award: true
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns grouped array of notes" do
|
|
|
|
expect(Note.grouped_awards.first.first).to eq("smile")
|
|
|
|
expect(Note.grouped_awards.first.last).to match_array(Note.all)
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|