2021-02-22 17:27:13 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'fast_spec_helper'
|
|
|
|
require_relative '../../../../rubocop/cop/gitlab/policy_rule_boolean'
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
RSpec.describe RuboCop::Cop::Gitlab::PolicyRuleBoolean do
|
2021-02-22 17:27:13 +05:30
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
|
|
|
it 'registers offense for &&' do
|
|
|
|
expect_offense(<<~SOURCE)
|
|
|
|
rule { conducts_electricity && batteries }.enable :light_bulb
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ && is not allowed within a rule block. Did you mean to use `&`?
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers offense for ||' do
|
|
|
|
expect_offense(<<~SOURCE)
|
|
|
|
rule { conducts_electricity || batteries }.enable :light_bulb
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ || is not allowed within a rule block. Did you mean to use `|`?
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers offense for if' do
|
|
|
|
expect_offense(<<~SOURCE)
|
|
|
|
rule { if conducts_electricity then can?(:magnetize) else batteries end }.enable :motor
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ if and ternary operators are not allowed within a rule block.
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers offense for ternary operator' do
|
|
|
|
expect_offense(<<~SOURCE)
|
|
|
|
rule { conducts_electricity ? can?(:magnetize) : batteries }.enable :motor
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ if and ternary operators are not allowed within a rule block.
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers no offense for &' do
|
|
|
|
expect_no_offenses(<<~SOURCE)
|
|
|
|
rule { conducts_electricity & batteries }.enable :light_bulb
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers no offense for |' do
|
|
|
|
expect_no_offenses(<<~SOURCE)
|
|
|
|
rule { conducts_electricity | batteries }.enable :light_bulb
|
|
|
|
SOURCE
|
|
|
|
end
|
|
|
|
end
|