debian-mirror-gitlab/spec/graphql/resolvers/group_milestones_resolver_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

202 lines
7.4 KiB
Ruby
Raw Normal View History

2020-10-24 23:57:45 +05:30
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Resolvers::GroupMilestonesResolver do
2021-09-30 23:02:18 +05:30
using RSpec::Parameterized::TableSyntax
2020-10-24 23:57:45 +05:30
include GraphqlHelpers
describe '#resolve' do
let_it_be(:current_user) { create(:user) }
def resolve_group_milestones(args = {}, context = { current_user: current_user })
2022-07-23 23:45:48 +05:30
resolve(described_class, obj: group, args: args, ctx: context, arg_style: :internal)
2020-10-24 23:57:45 +05:30
end
let_it_be(:now) { Time.now }
let_it_be(:group) { create(:group, :private) }
2021-01-03 14:25:43 +05:30
def args(**arguments)
satisfy("contain only #{arguments.inspect}") do |passed|
expect(passed.compact).to match(arguments)
end
end
2020-10-24 23:57:45 +05:30
before_all do
group.add_developer(current_user)
end
it 'calls MilestonesFinder#execute' do
expect_next_instance_of(MilestonesFinder) do |finder|
expect(finder).to receive(:execute)
end
resolve_group_milestones
end
context 'without parameters' do
it 'calls MilestonesFinder to retrieve all milestones' do
expect(MilestonesFinder).to receive(:new)
2021-01-03 14:25:43 +05:30
.with(args(group_ids: group.id, state: 'all'))
2020-10-24 23:57:45 +05:30
.and_call_original
resolve_group_milestones
end
end
context 'with parameters' do
it 'calls MilestonesFinder with correct parameters' do
start_date = now
end_date = start_date + 1.hour
expect(MilestonesFinder).to receive(:new)
2021-01-03 14:25:43 +05:30
.with(args(group_ids: group.id, state: 'closed', start_date: start_date, end_date: end_date))
2020-10-24 23:57:45 +05:30
.and_call_original
resolve_group_milestones(start_date: start_date, end_date: end_date, state: 'closed')
end
2021-01-03 14:25:43 +05:30
it 'understands the timeframe argument' do
start_date = now
end_date = start_date + 1.hour
expect(MilestonesFinder).to receive(:new)
.with(args(group_ids: group.id, state: 'closed', start_date: start_date, end_date: end_date))
.and_call_original
resolve_group_milestones(timeframe: { start: start_date, end: end_date }, state: 'closed')
end
2020-10-24 23:57:45 +05:30
end
context 'by ids' do
it 'calls MilestonesFinder with correct parameters' do
milestone = create(:milestone, group: group)
expect(MilestonesFinder).to receive(:new)
2021-01-03 14:25:43 +05:30
.with(args(ids: [milestone.id.to_s], group_ids: group.id, state: 'all'))
2020-10-24 23:57:45 +05:30
.and_call_original
resolve_group_milestones(ids: [milestone.to_global_id])
end
end
2021-09-30 23:02:18 +05:30
context 'by sort' do
it 'calls MilestonesFinder with correct parameters' do
expect(MilestonesFinder).to receive(:new)
.with(args(group_ids: group.id, state: 'all', sort: :due_date_desc))
.and_call_original
resolve_group_milestones(sort: :due_date_desc)
end
%i[expired_last_due_date_asc expired_last_due_date_desc].each do |sort_by|
it "uses offset-pagination when sorting by #{sort_by}" do
resolved = resolve_group_milestones(sort: sort_by)
expect(resolved).to be_a(::Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection)
end
end
end
2020-10-24 23:57:45 +05:30
context 'by timeframe' do
context 'when start_date and end_date are present' do
context 'when start date is after end_date' do
2022-05-07 20:08:51 +05:30
it 'generates an error' do
expect_graphql_error_to_be_created(Gitlab::Graphql::Errors::ArgumentError, "startDate is after endDate") do
2020-10-24 23:57:45 +05:30
resolve_group_milestones(start_date: now, end_date: now - 2.days)
2022-05-07 20:08:51 +05:30
end
2020-10-24 23:57:45 +05:30
end
end
end
context 'when only start_date is present' do
2022-05-07 20:08:51 +05:30
it 'generates an error' do
expect_graphql_error_to_be_created(Gitlab::Graphql::Errors::ArgumentError, /Both startDate and endDate/) do
2020-10-24 23:57:45 +05:30
resolve_group_milestones(start_date: now)
2022-05-07 20:08:51 +05:30
end
2020-10-24 23:57:45 +05:30
end
end
context 'when only end_date is present' do
2022-05-07 20:08:51 +05:30
it 'generates an error' do
expect_graphql_error_to_be_created(Gitlab::Graphql::Errors::ArgumentError, /Both startDate and endDate/) do
2020-10-24 23:57:45 +05:30
resolve_group_milestones(end_date: now)
2022-05-07 20:08:51 +05:30
end
2020-10-24 23:57:45 +05:30
end
end
end
context 'when including descendant milestones in a public group' do
let_it_be(:group) { create(:group, :public) }
2021-06-08 01:23:25 +05:30
2020-10-24 23:57:45 +05:30
let(:args) { { include_descendants: true } }
it 'finds milestones only in accessible projects and groups' do
accessible_group = create(:group, :private, parent: group)
accessible_project = create(:project, group: accessible_group)
accessible_group.add_developer(current_user)
inaccessible_group = create(:group, :private, parent: group)
inaccessible_project = create(:project, :private, group: group)
milestone1 = create(:milestone, group: group)
milestone2 = create(:milestone, group: accessible_group)
milestone3 = create(:milestone, project: accessible_project)
create(:milestone, group: inaccessible_group)
create(:milestone, project: inaccessible_project)
expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3])
end
end
2021-04-29 21:17:54 +05:30
describe 'include_descendants and include_ancestors' do
let_it_be(:parent_group) { create(:group, :public) }
let_it_be(:group) { create(:group, :public, parent: parent_group) }
let_it_be(:accessible_group) { create(:group, :private, parent: group) }
let_it_be(:accessible_project) { create(:project, group: accessible_group) }
let_it_be(:inaccessible_group) { create(:group, :private, parent: group) }
let_it_be(:inaccessible_project) { create(:project, :private, group: group) }
let_it_be(:milestone1) { create(:milestone, group: group) }
let_it_be(:milestone2) { create(:milestone, group: accessible_group) }
let_it_be(:milestone3) { create(:milestone, project: accessible_project) }
let_it_be(:milestone4) { create(:milestone, group: inaccessible_group) }
let_it_be(:milestone5) { create(:milestone, project: inaccessible_project) }
let_it_be(:milestone6) { create(:milestone, group: parent_group) }
before do
accessible_group.add_developer(current_user)
end
context 'when including neither ancestor or descendant milestones in a public group' do
let(:args) { {} }
it 'finds milestones only in accessible projects and groups' do
expect(resolve_group_milestones(args)).to match_array([milestone1])
end
end
context 'when including descendant milestones in a public group' do
let(:args) { { include_descendants: true } }
it 'finds milestones only in accessible projects and groups' do
expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3])
end
end
context 'when including ancestor milestones in a public group' do
let(:args) { { include_ancestors: true } }
it 'finds milestones only in accessible projects and groups' do
expect(resolve_group_milestones(args)).to match_array([milestone1, milestone6])
end
end
context 'when including both ancestor or descendant milestones in a public group' do
let(:args) { { include_descendants: true, include_ancestors: true } }
it 'finds milestones only in accessible projects and groups' do
expect(resolve_group_milestones(args)).to match_array([milestone1, milestone2, milestone3, milestone6])
end
end
end
2020-10-24 23:57:45 +05:30
end
end