2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe 'Issue Boards new issue', :js do
|
2021-04-29 21:17:54 +05:30
|
|
|
let_it_be(:project) { create(:project, :public) }
|
|
|
|
let_it_be(:board) { create(:board, project: project) }
|
|
|
|
let_it_be(:backlog_list) { create(:backlog_list, board: board) }
|
|
|
|
let_it_be(:label) { create(:label, project: project, name: 'Label 1') }
|
|
|
|
let_it_be(:list) { create(:list, board: board, label: label, position: 0) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
let(:board_list_header) { first('[data-testid="board-list-header"]') }
|
|
|
|
let(:project_select_dropdown) { find('[data-testid="project-select-dropdown"]') }
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
context 'authorized user' do
|
|
|
|
before do
|
2018-11-18 11:00:15 +05:30
|
|
|
project.add_maintainer(user)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(user)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
visit project_board_path(project, board)
|
2021-04-29 21:17:54 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
wait_for_requests
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(page).to have_selector('.board', count: 3)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'displays new issue button' do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(first('.board')).to have_button('New issue', count: 1)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'does not display new issue button in closed list' do
|
2017-09-10 17:25:29 +05:30
|
|
|
page.within('.board:nth-child(3)') do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).not_to have_button('New issue')
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows form when clicking button' do
|
|
|
|
page.within(first('.board')) do
|
2021-06-08 01:23:25 +05:30
|
|
|
click_button 'New issue'
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
expect(page).to have_selector('.board-new-issue-form')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'hides form when clicking cancel' do
|
|
|
|
page.within(first('.board')) do
|
2021-06-08 01:23:25 +05:30
|
|
|
click_button 'New issue'
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
expect(page).to have_selector('.board-new-issue-form')
|
|
|
|
|
|
|
|
click_button 'Cancel'
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).not_to have_selector('.board-new-issue-form')
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates new issue' do
|
|
|
|
page.within(first('.board')) do
|
2021-06-08 01:23:25 +05:30
|
|
|
click_button 'New issue'
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
page.within(first('.board-new-issue-form')) do
|
|
|
|
find('.form-control').set('bug')
|
2021-04-29 21:17:54 +05:30
|
|
|
click_button 'Create issue'
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
wait_for_requests
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
page.within(first('.board .issue-count-badge-count')) do
|
2016-11-03 12:29:30 +05:30
|
|
|
expect(page).to have_content('1')
|
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
page.within(first('.board-card')) do
|
2018-05-09 12:01:36 +05:30
|
|
|
issue = project.issues.find_by_title('bug')
|
|
|
|
|
|
|
|
expect(page).to have_content(issue.to_reference)
|
2021-04-29 21:17:54 +05:30
|
|
|
expect(page).to have_link(issue.title, href: /#{issue_path(issue)}/)
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
# TODO https://gitlab.com/gitlab-org/gitlab/-/issues/323446
|
|
|
|
xit 'shows sidebar when creating new issue' do
|
2017-08-17 22:00:37 +05:30
|
|
|
page.within(first('.board')) do
|
2021-06-08 01:23:25 +05:30
|
|
|
click_button 'New issue'
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
page.within(first('.board-new-issue-form')) do
|
|
|
|
find('.form-control').set('bug')
|
2021-04-29 21:17:54 +05:30
|
|
|
click_button 'Create issue'
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
wait_for_requests
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
expect(page).to have_selector('[data-testid="issue-boards-sidebar"]')
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'successfuly loads labels to be added to newly created issue' do
|
|
|
|
page.within(first('.board')) do
|
2021-06-08 01:23:25 +05:30
|
|
|
click_button 'New issue'
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
page.within(first('.board-new-issue-form')) do
|
|
|
|
find('.form-control').set('new issue')
|
2021-04-29 21:17:54 +05:30
|
|
|
click_button 'Create issue'
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
wait_for_requests
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
page.within(first('.board')) do
|
|
|
|
find('.board-card').click
|
|
|
|
end
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
page.within('[data-testid="sidebar-labels"]') do
|
|
|
|
click_button 'Edit'
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
wait_for_requests
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).to have_content 'Label 1'
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'unauthorized user' do
|
|
|
|
before do
|
2017-09-10 17:25:29 +05:30
|
|
|
visit project_board_path(project, board)
|
|
|
|
wait_for_requests
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
it 'displays new issue button in open list' do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(first('.board')).to have_button('New issue', count: 1)
|
2018-12-13 13:39:08 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not display new issue button in label list' do
|
|
|
|
page.within('.board:nth-child(2)') do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).not_to have_button('New issue')
|
2018-12-13 13:39:08 +05:30
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
context 'group boards' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group) { create(:group, :public) }
|
2021-06-08 01:23:25 +05:30
|
|
|
let_it_be(:project) { create(:project, namespace: group, name: "root project") }
|
|
|
|
let_it_be(:subgroup) { create(:group, parent: group) }
|
|
|
|
let_it_be(:subproject1) { create(:project, group: subgroup, name: "sub project1") }
|
|
|
|
let_it_be(:subproject2) { create(:project, group: subgroup, name: "sub project2") }
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group_board) { create(:board, group: group) }
|
2020-11-24 15:15:51 +05:30
|
|
|
let_it_be(:project_label) { create(:label, project: project, name: 'label') }
|
|
|
|
let_it_be(:list) { create(:list, board: group_board, label: project_label, position: 0) }
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
context 'for unauthorized users' do
|
2021-06-08 01:23:25 +05:30
|
|
|
before do
|
|
|
|
visit group_board_path(group, group_board)
|
|
|
|
wait_for_requests
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
context 'when backlog does not exist' do
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'does not display new issue button in label list' do
|
|
|
|
page.within('.board.is-draggable') do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).not_to have_button('New issue')
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'when backlog list already exists' do
|
2021-06-08 01:23:25 +05:30
|
|
|
let_it_be(:backlog_list) { create(:backlog_list, board: group_board) }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
it 'displays new issue button in open list' do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(first('.board')).to have_button('New issue', count: 1)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not display new issue button in label list' do
|
|
|
|
page.within('.board.is-draggable') do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).not_to have_button('New issue')
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for authorized users' do
|
2021-06-08 01:23:25 +05:30
|
|
|
before do
|
2019-12-04 20:38:33 +05:30
|
|
|
project.add_reporter(user)
|
2021-06-08 01:23:25 +05:30
|
|
|
subproject1.add_reporter(user)
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
visit group_board_path(group, group_board)
|
|
|
|
wait_for_requests
|
2021-06-08 01:23:25 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when backlog does not exist' do
|
|
|
|
it 'display new issue button in label list' do
|
|
|
|
expect(board_list_header).to have_button('New issue')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'project select dropdown' do
|
|
|
|
let_it_be(:backlog_list) { create(:backlog_list, board: group_board) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
page.within(board_list_header) do
|
|
|
|
click_button 'New issue'
|
|
|
|
end
|
|
|
|
|
|
|
|
project_select_dropdown.click
|
|
|
|
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'lists a project which is a direct descendant of the top-level group' do
|
|
|
|
expect(project_select_dropdown).to have_button("root project")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'lists a project that belongs to a subgroup' do
|
|
|
|
expect(project_select_dropdown).to have_button("sub project1")
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
it "does not list projects to which user doesn't have access" do
|
|
|
|
expect(project_select_dropdown).not_to have_button("sub project2")
|
2019-12-04 20:38:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|