debian-mirror-gitlab/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb

42 lines
1.3 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2020-07-28 23:09:34 +05:30
require 'fast_spec_helper'
2017-08-17 22:00:37 +05:30
require_relative '../../../../rubocop/cop/migration/add_concurrent_foreign_key'
2021-03-08 18:12:59 +05:30
RSpec.describe RuboCop::Cop::Migration::AddConcurrentForeignKey do
2017-08-17 22:00:37 +05:30
let(:cop) { described_class.new }
2021-04-17 20:07:23 +05:30
context 'when outside of a migration' do
2017-08-17 22:00:37 +05:30
it 'does not register any offenses' do
2021-04-17 20:07:23 +05:30
expect_no_offenses('def up; add_foreign_key(:projects, :users, column: :user_id); end')
2017-08-17 22:00:37 +05:30
end
end
2021-04-17 20:07:23 +05:30
context 'when in a migration' do
2017-08-17 22:00:37 +05:30
before do
allow(cop).to receive(:in_migration?).and_return(true)
end
it 'registers an offense when using add_foreign_key' do
2021-04-17 20:07:23 +05:30
expect_offense(<<~RUBY)
def up
add_foreign_key(:projects, :users, column: :user_id)
^^^^^^^^^^^^^^^ `add_foreign_key` requires downtime, use `add_concurrent_foreign_key` instead
end
RUBY
2017-08-17 22:00:37 +05:30
end
2020-05-24 23:13:21 +05:30
it 'does not register an offense when a `NOT VALID` foreign key is added' do
2021-04-17 20:07:23 +05:30
expect_no_offenses('def up; add_foreign_key(:projects, :users, column: :user_id, validate: false); end')
2020-05-24 23:13:21 +05:30
end
2021-01-03 14:25:43 +05:30
it 'does not register an offense when `add_foreign_key` is within `with_lock_retries`' do
2021-04-17 20:07:23 +05:30
expect_no_offenses(<<~RUBY)
2021-01-03 14:25:43 +05:30
with_lock_retries do
add_foreign_key :key, :projects, column: :project_id, on_delete: :cascade
end
RUBY
end
2017-08-17 22:00:37 +05:30
end
end