2019-12-26 22:10:19 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe GlobalPolicy do
|
2018-10-15 14:42:47 +05:30
|
|
|
include TermsHelper
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
let_it_be(:project_bot) { create(:user, :project_bot) }
|
2020-05-24 23:13:21 +05:30
|
|
|
let_it_be(:migration_bot) { create(:user, :migration_bot) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:current_user) { create(:user) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
subject { described_class.new(current_user, [user]) }
|
|
|
|
|
|
|
|
describe "reading the list of users" do
|
|
|
|
context "for a logged in user" do
|
|
|
|
it { is_expected.to be_allowed(:read_users_list) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "for an anonymous user" do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
context "when the public level is restricted" do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:read_users_list) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the public level is not restricted" do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [])
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:read_users_list) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "for an admin" do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
context "when the public level is restricted" do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:read_users_list) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the public level is not restricted" do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [])
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:read_users_list) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
describe "create fork" do
|
|
|
|
context "when user has not exceeded project limit" do
|
|
|
|
it { is_expected.to be_allowed(:create_fork) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when user has exceeded project limit" do
|
|
|
|
let(:current_user) { create(:user, projects_limit: 0) }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:create_fork) }
|
|
|
|
end
|
|
|
|
|
2018-11-18 11:00:15 +05:30
|
|
|
context "when user is a maintainer in a group" do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:current_user) { create(:user, projects_limit: 0) }
|
|
|
|
|
|
|
|
before do
|
2018-11-18 11:00:15 +05:30
|
|
|
group.add_maintainer(current_user)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:create_fork) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
describe 'create group' do
|
|
|
|
context 'when user has the ability to create group' do
|
|
|
|
let(:current_user) { create(:user, can_create_group: true) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:create_group) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have the ability to create group' do
|
|
|
|
let(:current_user) { create(:user, can_create_group: false) }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:create_group) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'create group with default branch protection' do
|
|
|
|
context 'when user has the ability to create group' do
|
|
|
|
let(:current_user) { create(:user, can_create_group: true) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:create_group_with_default_branch_protection) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have the ability to create group' do
|
|
|
|
let(:current_user) { create(:user, can_create_group: false) }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:create_group_with_default_branch_protection) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
describe 'custom attributes' do
|
|
|
|
context 'regular user' do
|
|
|
|
it { is_expected.not_to be_allowed(:read_custom_attribute) }
|
|
|
|
it { is_expected.not_to be_allowed(:update_custom_attribute) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { create(:user, :admin) }
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
|
|
it { is_expected.to be_allowed(:read_custom_attribute) }
|
|
|
|
it { is_expected.to be_allowed(:update_custom_attribute) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode is disabled' do
|
|
|
|
it { is_expected.to be_disallowed(:read_custom_attribute) }
|
|
|
|
it { is_expected.to be_disallowed(:update_custom_attribute) }
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
shared_examples 'access allowed when terms accepted' do |ability|
|
|
|
|
it { is_expected.not_to be_allowed(ability) }
|
|
|
|
|
|
|
|
it "allows #{ability} when the user accepted the terms" do
|
|
|
|
accept_terms(current_user)
|
|
|
|
|
|
|
|
is_expected.to be_allowed(ability)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'API access' do
|
|
|
|
context 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'project bot' do
|
|
|
|
let(:current_user) { project_bot }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
context 'migration bot' do
|
|
|
|
let(:current_user) { migration_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
context 'when terms are enforced' do
|
|
|
|
before do
|
|
|
|
enforce_terms
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'regular user' do
|
|
|
|
it_behaves_like 'access allowed when terms accepted', :access_api
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it_behaves_like 'access allowed when terms accepted', :access_api
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
end
|
2020-02-01 01:16:34 +05:30
|
|
|
|
|
|
|
context 'inactive user' do
|
|
|
|
before do
|
|
|
|
current_user.update!(confirmed_at: nil, confirmation_sent_at: 5.days.ago)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when within the confirmation grace period' do
|
|
|
|
before do
|
|
|
|
allow(User).to receive(:allow_unconfirmed_access_for).and_return(10.days)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when confirmation grace period is expired' do
|
|
|
|
before do
|
|
|
|
allow(User).to receive(:allow_unconfirmed_access_for).and_return(2.days)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:access_api) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'when `inactive_policy_condition` feature flag is turned off' do
|
|
|
|
stub_feature_flags(inactive_policy_condition: false)
|
|
|
|
|
|
|
|
is_expected.to be_allowed(:access_api)
|
|
|
|
end
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
describe 'receive notifications' do
|
|
|
|
describe 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:receive_notifications) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:receive_notifications) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:receive_notifications) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'blocked user' do
|
|
|
|
before do
|
|
|
|
current_user.block
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:receive_notifications) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'deactivated user' do
|
|
|
|
before do
|
|
|
|
current_user.deactivate
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:receive_notifications) }
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
context 'project bot' do
|
|
|
|
let(:current_user) { project_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:receive_notifications) }
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'migration bot' do
|
|
|
|
let(:current_user) { migration_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:receive_notifications) }
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
describe 'git access' do
|
|
|
|
describe 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
context 'migration bot' do
|
|
|
|
let(:current_user) { migration_bot }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
describe 'deactivated user' do
|
|
|
|
before do
|
|
|
|
current_user.deactivate
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
|
2020-02-01 01:16:34 +05:30
|
|
|
describe 'inactive user' do
|
|
|
|
before do
|
|
|
|
current_user.update!(confirmed_at: nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:access_git) }
|
|
|
|
|
|
|
|
it 'when `inactive_policy_condition` feature flag is turned off' do
|
|
|
|
stub_feature_flags(inactive_policy_condition: false)
|
|
|
|
|
|
|
|
is_expected.to be_allowed(:access_git)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
context 'when terms are enforced' do
|
|
|
|
before do
|
|
|
|
enforce_terms
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'regular user' do
|
|
|
|
it_behaves_like 'access allowed when terms accepted', :access_git
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it_behaves_like 'access allowed when terms accepted', :access_git
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
context 'project bot' do
|
|
|
|
let(:current_user) { project_bot }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:access_git) }
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
describe 'read instance metadata' do
|
|
|
|
context 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:read_instance_metadata) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:read_instance_metadata) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-18 11:00:15 +05:30
|
|
|
describe 'read instance statistics' do
|
|
|
|
context 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:read_instance_statistics) }
|
|
|
|
|
|
|
|
context 'when instance statistics are set to private' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(instance_statistics_visibility_private: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:read_instance_statistics) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:read_instance_statistics) }
|
|
|
|
|
|
|
|
context 'when instance statistics are set to private' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(instance_statistics_visibility_private: true)
|
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
|
|
it { is_expected.to be_allowed(:read_instance_statistics) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode is disabled' do
|
|
|
|
it { is_expected.to be_disallowed(:read_instance_statistics) }
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:read_instance_statistics) }
|
|
|
|
end
|
|
|
|
end
|
2019-07-31 22:56:46 +05:30
|
|
|
|
|
|
|
describe 'slash commands' do
|
|
|
|
context 'regular user' do
|
|
|
|
it { is_expected.to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when internal' do
|
|
|
|
let(:current_user) { User.ghost }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when blocked' do
|
|
|
|
before do
|
|
|
|
current_user.block
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
context 'when deactivated' do
|
|
|
|
before do
|
|
|
|
current_user.deactivate
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
|
|
|
|
2020-02-01 01:16:34 +05:30
|
|
|
describe 'inactive user' do
|
|
|
|
before do
|
|
|
|
current_user.update!(confirmed_at: nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
|
|
|
|
it 'when `inactive_policy_condition` feature flag is turned off' do
|
|
|
|
stub_feature_flags(inactive_policy_condition: false)
|
|
|
|
|
|
|
|
is_expected.to be_allowed(:use_slash_commands)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
context 'when access locked' do
|
|
|
|
before do
|
|
|
|
current_user.lock_access!
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
context 'project bot' do
|
|
|
|
let(:current_user) { project_bot }
|
|
|
|
|
|
|
|
it { is_expected.to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'migration bot' do
|
|
|
|
let(:current_user) { migration_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:use_slash_commands) }
|
|
|
|
end
|
2019-07-31 22:56:46 +05:30
|
|
|
end
|
2020-01-01 13:55:28 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe 'create_snippet' do
|
2020-01-01 13:55:28 +05:30
|
|
|
context 'when anonymous' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { is_expected.not_to be_allowed(:create_snippet) }
|
2020-01-01 13:55:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'regular user' do
|
2020-03-13 15:44:24 +05:30
|
|
|
it { is_expected.to be_allowed(:create_snippet) }
|
2020-01-01 13:55:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when external' do
|
|
|
|
let(:current_user) { build(:user, :external) }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { is_expected.not_to be_allowed(:create_snippet) }
|
2020-01-01 13:55:28 +05:30
|
|
|
end
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
describe 'log in' do
|
|
|
|
context 'project bot' do
|
|
|
|
let(:current_user) { project_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:log_in) }
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'migration bot' do
|
|
|
|
let(:current_user) { migration_bot }
|
|
|
|
|
|
|
|
it { is_expected.not_to be_allowed(:log_in) }
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|