debian-mirror-gitlab/app/controllers/projects/issues_controller.rb

250 lines
6.9 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
class Projects::IssuesController < Projects::ApplicationController
2017-08-17 22:00:37 +05:30
include RendersNotes
2016-06-02 11:05:42 +05:30
include ToggleSubscriptionAction
include IssuableActions
include ToggleAwardEmoji
2016-09-13 17:45:13 +05:30
include IssuableCollections
2018-11-08 19:23:39 +05:30
include IssuesCalendar
2016-09-13 17:45:13 +05:30
include SpammableActions
2016-06-02 11:05:42 +05:30
2017-08-17 22:00:37 +05:30
prepend_before_action :authenticate_user!, only: [:new]
2018-03-17 18:26:18 +05:30
before_action :whitelist_query_limiting, only: [:create, :create_merge_request, :move, :bulk_update]
2017-09-10 17:25:29 +05:30
before_action :check_issues_available!
2018-11-08 19:23:39 +05:30
before_action :issue, except: [:index, :calendar, :new, :create, :bulk_update]
before_action :set_issuables_index, only: [:index, :calendar]
2014-09-02 18:07:02 +05:30
# Allow write(create) issue
2015-09-11 14:41:01 +05:30
before_action :authorize_create_issue!, only: [:new, :create]
2014-09-02 18:07:02 +05:30
# Allow modify issue
2018-03-17 18:26:18 +05:30
before_action :authorize_update_issuable!, only: [:edit, :update, :move]
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
# Allow create a new branch and empty WIP merge request from current issue
2018-05-09 12:01:36 +05:30
before_action :authorize_create_merge_request_from!, only: [:create_merge_request]
2017-08-17 22:00:37 +05:30
2014-09-02 18:07:02 +05:30
respond_to :html
def index
2018-03-17 18:26:18 +05:30
@issues = @issuables
2017-08-17 22:00:37 +05:30
2014-09-02 18:07:02 +05:30
respond_to do |format|
format.html
2017-09-10 17:25:29 +05:30
format.atom { render layout: 'xml.atom' }
2014-09-02 18:07:02 +05:30
format.json do
render json: {
2016-06-02 11:05:42 +05:30
html: view_to_html_string("projects/issues/_issues"),
labels: @labels.as_json(methods: :text_color)
2014-09-02 18:07:02 +05:30
}
end
end
end
2018-11-08 19:23:39 +05:30
def calendar
render_issues_calendar(@issuables)
end
2014-09-02 18:07:02 +05:30
def new
params[:issue] ||= ActionController::Parameters.new(
2017-08-17 22:00:37 +05:30
assignee_ids: ""
2014-09-02 18:07:02 +05:30
)
2017-08-17 22:00:37 +05:30
build_params = issue_params.merge(
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
discussion_to_resolve: params[:discussion_to_resolve]
)
service = Issues::BuildService.new(project, current_user, build_params)
@issue = @noteable = service.execute
@merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
@discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
2014-09-02 18:07:02 +05:30
respond_with(@issue)
end
def edit
respond_with(@issue)
end
def create
2017-08-17 22:00:37 +05:30
create_params = issue_params.merge(spammable_params).merge(
merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
discussion_to_resolve: params[:discussion_to_resolve]
)
service = Issues::CreateService.new(project, current_user, create_params)
@issue = service.execute
if service.discussions_to_resolve.count(&:resolved?) > 0
flash[:notice] = if service.discussion_to_resolve_id
"Resolved 1 discussion."
else
"Resolved all discussions."
end
end
2014-09-02 18:07:02 +05:30
respond_to do |format|
format.html do
2017-08-17 22:00:37 +05:30
recaptcha_check_with_fallback { render :new }
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
format.js do
2014-09-02 18:07:02 +05:30
@link = @issue.attachment.url.to_js
end
end
end
2018-03-17 18:26:18 +05:30
def move
params.require(:move_to_project_id)
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
if params[:move_to_project_id].to_i > 0
new_project = Project.find(params[:move_to_project_id])
return render_404 unless issue.can_move?(current_user, new_project)
2018-03-17 18:26:18 +05:30
@issue = Issues::UpdateService.new(project, current_user, target_project: new_project).execute(issue)
2016-06-02 11:05:42 +05:30
end
2014-09-02 18:07:02 +05:30
respond_to do |format|
2016-06-02 11:05:42 +05:30
format.json do
2018-03-17 18:26:18 +05:30
render_issue_json
2016-06-02 11:05:42 +05:30
end
end
2016-09-29 09:46:39 +05:30
rescue ActiveRecord::StaleObjectError
2017-08-17 22:00:37 +05:30
render_conflict_response
2016-06-02 11:05:42 +05:30
end
def referenced_merge_requests
2018-11-20 20:47:30 +05:30
@merge_requests, @closed_by_merge_requests = ::Issues::ReferencedMergeRequestsService.new(project, current_user).execute(issue)
2016-06-02 11:05:42 +05:30
respond_to do |format|
2014-09-02 18:07:02 +05:30
format.json do
render json: {
2016-06-02 11:05:42 +05:30
html: view_to_html_string('projects/issues/_merge_requests')
2014-09-02 18:07:02 +05:30
}
end
end
end
2016-06-02 11:05:42 +05:30
def related_branches
@related_branches = @issue.related_branches(current_user)
respond_to do |format|
format.json do
render json: {
html: view_to_html_string('projects/issues/_related_branches')
}
end
end
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
def can_create_branch
can_create = current_user &&
can?(current_user, :push_code, @project) &&
2018-10-15 14:42:47 +05:30
@issue.can_be_worked_on?
2015-09-11 14:41:01 +05:30
2016-06-02 11:05:42 +05:30
respond_to do |format|
format.json do
2018-10-15 14:42:47 +05:30
render json: { can_create_branch: can_create, suggested_branch_name: @issue.suggested_branch_name }
2016-06-02 11:05:42 +05:30
end
end
2015-04-26 12:48:37 +05:30
end
2017-08-17 22:00:37 +05:30
def create_merge_request
2018-03-17 18:26:18 +05:30
create_params = params.slice(:branch_name, :ref).merge(issue_iid: issue.iid)
result = ::MergeRequests::CreateFromIssueService.new(project, current_user, create_params).execute
2017-08-17 22:00:37 +05:30
if result[:status] == :success
render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
else
render json: result[:messsage], status: :unprocessable_entity
end
end
2014-09-02 18:07:02 +05:30
protected
def issue
2017-09-10 17:25:29 +05:30
return @issue if defined?(@issue)
2018-03-17 18:26:18 +05:30
2016-11-03 12:29:30 +05:30
# The Sortable default scope causes performance issues when used with find_by
2018-11-18 11:00:15 +05:30
@issuable = @noteable = @issue ||= @project.issues.includes(author: :status).where(iid: params[:id]).reorder(nil).take!
2018-03-17 18:26:18 +05:30
@note = @project.notes.new(noteable: @issuable)
2017-09-10 17:25:29 +05:30
return render_404 unless can?(current_user, :read_issue, @issue)
@issue
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
alias_method :subscribable_resource, :issue
alias_method :issuable, :issue
alias_method :awardable, :issue
2016-09-13 17:45:13 +05:30
alias_method :spammable, :issue
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
def spammable_path
project_issue_path(@project, @issue)
2016-06-02 11:05:42 +05:30
end
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
def authorize_create_merge_request!
2018-10-15 14:42:47 +05:30
render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
def render_issue_json
if @issue.valid?
render json: serializer.represent(@issue)
2016-09-13 17:45:13 +05:30
else
2018-03-17 18:26:18 +05:30
render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
2016-09-13 17:45:13 +05:30
end
end
2017-09-10 17:25:29 +05:30
def issue_params
params.require(:issue).permit(*issue_params_attributes)
2014-09-02 18:07:02 +05:30
end
2017-09-10 17:25:29 +05:30
def issue_params_attributes
%i[
title
assignee_id
position
description
confidential
milestone_id
due_date
state_event
task_num
lock_version
2018-03-17 18:26:18 +05:30
discussion_locked
2017-09-10 17:25:29 +05:30
] + [{ label_ids: [], assignee_ids: [] }]
2014-09-02 18:07:02 +05:30
end
2017-08-17 22:00:37 +05:30
def authenticate_user!
return if current_user
notice = "Please sign in to create the new issue."
2017-09-10 17:25:29 +05:30
if request.get? && !request.xhr?
store_location_for :user, request.fullpath
end
2017-08-17 22:00:37 +05:30
redirect_to new_user_session_path, notice: notice
end
2018-03-17 18:26:18 +05:30
def serializer
IssueSerializer.new(current_user: current_user, project: issue.project)
end
def update_service
update_params = issue_params.merge(spammable_params)
Issues::UpdateService.new(project, current_user, update_params)
end
2018-03-27 19:54:05 +05:30
def finder_type
IssuesFinder
2018-03-17 18:26:18 +05:30
end
def whitelist_query_limiting
# Also see the following issues:
#
# 1. https://gitlab.com/gitlab-org/gitlab-ce/issues/42423
# 2. https://gitlab.com/gitlab-org/gitlab-ce/issues/42424
# 3. https://gitlab.com/gitlab-org/gitlab-ce/issues/42426
Gitlab::QueryLimiting.whitelist('https://gitlab.com/gitlab-org/gitlab-ce/issues/42422')
end
2014-09-02 18:07:02 +05:30
end