debian-mirror-gitlab/spec/features/merge_request/user_sees_versions_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

247 lines
8.1 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2019-12-04 20:38:33 +05:30
require 'spec_helper'
2017-08-17 22:00:37 +05:30
2023-03-17 16:20:25 +05:30
RSpec.describe 'Merge request > User sees versions', :js, feature_category: :code_review_workflow do
2022-04-04 11:22:00 +05:30
include MergeRequestDiffHelpers
2019-03-13 22:55:13 +05:30
let(:merge_request) do
create(:merge_request).tap do |mr|
2020-10-24 23:57:45 +05:30
mr.merge_request_diff.destroy!
2019-03-13 22:55:13 +05:30
end
end
2020-10-24 23:57:45 +05:30
2017-08-17 22:00:37 +05:30
let(:project) { merge_request.source_project }
2018-03-17 18:26:18 +05:30
let(:user) { project.creator }
2020-10-24 23:57:45 +05:30
let!(:merge_request_diff1) { merge_request.merge_request_diffs.create!(head_commit_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9') }
let!(:merge_request_diff2) { merge_request.merge_request_diffs.create!(head_commit_sha: nil) }
let!(:merge_request_diff3) { merge_request.merge_request_diffs.create!(head_commit_sha: '5937ac0a7beb003549fc5fd26fc247adbce4a52e') }
2018-03-17 18:26:18 +05:30
let!(:params) { {} }
2017-08-17 22:00:37 +05:30
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2018-03-17 18:26:18 +05:30
sign_in(user)
visit diffs_project_merge_request_path(project, merge_request, params)
2017-08-17 22:00:37 +05:30
end
2022-08-13 15:12:31 +05:30
shared_examples 'allows commenting' do |file_name:, line_text:, comment:|
2018-03-17 18:26:18 +05:30
it do
2022-08-13 15:12:31 +05:30
page.within find_by_scrolling('.diff-file', text: file_name) do
line_code_element = page.find('.diff-grid-row', text: line_text)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
# scrolling to element's bottom is required in order for .hover action to work
# otherwise, the element could be hidden underneath a sticky header
scroll_to_elements_bottom(line_code_element)
line_code_element.hover
2022-08-13 15:12:31 +05:30
page.find("[data-testid='left-comment-button']", visible: true).click
2018-03-17 18:26:18 +05:30
2022-08-13 15:12:31 +05:30
expect(page).to have_selector("form", count: 1)
fill_in("note[note]", with: comment)
click_button('Add comment now')
2018-03-17 18:26:18 +05:30
wait_for_requests
expect(page).to have_content(comment)
end
end
end
describe 'compare with the latest version' do
it 'show the latest version of the diff' do
page.within '.mr-version-dropdown' do
expect(page).to have_content 'latest version'
end
2020-03-13 15:44:24 +05:30
expect(page).to have_content '8 files'
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
it_behaves_like 'allows commenting',
2022-08-13 15:12:31 +05:30
file_name: '.gitmodules',
line_text: '[submodule "six"]',
2018-03-17 18:26:18 +05:30
comment: 'Typo, please fix.'
2017-08-17 22:00:37 +05:30
end
describe 'switch between versions' do
before do
page.within '.mr-version-dropdown' do
find('.btn-default').click
click_link 'version 1'
end
# Wait for the page to load
page.within '.mr-version-dropdown' do
expect(page).to have_content 'version 1'
end
end
2019-02-15 15:39:39 +05:30
it 'shows the commit SHAs for every version in the dropdown' do
page.within '.mr-version-dropdown' do
2021-02-22 17:27:13 +05:30
find('.gl-dropdown-toggle').click
end
2019-02-15 15:39:39 +05:30
2021-02-22 17:27:13 +05:30
page.within '.mr-version-dropdown' do
shas = merge_request.merge_request_diffs.map { |diff| Commit.truncate_sha(diff.head_commit_sha) }
shas.each { |sha| expect(page).to have_content(sha) }
2019-02-15 15:39:39 +05:30
end
end
2018-03-17 18:26:18 +05:30
it 'shows comments that were last relevant at that version' do
2020-03-13 15:44:24 +05:30
expect(page).to have_content '5 files'
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
position = build(:text_diff_position, :added,
file: ".gitmodules",
2017-08-17 22:00:37 +05:30
new_line: 4,
diff_refs: merge_request_diff1.diff_refs
)
outdated_diff_note = create(:diff_note_on_merge_request, project: project, noteable: merge_request, position: position)
outdated_diff_note.position = outdated_diff_note.original_position
outdated_diff_note.save!
2018-03-17 18:26:18 +05:30
refresh
2022-07-23 23:45:48 +05:30
wait_for_requests
2017-08-17 22:00:37 +05:30
expect(page).to have_css(".diffs .notes[data-discussion-id='#{outdated_diff_note.discussion_id}']")
end
2018-03-17 18:26:18 +05:30
it_behaves_like 'allows commenting',
2022-08-13 15:12:31 +05:30
file_name: '.gitmodules',
line_text: 'path = six',
2018-03-17 18:26:18 +05:30
comment: 'Typo, please fix.'
2017-08-17 22:00:37 +05:30
end
describe 'compare with older version' do
before do
page.within '.mr-version-compare-dropdown' do
find('.btn-default').click
click_link 'version 1'
end
# Wait for the page to load
page.within '.mr-version-compare-dropdown' do
expect(page).to have_content 'version 1'
end
end
2018-03-17 18:26:18 +05:30
it 'has a path with comparison context and shows comments that were last relevant at that version' do
2017-09-10 17:25:29 +05:30
expect(page).to have_current_path diffs_project_merge_request_path(
2017-08-17 22:00:37 +05:30
project,
merge_request.iid,
diff_id: merge_request_diff3.id,
start_sha: '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9'
)
2020-03-13 15:44:24 +05:30
expect(page).to have_content '4 files'
2019-03-02 22:35:43 +05:30
2021-09-04 01:27:46 +05:30
additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-addition-line"]').text
deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-deletion-line"]').text
2019-03-02 22:35:43 +05:30
expect(additions_content).to eq '15'
expect(deletions_content).to eq '6'
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
position = build(:text_diff_position,
file: ".gitmodules",
2017-08-17 22:00:37 +05:30
old_line: 4,
new_line: 4,
diff_refs: merge_request_diff3.compare_with(merge_request_diff1.head_commit_sha).diff_refs
)
outdated_diff_note = create(:diff_note_on_merge_request, project: project, noteable: merge_request, position: position)
2017-09-10 17:25:29 +05:30
outdated_diff_note.position = outdated_diff_note.original_position
outdated_diff_note.save!
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
refresh
2017-09-10 17:25:29 +05:30
wait_for_requests
2017-08-17 22:00:37 +05:30
expect(page).to have_css(".diffs .notes[data-discussion-id='#{outdated_diff_note.discussion_id}']")
end
it 'show diff between new and old version' do
2021-09-04 01:27:46 +05:30
additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-addition-line"]').text
deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-deletion-line"]').text
2019-03-02 22:35:43 +05:30
2020-03-13 15:44:24 +05:30
expect(page).to have_content '4 files'
2019-03-02 22:35:43 +05:30
expect(additions_content).to eq '15'
expect(deletions_content).to eq '6'
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
it 'returns to latest version when "Show latest version" button is clicked' do
2017-08-17 22:00:37 +05:30
click_link 'Show latest version'
page.within '.mr-version-dropdown' do
expect(page).to have_content 'latest version'
end
2020-03-13 15:44:24 +05:30
expect(page).to have_content '8 files'
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
it_behaves_like 'allows commenting',
2022-08-13 15:12:31 +05:30
file_name: '.gitmodules',
line_text: '[submodule "gitlab-shell"]',
comment: 'Typo, please fix.'
2017-08-17 22:00:37 +05:30
end
describe 'compare with same version' do
before do
page.within '.mr-version-compare-dropdown' do
find('.btn-default').click
click_link 'version 1'
end
end
2018-03-17 18:26:18 +05:30
it 'has 0 chages between versions' do
2017-08-17 22:00:37 +05:30
page.within '.mr-version-compare-dropdown' do
2021-02-22 17:27:13 +05:30
expect(find('.gl-dropdown-toggle')).to have_content 'version 1'
2017-08-17 22:00:37 +05:30
end
page.within '.mr-version-dropdown' do
find('.btn-default').click
click_link 'version 1'
end
2021-03-08 18:12:59 +05:30
expect(page).to have_content 'No changes between version 1 and version 1'
2017-08-17 22:00:37 +05:30
end
end
describe 'compare with newer version' do
before do
page.within '.mr-version-compare-dropdown' do
find('.btn-default').click
click_link 'version 2'
end
end
2018-03-17 18:26:18 +05:30
it 'sets the compared versions to be the same' do
2017-08-17 22:00:37 +05:30
page.within '.mr-version-compare-dropdown' do
2021-02-22 17:27:13 +05:30
expect(find('.gl-dropdown-toggle')).to have_content 'version 2'
2017-08-17 22:00:37 +05:30
end
page.within '.mr-version-dropdown' do
find('.btn-default').click
click_link 'version 1'
end
page.within '.mr-version-compare-dropdown' do
expect(page).to have_content 'version 1'
end
2021-03-08 18:12:59 +05:30
expect(page).to have_content 'No changes between version 1 and version 1'
2017-08-17 22:00:37 +05:30
end
end
2018-03-17 18:26:18 +05:30
describe 'scoped in a commit' do
let(:params) { { commit_id: '570e7b2abdd848b95f2f578043fc23bd6f6fd24d' } }
before do
wait_for_requests
end
2019-07-07 11:18:12 +05:30
it 'only shows diffs from the commit' do
2022-08-27 11:52:29 +05:30
diff_commit_ids = find_all('.diff-file [data-commit-id]').map { |diff| diff['data-commit-id'] }
2018-03-17 18:26:18 +05:30
expect(diff_commit_ids).not_to be_empty
expect(diff_commit_ids).to all(eq(params[:commit_id]))
end
it_behaves_like 'allows commenting',
2022-08-13 15:12:31 +05:30
file_name: 'files/ruby/popen.rb',
line_text: 'RuntimeError',
2018-03-17 18:26:18 +05:30
comment: 'Typo, please fix.'
end
2017-08-17 22:00:37 +05:30
end