2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-10-24 18:46:33 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
RSpec.describe 'Commits', feature_category: :source_code_management do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
2015-10-24 18:46:33 +05:30
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
describe 'CI' do
|
2015-10-24 18:46:33 +05:30
|
|
|
before do
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(user)
|
2016-06-16 23:09:34 +05:30
|
|
|
stub_ci_pipeline_to_return_yaml_file
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
let(:creator) { create(:user, developer_projects: [project]) }
|
2016-06-16 23:09:34 +05:30
|
|
|
let!(:pipeline) do
|
2016-11-24 13:41:30 +05:30
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
2017-08-17 22:00:37 +05:30
|
|
|
user: creator,
|
2016-11-24 13:41:30 +05:30
|
|
|
ref: project.default_branch,
|
|
|
|
sha: project.commit.sha,
|
2017-08-17 22:00:37 +05:30
|
|
|
status: :success,
|
|
|
|
created_at: 5.months.ago)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
2016-02-05 20:25:01 +05:30
|
|
|
context 'commit status is Generic Commit Status' do
|
2023-04-23 21:23:45 +05:30
|
|
|
let(:stage) { create(:ci_stage, pipeline: pipeline, name: 'external') }
|
|
|
|
let!(:status) { create(:generic_commit_status, pipeline: pipeline, ref: pipeline.ref, ci_stage: stage) }
|
2015-12-23 02:04:40 +05:30
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
project.add_reporter(user)
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
describe 'Commit builds', :js do
|
2022-03-02 08:16:31 +05:30
|
|
|
before do
|
|
|
|
visit builds_project_pipeline_path(project, pipeline)
|
|
|
|
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(page).to have_content pipeline.sha[0..7] }
|
|
|
|
|
|
|
|
it 'contains generic commit status build' do
|
|
|
|
page.within('[data-testid="jobs-tab-table"]') do
|
|
|
|
expect(page).to have_content "##{status.id}" # build id
|
|
|
|
expect(page).to have_content 'generic' # build name
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|
|
|
|
|
2016-02-05 20:25:01 +05:30
|
|
|
context 'commit status is Ci Build' do
|
2016-11-24 13:41:30 +05:30
|
|
|
let!(:build) { create(:ci_build, pipeline: pipeline) }
|
2018-11-08 19:23:39 +05:30
|
|
|
let(:artifacts_file) { fixture_file_upload('spec/fixtures/banana_sample.gif', 'image/gif') }
|
2015-10-24 18:46:33 +05:30
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
context 'when logged as developer' do
|
2016-02-05 20:25:01 +05:30
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
project.add_developer(user)
|
2016-02-05 20:25:01 +05:30
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
describe 'Project commits' do
|
2016-11-24 13:41:30 +05:30
|
|
|
let!(:pipeline_from_other_branch) do
|
|
|
|
create(:ci_pipeline,
|
|
|
|
project: project,
|
|
|
|
ref: 'fix',
|
|
|
|
sha: project.commit.sha,
|
|
|
|
status: :failed)
|
|
|
|
end
|
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
before do
|
2017-09-10 17:25:29 +05:30
|
|
|
visit project_commits_path(project, :master)
|
2016-02-05 20:25:01 +05:30
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2016-11-24 13:41:30 +05:30
|
|
|
it 'shows correct build status from default branch' do
|
2016-06-16 23:09:34 +05:30
|
|
|
page.within("//li[@id='commit-#{pipeline.short_sha}']") do
|
2016-11-24 13:41:30 +05:30
|
|
|
expect(page).to have_css('.ci-status-link')
|
|
|
|
expect(page).to have_css('.ci-status-icon-success')
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
end
|
2016-02-05 20:25:01 +05:30
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe 'Commit builds', :js do
|
2016-04-02 18:10:28 +05:30
|
|
|
before do
|
2019-09-04 21:01:54 +05:30
|
|
|
project.add_developer(user)
|
2018-03-17 18:26:18 +05:30
|
|
|
visit pipeline_path(pipeline)
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
it 'shows pipeline data' do
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).to have_content pipeline.user.name
|
|
|
|
end
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
context 'Download artifacts', :js do
|
2022-03-02 08:16:31 +05:30
|
|
|
before do
|
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
|
|
|
visit builds_project_pipeline_path(project, pipeline)
|
|
|
|
wait_for_requests
|
|
|
|
expect(page).to have_link('Download artifacts', href: download_project_job_artifacts_path(project, build, file_type: :archive))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
describe 'Cancel all builds' do
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'cancels commit', :js, :sidekiq_might_not_need_inline do
|
2018-03-17 18:26:18 +05:30
|
|
|
visit pipeline_path(pipeline)
|
2016-04-02 18:10:28 +05:30
|
|
|
click_on 'Cancel running'
|
|
|
|
expect(page).to have_content 'canceled'
|
2016-02-05 20:25:01 +05:30
|
|
|
end
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
2016-02-05 20:25:01 +05:30
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
describe 'Cancel build' do
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'cancels build', :js, :sidekiq_might_not_need_inline do
|
2018-03-17 18:26:18 +05:30
|
|
|
visit pipeline_path(pipeline)
|
2020-10-24 23:57:45 +05:30
|
|
|
find('[data-testid="cancelPipeline"]').click
|
2016-04-02 18:10:28 +05:30
|
|
|
expect(page).to have_content 'canceled'
|
2016-02-05 20:25:01 +05:30
|
|
|
end
|
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|
2016-04-02 18:10:28 +05:30
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
context "when logged as reporter", :js do
|
2022-03-02 08:16:31 +05:30
|
|
|
before do
|
|
|
|
project.add_reporter(user)
|
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
|
|
|
visit builds_project_pipeline_path(project, pipeline)
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders header' do
|
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
|
|
|
expect(page).to have_content pipeline.user.name
|
|
|
|
expect(page).not_to have_link('Cancel running')
|
|
|
|
expect(page).not_to have_link('Retry')
|
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
|
|
|
expect(page).to have_link('Download artifacts')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-03-11 19:13:27 +05:30
|
|
|
context 'when accessing internal project with disallowed access', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/299575' do
|
2016-04-02 18:10:28 +05:30
|
|
|
before do
|
2021-04-29 21:17:54 +05:30
|
|
|
project.update!(
|
2016-04-02 18:10:28 +05:30
|
|
|
visibility_level: Gitlab::VisibilityLevel::INTERNAL,
|
|
|
|
public_builds: false)
|
2019-09-04 21:01:54 +05:30
|
|
|
create(:ci_job_artifact, :archive, file: artifacts_file, job: build)
|
2018-03-17 18:26:18 +05:30
|
|
|
visit pipeline_path(pipeline)
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(page).to have_content pipeline.sha[0..7]
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(page).to have_content pipeline.git_commit_message.gsub!(/\s+/, ' ')
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).to have_content pipeline.user.name
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(page).not_to have_link('Cancel running')
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).not_to have_link('Retry')
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
context 'viewing commits for a branch' do
|
|
|
|
let(:branch_name) { 'master' }
|
2023-06-20 00:43:36 +05:30
|
|
|
let(:ref_selector) { '.ref-selector' }
|
|
|
|
let(:ref_with_hash) { 'ref-#-hash' }
|
|
|
|
|
|
|
|
def switch_ref_to(ref_name)
|
|
|
|
first(ref_selector).click
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
page.within ref_selector do
|
|
|
|
fill_in 'Search by Git revision', with: ref_name
|
|
|
|
wait_for_requests
|
|
|
|
find('li', text: ref_name, match: :prefer_exact).click
|
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
before do
|
2018-11-18 11:00:15 +05:30
|
|
|
project.add_maintainer(user)
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(user)
|
2023-06-20 00:43:36 +05:30
|
|
|
project.repository.create_branch(ref_with_hash, branch_name)
|
2017-09-10 17:25:29 +05:30
|
|
|
visit project_commits_path(project, branch_name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the committed_date for each commit' do
|
2018-03-17 18:26:18 +05:30
|
|
|
commits = project.repository.commits(branch_name, limit: 40)
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
commits.each do |commit|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(page).to have_content("authored #{commit.authored_date.strftime("%b %d, %Y")}")
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-06-20 00:43:36 +05:30
|
|
|
it 'switches ref to ref containing a hash', :js do
|
|
|
|
switch_ref_to(ref_with_hash)
|
|
|
|
|
|
|
|
expect(page).to have_selector ref_selector, text: ref_with_hash
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'shows the ref switcher with the multi-file editor enabled', :js do
|
|
|
|
set_cookie('new_repo', 'true')
|
|
|
|
visit project_commits_path(project, branch_name)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2023-06-20 00:43:36 +05:30
|
|
|
expect(find(ref_selector)).to have_content branch_name
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
context 'viewing commits for an author' do
|
|
|
|
let(:author_commit) { project.repository.commits(nil, limit: 1).first }
|
|
|
|
let(:commits) { project.repository.commits(nil, author: author, limit: 40) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_maintainer(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit project_commits_path(project, nil, author: author)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'show commits by author' do
|
|
|
|
it "includes the author's commits" do
|
|
|
|
commits.each do |commit|
|
|
|
|
expect(page).to have_content("#{author_commit.author_name} authored #{commit.authored_date.strftime("%b %d, %Y")}")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is complete' do
|
|
|
|
let(:author) { "#{author_commit.author_name} <#{author_commit.author_email}>" }
|
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is just a name' do
|
2023-01-13 00:05:48 +05:30
|
|
|
let(:author) { author_commit.author_name.to_s }
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'author is just an email' do
|
2023-01-13 00:05:48 +05:30
|
|
|
let(:author) { author_commit.author_email.to_s }
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
it_behaves_like 'show commits by author'
|
|
|
|
end
|
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|