debian-mirror-gitlab/tooling/danger/commit_linter.rb

151 lines
4 KiB
Ruby
Raw Normal View History

2020-03-13 15:44:24 +05:30
# frozen_string_literal: true
2021-03-11 19:13:27 +05:30
require_relative 'base_linter'
require_relative 'emoji_checker'
2020-03-13 15:44:24 +05:30
2021-03-11 19:13:27 +05:30
module Tooling
2020-03-13 15:44:24 +05:30
module Danger
2021-02-22 17:27:13 +05:30
class CommitLinter < BaseLinter
2020-03-13 15:44:24 +05:30
MAX_CHANGED_FILES_IN_COMMIT = 3
MAX_CHANGED_LINES_IN_COMMIT = 30
2021-01-03 14:25:43 +05:30
SHORT_REFERENCE_REGEX = %r{([\w\-\/]+)?(?<!`)(#|!|&|%)\d+(?<!`)}.freeze
2021-02-22 17:27:13 +05:30
def self.problems_mapping
super.merge(
{
separator_missing: "The commit subject and body must be separated by a blank line",
details_too_many_changes: "Commits that change #{MAX_CHANGED_LINES_IN_COMMIT} or more lines across " \
2020-03-13 15:44:24 +05:30
"at least #{MAX_CHANGED_FILES_IN_COMMIT} files must describe these changes in the commit body",
2021-02-22 17:27:13 +05:30
details_line_too_long: "The commit body should not contain more than #{MAX_LINE_LENGTH} characters per line",
message_contains_text_emoji: "Avoid the use of Markdown Emoji such as `:+1:`. These add limited value " \
2020-03-13 15:44:24 +05:30
"to the commit message, and are displayed as plain text outside of GitLab",
2021-02-22 17:27:13 +05:30
message_contains_unicode_emoji: "Avoid the use of Unicode Emoji. These add no value to the commit " \
2020-03-13 15:44:24 +05:30
"message, and may not be displayed properly everywhere",
2021-02-22 17:27:13 +05:30
message_contains_short_reference: "Use full URLs instead of short references (`gitlab-org/gitlab#123` or " \
2020-03-13 15:44:24 +05:30
"`!123`), as short references are displayed as plain text outside of GitLab"
2021-02-22 17:27:13 +05:30
}
)
end
2020-03-13 15:44:24 +05:30
def initialize(commit)
2021-02-22 17:27:13 +05:30
super
2020-03-13 15:44:24 +05:30
@linted = false
end
def fixup?
commit.message.start_with?('fixup!', 'squash!')
end
def suggestion?
commit.message.start_with?('Apply suggestion to')
end
def merge?
commit.message.start_with?('Merge branch')
end
def revert?
commit.message.start_with?('Revert "')
end
def multi_line?
!details.nil? && !details.empty?
end
2021-02-22 17:27:13 +05:30
def lint
2020-03-13 15:44:24 +05:30
return self if @linted
@linted = true
2021-02-22 17:27:13 +05:30
lint_subject
2020-03-13 15:44:24 +05:30
lint_separator
lint_details
lint_message
self
end
private
def lint_separator
return self unless separator && !separator.empty?
add_problem(:separator_missing)
self
end
def lint_details
if !multi_line? && many_changes?
add_problem(:details_too_many_changes)
end
details&.each_line do |line|
2021-02-22 17:27:13 +05:30
line_without_urls = line.strip.gsub(%r{https?://\S+}, '')
2020-03-13 15:44:24 +05:30
# If the line includes a URL, we'll allow it to exceed MAX_LINE_LENGTH characters, but
# only if the line _without_ the URL does not exceed this limit.
2021-02-22 17:27:13 +05:30
next unless line_too_long?(line_without_urls)
2020-03-13 15:44:24 +05:30
add_problem(:details_line_too_long)
break
end
self
end
def lint_message
if message_contains_text_emoji?
add_problem(:message_contains_text_emoji)
end
if message_contains_unicode_emoji?
add_problem(:message_contains_unicode_emoji)
end
if message_contains_short_reference?
add_problem(:message_contains_short_reference)
end
self
end
def files_changed
commit.diff_parent.stats[:total][:files]
end
def lines_changed
commit.diff_parent.stats[:total][:lines]
end
def many_changes?
files_changed > MAX_CHANGED_FILES_IN_COMMIT && lines_changed > MAX_CHANGED_LINES_IN_COMMIT
end
def separator
message_parts[1]
end
def details
2020-04-22 19:07:51 +05:30
message_parts[2]&.gsub(/^Signed-off-by.*$/, '')
2020-03-13 15:44:24 +05:30
end
def message_contains_text_emoji?
emoji_checker.includes_text_emoji?(commit.message)
end
def message_contains_unicode_emoji?
emoji_checker.includes_unicode_emoji?(commit.message)
end
def message_contains_short_reference?
commit.message.match?(SHORT_REFERENCE_REGEX)
end
def emoji_checker
2021-03-11 19:13:27 +05:30
@emoji_checker ||= Tooling::Danger::EmojiChecker.new
2020-03-13 15:44:24 +05:30
end
end
end
end