debian-mirror-gitlab/spec/finders/members_finder_spec.rb

203 lines
7.6 KiB
Ruby
Raw Normal View History

2019-12-21 20:55:43 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe MembersFinder, '#execute' do
2020-03-13 15:44:24 +05:30
let_it_be(:group) { create(:group) }
let_it_be(:nested_group) { create(:group, parent: group) }
let_it_be(:project, reload: true) { create(:project, namespace: nested_group) }
let_it_be(:user1) { create(:user) }
let_it_be(:user2) { create(:user) }
let_it_be(:user3) { create(:user) }
let_it_be(:user4) { create(:user) }
2020-10-24 23:57:45 +05:30
let_it_be(:blocked_user) { create(:user, :blocked) }
2017-08-17 22:00:37 +05:30
2019-10-12 21:52:04 +05:30
it 'returns members for project and parent groups' do
2017-08-17 22:00:37 +05:30
nested_group.request_access(user1)
2018-11-18 11:00:15 +05:30
member1 = group.add_maintainer(user2)
member2 = nested_group.add_maintainer(user3)
member3 = project.add_maintainer(user4)
2020-10-24 23:57:45 +05:30
blocked_member = project.add_maintainer(blocked_user)
2017-08-17 22:00:37 +05:30
result = described_class.new(project, user2).execute
2020-10-24 23:57:45 +05:30
expect(result).to contain_exactly(member1, member2, member3, blocked_member)
end
it 'returns owners and maintainers' do
member1 = group.add_owner(user1)
group.add_developer(user2)
member3 = project.add_maintainer(user3)
project.add_developer(user4)
result = described_class.new(project, user2, params: { owners_and_maintainers: true }).execute
expect(result).to contain_exactly(member1, member3)
end
it 'returns active users and excludes invited users' do
member1 = project.add_maintainer(user2)
create(:project_member, :invited, project: project, invite_email: create(:user).email)
project.add_maintainer(blocked_user)
result = described_class.new(project, user2, params: { active_without_invites_and_requests: true }).execute
expect(result).to contain_exactly(member1)
2017-08-17 22:00:37 +05:30
end
2018-11-08 19:23:39 +05:30
2020-11-24 15:15:51 +05:30
it 'does not return members of parent group with minimal access' do
nested_group.request_access(user1)
member1 = group.add_maintainer(user2)
member2 = nested_group.add_maintainer(user3)
member3 = project.add_maintainer(user4)
create(:group_member, :minimal_access, user: create(:user), source: group)
result = described_class.new(project, user2).execute
expect(result).to contain_exactly(member1, member2, member3)
end
2020-01-01 13:55:28 +05:30
it 'includes only non-invite members if user do not have amdin permissions on project' do
create(:project_member, :invited, project: project, invite_email: create(:user).email)
member1 = project.add_maintainer(user1)
member2 = project.add_developer(user2)
result = described_class.new(project, user2).execute(include_relations: [:direct])
expect(result).to contain_exactly(member1, member2)
end
it 'includes invited members if user have admin permissions on project' do
member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email)
member1 = project.add_maintainer(user1)
member2 = project.add_maintainer(user2)
result = described_class.new(project, user2).execute(include_relations: [:direct])
expect(result).to contain_exactly(member1, member2, member_invite)
end
2019-12-04 20:38:33 +05:30
it 'includes nested group members if asked', :nested_groups do
2018-11-08 19:23:39 +05:30
nested_group.request_access(user1)
2018-11-18 11:00:15 +05:30
member1 = group.add_maintainer(user2)
member2 = nested_group.add_maintainer(user3)
member3 = project.add_maintainer(user4)
2018-11-08 19:23:39 +05:30
2020-01-01 13:55:28 +05:30
result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants])
2018-11-08 19:23:39 +05:30
2019-12-04 20:38:33 +05:30
expect(result).to contain_exactly(member1, member2, member3)
end
2020-01-01 13:55:28 +05:30
it 'returns only members of project if asked' do
nested_group.request_access(user1)
group.add_maintainer(user2)
nested_group.add_maintainer(user3)
member4 = project.add_maintainer(user4)
result = described_class.new(project, user2).execute(include_relations: [:direct])
expect(result).to contain_exactly(member4)
end
it 'returns only inherited members of project if asked' do
nested_group.request_access(user1)
member2 = group.add_maintainer(user2)
member3 = nested_group.add_maintainer(user3)
project.add_maintainer(user4)
result = described_class.new(project, user2).execute(include_relations: [:inherited])
expect(result).to contain_exactly(member2, member3)
end
2020-03-13 15:44:24 +05:30
it 'returns only inherited members of a personal project' do
project = create(:project, namespace: user1.namespace)
member = project.members.first
result = described_class.new(project, user1).execute(include_relations: [:inherited])
expect(result).to contain_exactly(member)
end
2019-12-04 20:38:33 +05:30
it 'returns the members.access_level when the user is invited', :nested_groups do
member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email)
member1 = group.add_maintainer(user2)
2020-01-01 13:55:28 +05:30
result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants])
2019-12-04 20:38:33 +05:30
expect(result).to contain_exactly(member1, member_invite)
expect(result.last.access_level).to eq(member_invite.access_level)
end
it 'returns the highest access_level for the user', :nested_groups do
member1 = project.add_guest(user1)
group.add_developer(user1)
nested_group.add_reporter(user1)
2020-01-01 13:55:28 +05:30
result = described_class.new(project, user1).execute(include_relations: [:direct, :descendants])
2019-12-04 20:38:33 +05:30
expect(result).to contain_exactly(member1)
expect(result.first.access_level).to eq(Gitlab::Access::DEVELOPER)
2018-11-08 19:23:39 +05:30
end
2019-09-04 21:01:54 +05:30
2020-03-13 15:44:24 +05:30
it 'returns searched members if requested' do
project.add_maintainer(user2)
project.add_maintainer(user3)
member3 = project.add_maintainer(user4)
2020-05-24 23:13:21 +05:30
result = described_class.new(project, user2, params: { search: user4.name }).execute
2020-03-13 15:44:24 +05:30
expect(result).to contain_exactly(member3)
end
it 'returns members sorted by id_desc' do
member1 = project.add_maintainer(user2)
member2 = project.add_maintainer(user3)
member3 = project.add_maintainer(user4)
2020-05-24 23:13:21 +05:30
result = described_class.new(project, user2, params: { sort: 'id_desc' }).execute
2020-03-13 15:44:24 +05:30
expect(result).to eq([member3, member2, member1])
end
2021-02-22 17:27:13 +05:30
context 'when :invited_groups is passed' do
subject { described_class.new(project, user2).execute(include_relations: [:inherited, :direct, :invited_groups]) }
2019-09-04 21:01:54 +05:30
2020-03-13 15:44:24 +05:30
let_it_be(:linked_group) { create(:group, :public) }
let_it_be(:nested_linked_group) { create(:group, parent: linked_group) }
let_it_be(:linked_group_member) { linked_group.add_guest(user1) }
let_it_be(:nested_linked_group_member) { nested_linked_group.add_guest(user2) }
2019-09-04 21:01:54 +05:30
2019-10-12 21:52:04 +05:30
it 'includes all the invited_groups members including members inherited from ancestor groups' do
2019-09-04 21:01:54 +05:30
create(:project_group_link, project: project, group: nested_linked_group)
expect(subject).to contain_exactly(linked_group_member, nested_linked_group_member)
end
it 'includes all the invited_groups members' do
create(:project_group_link, project: project, group: linked_group)
expect(subject).to contain_exactly(linked_group_member)
end
it 'excludes group_members not visible to the user' do
create(:project_group_link, project: project, group: linked_group)
private_linked_group = create(:group, :private)
private_linked_group.add_developer(user3)
create(:project_group_link, project: project, group: private_linked_group)
expect(subject).to contain_exactly(linked_group_member)
end
2019-12-04 20:38:33 +05:30
context 'when the user is a member of invited group and ancestor groups' do
it 'returns the highest access_level for the user limited by project_group_link.group_access', :nested_groups do
create(:project_group_link, project: project, group: nested_linked_group, group_access: Gitlab::Access::REPORTER)
nested_linked_group.add_developer(user1)
2019-12-21 20:55:43 +05:30
expect(subject.map(&:user)).to contain_exactly(user1, user2)
expect(subject.max_by(&:access_level).access_level).to eq(Gitlab::Access::REPORTER)
2019-12-04 20:38:33 +05:30
end
end
2019-09-04 21:01:54 +05:30
end
2017-08-17 22:00:37 +05:30
end