2016-06-02 11:05:42 +05:30
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
|
describe Groups::CreateService, '#execute' do
|
2017-08-17 22:00:37 +05:30
|
|
|
|
let!(:user) { create(:user) }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
let!(:group_params) { { path: "group_path", visibility_level: Gitlab::VisibilityLevel::PUBLIC } }
|
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
|
subject { service.execute }
|
|
|
|
|
|
|
|
|
|
describe 'visibility level restrictions' do
|
|
|
|
|
let!(:service) { described_class.new(user, group_params) }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
|
|
context "create groups without restricted visibility level" do
|
|
|
|
|
it { is_expected.to be_persisted }
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "cannot create group with restricted visibility level" do
|
2017-09-10 17:25:29 +05:30
|
|
|
|
before do
|
|
|
|
|
allow_any_instance_of(ApplicationSetting).to receive(:restricted_visibility_levels).and_return([Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
|
it { is_expected.not_to be_persisted }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
end
|
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
|
describe 'creating a top level group' do
|
|
|
|
|
let(:service) { described_class.new(user, group_params) }
|
|
|
|
|
|
|
|
|
|
context 'when user can create a group' do
|
|
|
|
|
before do
|
|
|
|
|
user.update_attribute(:can_create_group, true)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it { is_expected.to be_persisted }
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when user can not create a group' do
|
|
|
|
|
before do
|
|
|
|
|
user.update_attribute(:can_create_group, false)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it { is_expected.not_to be_persisted }
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe 'creating subgroup', :nested_groups do
|
2017-08-17 22:00:37 +05:30
|
|
|
|
let!(:group) { create(:group) }
|
|
|
|
|
let!(:service) { described_class.new(user, group_params.merge(parent_id: group.id)) }
|
|
|
|
|
|
|
|
|
|
context 'as group owner' do
|
2017-09-10 17:25:29 +05:30
|
|
|
|
before do
|
|
|
|
|
group.add_owner(user)
|
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
|
|
it { is_expected.to be_persisted }
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
|
|
context 'when nested groups feature is disabled' do
|
|
|
|
|
it 'does not save group and returns an error' do
|
2019-02-15 15:39:39 +05:30
|
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(false)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
|
|
is_expected.not_to be_persisted
|
|
|
|
|
expect(subject.errors[:parent_id]).to include('You don’t have permission to create a subgroup in this group.')
|
|
|
|
|
expect(subject.parent_id).to be_nil
|
|
|
|
|
end
|
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
end
|
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
|
context 'when nested groups feature is enabled' do
|
|
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(true)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'as guest' do
|
|
|
|
|
it 'does not save group and returns an error' do
|
|
|
|
|
is_expected.not_to be_persisted
|
|
|
|
|
|
|
|
|
|
expect(subject.errors[:parent_id].first).to eq('You don’t have permission to create a subgroup in this group.')
|
|
|
|
|
expect(subject.parent_id).to be_nil
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'as owner' do
|
|
|
|
|
before do
|
|
|
|
|
group.add_owner(user)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it { is_expected.to be_persisted }
|
2017-08-17 22:00:37 +05:30
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe 'creating a mattermost team' do
|
|
|
|
|
let!(:params) { group_params.merge(create_chat_team: "true") }
|
|
|
|
|
let!(:service) { described_class.new(user, params) }
|
|
|
|
|
|
|
|
|
|
before do
|
|
|
|
|
stub_mattermost_setting(enabled: true)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'create the chat team with the group' do
|
|
|
|
|
allow_any_instance_of(Mattermost::Team).to receive(:create)
|
|
|
|
|
.and_return({ 'name' => 'tanuki', 'id' => 'lskdjfwlekfjsdifjj' })
|
|
|
|
|
|
|
|
|
|
expect { subject }.to change { ChatTeam.count }.from(0).to(1)
|
|
|
|
|
end
|
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
end
|