debian-mirror-gitlab/spec/services/ci/register_job_service_spec.rb

380 lines
13 KiB
Ruby
Raw Normal View History

2015-09-25 12:07:36 +05:30
require 'spec_helper'
module Ci
2017-09-10 17:25:29 +05:30
describe RegisterJobService do
2018-03-17 18:26:18 +05:30
let!(:project) { FactoryBot.create :project, shared_runners_enabled: false }
let!(:pipeline) { FactoryBot.create :ci_pipeline, project: project }
let!(:pending_job) { FactoryBot.create :ci_build, pipeline: pipeline }
let!(:shared_runner) { FactoryBot.create(:ci_runner, is_shared: true) }
let!(:specific_runner) { FactoryBot.create(:ci_runner, is_shared: false) }
2015-09-25 12:07:36 +05:30
before do
2015-12-23 02:04:40 +05:30
specific_runner.assign_to(project)
2015-09-25 12:07:36 +05:30
end
2016-08-24 12:49:21 +05:30
describe '#execute' do
2015-09-25 12:07:36 +05:30
context 'runner follow tag list' do
it "picks build with the same tag" do
2018-03-17 18:26:18 +05:30
pending_job.update(tag_list: ["linux"])
specific_runner.update(tag_list: ["linux"])
expect(execute(specific_runner)).to eq(pending_job)
2015-09-25 12:07:36 +05:30
end
it "does not pick build with different tag" do
2018-03-17 18:26:18 +05:30
pending_job.update(tag_list: ["linux"])
specific_runner.update(tag_list: ["win32"])
2017-08-17 22:00:37 +05:30
expect(execute(specific_runner)).to be_falsey
2015-09-25 12:07:36 +05:30
end
it "picks build without tag" do
2018-03-17 18:26:18 +05:30
expect(execute(specific_runner)).to eq(pending_job)
2015-09-25 12:07:36 +05:30
end
it "does not pick build with tag" do
2018-03-17 18:26:18 +05:30
pending_job.update(tag_list: ["linux"])
2017-08-17 22:00:37 +05:30
expect(execute(specific_runner)).to be_falsey
2015-09-25 12:07:36 +05:30
end
it "pick build without tag" do
2018-03-17 18:26:18 +05:30
specific_runner.update(tag_list: ["win32"])
expect(execute(specific_runner)).to eq(pending_job)
2015-09-25 12:07:36 +05:30
end
end
2016-06-22 15:30:34 +05:30
context 'deleted projects' do
before do
project.update(pending_delete: true)
end
context 'for shared runners' do
before do
project.update(shared_runners_enabled: true)
end
it 'does not pick a build' do
2017-08-17 22:00:37 +05:30
expect(execute(shared_runner)).to be_nil
2016-06-22 15:30:34 +05:30
end
end
context 'for specific runner' do
it 'does not pick a build' do
2017-08-17 22:00:37 +05:30
expect(execute(specific_runner)).to be_nil
2016-06-22 15:30:34 +05:30
end
end
end
2015-09-25 12:07:36 +05:30
context 'allow shared runners' do
before do
2015-12-23 02:04:40 +05:30
project.update(shared_runners_enabled: true)
2015-09-25 12:07:36 +05:30
end
2016-06-22 15:30:34 +05:30
context 'for multiple builds' do
2017-09-10 17:25:29 +05:30
let!(:project2) { create :project, shared_runners_enabled: true }
2016-06-22 15:30:34 +05:30
let!(:pipeline2) { create :ci_pipeline, project: project2 }
2017-09-10 17:25:29 +05:30
let!(:project3) { create :project, shared_runners_enabled: true }
2016-06-22 15:30:34 +05:30
let!(:pipeline3) { create :ci_pipeline, project: project3 }
2018-03-17 18:26:18 +05:30
let!(:build1_project1) { pending_job }
let!(:build2_project1) { FactoryBot.create :ci_build, pipeline: pipeline }
let!(:build3_project1) { FactoryBot.create :ci_build, pipeline: pipeline }
let!(:build1_project2) { FactoryBot.create :ci_build, pipeline: pipeline2 }
let!(:build2_project2) { FactoryBot.create :ci_build, pipeline: pipeline2 }
let!(:build1_project3) { FactoryBot.create :ci_build, pipeline: pipeline3 }
2016-06-22 15:30:34 +05:30
it 'prefers projects without builds first' do
# it gets for one build from each of the projects
2017-08-17 22:00:37 +05:30
expect(execute(shared_runner)).to eq(build1_project1)
expect(execute(shared_runner)).to eq(build1_project2)
expect(execute(shared_runner)).to eq(build1_project3)
2016-06-22 15:30:34 +05:30
# then it gets a second build from each of the projects
2017-08-17 22:00:37 +05:30
expect(execute(shared_runner)).to eq(build2_project1)
expect(execute(shared_runner)).to eq(build2_project2)
2016-06-22 15:30:34 +05:30
# in the end the third build
2017-08-17 22:00:37 +05:30
expect(execute(shared_runner)).to eq(build3_project1)
2016-06-22 15:30:34 +05:30
end
it 'equalises number of running builds' do
# after finishing the first build for project 1, get a second build from the same project
2017-08-17 22:00:37 +05:30
expect(execute(shared_runner)).to eq(build1_project1)
build1_project1.reload.success
expect(execute(shared_runner)).to eq(build2_project1)
expect(execute(shared_runner)).to eq(build1_project2)
build1_project2.reload.success
expect(execute(shared_runner)).to eq(build2_project2)
expect(execute(shared_runner)).to eq(build1_project3)
expect(execute(shared_runner)).to eq(build3_project1)
2016-06-22 15:30:34 +05:30
end
end
2015-09-25 12:07:36 +05:30
context 'shared runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(shared_runner) }
2015-09-25 12:07:36 +05:30
it { expect(build).to be_kind_of(Build) }
it { expect(build).to be_valid }
it { expect(build).to be_running }
it { expect(build.runner).to eq(shared_runner) }
end
context 'specific runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(specific_runner) }
2015-09-25 12:07:36 +05:30
it { expect(build).to be_kind_of(Build) }
it { expect(build).to be_valid }
it { expect(build).to be_running }
it { expect(build.runner).to eq(specific_runner) }
end
end
context 'disallow shared runners' do
2015-11-26 14:37:03 +05:30
before do
2015-12-23 02:04:40 +05:30
project.update(shared_runners_enabled: false)
2015-11-26 14:37:03 +05:30
end
2015-09-25 12:07:36 +05:30
context 'shared runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(shared_runner) }
2015-09-25 12:07:36 +05:30
it { expect(build).to be_nil }
end
context 'specific runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(specific_runner) }
2015-09-25 12:07:36 +05:30
it { expect(build).to be_kind_of(Build) }
it { expect(build).to be_valid }
it { expect(build).to be_running }
it { expect(build.runner).to eq(specific_runner) }
end
end
2016-09-29 09:46:39 +05:30
context 'disallow when builds are disabled' do
before do
project.update(shared_runners_enabled: true)
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
end
context 'and uses shared runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(shared_runner) }
2016-09-29 09:46:39 +05:30
it { expect(build).to be_nil }
end
context 'and uses specific runner' do
2017-08-17 22:00:37 +05:30
let(:build) { execute(specific_runner) }
2016-09-29 09:46:39 +05:30
it { expect(build).to be_nil }
end
end
2017-08-17 22:00:37 +05:30
context 'when first build is stalled' do
before do
2018-03-17 18:26:18 +05:30
pending_job.update(lock_version: 0)
2017-08-17 22:00:37 +05:30
end
subject { described_class.new(specific_runner).execute }
context 'with multiple builds are in queue' do
let!(:other_build) { create :ci_build, pipeline: pipeline }
before do
allow_any_instance_of(Ci::RegisterJobService).to receive(:builds_for_specific_runner)
2018-03-17 18:26:18 +05:30
.and_return(Ci::Build.where(id: [pending_job, other_build]))
2017-08-17 22:00:37 +05:30
end
it "receives second build from the queue" do
expect(subject).to be_valid
expect(subject.build).to eq(other_build)
end
end
context 'when single build is in queue' do
before do
allow_any_instance_of(Ci::RegisterJobService).to receive(:builds_for_specific_runner)
2018-03-17 18:26:18 +05:30
.and_return(Ci::Build.where(id: pending_job))
2017-08-17 22:00:37 +05:30
end
it "does not receive any valid result" do
expect(subject).not_to be_valid
end
end
context 'when there is no build in queue' do
before do
allow_any_instance_of(Ci::RegisterJobService).to receive(:builds_for_specific_runner)
2018-03-17 18:26:18 +05:30
.and_return(Ci::Build.none)
2017-08-17 22:00:37 +05:30
end
it "does not receive builds but result is valid" do
expect(subject).to be_valid
expect(subject.build).to be_nil
end
end
end
2018-03-17 18:26:18 +05:30
context 'when access_level of runner is not_protected' do
let!(:specific_runner) { create(:ci_runner, :specific) }
context 'when a job is protected' do
let!(:pending_job) { create(:ci_build, :protected, pipeline: pipeline) }
it 'picks the job' do
expect(execute(specific_runner)).to eq(pending_job)
end
end
context 'when a job is unprotected' do
let!(:pending_job) { create(:ci_build, pipeline: pipeline) }
it 'picks the job' do
expect(execute(specific_runner)).to eq(pending_job)
end
end
context 'when protected attribute of a job is nil' do
let!(:pending_job) { create(:ci_build, pipeline: pipeline) }
before do
pending_job.update_attribute(:protected, nil)
end
it 'picks the job' do
expect(execute(specific_runner)).to eq(pending_job)
end
end
end
context 'when access_level of runner is ref_protected' do
let!(:specific_runner) { create(:ci_runner, :ref_protected, :specific) }
context 'when a job is protected' do
let!(:pending_job) { create(:ci_build, :protected, pipeline: pipeline) }
it 'picks the job' do
expect(execute(specific_runner)).to eq(pending_job)
end
end
context 'when a job is unprotected' do
let!(:pending_job) { create(:ci_build, pipeline: pipeline) }
it 'does not pick the job' do
expect(execute(specific_runner)).to be_nil
end
end
context 'when protected attribute of a job is nil' do
let!(:pending_job) { create(:ci_build, pipeline: pipeline) }
before do
pending_job.update_attribute(:protected, nil)
end
it 'does not pick the job' do
expect(execute(specific_runner)).to be_nil
end
end
end
context 'when "dependencies" keyword is specified' do
shared_examples 'not pick' do
it 'does not pick the build and drops the build' do
expect(subject).to be_nil
expect(pending_job.reload).to be_failed
expect(pending_job).to be_missing_dependency_failure
end
end
shared_examples 'validation is active' do
context 'when depended job has not been completed yet' do
let!(:pre_stage_job) { create(:ci_build, :manual, pipeline: pipeline, name: 'test', stage_idx: 0) }
it { expect(subject).to eq(pending_job) }
end
context 'when artifacts of depended job has been expired' do
let!(:pre_stage_job) { create(:ci_build, :success, :expired, pipeline: pipeline, name: 'test', stage_idx: 0) }
it_behaves_like 'not pick'
end
context 'when artifacts of depended job has been erased' do
let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0, erased_at: 1.minute.ago) }
before do
pre_stage_job.erase
end
it_behaves_like 'not pick'
end
context 'when job object is staled' do
let!(:pre_stage_job) { create(:ci_build, :success, :expired, pipeline: pipeline, name: 'test', stage_idx: 0) }
before do
allow_any_instance_of(Ci::Build).to receive(:drop!)
.and_raise(ActiveRecord::StaleObjectError.new(pending_job, :drop!))
end
it 'does not drop nor pick' do
expect(subject).to be_nil
end
end
end
shared_examples 'validation is not active' do
context 'when depended job has not been completed yet' do
let!(:pre_stage_job) { create(:ci_build, :manual, pipeline: pipeline, name: 'test', stage_idx: 0) }
it { expect(subject).to eq(pending_job) }
end
context 'when artifacts of depended job has been expired' do
let!(:pre_stage_job) { create(:ci_build, :success, :expired, pipeline: pipeline, name: 'test', stage_idx: 0) }
it { expect(subject).to eq(pending_job) }
end
context 'when artifacts of depended job has been erased' do
let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0, erased_at: 1.minute.ago) }
before do
pre_stage_job.erase
end
it { expect(subject).to eq(pending_job) }
end
end
before do
stub_feature_flags(ci_disable_validates_dependencies: false)
end
let!(:pre_stage_job) { create(:ci_build, :success, pipeline: pipeline, name: 'test', stage_idx: 0) }
let!(:pending_job) { create(:ci_build, :pending, pipeline: pipeline, stage_idx: 1, options: { dependencies: ['test'] } ) }
subject { execute(specific_runner) }
context 'when validates for dependencies is enabled' do
before do
stub_feature_flags(ci_disable_validates_dependencies: false)
end
it_behaves_like 'validation is active'
end
context 'when validates for dependencies is disabled' do
before do
stub_feature_flags(ci_disable_validates_dependencies: true)
end
it_behaves_like 'validation is not active'
end
end
2017-08-17 22:00:37 +05:30
def execute(runner)
described_class.new(runner).execute.build
end
2015-09-25 12:07:36 +05:30
end
end
end