debian-mirror-gitlab/spec/workers/process_commit_worker_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

177 lines
5.6 KiB
Ruby
Raw Normal View History

2019-07-07 11:18:12 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe ProcessCommitWorker do
2017-08-17 22:00:37 +05:30
let(:worker) { described_class.new }
let(:user) { create(:user) }
let(:project) { create(:project, :public, :repository) }
let(:issue) { create(:issue, project: project, author: user) }
let(:commit) { project.commit }
describe '#perform' do
it 'does not process the commit when the project does not exist' do
expect(worker).not_to receive(:close_issues)
worker.perform(-1, user.id, commit.to_hash)
end
it 'does not process the commit when the user does not exist' do
expect(worker).not_to receive(:close_issues)
worker.perform(project.id, -1, commit.to_hash)
end
2020-05-24 23:13:21 +05:30
include_examples 'an idempotent worker' do
subject do
perform_multiple([project.id, user.id, commit.to_hash], worker: worker)
end
it 'processes the commit message' do
expect(worker).to receive(:process_commit_message)
.exactly(IdempotentWorkerHelper::WORKER_EXEC_TIMES)
.and_call_original
subject
end
it 'updates the issue metrics' do
expect(worker).to receive(:update_issue_metrics)
.exactly(IdempotentWorkerHelper::WORKER_EXEC_TIMES)
.and_call_original
subject
end
2017-08-17 22:00:37 +05:30
end
end
describe '#process_commit_message' do
context 'when pushing to the default branch' do
2018-03-27 19:54:05 +05:30
before do
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
end
2017-08-17 22:00:37 +05:30
it 'closes issues that should be closed per the commit message' do
2018-03-27 19:54:05 +05:30
expect(worker).to receive(:close_issues).with(project, user, user, commit, [issue])
worker.process_commit_message(project, commit, user, user, true)
end
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
it 'creates cross references' do
expect(commit).to receive(:create_cross_references!).with(user, [issue])
2017-08-17 22:00:37 +05:30
worker.process_commit_message(project, commit, user, user, true)
end
end
context 'when pushing to a non-default branch' do
it 'does not close any issues' do
2018-03-27 19:54:05 +05:30
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
2017-08-17 22:00:37 +05:30
expect(worker).not_to receive(:close_issues)
worker.process_commit_message(project, commit, user, user, false)
end
2018-03-27 19:54:05 +05:30
it 'does not create cross references' do
expect(commit).to receive(:create_cross_references!).with(user, [])
worker.process_commit_message(project, commit, user, user, false)
end
2017-08-17 22:00:37 +05:30
end
2018-03-27 19:54:05 +05:30
context 'when commit is a merge request merge commit to the default branch' do
let(:merge_request) do
create(:merge_request,
description: "Closes #{issue.to_reference}",
source_branch: 'feature-merged',
target_branch: 'master',
source_project: project)
end
let(:commit) do
project.repository.create_branch('feature-merged', 'feature')
2019-12-26 22:10:19 +05:30
project.repository.after_create_branch
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
MergeRequests::MergeService
2021-06-08 01:23:25 +05:30
.new(project: project, current_user: merge_request.author, params: { sha: merge_request.diff_head_sha })
2018-03-27 19:54:05 +05:30
.execute(merge_request)
merge_request.reload.merge_commit
end
it 'does not close any issues from the commit message' do
expect(worker).not_to receive(:close_issues)
worker.process_commit_message(project, commit, user, user, true)
end
it 'still creates cross references' do
expect(commit).to receive(:create_cross_references!).with(user, [])
worker.process_commit_message(project, commit, user, user, true)
end
2017-08-17 22:00:37 +05:30
end
end
describe '#close_issues' do
2022-10-11 01:57:18 +05:30
it 'creates Issue::CloseWorker jobs' do
expect do
2017-08-17 22:00:37 +05:30
worker.close_issues(project, user, user, commit, [issue])
2022-10-11 01:57:18 +05:30
end.to change(Issues::CloseWorker.jobs, :size).by(1)
end
2017-08-17 22:00:37 +05:30
end
2021-09-04 01:27:46 +05:30
describe '#update_issue_metrics', :clean_gitlab_redis_cache do
2020-01-01 13:55:28 +05:30
context 'when commit has issue reference' do
subject(:update_metrics_and_reload) do
-> {
worker.update_issue_metrics(commit, user)
issue.metrics.reload
}
end
before do
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
end
2017-08-17 22:00:37 +05:30
2020-01-01 13:55:28 +05:30
context 'when issue has no first_mentioned_in_commit_at set' do
it 'updates issue metrics' do
expect(update_metrics_and_reload)
.to change { issue.metrics.first_mentioned_in_commit_at }.to(commit.committed_date)
end
end
2017-08-17 22:00:37 +05:30
2020-01-01 13:55:28 +05:30
context 'when issue has first_mentioned_in_commit_at earlier than given committed_date' do
before do
2020-10-24 23:57:45 +05:30
issue.metrics.update!(first_mentioned_in_commit_at: commit.committed_date - 1.day)
2020-01-01 13:55:28 +05:30
end
2017-08-17 22:00:37 +05:30
2020-01-01 13:55:28 +05:30
it "doesn't update issue metrics" do
expect(update_metrics_and_reload).not_to change { issue.metrics.first_mentioned_in_commit_at }
end
end
context 'when issue has first_mentioned_in_commit_at later than given committed_date' do
before do
2020-10-24 23:57:45 +05:30
issue.metrics.update!(first_mentioned_in_commit_at: commit.committed_date + 1.day)
2020-01-01 13:55:28 +05:30
end
it "doesn't update issue metrics" do
expect(update_metrics_and_reload)
.to change { issue.metrics.first_mentioned_in_commit_at }.to(commit.committed_date)
end
end
2017-08-17 22:00:37 +05:30
end
2020-01-01 13:55:28 +05:30
context 'when commit has no issue references' do
it "doesn't execute any queries with false conditions" do
allow(commit).to receive(:safe_message).and_return("Lorem Ipsum")
2017-08-17 22:00:37 +05:30
2020-01-01 13:55:28 +05:30
expect { worker.update_issue_metrics(commit, user) }
.not_to make_queries_matching(/WHERE (?:1=0|0=1)/)
end
2017-08-17 22:00:37 +05:30
end
end
end