debian-mirror-gitlab/spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

76 lines
2.1 KiB
Ruby
Raw Normal View History

2020-05-24 23:13:21 +05:30
# frozen_string_literal: true
2022-10-11 01:57:18 +05:30
require 'rubocop_spec_helper'
2020-05-24 23:13:21 +05:30
require_relative '../../../../rubocop/cop/migration/with_lock_retries_disallowed_method'
2021-03-08 18:12:59 +05:30
RSpec.describe RuboCop::Cop::Migration::WithLockRetriesDisallowedMethod do
2021-04-17 20:07:23 +05:30
context 'when in migration' do
2020-05-24 23:13:21 +05:30
before do
allow(cop).to receive(:in_migration?).and_return(true)
end
it 'registers an offense when `with_lock_retries` block has disallowed method' do
2021-04-17 20:07:23 +05:30
expect_offense(<<~RUBY)
def change
with_lock_retries { disallowed_method }
^^^^^^^^^^^^^^^^^ The method is not allowed [...]
end
RUBY
2020-05-24 23:13:21 +05:30
end
it 'registers an offense when `with_lock_retries` block has disallowed methods' do
2021-04-17 20:07:23 +05:30
expect_offense(<<~RUBY)
def change
with_lock_retries do
disallowed_method
^^^^^^^^^^^^^^^^^ The method is not allowed [...]
2020-05-24 23:13:21 +05:30
2021-04-17 20:07:23 +05:30
create_table do |t|
t.text :text
end
2020-05-24 23:13:21 +05:30
2021-04-17 20:07:23 +05:30
other_disallowed_method
^^^^^^^^^^^^^^^^^^^^^^^ The method is not allowed [...]
2020-05-24 23:13:21 +05:30
2021-04-17 20:07:23 +05:30
add_column :users, :name
end
2020-05-24 23:13:21 +05:30
end
2021-04-17 20:07:23 +05:30
RUBY
2020-05-24 23:13:21 +05:30
end
it 'registers no offense when `with_lock_retries` has only allowed method' do
2021-04-17 20:07:23 +05:30
expect_no_offenses(<<~RUBY)
def up
with_lock_retries { add_foreign_key :foo, :bar }
end
RUBY
2020-05-24 23:13:21 +05:30
end
2021-01-03 14:25:43 +05:30
describe 'for `add_foreign_key`' do
it 'registers an offense when more than two FKs are added' do
message = described_class::MSG_ONLY_ONE_FK_ALLOWED
2021-04-17 20:07:23 +05:30
expect_offense(<<~RUBY)
2021-01-03 14:25:43 +05:30
with_lock_retries do
add_foreign_key :imports, :projects, column: :project_id, on_delete: :cascade
^^^^^^^^^^^^^^^ #{message}
add_column :projects, :name, :text
add_foreign_key :imports, :users, column: :user_id, on_delete: :cascade
^^^^^^^^^^^^^^^ #{message}
end
RUBY
end
end
2020-05-24 23:13:21 +05:30
end
2021-04-17 20:07:23 +05:30
context 'when outside of migration' do
2020-05-24 23:13:21 +05:30
it 'registers no offense' do
2021-04-17 20:07:23 +05:30
expect_no_offenses(<<~RUBY)
def change
with_lock_retries { disallowed_method }
end
RUBY
2020-05-24 23:13:21 +05:30
end
end
end