2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-27 19:54:05 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe NotificationRecipient do
|
2018-03-27 19:54:05 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:project) { create(:project, namespace: user.namespace) }
|
|
|
|
let(:target) { create(:issue, project: project) }
|
|
|
|
|
|
|
|
subject(:recipient) { described_class.new(user, :watch, target: target, project: project) }
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
describe '#notifiable?' do
|
|
|
|
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
|
|
|
|
|
|
|
|
context 'when emails are disabled' do
|
|
|
|
it 'returns false if group disabled' do
|
|
|
|
expect(project.namespace).to receive(:emails_disabled?).and_return(true)
|
|
|
|
expect(recipient).to receive(:emails_disabled?).and_call_original
|
|
|
|
expect(recipient.notifiable?).to eq false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if project disabled' do
|
|
|
|
expect(project).to receive(:emails_disabled?).and_return(true)
|
|
|
|
expect(recipient).to receive(:emails_disabled?).and_call_original
|
|
|
|
expect(recipient.notifiable?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when emails are enabled' do
|
|
|
|
it 'returns true if group enabled' do
|
|
|
|
expect(project.namespace).to receive(:emails_disabled?).and_return(false)
|
|
|
|
expect(recipient).to receive(:emails_disabled?).and_call_original
|
|
|
|
expect(recipient.notifiable?).to eq true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true if project enabled' do
|
|
|
|
expect(project).to receive(:emails_disabled?).and_return(false)
|
|
|
|
expect(recipient).to receive(:emails_disabled?).and_call_original
|
|
|
|
expect(recipient.notifiable?).to eq true
|
|
|
|
end
|
|
|
|
end
|
2022-10-11 01:57:18 +05:30
|
|
|
|
|
|
|
context 'when recipient email is blocked', :clean_gitlab_redis_rate_limiting do
|
|
|
|
before do
|
|
|
|
allow(Gitlab::ApplicationRateLimiter).to receive(:rate_limits)
|
|
|
|
.and_return(
|
|
|
|
temporary_email_failure: { threshold: 1, interval: 1.minute },
|
|
|
|
permanent_email_failure: { threshold: 1, interval: 1.minute }
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with permanent failures' do
|
|
|
|
before do
|
|
|
|
2.times { Gitlab::ApplicationRateLimiter.throttled?(:permanent_email_failure, scope: user.email) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.notifiable?).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with temporary failures' do
|
|
|
|
before do
|
|
|
|
2.times { Gitlab::ApplicationRateLimiter.throttled?(:temporary_email_failure, scope: user.email) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.notifiable?).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
2019-05-03 19:53:19 +05:30
|
|
|
describe '#has_access?' do
|
|
|
|
before do
|
|
|
|
allow(user).to receive(:can?).and_call_original
|
|
|
|
end
|
2018-03-27 19:54:05 +05:30
|
|
|
|
2019-05-03 19:53:19 +05:30
|
|
|
context 'user cannot read cross project' do
|
|
|
|
it 'returns false' do
|
|
|
|
expect(user).to receive(:can?).with(:read_cross_project).and_return(false)
|
|
|
|
expect(recipient.has_access?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'user cannot read build' do
|
|
|
|
let(:target) { build(:ci_pipeline) }
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(user).to receive(:can?).with(:read_build, target).and_return(false)
|
|
|
|
expect(recipient.has_access?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'user cannot read commit' do
|
|
|
|
let(:target) { build(:commit) }
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(user).to receive(:can?).with(:read_commit, target).and_return(false)
|
|
|
|
expect(recipient.has_access?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'target has no policy' do
|
|
|
|
let(:target) { double.as_null_object }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.has_access?).to eq true
|
|
|
|
end
|
|
|
|
end
|
2018-03-27 19:54:05 +05:30
|
|
|
end
|
2018-11-08 19:23:39 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe '#notification_setting' do
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'for child groups' do
|
2018-11-08 19:23:39 +05:30
|
|
|
let!(:moved_group) { create(:group) }
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:sub_group_1) { create(:group, parent: group) }
|
|
|
|
let(:sub_group_2) { create(:group, parent: sub_group_1) }
|
|
|
|
let(:project) { create(:project, namespace: moved_group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sub_group_2.add_owner(user)
|
|
|
|
moved_group.add_owner(user)
|
|
|
|
Groups::TransferService.new(moved_group, user).execute(sub_group_2)
|
|
|
|
|
|
|
|
moved_group.reload
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notification setting is global' do
|
|
|
|
before do
|
|
|
|
user.notification_settings_for(group).global!
|
|
|
|
user.notification_settings_for(sub_group_1).mention!
|
|
|
|
user.notification_settings_for(sub_group_2).global!
|
|
|
|
user.notification_settings_for(moved_group).global!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'considers notification setting from the first parent without global setting' do
|
|
|
|
expect(subject.notification_setting.source).to eq(sub_group_1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notification setting is not global' do
|
|
|
|
before do
|
|
|
|
user.notification_settings_for(group).global!
|
|
|
|
user.notification_settings_for(sub_group_1).mention!
|
|
|
|
user.notification_settings_for(sub_group_2).watch!
|
|
|
|
user.notification_settings_for(moved_group).disabled!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'considers notification setting from lowest group member in hierarchy' do
|
|
|
|
expect(subject.notification_setting.source).to eq(moved_group)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
|
|
|
describe '#suitable_notification_level?' do
|
|
|
|
context 'when notification level is mention' do
|
|
|
|
before do
|
|
|
|
user.notification_settings_for(project).mention!
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is mention' do
|
|
|
|
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is not mention' do
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notification level is participating' do
|
|
|
|
let(:notification_setting) { user.notification_settings_for(project) }
|
|
|
|
|
|
|
|
context 'when type is participating' do
|
|
|
|
let(:recipient) { described_class.new(user, :participating, target: target, project: project) }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is mention' do
|
|
|
|
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with custom action' do
|
|
|
|
context "when action is failed_pipeline" do
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :failed_pipeline,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when action is fixed_pipeline" do
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :fixed_pipeline,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
context "when action is not fixed_pipeline or failed_pipeline" do
|
2019-09-04 21:01:54 +05:30
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :success_pipeline,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notification level is custom' do
|
|
|
|
before do
|
|
|
|
user.notification_settings_for(project).custom!
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is participating' do
|
|
|
|
let(:notification_setting) { user.notification_settings_for(project) }
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:participating,
|
|
|
|
custom_action: :new_note,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(new_note: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(new_note: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is mention' do
|
|
|
|
let(:notification_setting) { user.notification_settings_for(project) }
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:mention,
|
|
|
|
custom_action: :new_issue,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(new_issue: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(new_issue: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is watch' do
|
|
|
|
let(:notification_setting) { user.notification_settings_for(project) }
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :failed_pipeline,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(failed_pipeline: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(failed_pipeline: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq false
|
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
context 'when custom_action is fixed_pipeline and success_pipeline event is enabled' do
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :fixed_pipeline,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
notification_setting.update!(success_pipeline: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
|
|
|
|
context 'with merge_when_pipeline_succeeds' do
|
|
|
|
let(:notification_setting) { user.notification_settings_for(project) }
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(
|
|
|
|
user,
|
|
|
|
:watch,
|
|
|
|
custom_action: :merge_when_pipeline_succeeds,
|
|
|
|
target: target,
|
|
|
|
project: project
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'custom event enabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(merge_when_pipeline_succeeds: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'custom event disabled' do
|
|
|
|
before do
|
|
|
|
notification_setting.update!(merge_when_pipeline_succeeds: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when notification level is watch' do
|
|
|
|
before do
|
|
|
|
user.notification_settings_for(project).watch!
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is watch' do
|
|
|
|
context 'without excluded watcher events' do
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with excluded watcher events' do
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(user, :watch, custom_action: :issue_due, target: target, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is not watch' do
|
|
|
|
context 'without excluded watcher events' do
|
|
|
|
let(:recipient) { described_class.new(user, :participating, target: target, project: project) }
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with excluded watcher events' do
|
|
|
|
let(:recipient) do
|
|
|
|
described_class.new(user, :participating, custom_action: :issue_due, target: target, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(recipient.suitable_notification_level?).to eq true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-03-27 19:54:05 +05:30
|
|
|
end
|