debian-mirror-gitlab/spec/support/controllers/githubish_import_controller_shared_examples.rb

410 lines
15 KiB
Ruby
Raw Normal View History

2017-08-17 22:00:37 +05:30
# Specifications for behavior common to all objects with an email attribute.
# Takes a list of email-format attributes and requires:
# - subject { "the object with a attribute= setter" }
# Note: You have access to `email_value` which is the email address value
# being currently tested).
def assign_session_token(provider)
session[:"#{provider}_access_token"] = 'asdasd12345'
end
shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
let(:status_import_url) { public_send("status_import_#{provider}_url") }
it "updates access token" do
token = 'asdfasdf9876'
2018-03-17 18:26:18 +05:30
allow_any_instance_of(Gitlab::LegacyGithubImport::Client)
2017-09-10 17:25:29 +05:30
.to receive(:user).and_return(true)
2017-08-17 22:00:37 +05:30
post :personal_access_token, personal_access_token: token
expect(session[:"#{provider}_access_token"]).to eq(token)
expect(controller).to redirect_to(status_import_url)
end
2018-12-13 13:39:08 +05:30
it "strips access token with spaces" do
token = 'asdfasdf9876'
allow_any_instance_of(Gitlab::LegacyGithubImport::Client)
.to receive(:user).and_return(true)
post :personal_access_token, personal_access_token: " #{token} "
expect(session[:"#{provider}_access_token"]).to eq(token)
expect(controller).to redirect_to(status_import_url)
end
2017-08-17 22:00:37 +05:30
end
shared_examples 'a GitHub-ish import controller: GET new' do
let(:status_import_url) { public_send("status_import_#{provider}_url") }
it "redirects to status if we already have a token" do
assign_session_token(provider)
allow(controller).to receive(:logged_in_with_provider?).and_return(false)
get :new
expect(controller).to redirect_to(status_import_url)
end
it "renders the :new page if no token is present in session" do
get :new
expect(response).to render_template(:new)
end
end
shared_examples 'a GitHub-ish import controller: GET status' do
let(:new_import_url) { public_send("new_import_#{provider}_url") }
let(:user) { create(:user) }
let(:repo) { OpenStruct.new(login: 'vim', full_name: 'asd/vim') }
let(:org) { OpenStruct.new(login: 'company') }
let(:org_repo) { OpenStruct.new(login: 'company', full_name: 'company/repo') }
let(:extra_assign_expectations) { {} }
before do
assign_session_token(provider)
end
it "assigns variables" do
2018-10-15 14:42:47 +05:30
project = create(:project, import_type: provider, namespace: user.namespace)
2017-08-17 22:00:37 +05:30
stub_client(repos: [repo, org_repo], orgs: [org], org_repos: [org_repo])
get :status
expect(assigns(:already_added_projects)).to eq([project])
expect(assigns(:repos)).to eq([repo, org_repo])
extra_assign_expectations.each do |key, value|
expect(assigns(key)).to eq(value)
end
end
it "does not show already added project" do
2018-10-15 14:42:47 +05:30
project = create(:project, import_type: provider, namespace: user.namespace, import_source: 'asd/vim')
2017-08-17 22:00:37 +05:30
stub_client(repos: [repo], orgs: [])
get :status
expect(assigns(:already_added_projects)).to eq([project])
expect(assigns(:repos)).to eq([])
end
it "handles an invalid access token" do
2018-03-17 18:26:18 +05:30
allow_any_instance_of(Gitlab::LegacyGithubImport::Client)
2017-09-10 17:25:29 +05:30
.to receive(:repos).and_raise(Octokit::Unauthorized)
2017-08-17 22:00:37 +05:30
get :status
expect(session[:"#{provider}_access_token"]).to be_nil
expect(controller).to redirect_to(new_import_url)
expect(flash[:alert]).to eq("Access denied to your #{Gitlab::ImportSources.title(provider.to_s)} account.")
end
end
shared_examples 'a GitHub-ish import controller: POST create' do
let(:user) { create(:user) }
2018-03-27 19:54:05 +05:30
let(:project) { create(:project) }
2017-08-17 22:00:37 +05:30
let(:provider_username) { user.username }
let(:provider_user) { OpenStruct.new(login: provider_username) }
let(:provider_repo) do
OpenStruct.new(
name: 'vim',
full_name: "#{provider_username}/vim",
owner: OpenStruct.new(login: provider_username)
)
end
before do
stub_client(user: provider_user, repo: provider_repo)
assign_session_token(provider)
end
2018-03-27 19:54:05 +05:30
it 'returns 200 response when the project is imported successfully' do
allow(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
.and_return(double(execute: project))
post :create, format: :json
expect(response).to have_gitlab_http_status(200)
end
2018-11-08 19:23:39 +05:30
it 'returns 422 response with the base error when the project could not be imported' do
project = build(:project)
project.errors.add(:name, 'is invalid')
project.errors.add(:path, 'is old')
2018-03-27 19:54:05 +05:30
allow(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
2018-11-08 19:23:39 +05:30
.and_return(double(execute: project))
2018-03-27 19:54:05 +05:30
post :create, format: :json
expect(response).to have_gitlab_http_status(422)
2018-11-08 19:23:39 +05:30
expect(json_response['errors']).to eq('Name is invalid, Path is old')
2018-03-27 19:54:05 +05:30
end
2017-08-17 22:00:37 +05:30
context "when the repository owner is the provider user" do
context "when the provider user and GitLab user's usernames match" do
it "takes the current user's namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, format: :json
2017-08-17 22:00:37 +05:30
end
end
context "when the provider user and GitLab user's usernames don't match" do
let(:provider_username) { "someone_else" }
it "takes the current user's namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, format: :json
2017-08-17 22:00:37 +05:30
end
end
end
context "when the repository owner is not the provider user" do
let(:other_username) { "someone_else" }
before do
provider_repo.owner = OpenStruct.new(login: other_username)
assign_session_token(provider)
end
context "when a namespace with the provider user's username already exists" do
2018-03-17 18:26:18 +05:30
let!(:existing_namespace) { user.namespace }
2017-08-17 22:00:37 +05:30
context "when the namespace is owned by the GitLab user" do
2018-03-17 18:26:18 +05:30
before do
user.username = other_username
user.save
end
2017-08-17 22:00:37 +05:30
it "takes the existing namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, existing_namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, format: :json
2017-08-17 22:00:37 +05:30
end
end
context "when the namespace is not owned by the GitLab user" do
it "creates a project using user's namespace" do
2018-03-17 18:26:18 +05:30
create(:user, username: other_username)
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, format: :json
2017-08-17 22:00:37 +05:30
end
end
end
context "when a namespace with the provider user's username doesn't exist" do
context "when current user can create namespaces" do
it "creates the namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2018-03-27 19:54:05 +05:30
.to receive(:new).and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
expect { post :create, target_namespace: provider_repo.name, format: :json }.to change(Namespace, :count).by(1)
2017-08-17 22:00:37 +05:30
end
it "takes the new namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, an_instance_of(Group), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, target_namespace: provider_repo.name, format: :json
2017-08-17 22:00:37 +05:30
end
end
context "when current user can't create namespaces" do
before do
user.update_attribute(:can_create_group, false)
end
it "doesn't create the namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2018-03-27 19:54:05 +05:30
.to receive(:new).and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
expect { post :create, format: :json }.not_to change(Namespace, :count)
2017-08-17 22:00:37 +05:30
end
it "takes the current user's namespace" do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, provider_repo.name, user.namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, format: :json
2017-08-17 22:00:37 +05:30
end
end
end
context 'user has chosen a namespace and name for the project' do
2017-09-10 17:25:29 +05:30
let(:test_namespace) { create(:group, name: 'test_namespace') }
2017-08-17 22:00:37 +05:30
let(:test_name) { 'test_name' }
2017-09-10 17:25:29 +05:30
before do
test_namespace.add_owner(user)
end
2017-08-17 22:00:37 +05:30
it 'takes the selected namespace and name' do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, test_namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { target_namespace: test_namespace.name, new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
end
it 'takes the selected name and default namespace' do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, user.namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'user has chosen an existing nested namespace and name for the project', :postgresql do
2018-10-15 14:42:47 +05:30
let(:parent_namespace) { create(:group, name: 'foo') }
2017-09-10 17:25:29 +05:30
let(:nested_namespace) { create(:group, name: 'bar', parent: parent_namespace) }
2017-08-17 22:00:37 +05:30
let(:test_name) { 'test_name' }
2017-09-10 17:25:29 +05:30
before do
2018-10-15 14:42:47 +05:30
parent_namespace.add_owner(user)
2017-09-10 17:25:29 +05:30
nested_namespace.add_owner(user)
end
2017-08-17 22:00:37 +05:30
it 'takes the selected namespace and name' do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, nested_namespace, user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { target_namespace: nested_namespace.full_path, new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'user has chosen a non-existent nested namespaces and name for the project', :postgresql do
2017-08-17 22:00:37 +05:30
let(:test_name) { 'test_name' }
it 'takes the selected namespace and name' do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { target_namespace: 'foo/bar', new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
end
it 'creates the namespaces' do
2018-03-17 18:26:18 +05:30
allow(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
expect { post :create, { target_namespace: 'foo/bar', new_name: test_name, format: :json } }
2017-08-17 22:00:37 +05:30
.to change { Namespace.count }.by(2)
end
it 'new namespace has the right parent' do
2018-03-17 18:26:18 +05:30
allow(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { target_namespace: 'foo/bar', new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
expect(Namespace.find_by_path_or_name('bar').parent.path).to eq('foo')
end
end
2018-03-17 18:26:18 +05:30
context 'user has chosen existent and non-existent nested namespaces and name for the project', :postgresql do
2017-08-17 22:00:37 +05:30
let(:test_name) { 'test_name' }
2018-10-15 14:42:47 +05:30
let!(:parent_namespace) { create(:group, name: 'foo') }
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
before do
parent_namespace.add_owner(user)
end
2017-08-17 22:00:37 +05:30
it 'takes the selected namespace and name' do
2018-03-17 18:26:18 +05:30
expect(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
post :create, { target_namespace: 'foo/foobar/bar', new_name: test_name, format: :json }
2017-08-17 22:00:37 +05:30
end
it 'creates the namespaces' do
2018-03-17 18:26:18 +05:30
allow(Gitlab::LegacyGithubImport::ProjectCreator)
2017-09-10 17:25:29 +05:30
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
2018-03-27 19:54:05 +05:30
.and_return(double(execute: project))
2017-08-17 22:00:37 +05:30
2018-03-27 19:54:05 +05:30
expect { post :create, { target_namespace: 'foo/foobar/bar', new_name: test_name, format: :json } }
2017-08-17 22:00:37 +05:30
.to change { Namespace.count }.by(2)
end
2018-03-17 18:26:18 +05:30
it 'does not create a new namespace under the user namespace' do
expect(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, test_name, user.namespace, user, access_params, type: provider)
.and_return(double(execute: build_stubbed(:project)))
expect { post :create, { target_namespace: "#{user.namespace_path}/test_group", new_name: test_name, format: :js } }
.not_to change { Namespace.count }
end
end
context 'user cannot create a subgroup inside a group is not a member of' do
let(:test_name) { 'test_name' }
let!(:parent_namespace) { create(:group, name: 'foo') }
it 'does not take the selected namespace and name' do
expect(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, test_name, user.namespace, user, access_params, type: provider)
.and_return(double(execute: build_stubbed(:project)))
post :create, { target_namespace: 'foo/foobar/bar', new_name: test_name, format: :js }
end
it 'does not create the namespaces' do
allow(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, test_name, kind_of(Namespace), user, access_params, type: provider)
.and_return(double(execute: build_stubbed(:project)))
expect { post :create, { target_namespace: 'foo/foobar/bar', new_name: test_name, format: :js } }
.not_to change { Namespace.count }
end
end
context 'user can use a group without having permissions to create a group' do
let(:test_name) { 'test_name' }
let!(:group) { create(:group, name: 'foo') }
it 'takes the selected namespace and name' do
group.add_owner(user)
user.update!(can_create_group: false)
expect(Gitlab::LegacyGithubImport::ProjectCreator)
.to receive(:new).with(provider_repo, test_name, group, user, access_params, type: provider)
.and_return(double(execute: build_stubbed(:project)))
post :create, { target_namespace: 'foo', new_name: test_name, format: :js }
end
2017-08-17 22:00:37 +05:30
end
2018-03-27 19:54:05 +05:30
context 'when user can not create projects in the chosen namespace' do
it 'returns 422 response' do
other_namespace = create(:group, name: 'other_namespace')
post :create, { target_namespace: other_namespace.name, format: :json }
expect(response).to have_gitlab_http_status(422)
end
end
2017-08-17 22:00:37 +05:30
end
end