2018-11-20 20:47:30 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
module RelativePositioning
|
|
|
|
extend ActiveSupport::Concern
|
|
|
|
|
|
|
|
MIN_POSITION = 0
|
|
|
|
START_POSITION = Gitlab::Database::MAX_INT_VALUE / 2
|
|
|
|
MAX_POSITION = Gitlab::Database::MAX_INT_VALUE
|
|
|
|
IDEAL_DISTANCE = 500
|
|
|
|
|
|
|
|
included do
|
|
|
|
after_save :save_positionable_neighbours
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
class_methods do
|
|
|
|
def move_to_end(objects)
|
|
|
|
objects = objects.reject(&:relative_position)
|
|
|
|
|
2019-02-13 22:33:31 +05:30
|
|
|
return if objects.empty?
|
|
|
|
|
|
|
|
max_relative_position = objects.first.max_relative_position
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
self.transaction do
|
|
|
|
objects.each do |object|
|
|
|
|
relative_position = position_between(max_relative_position, MAX_POSITION)
|
|
|
|
object.relative_position = relative_position
|
|
|
|
max_relative_position = relative_position
|
|
|
|
object.save
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# This method takes two integer values (positions) and
|
|
|
|
# calculates the position between them. The range is huge as
|
|
|
|
# the maximum integer value is 2147483647. We are incrementing position by IDEAL_DISTANCE * 2 every time
|
|
|
|
# when we have enough space. If distance is less then IDEAL_DISTANCE we are calculating an average number
|
|
|
|
def position_between(pos_before, pos_after)
|
|
|
|
pos_before ||= MIN_POSITION
|
|
|
|
pos_after ||= MAX_POSITION
|
|
|
|
|
|
|
|
pos_before, pos_after = [pos_before, pos_after].sort
|
|
|
|
|
|
|
|
halfway = (pos_after + pos_before) / 2
|
|
|
|
distance_to_halfway = pos_after - halfway
|
|
|
|
|
|
|
|
if distance_to_halfway < IDEAL_DISTANCE
|
|
|
|
halfway
|
|
|
|
else
|
|
|
|
if pos_before == MIN_POSITION
|
|
|
|
pos_after - IDEAL_DISTANCE
|
|
|
|
elsif pos_after == MAX_POSITION
|
|
|
|
pos_before + IDEAL_DISTANCE
|
|
|
|
else
|
|
|
|
halfway
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-13 22:33:31 +05:30
|
|
|
def min_relative_position(&block)
|
|
|
|
calculate_relative_position('MIN', &block)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2019-02-13 22:33:31 +05:30
|
|
|
def max_relative_position(&block)
|
|
|
|
calculate_relative_position('MAX', &block)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def prev_relative_position
|
|
|
|
prev_pos = nil
|
|
|
|
|
|
|
|
if self.relative_position
|
2019-02-13 22:33:31 +05:30
|
|
|
prev_pos = max_relative_position do |relation|
|
|
|
|
relation.where('relative_position < ?', self.relative_position)
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
prev_pos
|
|
|
|
end
|
|
|
|
|
|
|
|
def next_relative_position
|
|
|
|
next_pos = nil
|
|
|
|
|
|
|
|
if self.relative_position
|
2019-02-13 22:33:31 +05:30
|
|
|
next_pos = min_relative_position do |relation|
|
|
|
|
relation.where('relative_position > ?', self.relative_position)
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
next_pos
|
|
|
|
end
|
|
|
|
|
|
|
|
def move_between(before, after)
|
|
|
|
return move_after(before) unless after
|
|
|
|
return move_before(after) unless before
|
|
|
|
|
|
|
|
# If there is no place to insert an issue we need to create one by moving the before issue closer
|
|
|
|
# to its predecessor. This process will recursively move all the predecessors until we have a place
|
|
|
|
if (after.relative_position - before.relative_position) < 2
|
|
|
|
before.move_before
|
2018-03-17 18:26:18 +05:30
|
|
|
@positionable_neighbours = [before] # rubocop:disable Gitlab/ModuleWithInstanceVariables
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
self.relative_position = self.class.position_between(before.relative_position, after.relative_position)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def move_after(before = self)
|
|
|
|
pos_before = before.relative_position
|
|
|
|
pos_after = before.next_relative_position
|
|
|
|
|
|
|
|
if before.shift_after?
|
2018-03-17 18:26:18 +05:30
|
|
|
issue_to_move = self.class.in_parents(parent_ids).find_by!(relative_position: pos_after)
|
2017-08-17 22:00:37 +05:30
|
|
|
issue_to_move.move_after
|
2018-03-17 18:26:18 +05:30
|
|
|
@positionable_neighbours = [issue_to_move] # rubocop:disable Gitlab/ModuleWithInstanceVariables
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
pos_after = issue_to_move.relative_position
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
self.relative_position = self.class.position_between(pos_before, pos_after)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def move_before(after = self)
|
|
|
|
pos_after = after.relative_position
|
|
|
|
pos_before = after.prev_relative_position
|
|
|
|
|
|
|
|
if after.shift_before?
|
2018-03-17 18:26:18 +05:30
|
|
|
issue_to_move = self.class.in_parents(parent_ids).find_by!(relative_position: pos_before)
|
2017-08-17 22:00:37 +05:30
|
|
|
issue_to_move.move_before
|
2018-03-17 18:26:18 +05:30
|
|
|
@positionable_neighbours = [issue_to_move] # rubocop:disable Gitlab/ModuleWithInstanceVariables
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
pos_before = issue_to_move.relative_position
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
self.relative_position = self.class.position_between(pos_before, pos_after)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def move_to_end
|
2018-12-13 13:39:08 +05:30
|
|
|
self.relative_position = self.class.position_between(max_relative_position || START_POSITION, MAX_POSITION)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
def move_to_start
|
2018-12-13 13:39:08 +05:30
|
|
|
self.relative_position = self.class.position_between(min_relative_position || START_POSITION, MIN_POSITION)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Indicates if there is an issue that should be shifted to free the place
|
|
|
|
def shift_after?
|
|
|
|
next_pos = next_relative_position
|
|
|
|
next_pos && (next_pos - relative_position) == 1
|
|
|
|
end
|
|
|
|
|
|
|
|
# Indicates if there is an issue that should be shifted to free the place
|
|
|
|
def shift_before?
|
|
|
|
prev_pos = prev_relative_position
|
|
|
|
prev_pos && (relative_position - prev_pos) == 1
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
# rubocop:disable Gitlab/ModuleWithInstanceVariables
|
2017-08-17 22:00:37 +05:30
|
|
|
def save_positionable_neighbours
|
|
|
|
return unless @positionable_neighbours
|
|
|
|
|
|
|
|
status = @positionable_neighbours.all?(&:save)
|
|
|
|
@positionable_neighbours = nil
|
|
|
|
|
|
|
|
status
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
# rubocop:enable Gitlab/ModuleWithInstanceVariables
|
2019-02-13 22:33:31 +05:30
|
|
|
|
|
|
|
def calculate_relative_position(calculation)
|
|
|
|
# When calculating across projects, this is much more efficient than
|
|
|
|
# MAX(relative_position) without the GROUP BY, due to index usage:
|
|
|
|
# https://gitlab.com/gitlab-org/gitlab-ce/issues/54276#note_119340977
|
|
|
|
relation = self.class
|
|
|
|
.in_parents(parent_ids)
|
|
|
|
.order(Gitlab::Database.nulls_last_order('position', 'DESC'))
|
|
|
|
.limit(1)
|
|
|
|
.group(self.class.parent_column)
|
|
|
|
|
|
|
|
relation = yield relation if block_given?
|
|
|
|
|
|
|
|
relation
|
|
|
|
.pluck(self.class.parent_column, "#{calculation}(relative_position) AS position")
|
|
|
|
.first&.
|
|
|
|
last
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|