debian-mirror-gitlab/spec/features/users/login_spec.rb

829 lines
26 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2015-09-11 14:41:01 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe 'Login' do
2018-10-15 14:42:47 +05:30
include TermsHelper
2019-02-15 15:39:39 +05:30
include UserLoginHelper
2018-10-15 14:42:47 +05:30
2018-11-18 11:00:15 +05:30
before do
stub_authentication_activity_metrics(debug: true)
end
describe 'password reset token after successful sign in' do
it 'invalidates password reset token' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
user = create(:user)
2018-03-27 19:54:05 +05:30
2018-11-18 11:00:15 +05:30
expect(user.reset_password_token).to be_nil
2018-03-27 19:54:05 +05:30
2018-11-18 11:00:15 +05:30
visit new_user_password_path
fill_in 'user_email', with: user.email
click_button 'Reset password'
2018-03-27 19:54:05 +05:30
2018-11-18 11:00:15 +05:30
user.reload
expect(user.reset_password_token).not_to be_nil
2018-03-27 19:54:05 +05:30
2018-11-18 11:00:15 +05:30
find('a[href="#login-pane"]').click
gitlab_sign_in(user)
expect(current_path).to eq root_path
2018-03-27 19:54:05 +05:30
2018-11-18 11:00:15 +05:30
user.reload
expect(user.reset_password_token).to be_nil
end
2018-03-27 19:54:05 +05:30
end
2016-06-02 11:05:42 +05:30
describe 'initial login after setup' do
it 'allows the initial admin to create a password' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2016-06-02 11:05:42 +05:30
# This behavior is dependent on there only being one user
User.delete_all
user = create(:admin, password_automatically_set: true)
visit root_path
expect(current_path).to eq edit_user_password_path
expect(page).to have_content('Please create a password for your new account.')
fill_in 'user_password', with: 'password'
fill_in 'user_password_confirmation', with: 'password'
click_button 'Change your password'
expect(current_path).to eq new_user_session_path
expect(page).to have_content(I18n.t('devise.passwords.updated_not_active'))
fill_in 'user_login', with: user.username
fill_in 'user_password', with: 'password'
click_button 'Sign in'
expect(current_path).to eq root_path
end
2017-08-17 22:00:37 +05:30
it 'does not show flash messages when login page' do
visit root_path
expect(page).not_to have_content('You need to sign in or sign up before continuing.')
end
end
describe 'with a blocked account' do
it 'prevents the user from logging in' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_blocked_counter)
.and increment(:user_unauthenticated_counter)
.and increment(:user_session_destroyed_counter).twice
2017-08-17 22:00:37 +05:30
user = create(:user, :blocked)
2017-09-10 17:25:29 +05:30
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(page).to have_content('Your account has been blocked.')
end
2017-09-10 17:25:29 +05:30
it 'does not update Devise trackable attributes', :clean_gitlab_redis_shared_state do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_blocked_counter)
.and increment(:user_unauthenticated_counter)
.and increment(:user_session_destroyed_counter).twice
2017-08-17 22:00:37 +05:30
user = create(:user, :blocked)
2017-09-10 17:25:29 +05:30
expect { gitlab_sign_in(user) }.not_to change { user.reload.sign_in_count }
2017-08-17 22:00:37 +05:30
end
end
2019-10-12 21:52:04 +05:30
describe 'with an unconfirmed email address' do
let!(:user) { create(:user, confirmed_at: nil) }
let(:grace_period) { 2.days }
before do
stub_application_setting(send_user_confirmation_email: true)
allow(User).to receive(:allow_unconfirmed_access_for).and_return grace_period
end
context 'within the grace period' do
it 'allows to login' do
expect(authentication_metrics).to increment(:user_authenticated_counter)
gitlab_sign_in(user)
expect(page).not_to have_content('You have to confirm your email address before continuing.')
expect(page).not_to have_link('Resend confirmation email', href: new_user_confirmation_path)
end
end
context 'when the confirmation grace period is expired' do
it 'prevents the user from logging in and renders a resend confirmation email link' do
travel_to((grace_period + 1.day).from_now) do
expect(authentication_metrics)
.to increment(:user_unauthenticated_counter)
.and increment(:user_session_destroyed_counter).twice
gitlab_sign_in(user)
expect(page).to have_content('You have to confirm your email address before continuing.')
expect(page).to have_link('Resend confirmation email', href: new_user_confirmation_path)
end
end
end
end
2017-08-17 22:00:37 +05:30
describe 'with the ghost user' do
it 'disallows login' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_unauthenticated_counter)
.and increment(:user_password_invalid_counter)
2017-09-10 17:25:29 +05:30
gitlab_sign_in(User.ghost)
2017-08-17 22:00:37 +05:30
expect(page).to have_content('Invalid Login or password.')
end
2017-09-10 17:25:29 +05:30
it 'does not update Devise trackable attributes', :clean_gitlab_redis_shared_state do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_unauthenticated_counter)
.and increment(:user_password_invalid_counter)
expect { gitlab_sign_in(User.ghost) }
.not_to change { User.ghost.reload.sign_in_count }
2017-08-17 22:00:37 +05:30
end
2016-06-02 11:05:42 +05:30
end
2020-03-13 15:44:24 +05:30
describe 'with two-factor authentication', :js do
2016-08-24 12:49:21 +05:30
def enter_code(code)
2016-11-03 12:29:30 +05:30
fill_in 'user_otp_attempt', with: code
2016-08-24 12:49:21 +05:30
click_button 'Verify code'
end
2015-09-11 14:41:01 +05:30
context 'with valid username/password' do
let(:user) { create(:user, :two_factor) }
before do
2017-09-10 17:25:29 +05:30
gitlab_sign_in(user, remember: true)
2018-11-18 11:00:15 +05:30
expect(page).to have_content('Two-Factor Authentication')
2015-09-11 14:41:01 +05:30
end
it 'does not show a "You are already signed in." error message' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2015-09-11 14:41:01 +05:30
enter_code(user.current_otp)
2018-11-18 11:00:15 +05:30
2019-07-31 22:56:46 +05:30
expect(page).not_to have_content(I18n.t('devise.failure.already_authenticated'))
2015-09-11 14:41:01 +05:30
end
context 'using one-time code' do
it 'allows login with valid code' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2015-09-11 14:41:01 +05:30
enter_code(user.current_otp)
2018-11-18 11:00:15 +05:30
2015-09-11 14:41:01 +05:30
expect(current_path).to eq root_path
end
it 'persists remember_me value via hidden field' do
field = first('input#user_remember_me', visible: false)
expect(field.value).to eq '1'
end
2015-09-11 14:41:01 +05:30
it 'blocks login with invalid code' do
2018-11-18 11:00:15 +05:30
# TODO invalid 2FA code does not generate any events
# See gitlab-org/gitlab-ce#49785
2015-09-11 14:41:01 +05:30
enter_code('foo')
2018-11-18 11:00:15 +05:30
2015-09-11 14:41:01 +05:30
expect(page).to have_content('Invalid two-factor code')
end
it 'allows login with invalid code, then valid code' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2015-09-11 14:41:01 +05:30
enter_code('foo')
expect(page).to have_content('Invalid two-factor code')
enter_code(user.current_otp)
expect(current_path).to eq root_path
end
2019-10-12 21:52:04 +05:30
it 'triggers ActiveSession.cleanup for the user' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
expect(ActiveSession).to receive(:cleanup).with(user).once.and_call_original
enter_code(user.current_otp)
end
2015-09-11 14:41:01 +05:30
end
context 'using backup code' do
let(:codes) { user.generate_otp_backup_codes! }
before do
expect(codes.size).to eq 10
# Ensure the generated codes get saved
user.save
end
context 'with valid code' do
it 'allows login' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2015-09-11 14:41:01 +05:30
enter_code(codes.sample)
2018-11-18 11:00:15 +05:30
2015-09-11 14:41:01 +05:30
expect(current_path).to eq root_path
end
it 'invalidates the used code' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2017-09-10 17:25:29 +05:30
expect { enter_code(codes.sample) }
.to change { user.reload.otp_backup_codes.size }.by(-1)
2015-09-11 14:41:01 +05:30
end
2018-03-17 18:26:18 +05:30
it 'invalidates backup codes twice in a row' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter).twice
.and increment(:user_two_factor_authenticated_counter).twice
.and increment(:user_session_destroyed_counter)
2018-03-17 18:26:18 +05:30
random_code = codes.delete(codes.sample)
expect { enter_code(random_code) }
.to change { user.reload.otp_backup_codes.size }.by(-1)
gitlab_sign_out
gitlab_sign_in(user)
expect { enter_code(codes.sample) }
.to change { user.reload.otp_backup_codes.size }.by(-1)
end
2019-10-12 21:52:04 +05:30
it 'triggers ActiveSession.cleanup for the user' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
expect(ActiveSession).to receive(:cleanup).with(user).once.and_call_original
enter_code(codes.sample)
end
2015-09-11 14:41:01 +05:30
end
context 'with invalid code' do
it 'blocks login' do
2018-11-18 11:00:15 +05:30
# TODO, invalid two factor authentication does not increment
# metrics / counters, see gitlab-org/gitlab-ce#49785
2015-09-11 14:41:01 +05:30
code = codes.sample
expect(user.invalidate_otp_backup_code!(code)).to eq true
user.save!
expect(user.reload.otp_backup_codes.size).to eq 9
enter_code(code)
expect(page).to have_content('Invalid two-factor code.')
end
end
end
end
2016-08-24 12:49:21 +05:30
2018-11-18 11:00:15 +05:30
context 'when logging in via OAuth' do
2018-11-08 19:23:39 +05:30
let(:user) { create(:omniauth_user, :two_factor, extern_uid: 'my-uid', provider: 'saml')}
let(:mock_saml_response) do
File.read('spec/fixtures/authentication/saml_response.xml')
end
2016-08-24 12:49:21 +05:30
2018-11-08 19:23:39 +05:30
before do
stub_omniauth_saml_config(enabled: true, auto_link_saml_user: true, allow_single_sign_on: ['saml'],
providers: [mock_saml_config_with_upstream_two_factor_authn_contexts])
end
context 'when authn_context is worth two factors' do
let(:mock_saml_response) do
File.read('spec/fixtures/authentication/saml_response.xml')
2018-11-18 11:00:15 +05:30
.gsub('urn:oasis:names:tc:SAML:2.0:ac:classes:Password',
'urn:oasis:names:tc:SAML:2.0:ac:classes:SecondFactorOTPSMS')
2018-11-08 19:23:39 +05:30
end
it 'signs user in without prompting for second factor' do
2018-11-18 11:00:15 +05:30
# TODO, OAuth authentication does not fire events,
# see gitlab-org/gitlab-ce#49786
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2019-10-12 21:52:04 +05:30
expect(ActiveSession).to receive(:cleanup).with(user).once.and_call_original
2018-11-18 11:00:15 +05:30
sign_in_using_saml!
2018-11-08 19:23:39 +05:30
expect(page).not_to have_content('Two-Factor Authentication')
expect(current_path).to eq root_path
end
end
2018-11-18 11:00:15 +05:30
context 'when two factor authentication is required' do
2018-11-08 19:23:39 +05:30
it 'shows 2FA prompt after OAuth login' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2019-10-12 21:52:04 +05:30
expect(ActiveSession).to receive(:cleanup).with(user).once.and_call_original
2018-11-18 11:00:15 +05:30
sign_in_using_saml!
2018-11-08 19:23:39 +05:30
expect(page).to have_content('Two-Factor Authentication')
2018-11-18 11:00:15 +05:30
2018-11-08 19:23:39 +05:30
enter_code(user.current_otp)
2018-11-18 11:00:15 +05:30
2018-11-08 19:23:39 +05:30
expect(current_path).to eq root_path
end
2016-08-24 12:49:21 +05:30
end
2018-11-18 11:00:15 +05:30
def sign_in_using_saml!
gitlab_sign_in_via('saml', user, 'my-uid', mock_saml_response)
end
2016-08-24 12:49:21 +05:30
end
2015-09-11 14:41:01 +05:30
end
describe 'without two-factor authentication' do
2018-11-18 11:00:15 +05:30
context 'with correct username and password' do
let(:user) { create(:user) }
2015-09-11 14:41:01 +05:30
2018-11-18 11:00:15 +05:30
it 'allows basic login' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2015-09-11 14:41:01 +05:30
2018-11-18 11:00:15 +05:30
gitlab_sign_in(user)
expect(current_path).to eq root_path
2019-07-31 22:56:46 +05:30
expect(page).not_to have_content(I18n.t('devise.failure.already_authenticated'))
end
it 'does not show already signed in message when opening sign in page after login' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
visit new_user_session_path
expect(page).not_to have_content(I18n.t('devise.failure.already_authenticated'))
2018-11-18 11:00:15 +05:30
end
2019-10-12 21:52:04 +05:30
it 'triggers ActiveSession.cleanup for the user' do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
expect(ActiveSession).to receive(:cleanup).with(user).once.and_call_original
gitlab_sign_in(user)
end
2015-09-11 14:41:01 +05:30
end
2018-11-18 11:00:15 +05:30
context 'with invalid username and password' do
let(:user) { create(:user, password: 'not-the-default') }
2015-09-11 14:41:01 +05:30
2018-11-18 11:00:15 +05:30
it 'blocks invalid login' do
expect(authentication_metrics)
.to increment(:user_unauthenticated_counter)
.and increment(:user_password_invalid_counter)
gitlab_sign_in(user)
expect(page).to have_content('Invalid Login or password.')
end
2015-09-11 14:41:01 +05:30
end
end
describe 'with required two-factor authentication enabled' do
let(:user) { create(:user) }
2020-01-01 13:55:28 +05:30
2017-08-17 22:00:37 +05:30
# TODO: otp_grace_period_started_at
2017-08-17 22:00:37 +05:30
context 'global setting' do
2017-09-10 17:25:29 +05:30
before do
stub_application_setting(require_two_factor_authentication: true)
end
2017-08-17 22:00:37 +05:30
context 'with grace period defined' do
2017-09-10 17:25:29 +05:30
before do
2017-08-17 22:00:37 +05:30
stub_application_setting(two_factor_grace_period: 48)
end
2017-08-17 22:00:37 +05:30
context 'within the grace period' do
it 'redirects to two-factor configuration page' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).to have_content('The global settings require you to enable Two-Factor Authentication for your account. You need to do this before ')
end
2018-03-17 18:26:18 +05:30
it 'allows skipping two-factor configuration', :js do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
expect(current_path).to eq profile_two_factor_auth_path
2017-08-17 22:00:37 +05:30
click_link 'Configure it later'
expect(current_path).to eq root_path
end
end
2017-08-17 22:00:37 +05:30
context 'after the grace period' do
let(:user) { create(:user, otp_grace_period_started_at: 9999.hours.ago) }
2017-08-17 22:00:37 +05:30
it 'redirects to two-factor configuration page' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).to have_content(
'The global settings require you to enable Two-Factor Authentication for your account.'
)
end
2018-03-17 18:26:18 +05:30
it 'disallows skipping two-factor configuration', :js do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).not_to have_link('Configure it later')
end
end
end
context 'without grace period defined' do
2017-09-10 17:25:29 +05:30
before do
2017-08-17 22:00:37 +05:30
stub_application_setting(two_factor_grace_period: 0)
end
2017-08-17 22:00:37 +05:30
it 'redirects to two-factor configuration page' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
expect(current_path).to eq profile_two_factor_auth_path
2017-08-17 22:00:37 +05:30
expect(page).to have_content(
'The global settings require you to enable Two-Factor Authentication for your account.'
)
end
end
end
2017-08-17 22:00:37 +05:30
context 'group setting' do
before do
group1 = create :group, name: 'Group 1', require_two_factor_authentication: true
group1.add_user(user, GroupMember::DEVELOPER)
group2 = create :group, name: 'Group 2', require_two_factor_authentication: true
group2.add_user(user, GroupMember::DEVELOPER)
end
context 'with grace period defined' do
2017-09-10 17:25:29 +05:30
before do
2017-08-17 22:00:37 +05:30
stub_application_setting(two_factor_grace_period: 48)
end
context 'within the grace period' do
it 'redirects to two-factor configuration page' do
2019-07-07 11:18:12 +05:30
Timecop.freeze do
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
expect(current_path).to eq profile_two_factor_auth_path
expect(page).to have_content(
'The group settings for Group 1 and Group 2 require you to enable '\
'Two-Factor Authentication for your account. '\
'You can leave Group 1 and leave Group 2. '\
'You need to do this '\
'before '\
"#{(Time.zone.now + 2.days).strftime("%a, %d %b %Y %H:%M:%S %z")}"
)
end
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
it 'allows skipping two-factor configuration', :js do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
gitlab_sign_in(user)
expect(current_path).to eq profile_two_factor_auth_path
2017-08-17 22:00:37 +05:30
click_link 'Configure it later'
expect(current_path).to eq root_path
end
end
context 'after the grace period' do
let(:user) { create(:user, otp_grace_period_started_at: 9999.hours.ago) }
it 'redirects to two-factor configuration page' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).to have_content(
'The group settings for Group 1 and Group 2 require you to enable ' \
'Two-Factor Authentication for your account.'
)
end
2018-03-17 18:26:18 +05:30
it 'disallows skipping two-factor configuration', :js do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).not_to have_link('Configure it later')
end
end
end
2017-08-17 22:00:37 +05:30
context 'without grace period defined' do
2017-09-10 17:25:29 +05:30
before do
2017-08-17 22:00:37 +05:30
stub_application_setting(two_factor_grace_period: 0)
end
it 'redirects to two-factor configuration page' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
gitlab_sign_in(user)
2017-08-17 22:00:37 +05:30
expect(current_path).to eq profile_two_factor_auth_path
expect(page).to have_content(
'The group settings for Group 1 and Group 2 require you to enable ' \
2019-07-07 11:18:12 +05:30
'Two-Factor Authentication for your account. '\
'You can leave Group 1 and leave Group 2.'
2017-08-17 22:00:37 +05:30
)
end
end
end
end
2016-11-03 12:29:30 +05:30
describe 'UI tabs and panes' do
context 'when no defaults are changed' do
it 'correctly renders tabs and panes' do
ensure_tab_pane_correctness
end
end
context 'when signup is disabled' do
before do
stub_application_setting(signup_enabled: false)
end
it 'correctly renders tabs and panes' do
ensure_tab_pane_correctness
end
end
context 'when ldap is enabled' do
before do
visit new_user_session_path
allow(page).to receive(:form_based_providers).and_return([:ldapmain])
allow(page).to receive(:ldap_enabled).and_return(true)
end
it 'correctly renders tabs and panes' do
ensure_tab_pane_correctness(false)
end
end
context 'when crowd is enabled' do
before do
visit new_user_session_path
allow(page).to receive(:form_based_providers).and_return([:crowd])
allow(page).to receive(:crowd_enabled?).and_return(true)
end
it 'correctly renders tabs and panes' do
ensure_tab_pane_correctness(false)
end
end
end
2018-10-15 14:42:47 +05:30
2019-12-04 20:38:33 +05:30
describe 'Client helper classes and flags' do
it 'adds client browser and platform classes to page body' do
visit root_path
expect(find('body')[:class]).to include('gl-browser-generic')
expect(find('body')[:class]).to include('gl-platform-other')
end
end
2018-10-15 14:42:47 +05:30
context 'when terms are enforced' do
let(:user) { create(:user) }
before do
enforce_terms
end
it 'asks to accept the terms on first login' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2018-10-15 14:42:47 +05:30
visit new_user_session_path
fill_in 'user_login', with: user.email
fill_in 'user_password', with: '12345678'
click_button 'Sign in'
expect_to_be_on_terms_page
click_button 'Accept terms'
expect(current_path).to eq(root_path)
2019-07-31 22:56:46 +05:30
expect(page).not_to have_content(I18n.t('devise.failure.already_authenticated'))
2018-10-15 14:42:47 +05:30
end
it 'does not ask for terms when the user already accepted them' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2018-10-15 14:42:47 +05:30
accept_terms(user)
visit new_user_session_path
fill_in 'user_login', with: user.email
fill_in 'user_password', with: '12345678'
click_button 'Sign in'
expect(current_path).to eq(root_path)
end
context 'when 2FA is required for the user' do
before do
group = create(:group, require_two_factor_authentication: true)
group.add_developer(user)
end
context 'when the user did not enable 2FA' do
it 'asks to set 2FA before asking to accept the terms' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2018-10-15 14:42:47 +05:30
visit new_user_session_path
fill_in 'user_login', with: user.email
fill_in 'user_password', with: '12345678'
click_button 'Sign in'
expect_to_be_on_terms_page
click_button 'Accept terms'
expect(current_path).to eq(profile_two_factor_auth_path)
fill_in 'pin_code', with: user.reload.current_otp
click_button 'Register with two-factor app'
click_link 'Proceed'
expect(current_path).to eq(profile_account_path)
end
end
context 'when the user already enabled 2FA' do
before do
user.update!(otp_required_for_login: true,
otp_secret: User.generate_otp_secret(32))
end
it 'asks the user to accept the terms' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
.and increment(:user_two_factor_authenticated_counter)
2018-10-15 14:42:47 +05:30
visit new_user_session_path
fill_in 'user_login', with: user.email
fill_in 'user_password', with: '12345678'
click_button 'Sign in'
fill_in 'user_otp_attempt', with: user.reload.current_otp
click_button 'Verify code'
expect_to_be_on_terms_page
click_button 'Accept terms'
expect(current_path).to eq(root_path)
end
end
end
context 'when the users password is expired' do
before do
user.update!(password_expires_at: Time.parse('2018-05-08 11:29:46 UTC'))
end
it 'asks the user to accept the terms before setting a new password' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2018-10-15 14:42:47 +05:30
visit new_user_session_path
fill_in 'user_login', with: user.email
fill_in 'user_password', with: '12345678'
click_button 'Sign in'
expect_to_be_on_terms_page
click_button 'Accept terms'
expect(current_path).to eq(new_profile_password_path)
fill_in 'user_current_password', with: '12345678'
fill_in 'user_password', with: 'new password'
fill_in 'user_password_confirmation', with: 'new password'
click_button 'Set new password'
expect(page).to have_content('Password successfully changed')
end
end
context 'when the user does not have an email configured' do
let(:user) { create(:omniauth_user, extern_uid: 'my-uid', provider: 'saml', email: 'temp-email-for-oauth-user@gitlab.localhost') }
before do
stub_omniauth_saml_config(enabled: true, auto_link_saml_user: true, allow_single_sign_on: ['saml'], providers: [mock_saml_config])
end
it 'asks the user to accept the terms before setting an email' do
2018-11-18 11:00:15 +05:30
expect(authentication_metrics)
.to increment(:user_authenticated_counter)
2018-10-15 14:42:47 +05:30
gitlab_sign_in_via('saml', user, 'my-uid')
expect_to_be_on_terms_page
click_button 'Accept terms'
expect(current_path).to eq(profile_path)
fill_in 'Email', with: 'hello@world.com'
click_button 'Update profile settings'
expect(page).to have_content('Profile was successfully updated')
end
end
end
2019-10-12 21:52:04 +05:30
context 'when sending confirmation email and not yet confirmed' do
let!(:user) { create(:user, confirmed_at: nil) }
let(:grace_period) { 2.days }
before do
stub_application_setting(send_user_confirmation_email: true)
stub_feature_flags(soft_email_confirmation: true)
allow(User).to receive(:allow_unconfirmed_access_for).and_return grace_period
end
it 'allows login and shows a flash warning to confirm the email address' do
expect(authentication_metrics).to increment(:user_authenticated_counter)
gitlab_sign_in(user)
expect(current_path).to eq root_path
2019-12-26 22:10:19 +05:30
expect(page).to have_content("Please check your email (#{user.email}) to verify that you own this address and unlock the power of CI/CD.")
2019-10-12 21:52:04 +05:30
end
context "when not having confirmed within Devise's allow_unconfirmed_access_for time" do
it 'does not allow login and shows a flash alert to confirm the email address' do
travel_to((grace_period + 1.day).from_now) do
expect(authentication_metrics)
.to increment(:user_unauthenticated_counter)
.and increment(:user_session_destroyed_counter).twice
gitlab_sign_in(user)
expect(current_path).to eq new_user_session_path
expect(page).to have_content('You have to confirm your email address before continuing.')
end
end
end
end
2015-09-11 14:41:01 +05:30
end