debian-mirror-gitlab/spec/frontend/issue_show/components/app_spec.js

498 lines
15 KiB
JavaScript
Raw Normal View History

2017-09-10 17:25:29 +05:30
import Vue from 'vue';
2018-03-17 18:26:18 +05:30
import MockAdapter from 'axios-mock-adapter';
2020-05-24 23:13:21 +05:30
import { TEST_HOST } from 'helpers/test_constants';
2018-03-17 18:26:18 +05:30
import axios from '~/lib/utils/axios_utils';
2020-05-24 23:13:21 +05:30
import { visitUrl } from '~/lib/utils/url_utility';
2018-05-09 12:01:36 +05:30
import '~/behaviors/markdown/render_gfm';
2017-09-10 17:25:29 +05:30
import issuableApp from '~/issue_show/components/app.vue';
import eventHub from '~/issue_show/event_hub';
2020-03-13 15:44:24 +05:30
import { initialRequest, secondRequest } from '../mock_data';
2017-09-10 17:25:29 +05:30
function formatText(text) {
return text.trim().replace(/\s\s+/g, ' ');
}
2020-05-24 23:13:21 +05:30
jest.mock('~/lib/utils/url_utility');
jest.mock('~/issue_show/event_hub');
2020-03-13 15:44:24 +05:30
const REALTIME_REQUEST_STACK = [initialRequest, secondRequest];
2018-03-17 18:26:18 +05:30
2017-09-10 17:25:29 +05:30
describe('Issuable output', () => {
2018-03-17 18:26:18 +05:30
let mock;
let realtimeRequestCount = 0;
let vm;
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
beforeEach(() => {
2019-03-02 22:35:43 +05:30
setFixtures(`
<div>
2020-05-24 23:13:21 +05:30
<title>Title</title>
2019-12-21 20:55:43 +05:30
<div class="detail-page-description content-block">
<details open>
<summary>One</summary>
</details>
<details>
<summary>Two</summary>
</details>
</div>
2019-03-02 22:35:43 +05:30
<div class="flash-container"></div>
<span id="task_status"></span>
</div>
`);
2017-09-10 17:25:29 +05:30
const IssuableDescriptionComponent = Vue.extend(issuableApp);
2018-03-17 18:26:18 +05:30
mock = new MockAdapter(axios);
2020-04-08 14:13:33 +05:30
mock
.onGet('/gitlab-org/gitlab-shell/-/issues/9/realtime_changes/realtime_changes')
.reply(() => {
const res = Promise.resolve([200, REALTIME_REQUEST_STACK[realtimeRequestCount]]);
realtimeRequestCount += 1;
return res;
});
2017-09-10 17:25:29 +05:30
vm = new IssuableDescriptionComponent({
propsData: {
canUpdate: true,
canDestroy: true,
2020-04-08 14:13:33 +05:30
endpoint: '/gitlab-org/gitlab-shell/-/issues/9/realtime_changes',
2020-05-24 23:13:21 +05:30
updateEndpoint: TEST_HOST,
2017-09-10 17:25:29 +05:30
issuableRef: '#1',
initialTitleHtml: '',
initialTitleText: '',
2018-03-17 18:26:18 +05:30
initialDescriptionHtml: 'test',
initialDescriptionText: 'test',
2019-03-02 22:35:43 +05:30
lockVersion: 1,
2018-03-17 18:26:18 +05:30
markdownPreviewPath: '/',
markdownDocsPath: '/',
2017-09-10 17:25:29 +05:30
projectNamespace: '/',
projectPath: '/',
2019-12-21 20:55:43 +05:30
issuableTemplateNamesPath: '/issuable-templates-path',
2017-09-10 17:25:29 +05:30
},
}).$mount();
});
afterEach(() => {
2018-03-17 18:26:18 +05:30
mock.restore();
realtimeRequestCount = 0;
2017-09-10 17:25:29 +05:30
vm.poll.stop();
2018-03-17 18:26:18 +05:30
vm.$destroy();
2017-09-10 17:25:29 +05:30
});
2020-05-24 23:13:21 +05:30
it('should render a title/description/edited and update title/description/edited on update', () => {
2017-09-10 17:25:29 +05:30
let editedText;
2020-05-24 23:13:21 +05:30
return axios
.waitForAll()
2018-12-13 13:39:08 +05:30
.then(() => {
editedText = vm.$el.querySelector('.edited-text');
})
.then(() => {
expect(document.querySelector('title').innerText).toContain('this is a title (#1)');
expect(vm.$el.querySelector('.title').innerHTML).toContain('<p>this is a title</p>');
2019-07-07 11:18:12 +05:30
expect(vm.$el.querySelector('.md').innerHTML).toContain('<p>this is a description!</p>');
2018-12-13 13:39:08 +05:30
expect(vm.$el.querySelector('.js-task-list-field').value).toContain(
'this is a description',
);
expect(formatText(editedText.innerText)).toMatch(/Edited[\s\S]+?by Some User/);
expect(editedText.querySelector('.author-link').href).toMatch(/\/some_user$/);
expect(editedText.querySelector('time')).toBeTruthy();
2019-03-02 22:35:43 +05:30
expect(vm.state.lock_version).toEqual(1);
2018-12-13 13:39:08 +05:30
})
.then(() => {
vm.poll.makeRequest();
2020-05-24 23:13:21 +05:30
return axios.waitForAll();
2018-12-13 13:39:08 +05:30
})
.then(() => {
expect(document.querySelector('title').innerText).toContain('2 (#1)');
expect(vm.$el.querySelector('.title').innerHTML).toContain('<p>2</p>');
2019-07-07 11:18:12 +05:30
expect(vm.$el.querySelector('.md').innerHTML).toContain('<p>42</p>');
2018-12-13 13:39:08 +05:30
expect(vm.$el.querySelector('.js-task-list-field').value).toContain('42');
expect(vm.$el.querySelector('.edited-text')).toBeTruthy();
expect(formatText(vm.$el.querySelector('.edited-text').innerText)).toMatch(
/Edited[\s\S]+?by Other User/,
);
expect(editedText.querySelector('.author-link').href).toMatch(/\/other_user$/);
expect(editedText.querySelector('time')).toBeTruthy();
2019-03-02 22:35:43 +05:30
expect(vm.state.lock_version).toEqual(2);
2020-05-24 23:13:21 +05:30
});
2017-09-10 17:25:29 +05:30
});
2020-05-24 23:13:21 +05:30
it('shows actions if permissions are correct', () => {
2017-09-10 17:25:29 +05:30
vm.showForm = true;
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-12-13 13:39:08 +05:30
expect(vm.$el.querySelector('.btn')).not.toBeNull();
2017-09-10 17:25:29 +05:30
});
});
2020-05-24 23:13:21 +05:30
it('does not show actions if permissions are incorrect', () => {
2017-09-10 17:25:29 +05:30
vm.showForm = true;
vm.canUpdate = false;
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-12-13 13:39:08 +05:30
expect(vm.$el.querySelector('.btn')).toBeNull();
2017-09-10 17:25:29 +05:30
});
});
2020-05-24 23:13:21 +05:30
it('does not update formState if form is already open', () => {
2019-12-21 20:55:43 +05:30
vm.updateAndShowForm();
2017-09-10 17:25:29 +05:30
vm.state.titleText = 'testing 123';
2019-12-21 20:55:43 +05:30
vm.updateAndShowForm();
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-12-13 13:39:08 +05:30
expect(vm.store.formState.title).not.toBe('testing 123');
2020-05-24 23:13:21 +05:30
});
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
it('opens reCAPTCHA modal if update rejected as spam', () => {
let modal;
jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: {
recaptcha_html: '<div class="g-recaptcha">recaptcha_html</div>',
},
2017-09-10 17:25:29 +05:30
});
2020-05-24 23:13:21 +05:30
vm.canUpdate = true;
vm.showForm = true;
return vm
.$nextTick()
.then(() => {
vm.$refs.recaptchaModal.scriptSrc = '//scriptsrc';
return vm.updateIssuable();
})
.then(() => {
modal = vm.$el.querySelector('.js-recaptcha-modal');
expect(modal.style.display).not.toEqual('none');
expect(modal.querySelector('.g-recaptcha').textContent).toEqual('recaptcha_html');
expect(document.body.querySelector('.js-recaptcha-script').src).toMatch('//scriptsrc');
})
.then(() => {
modal.querySelector('.close').click();
return vm.$nextTick();
})
.then(() => {
expect(modal.style.display).toEqual('none');
expect(document.body.querySelector('.js-recaptcha-script')).toBeNull();
});
2017-09-10 17:25:29 +05:30
});
describe('updateIssuable', () => {
2020-05-24 23:13:21 +05:30
it('fetches new data after update', () => {
const updateStoreSpy = jest.spyOn(vm, 'updateStoreState');
const getDataSpy = jest.spyOn(vm.service, 'getData');
jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: { web_url: window.location.pathname },
});
return vm.updateIssuable().then(() => {
expect(updateStoreSpy).toHaveBeenCalled();
expect(getDataSpy).toHaveBeenCalled();
});
2017-09-10 17:25:29 +05:30
});
2020-05-24 23:13:21 +05:30
it('correctly updates issuable data', () => {
const spy = jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: { web_url: window.location.pathname },
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
return vm.updateIssuable().then(() => {
expect(spy).toHaveBeenCalledWith(vm.formState);
expect(eventHub.$emit).toHaveBeenCalledWith('close.form');
});
2017-09-10 17:25:29 +05:30
});
2020-05-24 23:13:21 +05:30
it('does not redirect if issue has not moved', () => {
jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: {
web_url: window.location.pathname,
confidential: vm.isConfidential,
},
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
return vm.updateIssuable().then(() => {
expect(visitUrl).not.toHaveBeenCalled();
});
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
it('does not redirect if issue has not moved and user has switched tabs', () => {
jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: {
web_url: '',
confidential: vm.isConfidential,
},
});
return vm.updateIssuable().then(() => {
2018-10-15 14:42:47 +05:30
expect(visitUrl).not.toHaveBeenCalled();
2017-09-10 17:25:29 +05:30
});
});
2020-05-24 23:13:21 +05:30
it('redirects if returned web_url has changed', () => {
jest.spyOn(vm.service, 'updateIssuable').mockResolvedValue({
data: {
web_url: '/testing-issue-move',
confidential: vm.isConfidential,
},
});
2017-09-10 17:25:29 +05:30
vm.updateIssuable();
2020-05-24 23:13:21 +05:30
return vm.updateIssuable().then(() => {
2018-10-15 14:42:47 +05:30
expect(visitUrl).toHaveBeenCalledWith('/testing-issue-move');
2017-09-10 17:25:29 +05:30
});
});
2018-03-17 18:26:18 +05:30
describe('shows dialog when issue has unsaved changed', () => {
2020-05-24 23:13:21 +05:30
it('confirms on title change', () => {
2018-03-17 18:26:18 +05:30
vm.showForm = true;
vm.state.titleText = 'title has changed';
const e = { returnValue: null };
vm.handleBeforeUnloadEvent(e);
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-03-17 18:26:18 +05:30
expect(e.returnValue).not.toBeNull();
});
});
2020-05-24 23:13:21 +05:30
it('confirms on description change', () => {
2018-03-17 18:26:18 +05:30
vm.showForm = true;
vm.state.descriptionText = 'description has changed';
const e = { returnValue: null };
vm.handleBeforeUnloadEvent(e);
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-03-17 18:26:18 +05:30
expect(e.returnValue).not.toBeNull();
});
});
2020-05-24 23:13:21 +05:30
it('does nothing when nothing has changed', () => {
2018-03-17 18:26:18 +05:30
const e = { returnValue: null };
vm.handleBeforeUnloadEvent(e);
2020-05-24 23:13:21 +05:30
return vm.$nextTick().then(() => {
2018-03-17 18:26:18 +05:30
expect(e.returnValue).toBeNull();
});
});
});
describe('error when updating', () => {
2020-05-24 23:13:21 +05:30
it('closes form on error', () => {
jest.spyOn(vm.service, 'updateIssuable').mockRejectedValue();
return vm.updateIssuable().then(() => {
2019-03-02 22:35:43 +05:30
expect(eventHub.$emit).not.toHaveBeenCalledWith('close.form');
expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
`Error updating issue`,
);
2018-03-17 18:26:18 +05:30
});
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
it('returns the correct error message for issuableType', () => {
jest.spyOn(vm.service, 'updateIssuable').mockRejectedValue();
2018-03-17 18:26:18 +05:30
vm.issuableType = 'merge request';
2020-05-24 23:13:21 +05:30
return vm
.$nextTick()
.then(vm.updateIssuable)
.then(() => {
2019-03-02 22:35:43 +05:30
expect(eventHub.$emit).not.toHaveBeenCalledWith('close.form');
expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
`Error updating merge request`,
);
2018-03-17 18:26:18 +05:30
});
2017-09-10 17:25:29 +05:30
});
2019-03-02 22:35:43 +05:30
2020-05-24 23:13:21 +05:30
it('shows error message from backend if exists', () => {
2019-03-02 22:35:43 +05:30
const msg = 'Custom error message from backend';
2020-05-24 23:13:21 +05:30
jest
.spyOn(vm.service, 'updateIssuable')
.mockRejectedValue({ response: { data: { errors: [msg] } } });
2019-03-02 22:35:43 +05:30
2020-05-24 23:13:21 +05:30
return vm.updateIssuable().then(() => {
2019-03-02 22:35:43 +05:30
expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
`${vm.defaultErrorMessage}. ${msg}`,
);
});
});
2017-09-10 17:25:29 +05:30
});
2018-03-17 18:26:18 +05:30
});
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
describe('deleteIssuable', () => {
it('changes URL when deleted', () => {
jest.spyOn(vm.service, 'deleteIssuable').mockResolvedValue({
2018-03-17 18:26:18 +05:30
data: {
2020-05-24 23:13:21 +05:30
web_url: '/test',
2018-03-17 18:26:18 +05:30
},
2017-09-10 17:25:29 +05:30
});
2018-03-17 18:26:18 +05:30
2020-05-24 23:13:21 +05:30
return vm.deleteIssuable().then(() => {
2018-10-15 14:42:47 +05:30
expect(visitUrl).toHaveBeenCalledWith('/test');
2017-09-10 17:25:29 +05:30
});
});
2020-05-24 23:13:21 +05:30
it('stops polling when deleting', () => {
const spy = jest.spyOn(vm.poll, 'stop');
jest.spyOn(vm.service, 'deleteIssuable').mockResolvedValue({
data: {
web_url: '/test',
},
});
2019-03-02 22:35:43 +05:30
2020-05-24 23:13:21 +05:30
return vm.deleteIssuable().then(() => {
expect(spy).toHaveBeenCalledWith();
2017-09-10 17:25:29 +05:30
});
});
2020-05-24 23:13:21 +05:30
it('closes form on error', () => {
jest.spyOn(vm.service, 'deleteIssuable').mockRejectedValue();
2017-09-10 17:25:29 +05:30
2020-05-24 23:13:21 +05:30
return vm.deleteIssuable().then(() => {
2019-03-02 22:35:43 +05:30
expect(eventHub.$emit).not.toHaveBeenCalledWith('close.form');
expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
'Error deleting issue',
);
2017-09-10 17:25:29 +05:30
});
});
});
2019-12-21 20:55:43 +05:30
describe('updateAndShowForm', () => {
2020-05-24 23:13:21 +05:30
it('shows locked warning if form is open & data is different', () => {
return vm
.$nextTick()
2017-09-10 17:25:29 +05:30
.then(() => {
2019-12-21 20:55:43 +05:30
vm.updateAndShowForm();
2017-09-10 17:25:29 +05:30
vm.poll.makeRequest();
2019-12-21 20:55:43 +05:30
return new Promise(resolve => {
vm.$watch('formState.lockedWarningVisible', value => {
if (value) resolve();
});
});
2017-09-10 17:25:29 +05:30
})
.then(() => {
2018-03-17 18:26:18 +05:30
expect(vm.formState.lockedWarningVisible).toEqual(true);
2019-03-02 22:35:43 +05:30
expect(vm.formState.lock_version).toEqual(1);
2018-03-17 18:26:18 +05:30
expect(vm.$el.querySelector('.alert')).not.toBeNull();
2020-05-24 23:13:21 +05:30
});
2017-09-10 17:25:29 +05:30
});
});
2018-03-17 18:26:18 +05:30
2019-12-21 20:55:43 +05:30
describe('requestTemplatesAndShowForm', () => {
2020-05-24 23:13:21 +05:30
let formSpy;
2019-12-21 20:55:43 +05:30
beforeEach(() => {
2020-05-24 23:13:21 +05:30
formSpy = jest.spyOn(vm, 'updateAndShowForm');
2019-12-21 20:55:43 +05:30
});
2020-05-24 23:13:21 +05:30
it('shows the form if template names request is successful', () => {
2019-12-21 20:55:43 +05:30
const mockData = [{ name: 'Bug' }];
mock.onGet('/issuable-templates-path').reply(() => Promise.resolve([200, mockData]));
2020-05-24 23:13:21 +05:30
return vm.requestTemplatesAndShowForm().then(() => {
expect(formSpy).toHaveBeenCalledWith(mockData);
});
2019-12-21 20:55:43 +05:30
});
2020-05-24 23:13:21 +05:30
it('shows the form if template names request failed', () => {
2019-12-21 20:55:43 +05:30
mock
.onGet('/issuable-templates-path')
.reply(() => Promise.reject(new Error('something went wrong')));
2020-05-24 23:13:21 +05:30
return vm.requestTemplatesAndShowForm().then(() => {
expect(document.querySelector('.flash-container .flash-text').textContent).toContain(
'Error updating issue',
);
2019-12-21 20:55:43 +05:30
2020-05-24 23:13:21 +05:30
expect(formSpy).toHaveBeenCalledWith();
});
2019-12-21 20:55:43 +05:30
});
});
2018-03-17 18:26:18 +05:30
describe('show inline edit button', () => {
it('should not render by default', () => {
expect(vm.$el.querySelector('.title-container .note-action-button')).toBeDefined();
});
it('should render if showInlineEditButton', () => {
vm.showInlineEditButton = true;
2018-12-13 13:39:08 +05:30
2018-03-17 18:26:18 +05:30
expect(vm.$el.querySelector('.title-container .note-action-button')).toBeDefined();
});
});
2019-03-02 22:35:43 +05:30
describe('updateStoreState', () => {
2020-05-24 23:13:21 +05:30
it('should make a request and update the state of the store', () => {
2019-03-02 22:35:43 +05:30
const data = { foo: 1 };
2020-05-24 23:13:21 +05:30
const getDataSpy = jest.spyOn(vm.service, 'getData').mockResolvedValue({ data });
const updateStateSpy = jest.spyOn(vm.store, 'updateState').mockImplementation(jest.fn);
2019-03-02 22:35:43 +05:30
2020-05-24 23:13:21 +05:30
return vm.updateStoreState().then(() => {
expect(getDataSpy).toHaveBeenCalled();
expect(updateStateSpy).toHaveBeenCalledWith(data);
});
2019-03-02 22:35:43 +05:30
});
2020-05-24 23:13:21 +05:30
it('should show error message if store update fails', () => {
jest.spyOn(vm.service, 'getData').mockRejectedValue();
2019-03-02 22:35:43 +05:30
vm.issuableType = 'merge request';
2020-05-24 23:13:21 +05:30
return vm.updateStoreState().then(() => {
expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
`Error updating ${vm.issuableType}`,
);
});
2019-03-02 22:35:43 +05:30
});
});
2019-07-31 22:56:46 +05:30
describe('issueChanged', () => {
beforeEach(() => {
vm.store.formState.title = '';
vm.store.formState.description = '';
vm.initialDescriptionText = '';
vm.initialTitleText = '';
});
it('returns true when title is changed', () => {
vm.store.formState.title = 'RandomText';
expect(vm.issueChanged).toBe(true);
});
it('returns false when title is empty null', () => {
vm.store.formState.title = null;
expect(vm.issueChanged).toBe(false);
});
it('returns false when `initialTitleText` is null and `formState.title` is empty string', () => {
vm.store.formState.title = '';
vm.initialTitleText = null;
expect(vm.issueChanged).toBe(false);
});
it('returns true when description is changed', () => {
vm.store.formState.description = 'RandomText';
expect(vm.issueChanged).toBe(true);
});
it('returns false when description is empty null', () => {
vm.store.formState.title = null;
expect(vm.issueChanged).toBe(false);
});
it('returns false when `initialDescriptionText` is null and `formState.description` is empty string', () => {
vm.store.formState.description = '';
vm.initialDescriptionText = null;
expect(vm.issueChanged).toBe(false);
});
});
2017-09-10 17:25:29 +05:30
});