debian-mirror-gitlab/spec/controllers/groups/milestones_controller_spec.rb

475 lines
16 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2015-12-23 02:04:40 +05:30
require 'spec_helper'
describe Groups::MilestonesController do
2019-09-30 23:59:55 +05:30
let(:group) { create(:group, :public) }
let!(:project) { create(:project, :public, group: group) }
2017-09-10 17:25:29 +05:30
let!(:project2) { create(:project, group: group) }
2015-12-23 02:04:40 +05:30
let(:user) { create(:user) }
let(:title) { '肯定不是中文的问题' }
2017-08-17 22:00:37 +05:30
let(:milestone) do
project_milestone = create(:milestone, project: project)
GroupMilestone.build(
group,
[project],
project_milestone.title
)
end
let(:milestone_path) { group_milestone_path(group, milestone.safe_title, title: milestone.title) }
2015-12-23 02:04:40 +05:30
2017-09-10 17:25:29 +05:30
let(:milestone_params) do
{
title: title,
start_date: Date.today,
due_date: 1.month.from_now.to_date
}
end
2015-12-23 02:04:40 +05:30
before do
sign_in(user)
group.add_owner(user)
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2015-12-23 02:04:40 +05:30
end
2017-09-10 17:25:29 +05:30
describe '#index' do
2019-03-02 22:35:43 +05:30
describe 'as HTML' do
render_views
2017-09-10 17:25:29 +05:30
2019-03-02 22:35:43 +05:30
it 'shows group milestones page' do
milestone
get :index, params: { group_id: group.to_param }
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-03-02 22:35:43 +05:30
expect(response.body).to include(milestone.title)
end
it 'searches legacy milestones by title when search_title is given' do
project_milestone = create(:milestone, project: project, title: 'Project milestone title')
get :index, params: { group_id: group.to_param, search_title: 'Project mil' }
expect(response.body).to include(project_milestone.title)
expect(response.body).not_to include(milestone.title)
end
it 'searches group milestones by title when search_title is given' do
group_milestone = create(:milestone, title: 'Group milestone title', group: group)
get :index, params: { group_id: group.to_param, search_title: 'Group mil' }
expect(response.body).to include(group_milestone.title)
expect(response.body).not_to include(milestone.title)
end
2019-09-30 23:59:55 +05:30
context 'when anonymous user' do
before do
sign_out(user)
end
it 'shows group milestones page' do
milestone
get :index, params: { group_id: group.to_param }
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-09-30 23:59:55 +05:30
expect(response.body).to include(milestone.title)
end
end
context 'when issues and merge requests are disabled in public project' do
shared_examples 'milestone not accessible' do
it 'does not return milestone' do
get :index, params: { group_id: public_group.to_param }
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-09-30 23:59:55 +05:30
expect(response.body).not_to include(private_milestone.title)
end
end
let!(:public_group) { create(:group, :public) }
let!(:public_project_with_private_issues_and_mrs) do
create(:project, :public, :issues_private, :merge_requests_private, group: public_group)
end
let!(:private_milestone) { create(:milestone, project: public_project_with_private_issues_and_mrs, title: 'project milestone') }
context 'when anonymous user' do
before do
sign_out(user)
end
it_behaves_like 'milestone not accessible'
end
context 'when non project or group member user' do
let(:non_member) { create(:user) }
before do
sign_in(non_member)
end
it_behaves_like 'milestone not accessible'
end
context 'when group member user' do
let(:member) { create(:user) }
before do
sign_in(member)
public_group.add_guest(member)
end
it 'returns the milestone' do
get :index, params: { group_id: public_group.to_param }
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-09-30 23:59:55 +05:30
expect(response.body).to include(private_milestone.title)
end
end
end
2020-03-13 15:44:24 +05:30
context 'when subgroup milestones are present' do
let(:subgroup) { create(:group, :private, parent: group) }
let(:sub_project) { create(:project, :private, group: subgroup) }
let!(:group_milestone) { create(:milestone, group: group, title: 'Group milestone') }
let!(:sub_project_milestone) { create(:milestone, project: sub_project, title: 'Sub Project Milestone') }
let!(:subgroup_milestone) { create(:milestone, title: 'Subgroup Milestone', group: subgroup) }
it 'shows subgroup milestones that user has access to' do
get :index, params: { group_id: group.to_param }
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).to include(group_milestone.title)
expect(response.body).to include(sub_project_milestone.title)
expect(response.body).to include(subgroup_milestone.title)
end
context 'when user has no access to subgroups' do
let(:non_member) { create(:user) }
before do
sign_in(non_member)
end
it 'does not show subgroup milestones' do
get :index, params: { group_id: group.to_param }
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).to include(group_milestone.title)
expect(response.body).not_to include(sub_project_milestone.title)
expect(response.body).not_to include(subgroup_milestone.title)
end
end
end
2017-09-10 17:25:29 +05:30
end
context 'as JSON' do
let!(:milestone) { create(:milestone, group: group, title: 'group milestone') }
let!(:legacy_milestone1) { create(:milestone, project: project, title: 'legacy') }
let!(:legacy_milestone2) { create(:milestone, project: project2, title: 'legacy') }
it 'lists legacy group milestones and group milestones' do
2019-02-15 15:39:39 +05:30
get :index, params: { group_id: group.to_param }, format: :json
2017-09-10 17:25:29 +05:30
2019-09-30 21:07:59 +05:30
milestones = json_response
2017-09-10 17:25:29 +05:30
expect(milestones.count).to eq(2)
expect(milestones.first["title"]).to eq("group milestone")
expect(milestones.second["title"]).to eq("legacy")
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-09-10 17:25:29 +05:30
expect(response.content_type).to eq 'application/json'
end
2020-03-13 15:44:24 +05:30
context 'with subgroup milestones' do
it 'lists descendants group milestones' do
subgroup = create(:group, :public, parent: group)
create(:milestone, group: subgroup, title: 'subgroup milestone')
get :index, params: { group_id: group.to_param }, format: :json
milestones = json_response
expect(milestones.count).to eq(3)
expect(milestones.second["title"]).to eq("subgroup milestone")
end
end
context 'for a subgroup' do
let(:subgroup) { create(:group, parent: group) }
it 'includes ancestor group milestones' do
get :index, params: { group_id: subgroup.to_param }, format: :json
milestones = json_response
expect(milestones.count).to eq(1)
expect(milestones.first['title']).to eq('group milestone')
end
end
2017-09-10 17:25:29 +05:30
end
2019-07-07 11:18:12 +05:30
context 'external authorization' do
subject { get :index, params: { group_id: group.to_param } }
it_behaves_like 'disabled when using an external authorization service'
end
2017-09-10 17:25:29 +05:30
end
describe '#show' do
let(:milestone1) { create(:milestone, project: project, title: 'legacy') }
let(:milestone2) { create(:milestone, project: project, title: 'legacy') }
let(:group_milestone) { create(:milestone, group: group) }
context 'when there is a title parameter' do
2018-12-13 13:39:08 +05:30
it 'searches for a legacy group milestone' do
2019-02-15 15:39:39 +05:30
expect(GroupMilestone).to receive(:build)
2017-09-10 17:25:29 +05:30
expect(Milestone).not_to receive(:find_by_iid)
2019-02-15 15:39:39 +05:30
get :show, params: { group_id: group.to_param, id: title, title: milestone1.safe_title }
2017-09-10 17:25:29 +05:30
end
end
context 'when there is not a title parameter' do
2018-12-13 13:39:08 +05:30
it 'searches for a group milestone' do
2017-09-10 17:25:29 +05:30
expect(GlobalMilestone).not_to receive(:build)
expect(Milestone).to receive(:find_by_iid)
2019-02-15 15:39:39 +05:30
get :show, params: { group_id: group.to_param, id: group_milestone.id }
2017-09-10 17:25:29 +05:30
end
end
end
2017-08-17 22:00:37 +05:30
it_behaves_like 'milestone tabs'
2015-12-23 02:04:40 +05:30
describe "#create" do
2016-09-13 17:45:13 +05:30
it "creates group milestone with Chinese title" do
2015-12-23 02:04:40 +05:30
post :create,
2019-02-15 15:39:39 +05:30
params: {
group_id: group.to_param,
milestone: milestone_params
}
2017-09-10 17:25:29 +05:30
milestone = Milestone.find_by_title(title)
expect(response).to redirect_to(group_milestone_path(group, milestone.iid))
expect(milestone.group_id).to eq(group.id)
expect(milestone.due_date).to eq(milestone_params[:due_date])
expect(milestone.start_date).to eq(milestone_params[:start_date])
end
end
describe "#update" do
let(:milestone) { create(:milestone, group: group) }
it "updates group milestone" do
milestone_params[:title] = "title changed"
put :update,
2019-02-15 15:39:39 +05:30
params: {
id: milestone.iid,
group_id: group.to_param,
milestone: milestone_params
}
2015-12-23 02:04:40 +05:30
2017-09-10 17:25:29 +05:30
milestone.reload
expect(response).to redirect_to(group_milestone_path(group, milestone.iid))
expect(milestone.title).to eq("title changed")
2015-12-23 02:04:40 +05:30
end
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
context "legacy group milestones" do
let!(:milestone1) { create(:milestone, project: project, title: 'legacy milestone', description: "old description") }
let!(:milestone2) { create(:milestone, project: project2, title: 'legacy milestone', description: "old description") }
it "updates only group milestones state" do
milestone_params[:title] = "title changed"
milestone_params[:description] = "description changed"
milestone_params[:state_event] = "close"
put :update,
2019-02-15 15:39:39 +05:30
params: {
id: milestone1.title.to_slug.to_s,
group_id: group.to_param,
milestone: milestone_params,
title: milestone1.title
}
2017-09-10 17:25:29 +05:30
expect(response).to redirect_to(group_milestone_path(group, milestone1.safe_title, title: milestone1.title))
[milestone1, milestone2].each do |milestone|
milestone.reload
expect(milestone.title).to eq("legacy milestone")
expect(milestone.description).to eq("old description")
expect(milestone.state).to eq("closed")
end
end
2016-06-02 11:05:42 +05:30
end
2015-12-23 02:04:40 +05:30
end
2017-08-17 22:00:37 +05:30
2018-11-20 20:47:30 +05:30
describe "#destroy" do
let(:milestone) { create(:milestone, group: group) }
it "removes milestone" do
2019-02-15 15:39:39 +05:30
delete :destroy, params: { group_id: group.to_param, id: milestone.iid }, format: :js
2018-11-20 20:47:30 +05:30
2019-12-04 20:38:33 +05:30
expect(response).to be_successful
2018-11-20 20:47:30 +05:30
expect { Milestone.find(milestone.id) }.to raise_exception(ActiveRecord::RecordNotFound)
end
end
2017-08-17 22:00:37 +05:30
describe '#ensure_canonical_path' do
before do
sign_in(user)
end
context 'for a GET request' do
context 'when requesting the canonical path' do
context 'non-show path' do
context 'with exactly matching casing' do
it 'does not redirect' do
2019-02-15 15:39:39 +05:30
get :index, params: { group_id: group.to_param }
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).not_to have_gitlab_http_status(:moved_permanently)
2017-08-17 22:00:37 +05:30
end
end
context 'with different casing' do
it 'redirects to the correct casing' do
2019-02-15 15:39:39 +05:30
get :index, params: { group_id: group.to_param.upcase }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(group_milestones_path(group.to_param))
expect(controller).not_to set_flash[:notice]
end
end
end
context 'show path' do
context 'with exactly matching casing' do
it 'does not redirect' do
2019-02-15 15:39:39 +05:30
get :show, params: { group_id: group.to_param, id: title }
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).not_to have_gitlab_http_status(:moved_permanently)
2017-08-17 22:00:37 +05:30
end
end
context 'with different casing' do
it 'redirects to the correct casing' do
2019-02-15 15:39:39 +05:30
get :show, params: { group_id: group.to_param.upcase, id: title }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(group_milestone_path(group.to_param, title))
expect(controller).not_to set_flash[:notice]
end
end
end
end
context 'when requesting a redirected path' do
let(:redirect_route) { group.redirect_routes.create(path: 'old-path') }
it 'redirects to the canonical path' do
2019-02-15 15:39:39 +05:30
get :merge_requests, params: { group_id: redirect_route.path, id: title }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
end
2019-12-26 22:10:19 +05:30
context 'with an AJAX request' do
it 'redirects to the canonical path but does not set flash message' do
get :merge_requests, params: { group_id: redirect_route.path, id: title }, xhr: true
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
expect(controller).not_to set_flash[:notice]
end
end
context 'with JSON format' do
it 'redirects to the canonical path but does not set flash message' do
get :merge_requests, params: { group_id: redirect_route.path, id: title }, format: :json
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title, format: :json))
expect(controller).not_to set_flash[:notice]
end
end
2017-08-17 22:00:37 +05:30
context 'when the old group path is a substring of the scheme or host' do
let(:redirect_route) { group.redirect_routes.create(path: 'http') }
it 'does not modify the requested host' do
2019-02-15 15:39:39 +05:30
get :merge_requests, params: { group_id: redirect_route.path, id: title }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
end
end
context 'when the old group path is substring of groups' do
# I.e. /groups/oups should not become /grfoo/oups
let(:redirect_route) { group.redirect_routes.create(path: 'oups') }
it 'does not modify the /groups part of the path' do
2019-02-15 15:39:39 +05:30
get :merge_requests, params: { group_id: redirect_route.path, id: title }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
end
end
context 'when the old group path is substring of groups plus the new path' do
# I.e. /groups/oups/oup should not become /grfoos
let(:redirect_route) { group.redirect_routes.create(path: 'oups/oup') }
it 'does not modify the /groups part of the path' do
2019-02-15 15:39:39 +05:30
get :merge_requests, params: { group_id: redirect_route.path, id: title }
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
end
end
end
end
end
context 'for a non-GET request' do
context 'when requesting the canonical path with different casing' do
it 'does not 404' do
post :create,
2019-02-15 15:39:39 +05:30
params: {
group_id: group.to_param,
milestone: { title: title }
}
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).not_to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
it 'does not redirect to the correct casing' do
post :create,
2019-02-15 15:39:39 +05:30
params: {
group_id: group.to_param,
milestone: { title: title }
}
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).not_to have_gitlab_http_status(:moved_permanently)
2017-08-17 22:00:37 +05:30
end
end
context 'when requesting a redirected path' do
let(:redirect_route) { group.redirect_routes.create(path: 'old-path') }
it 'returns not found' do
post :create,
2019-02-15 15:39:39 +05:30
params: {
group_id: redirect_route.path,
milestone: { title: title }
}
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
end
def group_moved_message(redirect_route, group)
"Group '#{redirect_route.path}' was moved to '#{group.full_path}'. Please update any links and bookmarks that may still have the old path."
end
2015-12-23 02:04:40 +05:30
end