debian-mirror-gitlab/spec/services/projects/update_service_spec.rb

163 lines
5.5 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
require 'spec_helper'
2017-09-10 17:25:29 +05:30
describe Projects::UpdateService, '#execute' do
let(:gitlab_shell) { Gitlab::Shell.new }
2017-08-17 22:00:37 +05:30
let(:user) { create(:user) }
let(:admin) { create(:admin) }
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
let(:project) do
create(:project, creator: user, namespace: user.namespace)
end
context 'when changing visibility level' do
2017-08-17 22:00:37 +05:30
context 'when visibility_level is INTERNAL' do
it 'updates the project to internal' do
result = update_project(project, user, visibility_level: Gitlab::VisibilityLevel::INTERNAL)
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
expect(result).to eq({ status: :success })
expect(project).to be_internal
2014-09-02 18:07:02 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'when visibility_level is PUBLIC' do
it 'updates the project to public' do
result = update_project(project, user, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
expect(result).to eq({ status: :success })
expect(project).to be_public
2014-09-02 18:07:02 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'when visibility levels are restricted to PUBLIC only' do
2014-09-02 18:07:02 +05:30
before do
2015-09-11 14:41:01 +05:30
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
2014-09-02 18:07:02 +05:30
end
2017-08-17 22:00:37 +05:30
context 'when visibility_level is INTERNAL' do
it 'updates the project to internal' do
result = update_project(project, user, visibility_level: Gitlab::VisibilityLevel::INTERNAL)
expect(result).to eq({ status: :success })
expect(project).to be_internal
2014-09-02 18:07:02 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'when visibility_level is PUBLIC' do
it 'does not update the project to public' do
result = update_project(project, user, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
expect(result).to eq({ status: :error, message: 'New visibility level not allowed!' })
2017-08-17 22:00:37 +05:30
expect(project).to be_private
2014-09-02 18:07:02 +05:30
end
2017-08-17 22:00:37 +05:30
context 'when updated by an admin' do
it 'updates the project to public' do
result = update_project(project, admin, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
expect(result).to eq({ status: :success })
expect(project).to be_public
end
2014-09-02 18:07:02 +05:30
end
end
end
end
2017-09-10 17:25:29 +05:30
describe 'when updating project that has forks' do
let(:project) { create(:project, :internal) }
2016-06-02 11:05:42 +05:30
let(:forked_project) { create(:forked_project_with_submodules, :internal) }
before do
2017-09-10 17:25:29 +05:30
forked_project.build_forked_project_link(forked_to_project_id: forked_project.id,
forked_from_project_id: project.id)
forked_project.save
end
2017-08-17 22:00:37 +05:30
it 'updates forks visibility level when parent set to more restrictive' do
opts = { visibility_level: Gitlab::VisibilityLevel::PRIVATE }
expect(project).to be_internal
expect(forked_project).to be_internal
2017-08-17 22:00:37 +05:30
expect(update_project(project, admin, opts)).to eq({ status: :success })
expect(project).to be_private
expect(forked_project.reload).to be_private
end
2017-08-17 22:00:37 +05:30
it 'does not update forks visibility level when parent set to less restrictive' do
opts = { visibility_level: Gitlab::VisibilityLevel::PUBLIC }
expect(project).to be_internal
expect(forked_project).to be_internal
2017-08-17 22:00:37 +05:30
expect(update_project(project, admin, opts)).to eq({ status: :success })
expect(project).to be_public
expect(forked_project.reload).to be_internal
end
end
2017-09-10 17:25:29 +05:30
context 'when updating a default branch' do
let(:project) { create(:project, :repository) }
it 'changes a default branch' do
update_project(project, admin, default_branch: 'feature')
expect(Project.find(project.id).default_branch).to eq 'feature'
end
end
context 'when updating a project that contains container images' do
before do
stub_container_registry_config(enabled: true)
stub_container_registry_tags(repository: /image/, tags: %w[rc1])
create(:container_repository, project: project, name: :image)
end
it 'does not allow to rename the project' do
result = update_project(project, admin, path: 'renamed')
expect(result).to include(status: :error)
expect(result[:message]).to match(/contains container registry tags/)
end
it 'allows to update other settings' do
result = update_project(project, admin, public_builds: true)
expect(result[:status]).to eq :success
expect(project.reload.public_builds).to be true
end
end
context 'when renaming a project' do
let(:repository_storage_path) { Gitlab.config.repositories.storages['default']['path'] }
before do
gitlab_shell.add_repository(repository_storage_path, "#{user.namespace.full_path}/existing")
end
after do
gitlab_shell.remove_repository(repository_storage_path, "#{user.namespace.full_path}/existing")
end
it 'does not allow renaming when new path matches existing repository on disk' do
result = update_project(project, admin, path: 'existing')
expect(result).to include(status: :error)
expect(result[:message]).to include('Cannot rename project')
expect(project.errors.messages).to have_key(:base)
expect(project.errors.messages[:base]).to include('There is already a repository with that name on disk')
end
end
context 'when passing invalid parameters' do
it 'returns an error result when record cannot be updated' do
result = update_project(project, admin, { name: 'foo&bar' })
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(result).to eq({ status: :error,
message: 'Project could not be updated!' })
end
2017-08-17 22:00:37 +05:30
end
2014-09-02 18:07:02 +05:30
def update_project(project, user, opts)
2017-08-17 22:00:37 +05:30
described_class.new(project, user, opts).execute
2014-09-02 18:07:02 +05:30
end
end