2019-02-15 15:39:39 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Projects::Serverless::FunctionsController do
|
|
|
|
include KubernetesHelpers
|
|
|
|
include ReactiveCachingHelpers
|
|
|
|
|
|
|
|
let(:user) { create(:user) }
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
let(:cluster) { create(:cluster, :project, :provided_by_gcp, projects: [project]) }
|
2019-02-15 15:39:39 +05:30
|
|
|
let(:service) { cluster.platform_kubernetes }
|
2019-10-12 21:52:04 +05:30
|
|
|
let(:environment) { create(:environment, project: project) }
|
|
|
|
let!(:deployment) { create(:deployment, :success, environment: environment, cluster: cluster) }
|
|
|
|
let(:knative_services_finder) { environment.knative_services_finder }
|
2019-12-26 22:10:19 +05:30
|
|
|
let(:function_description) { 'A serverless function' }
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:function_name) { 'some-function-name' }
|
2019-12-26 22:10:19 +05:30
|
|
|
let(:knative_stub_options) do
|
2020-03-13 15:44:24 +05:30
|
|
|
{ namespace: namespace.namespace, name: function_name, description: function_description }
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:knative) { create(:clusters_applications_knative, :installed, cluster: cluster) }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
let(:namespace) do
|
|
|
|
create(:cluster_kubernetes_namespace,
|
|
|
|
cluster: cluster,
|
|
|
|
cluster_project: cluster.cluster_project,
|
2019-10-12 21:52:04 +05:30
|
|
|
project: cluster.cluster_project.project,
|
|
|
|
environment: environment)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_maintainer(user)
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def params(opts = {})
|
|
|
|
opts.reverse_merge(namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #index' do
|
2019-09-04 21:01:54 +05:30
|
|
|
let(:expected_json) { { 'knative_installed' => knative_state, 'functions' => functions } }
|
|
|
|
|
|
|
|
context 'when cache is being read' do
|
|
|
|
let(:knative_state) { 'checking' }
|
|
|
|
let(:functions) { [] }
|
|
|
|
|
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get :index, params: params({ format: :json })
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
it 'returns checking' do
|
|
|
|
expect(json_response).to eq expected_json
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { expect(response).to have_gitlab_http_status(:ok) }
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when cache is ready' do
|
|
|
|
let(:knative_state) { true }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
before do
|
2019-10-12 21:52:04 +05:30
|
|
|
allow(Clusters::KnativeServicesFinder)
|
|
|
|
.to receive(:new)
|
2019-09-04 21:01:54 +05:30
|
|
|
.and_return(knative_services_finder)
|
|
|
|
synchronous_reactive_cache(knative_services_finder)
|
|
|
|
stub_kubeclient_service_pods(
|
|
|
|
kube_response({ "kind" => "PodList", "items" => [] }),
|
|
|
|
namespace: namespace.namespace
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no functions were found' do
|
|
|
|
let(:functions) { [] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_kubeclient_knative_services(
|
|
|
|
namespace: namespace.namespace,
|
|
|
|
response: kube_response({ "kind" => "ServiceList", "items" => [] })
|
|
|
|
)
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns checking' do
|
|
|
|
expect(json_response).to eq expected_json
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { expect(response).to have_gitlab_http_status(:ok) }
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when functions were found' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:functions) { [{}, {}] }
|
2019-09-04 21:01:54 +05:30
|
|
|
|
|
|
|
before do
|
2020-03-13 15:44:24 +05:30
|
|
|
stub_kubeclient_knative_services(namespace: namespace.namespace, cluster_id: cluster.id, name: function_name)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns functions' do
|
2020-03-13 15:44:24 +05:30
|
|
|
get :index, params: params({ format: :json })
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(json_response["functions"]).not_to be_empty
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'filters out the functions whose cluster the user does not have permission to read' do
|
|
|
|
allow(controller).to receive(:can?).and_return(true)
|
|
|
|
expect(controller).to receive(:can?).with(user, :read_cluster, cluster).and_return(false)
|
|
|
|
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
|
|
|
|
expect(json_response["functions"]).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a successful response status' do
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is serverless domain for a cluster' do
|
|
|
|
let!(:serverless_domain_cluster) do
|
|
|
|
create(:serverless_domain_cluster, clusters_applications_knative_id: knative.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns JSON with function details with serverless domain URL' do
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
|
|
|
|
expect(json_response["functions"]).not_to be_empty
|
|
|
|
|
|
|
|
expect(json_response["functions"]).to all(
|
|
|
|
include(
|
|
|
|
'url' => "https://#{function_name}-#{serverless_domain_cluster.uuid[0..1]}a1#{serverless_domain_cluster.uuid[2..-3]}f2#{serverless_domain_cluster.uuid[-2..-1]}#{"%x" % environment.id}-#{environment.slug}.#{serverless_domain_cluster.domain}"
|
|
|
|
)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no serverless domain for a cluster' do
|
|
|
|
it 'keeps function URL as it was' do
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(::Serverless::Domain).not_to receive(:new)
|
2020-03-13 15:44:24 +05:30
|
|
|
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-03-02 22:35:43 +05:30
|
|
|
describe 'GET #show' do
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'with function that does not exist' do
|
|
|
|
it 'returns 404' do
|
2019-03-02 22:35:43 +05:30
|
|
|
get :show, params: params({ format: :json, environment_id: "*", id: "foo" })
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-03-02 22:35:43 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
context 'with valid data', :use_clean_rails_memory_store_caching do
|
|
|
|
shared_examples 'GET #show with valid data' do
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'when there is serverless domain for a cluster' do
|
|
|
|
let!(:serverless_domain_cluster) do
|
|
|
|
create(:serverless_domain_cluster, clusters_applications_knative_id: knative.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns JSON with function details with serverless domain URL' do
|
|
|
|
get :show, params: params({ format: :json, environment_id: "*", id: function_name })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
|
|
|
|
expect(json_response).to include(
|
|
|
|
'url' => "https://#{function_name}-#{serverless_domain_cluster.uuid[0..1]}a1#{serverless_domain_cluster.uuid[2..-3]}f2#{serverless_domain_cluster.uuid[-2..-1]}#{"%x" % environment.id}-#{environment.slug}.#{serverless_domain_cluster.domain}"
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404 when user does not have permission to read the cluster' do
|
|
|
|
allow(controller).to receive(:can?).and_return(true)
|
|
|
|
expect(controller).to receive(:can?).with(user, :read_cluster, cluster).and_return(false)
|
|
|
|
|
|
|
|
get :show, params: params({ format: :json, environment_id: "*", id: function_name })
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no serverless domain for a cluster' do
|
|
|
|
it 'keeps function URL as it was' do
|
|
|
|
get :show, params: params({ format: :json, environment_id: "*", id: function_name })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
|
|
|
|
expect(json_response).to include(
|
|
|
|
'url' => "http://#{function_name}.#{namespace.namespace}.example.com"
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'return json with function details' do
|
|
|
|
get :show, params: params({ format: :json, environment_id: "*", id: function_name })
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-12-21 20:55:43 +05:30
|
|
|
|
|
|
|
expect(json_response).to include(
|
2020-03-13 15:44:24 +05:30
|
|
|
'name' => function_name,
|
|
|
|
'url' => "http://#{function_name}.#{namespace.namespace}.example.com",
|
2019-12-26 22:10:19 +05:30
|
|
|
'description' => function_description,
|
2020-03-13 15:44:24 +05:30
|
|
|
'podcount' => 0
|
2019-12-21 20:55:43 +05:30
|
|
|
)
|
|
|
|
end
|
2019-03-02 22:35:43 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'on Knative 0.5.0' do
|
|
|
|
before do
|
|
|
|
prepare_knative_stubs(knative_05_service(knative_stub_options))
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #show with valid data'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on Knative 0.6.0' do
|
2019-12-21 20:55:43 +05:30
|
|
|
before do
|
2019-12-26 22:10:19 +05:30
|
|
|
prepare_knative_stubs(knative_06_service(knative_stub_options))
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
2019-03-02 22:35:43 +05:30
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
include_examples 'GET #show with valid data'
|
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'on Knative 0.7.0' do
|
2019-12-21 20:55:43 +05:30
|
|
|
before do
|
2019-12-26 22:10:19 +05:30
|
|
|
prepare_knative_stubs(knative_07_service(knative_stub_options))
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #show with valid data'
|
2019-03-02 22:35:43 +05:30
|
|
|
end
|
2020-01-01 13:55:28 +05:30
|
|
|
|
|
|
|
context 'on Knative 0.9.0' do
|
|
|
|
before do
|
|
|
|
prepare_knative_stubs(knative_09_service(knative_stub_options))
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #show with valid data'
|
|
|
|
end
|
2019-03-02 22:35:43 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
describe 'GET #metrics' do
|
|
|
|
context 'invalid data' do
|
|
|
|
it 'has a bad function name' do
|
|
|
|
get :metrics, params: params({ format: :json, environment_id: "*", id: "foo" })
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:no_content)
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
describe 'GET #index with data', :use_clean_rails_memory_store_caching do
|
2019-12-21 20:55:43 +05:30
|
|
|
shared_examples 'GET #index with data' do
|
|
|
|
it 'has data' do
|
|
|
|
get :index, params: params({ format: :json })
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-12-21 20:55:43 +05:30
|
|
|
|
|
|
|
expect(json_response).to match({
|
2019-12-26 22:10:19 +05:30
|
|
|
'knative_installed' => 'checking',
|
|
|
|
'functions' => [
|
2019-12-21 20:55:43 +05:30
|
|
|
a_hash_including(
|
2020-03-13 15:44:24 +05:30
|
|
|
'name' => function_name,
|
|
|
|
'url' => "http://#{function_name}.#{namespace.namespace}.example.com",
|
2019-12-26 22:10:19 +05:30
|
|
|
'description' => function_description
|
2019-12-21 20:55:43 +05:30
|
|
|
)
|
|
|
|
]
|
|
|
|
})
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has data in html' do
|
|
|
|
get :index, params: params
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'on Knative 0.5.0' do
|
2019-12-21 20:55:43 +05:30
|
|
|
before do
|
2019-12-26 22:10:19 +05:30
|
|
|
prepare_knative_stubs(knative_05_service(knative_stub_options))
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #index with data'
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context 'on Knative 0.6.0' do
|
2019-12-21 20:55:43 +05:30
|
|
|
before do
|
2019-12-26 22:10:19 +05:30
|
|
|
prepare_knative_stubs(knative_06_service(knative_stub_options))
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
include_examples 'GET #index with data'
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
context 'on Knative 0.7.0' do
|
|
|
|
before do
|
|
|
|
prepare_knative_stubs(knative_07_service(knative_stub_options))
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #index with data'
|
|
|
|
end
|
2020-01-01 13:55:28 +05:30
|
|
|
|
|
|
|
context 'on Knative 0.9.0' do
|
|
|
|
before do
|
|
|
|
prepare_knative_stubs(knative_09_service(knative_stub_options))
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'GET #index with data'
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def prepare_knative_stubs(knative_service)
|
|
|
|
stub_kubeclient_service_pods
|
|
|
|
stub_reactive_cache(knative_services_finder,
|
|
|
|
{
|
|
|
|
services: [knative_service],
|
|
|
|
pods: kube_knative_pods_body(cluster.project.name, namespace.namespace)["items"]
|
|
|
|
},
|
|
|
|
*knative_services_finder.cache_args)
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|