2020-04-08 14:13:33 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'fast_spec_helper'
|
|
|
|
require 'rspec-parameterized'
|
2023-04-23 21:23:45 +05:30
|
|
|
require 'rubocop/ast'
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
require_relative '../../rubocop/migration_helpers'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe RuboCop::MigrationHelpers do
|
2020-04-08 14:13:33 +05:30
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
subject(:fake_cop) { Class.new { include RuboCop::MigrationHelpers }.new }
|
|
|
|
|
|
|
|
let(:node) { double(:node) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(node).to receive_message_chain('location.expression.source_buffer.name')
|
|
|
|
.and_return(name)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#in_migration?' do
|
|
|
|
where(:name, :expected) do
|
|
|
|
'/gitlab/db/migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/post_migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/geo/migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/geo/post_migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/elsewhere/20200210184420_create_operations_scopes_table.rb' | false
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it { expect(fake_cop.in_migration?(node)).to eq(expected) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#in_post_deployment_migration?' do
|
|
|
|
where(:name, :expected) do
|
|
|
|
'/gitlab/db/migrate/20200210184420_create_operations_scopes_table.rb' | false
|
|
|
|
'/gitlab/db/post_migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/geo/migrate/20200210184420_create_operations_scopes_table.rb' | false
|
|
|
|
'/gitlab/db/geo/post_migrate/20200210184420_create_operations_scopes_table.rb' | true
|
|
|
|
'/gitlab/db/elsewhere/20200210184420_create_operations_scopes_table.rb' | false
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it { expect(fake_cop.in_post_deployment_migration?(node)).to eq(expected) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#version" do
|
|
|
|
let(:name) do
|
|
|
|
'/path/to/gitlab/db/migrate/20200210184420_create_operations_scopes_table.rb'
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(fake_cop.version(node)).to eq(20200210184420) }
|
|
|
|
end
|
2023-01-13 00:05:48 +05:30
|
|
|
|
|
|
|
describe '#time_enforced?' do
|
|
|
|
before do
|
|
|
|
allow(fake_cop).to receive(:name).and_return("TestCop")
|
|
|
|
allow(fake_cop).to receive(:config).and_return(double(for_cop: { 'EnforcedSince' => 20221018000000 }))
|
|
|
|
end
|
|
|
|
|
|
|
|
where(:name, :expected) do
|
|
|
|
'/gitlab/db/post_migrate/20200210184420_create_operations_scopes_table.rb' | false
|
|
|
|
'/gitlab/db/post_migrate/20220210184420_create_fake_table.rb' | false
|
|
|
|
'/gitlab/db/post_migrate/20221019184420_add_id_to_reports_table.rb' | true
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it { expect(fake_cop.time_enforced?(node)).to eq(expected) }
|
|
|
|
end
|
|
|
|
end
|
2023-04-23 21:23:45 +05:30
|
|
|
|
|
|
|
describe '#array_column?' do
|
|
|
|
let(:name) { nil }
|
|
|
|
let(:node) { double(:node, each_descendant: [pair_node]) }
|
|
|
|
let(:pair_node) { double(child_nodes: child_nodes) }
|
|
|
|
|
|
|
|
context 'when it matches array: true' do
|
|
|
|
let(:child_nodes) do
|
|
|
|
[
|
|
|
|
RuboCop::AST::SymbolNode.new(:sym, [:array]),
|
|
|
|
RuboCop::AST::Node.new(:true) # rubocop:disable Lint/BooleanSymbol
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(fake_cop.array_column?(node)).to eq(true) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when it matches a variable => 100' do
|
|
|
|
let(:child_nodes) { [RuboCop::AST::Node.new(:lvar, [:variable]), RuboCop::AST::IntNode.new(:int, [100])] }
|
|
|
|
|
|
|
|
it { expect(fake_cop.array_column?(node)).to eq(false) }
|
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|