2020-11-24 15:15:51 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
RSpec.describe 'Query.issue(id)', feature_category: :team_planning do
|
2020-11-24 15:15:51 +05:30
|
|
|
include GraphqlHelpers
|
|
|
|
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
let_it_be(:issue) { create(:issue, project: project) }
|
|
|
|
let_it_be(:current_user) { create(:user) }
|
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
let(:issue_params) { { 'id' => global_id_of(issue) } }
|
2020-11-24 15:15:51 +05:30
|
|
|
let(:issue_data) { graphql_data['issue'] }
|
|
|
|
let(:issue_fields) { all_graphql_fields_for('Issue'.classify) }
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
graphql_query_for('issue', issue_params, issue_fields)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a working graphql query' do
|
|
|
|
before do
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-03-11 19:13:27 +05:30
|
|
|
it_behaves_like 'a noteable graphql type we can query' do
|
|
|
|
let(:noteable) { issue }
|
|
|
|
let(:project) { issue.project }
|
|
|
|
let(:path_to_noteable) { [:issue] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_guest(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def query(fields)
|
|
|
|
graphql_query_for('issue', issue_params, fields)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'when the user does not have access to the issue' do
|
|
|
|
it 'returns nil' do
|
|
|
|
project.project_feature.update!(issues_access_level: ProjectFeature::PRIVATE)
|
|
|
|
|
|
|
|
post_graphql(query)
|
|
|
|
|
|
|
|
expect(issue_data).to be nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user does have access' do
|
|
|
|
before do
|
|
|
|
project.add_guest(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the issue' do
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
|
|
|
expect(issue_data).to include(
|
|
|
|
'title' => issue.title,
|
|
|
|
'description' => issue.description
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
context 'when selecting any single field' do
|
2020-11-24 15:15:51 +05:30
|
|
|
where(:field) do
|
|
|
|
scalar_fields_of('Issue').map { |name| [name] }
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it_behaves_like 'a working graphql query' do
|
|
|
|
let(:issue_fields) do
|
|
|
|
field
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
end
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
it "returns the issue and field #{params['field']}" do
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(issue_data.keys).to eq([field])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
context 'when selecting multiple fields' do
|
2021-01-29 00:20:46 +05:30
|
|
|
let(:issue_fields) { ['title', 'description', 'updatedBy { username }'] }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
it 'returns the issue with the specified fields' do
|
2020-11-24 15:15:51 +05:30
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect(issue_data.keys).to eq %w[title description updatedBy]
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(issue_data['title']).to eq(issue.title)
|
|
|
|
expect(issue_data['description']).to eq(issue.description)
|
2021-01-29 00:20:46 +05:30
|
|
|
expect(issue_data['updatedBy']['username']).to eq(issue.author.username)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when issue got moved' do
|
|
|
|
let_it_be(:issue_fields) { ['moved', 'movedTo { title }'] }
|
|
|
|
let_it_be(:new_issue) { create(:issue) }
|
|
|
|
let_it_be(:issue) { create(:issue, project: project, moved_to: new_issue) }
|
2022-07-16 23:28:13 +05:30
|
|
|
|
|
|
|
let(:issue_params) { { 'id' => global_id_of(issue) } }
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
before_all do
|
|
|
|
new_issue.project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns correct attributes' do
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect(issue_data.keys).to eq %w[moved movedTo]
|
2021-01-29 00:20:46 +05:30
|
|
|
expect(issue_data['moved']).to eq(true)
|
|
|
|
expect(issue_data['movedTo']['title']).to eq(new_issue.title)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
context 'when passed a non-issue gid' do
|
2021-04-17 20:07:23 +05:30
|
|
|
let(:mr) { create(:merge_request) }
|
2020-11-24 15:15:51 +05:30
|
|
|
|
|
|
|
it 'returns an error' do
|
|
|
|
gid = mr.to_global_id.to_s
|
|
|
|
issue_params['id'] = gid
|
|
|
|
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
|
|
|
expect(graphql_errors).not_to be nil
|
|
|
|
expect(graphql_errors.first['message']).to eq("\"#{gid}\" does not represent an instance of Issue")
|
|
|
|
end
|
|
|
|
end
|
2022-07-23 23:45:48 +05:30
|
|
|
|
|
|
|
context 'when selecting `closed_as_duplicate_of`' do
|
|
|
|
let(:issue_fields) { ['closedAsDuplicateOf { id }'] }
|
|
|
|
let(:duplicate_issue) { create(:issue, project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
issue.update!(duplicated_to_id: duplicate_issue.id)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the related issue' do
|
|
|
|
expect(issue_data['closedAsDuplicateOf']['id']).to eq(duplicate_issue.to_global_id.to_s)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'no permission to related issue' do
|
|
|
|
let(:duplicate_issue) { create(:issue) }
|
|
|
|
|
|
|
|
it 'does not return the related issue' do
|
|
|
|
expect(issue_data['closedAsDuplicateOf']).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
2023-04-23 21:23:45 +05:30
|
|
|
context 'when selecting `related_merge_requests`' do
|
|
|
|
let(:issue_fields) { ['relatedMergeRequests { nodes { id } }'] }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:mr_project) { project }
|
|
|
|
let!(:merge_request) do
|
|
|
|
attributes = {
|
|
|
|
author: user,
|
|
|
|
source_project: mr_project,
|
|
|
|
target_project: mr_project,
|
|
|
|
source_branch: 'master',
|
|
|
|
target_branch: 'test',
|
|
|
|
description: "See #{issue.to_reference}"
|
|
|
|
}
|
|
|
|
|
|
|
|
create(:merge_request, attributes).tap do |merge_request|
|
|
|
|
create(:note, :system, project: issue.project, noteable: issue,
|
|
|
|
author: user, note: merge_request.to_reference(full: true))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the related merge request' do
|
|
|
|
expect(issue_data['relatedMergeRequests']['nodes']).to include a_hash_including({
|
|
|
|
'id' => merge_request.to_global_id.to_s
|
|
|
|
})
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'no permission to related merge request' do
|
|
|
|
let_it_be(:mr_project) { create(:project, :private) }
|
|
|
|
|
|
|
|
it 'does not return the related merge request' do
|
|
|
|
expect(issue_data['relatedMergeRequests']['nodes']).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'when there is a confidential issue' do
|
|
|
|
let!(:confidential_issue) do
|
|
|
|
create(:issue, :confidential, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:issue_params) { { 'id' => confidential_issue.to_global_id.to_s } }
|
|
|
|
|
|
|
|
context 'when the user cannot see confidential issues' do
|
2021-02-22 17:27:13 +05:30
|
|
|
it 'returns nil' do
|
2020-11-24 15:15:51 +05:30
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
|
|
|
expect(issue_data).to be nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user can see confidential issues' do
|
|
|
|
it 'returns the confidential issue' do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: current_user)
|
|
|
|
|
|
|
|
expect(graphql_data.count).to eq(1)
|
|
|
|
expect(issue_data['confidential']).to be(true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|