2022-05-07 20:08:51 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'set'
|
|
|
|
require 'rubocop'
|
|
|
|
require 'yaml'
|
|
|
|
|
|
|
|
require_relative '../todo_dir'
|
2022-08-27 11:52:29 +05:30
|
|
|
require_relative '../cop_todo'
|
2022-10-11 01:57:18 +05:30
|
|
|
require_relative '../formatter/graceful_formatter'
|
2022-05-07 20:08:51 +05:30
|
|
|
|
|
|
|
module RuboCop
|
|
|
|
module Formatter
|
|
|
|
# This formatter dumps a YAML configuration file per cop rule
|
|
|
|
# into `.rubocop_todo/**/*.yml` which contains detected offenses.
|
|
|
|
#
|
|
|
|
# For example, this formatter stores offenses for `RSpec/VariableName`
|
|
|
|
# in `.rubocop_todo/rspec/variable_name.yml`.
|
|
|
|
class TodoFormatter < BaseFormatter
|
2022-07-23 23:45:48 +05:30
|
|
|
DEFAULT_BASE_DIRECTORY = File.expand_path('../../.rubocop_todo', __dir__)
|
|
|
|
|
|
|
|
class << self
|
|
|
|
attr_accessor :base_directory
|
|
|
|
end
|
|
|
|
|
|
|
|
self.base_directory = DEFAULT_BASE_DIRECTORY
|
|
|
|
|
|
|
|
def initialize(output, _options = {})
|
|
|
|
@directory = self.class.base_directory
|
2022-08-27 11:52:29 +05:30
|
|
|
@todos = Hash.new { |hash, cop_name| hash[cop_name] = CopTodo.new(cop_name) }
|
2022-05-07 20:08:51 +05:30
|
|
|
@todo_dir = TodoDir.new(directory)
|
2022-07-23 23:45:48 +05:30
|
|
|
@config_inspect_todo_dir = load_config_inspect_todo_dir
|
|
|
|
@config_old_todo_yml = load_config_old_todo_yml
|
2022-05-07 20:08:51 +05:30
|
|
|
check_multiple_configurations!
|
2022-11-25 23:54:43 +05:30
|
|
|
create_empty_todos(@config_inspect_todo_dir)
|
2022-05-07 20:08:51 +05:30
|
|
|
|
|
|
|
super
|
|
|
|
end
|
|
|
|
|
|
|
|
def file_finished(file, offenses)
|
|
|
|
return if offenses.empty?
|
|
|
|
|
|
|
|
file = relative_path(file)
|
|
|
|
|
|
|
|
offenses.map(&:cop_name).tally.each do |cop_name, offense_count|
|
|
|
|
@todos[cop_name].record(file, offense_count)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def finished(_inspected_files)
|
|
|
|
@todos.values.sort_by(&:cop_name).each do |todo|
|
2022-11-25 23:54:43 +05:30
|
|
|
next unless configure_and_validate_todo(todo)
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
path = @todo_dir.write(todo.cop_name, todo.to_yaml)
|
2022-05-07 20:08:51 +05:30
|
|
|
output.puts "Written to #{relative_path(path)}\n"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
def self.with_base_directory(directory)
|
|
|
|
old = base_directory
|
|
|
|
self.base_directory = directory
|
|
|
|
|
|
|
|
yield
|
|
|
|
ensure
|
|
|
|
self.base_directory = old
|
|
|
|
end
|
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
private
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
attr_reader :directory
|
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
def relative_path(path)
|
2022-07-23 23:45:48 +05:30
|
|
|
parent = File.expand_path('..', directory)
|
2022-05-07 20:08:51 +05:30
|
|
|
path.delete_prefix("#{parent}/")
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_multiple_configurations!
|
|
|
|
cop_names = @config_inspect_todo_dir.keys & @config_old_todo_yml.keys
|
|
|
|
return if cop_names.empty?
|
|
|
|
|
|
|
|
list = cop_names.sort.map { |cop_name| "- #{cop_name}" }.join("\n")
|
|
|
|
raise "Multiple configurations found for cops:\n#{list}\n"
|
|
|
|
end
|
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
# For each inspected cop TODO config create a TODO object to make sure
|
|
|
|
# the cop TODO config will be written even without any offenses.
|
|
|
|
def create_empty_todos(inspected_cop_config)
|
|
|
|
inspected_cop_config.each_key do |cop_name|
|
|
|
|
@todos[cop_name]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
def config_for(todo)
|
2022-05-07 20:08:51 +05:30
|
|
|
cop_name = todo.cop_name
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
@config_old_todo_yml[cop_name] || @config_inspect_todo_dir[cop_name] || {}
|
|
|
|
end
|
|
|
|
|
|
|
|
def previously_disabled?(todo)
|
|
|
|
config = config_for(todo)
|
2022-05-07 20:08:51 +05:30
|
|
|
return false if config.empty?
|
|
|
|
|
|
|
|
config['Enabled'] == false
|
|
|
|
end
|
|
|
|
|
2022-10-11 01:57:18 +05:30
|
|
|
def grace_period?(todo)
|
|
|
|
config = config_for(todo)
|
|
|
|
|
|
|
|
GracefulFormatter.grace_period?(todo.cop_name, config)
|
|
|
|
end
|
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
def configure_and_validate_todo(todo)
|
|
|
|
todo.previously_disabled = previously_disabled?(todo)
|
|
|
|
todo.grace_period = grace_period?(todo)
|
|
|
|
|
|
|
|
if todo.previously_disabled && todo.grace_period
|
|
|
|
raise "#{todo.cop_name}: Cop must be enabled to use `#{GracefulFormatter.grace_period_key_value}`."
|
|
|
|
end
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
todo.generate?
|
2022-10-11 01:57:18 +05:30
|
|
|
end
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
def load_config_inspect_todo_dir
|
2022-05-07 20:08:51 +05:30
|
|
|
@todo_dir.list_inspect.each_with_object({}) do |path, combined|
|
|
|
|
config = YAML.load_file(path)
|
|
|
|
combined.update(config) if Hash === config
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# Load YAML configuration from `.rubocop_todo.yml`.
|
|
|
|
# We consider this file already old, obsolete, and to be removed soon.
|
2022-07-23 23:45:48 +05:30
|
|
|
def load_config_old_todo_yml
|
2022-05-07 20:08:51 +05:30
|
|
|
path = File.expand_path(File.join(directory, '../.rubocop_todo.yml'))
|
|
|
|
config = YAML.load_file(path) if File.exist?(path)
|
|
|
|
|
|
|
|
config || {}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|