2014-09-02 18:07:02 +05:30
|
|
|
require "spec_helper"
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe ProjectWiki do
|
2018-10-15 14:42:47 +05:30
|
|
|
let(:project) { create(:project, :wiki_repo) }
|
2014-09-02 18:07:02 +05:30
|
|
|
let(:repository) { project.repository }
|
|
|
|
let(:user) { project.owner }
|
|
|
|
let(:gitlab_shell) { Gitlab::Shell.new }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project_wiki) { described_class.new(project, user) }
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:raw_repository) { Gitlab::Git::Repository.new(project.repository_storage, subject.disk_path + '.git', 'foo') }
|
2014-09-02 18:07:02 +05:30
|
|
|
|
|
|
|
subject { project_wiki }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it { is_expected.to delegate_method(:empty?).to :pages }
|
2018-10-15 14:42:47 +05:30
|
|
|
it { is_expected.to delegate_method(:repository_storage).to :project }
|
2018-03-17 18:26:18 +05:30
|
|
|
it { is_expected.to delegate_method(:hashed_storage?).to :project }
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-27 19:54:05 +05:30
|
|
|
describe "#full_path" do
|
2014-09-02 18:07:02 +05:30
|
|
|
it "returns the project path with namespace with the .wiki extension" do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(subject.full_path).to eq(project.full_path + '.wiki')
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the same value as #full_path' do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(subject.full_path).to eq(subject.full_path)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
describe '#web_url' do
|
|
|
|
it 'returns the full web URL to the wiki' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(subject.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.full_path}/wikis/home")
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
describe "#url_to_repo" do
|
|
|
|
it "returns the correct ssh url to the repo" do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(subject.url_to_repo).to eq(gitlab_shell.url_to_repo(subject.full_path))
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#ssh_url_to_repo" do
|
|
|
|
it "equals #url_to_repo" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(subject.ssh_url_to_repo).to eq(subject.url_to_repo)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#http_url_to_repo" do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create :project }
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'returns the full http url to the repo' do
|
|
|
|
expected_url = "#{Gitlab.config.gitlab.url}/#{subject.full_path}.git"
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(project_wiki.http_url_to_repo).to eq(expected_url)
|
|
|
|
expect(project_wiki.http_url_to_repo).not_to include('@')
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-01-19 16:12:03 +05:30
|
|
|
describe "#wiki_base_path" do
|
|
|
|
it "returns the wiki base path" do
|
2017-09-10 17:25:29 +05:30
|
|
|
wiki_base_path = "#{Gitlab.config.gitlab.relative_url_root}/#{project.full_path}/wikis"
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2016-01-19 16:12:03 +05:30
|
|
|
expect(subject.wiki_base_path).to eq(wiki_base_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
describe "#wiki" do
|
2018-03-17 18:26:18 +05:30
|
|
|
it "contains a Gitlab::Git::Wiki instance" do
|
|
|
|
expect(subject.wiki).to be_a Gitlab::Git::Wiki
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "creates a new wiki repo if one does not yet exist" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(project_wiki.create_page("index", "test content")).to be_truthy
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "raises CouldNotCreateWikiError if it can't create the wiki repository" do
|
2018-03-17 18:26:18 +05:30
|
|
|
# Create a fresh project which will not have a wiki
|
|
|
|
project_wiki = described_class.new(create(:project), user)
|
|
|
|
gitlab_shell = double(:gitlab_shell)
|
2018-05-09 12:01:36 +05:30
|
|
|
allow(gitlab_shell).to receive(:create_repository)
|
2018-03-17 18:26:18 +05:30
|
|
|
allow(project_wiki).to receive(:gitlab_shell).and_return(gitlab_shell)
|
|
|
|
|
|
|
|
expect { project_wiki.send(:wiki) }.to raise_exception(ProjectWiki::CouldNotCreateWikiError)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#empty?" do
|
|
|
|
context "when the wiki repository is empty" do
|
2015-04-26 12:48:37 +05:30
|
|
|
describe '#empty?' do
|
|
|
|
subject { super().empty? }
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context "when the wiki has pages" do
|
|
|
|
before do
|
2015-04-26 12:48:37 +05:30
|
|
|
project_wiki.create_page("index", "This is an awesome new Gollum Wiki")
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
describe '#empty?' do
|
|
|
|
subject { super().empty? }
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#pages" do
|
|
|
|
before do
|
|
|
|
create_page("index", "This is an awesome new Gollum Wiki")
|
|
|
|
@pages = subject.pages
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
|
|
|
destroy_page(@pages.first.page)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an array of WikiPage instances" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(@pages.first).to be_a WikiPage
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "returns the correct number of pages" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(@pages.count).to eq(1)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#find_page" do
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_examples 'finding a wiki page' do
|
|
|
|
before do
|
|
|
|
create_page("index page", "This is an awesome Gollum Wiki")
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
after do
|
|
|
|
subject.pages.each { |page| destroy_page(page.page) }
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "returns the latest version of the page if it exists" do
|
|
|
|
page = subject.find_page("index page")
|
|
|
|
expect(page.title).to eq("index page")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil if the page does not exist" do
|
|
|
|
expect(subject.find_page("non-existant")).to eq(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "can find a page by slug" do
|
|
|
|
page = subject.find_page("index-page")
|
|
|
|
expect(page.title).to eq("index page")
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "returns a WikiPage instance" do
|
|
|
|
page = subject.find_page("index page")
|
|
|
|
expect(page).to be_a WikiPage
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'pages with multibyte-character title' do
|
|
|
|
before do
|
|
|
|
create_page("autre pagé", "C'est un génial Gollum Wiki")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "can find a page by slug" do
|
|
|
|
page = subject.find_page("autre pagé")
|
|
|
|
expect(page.title).to eq("autre pagé")
|
|
|
|
end
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
context 'pages with invalidly-encoded content' do
|
|
|
|
before do
|
|
|
|
create_page("encoding is fun", "f\xFCr".b)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "can find the page" do
|
|
|
|
page = subject.find_page("encoding is fun")
|
|
|
|
expect(page.content).to eq("fr")
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when Gitaly wiki_find_page is enabled' do
|
|
|
|
it_behaves_like 'finding a wiki page'
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when Gitaly wiki_find_page is disabled', :skip_gitaly_mock do
|
|
|
|
it_behaves_like 'finding a wiki page'
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#find_file' do
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_examples 'finding a wiki file' do
|
2018-05-09 12:01:36 +05:30
|
|
|
let(:image) { File.open(Rails.root.join('spec', 'fixtures', 'big-image.png')) }
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
|
|
|
subject.wiki # Make sure the wiki repo exists
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
BareRepoOperations.new(subject.repository.path_to_repo).commit_file(image, 'image.png')
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'returns the latest version of the file if it exists' do
|
|
|
|
file = subject.find_file('image.png')
|
|
|
|
expect(file.mime_type).to eq('image/png')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil if the page does not exist' do
|
|
|
|
expect(subject.find_file('non-existant')).to eq(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a Gitlab::Git::WikiFile instance' do
|
|
|
|
file = subject.find_file('image.png')
|
|
|
|
expect(file).to be_a Gitlab::Git::WikiFile
|
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'returns the whole file' do
|
|
|
|
file = subject.find_file('image.png')
|
|
|
|
image.rewind
|
|
|
|
|
|
|
|
expect(file.raw_data.b).to eq(image.read.b)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when Gitaly wiki_find_file is enabled' do
|
|
|
|
it_behaves_like 'finding a wiki file'
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when Gitaly wiki_find_file is disabled', :skip_gitaly_mock do
|
|
|
|
it_behaves_like 'finding a wiki file'
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#create_page" do
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_examples 'creating a wiki page' do
|
|
|
|
after do
|
|
|
|
destroy_page(subject.pages.first.page)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "creates a new wiki page" do
|
|
|
|
expect(subject.create_page("test page", "this is content")).not_to eq(false)
|
|
|
|
expect(subject.pages.count).to eq(1)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "returns false when a duplicate page exists" do
|
|
|
|
subject.create_page("test page", "content")
|
|
|
|
expect(subject.create_page("test page", "content")).to eq(false)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "stores an error message when a duplicate page exists" do
|
|
|
|
2.times { subject.create_page("test page", "content") }
|
|
|
|
expect(subject.error_message).to match(/Duplicate page:/)
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "sets the correct commit message" do
|
|
|
|
subject.create_page("test page", "some content", :markdown, "commit message")
|
|
|
|
expect(subject.pages.first.page.version.message).to eq("commit message")
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'updates project activity' do
|
|
|
|
subject.create_page('Test Page', 'This is content')
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
project.reload
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
|
|
|
|
expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when Gitaly wiki_write_page is enabled' do
|
|
|
|
it_behaves_like 'creating a wiki page'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when Gitaly wiki_write_page is disabled', :skip_gitaly_mock do
|
|
|
|
it_behaves_like 'creating a wiki page'
|
2015-11-26 14:37:03 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "#update_page" do
|
|
|
|
before do
|
|
|
|
create_page("update-page", "some content")
|
2018-03-17 18:26:18 +05:30
|
|
|
@gitlab_git_wiki_page = subject.wiki.page(title: "update-page")
|
2017-09-10 17:25:29 +05:30
|
|
|
subject.update_page(
|
2018-03-17 18:26:18 +05:30
|
|
|
@gitlab_git_wiki_page,
|
2017-09-10 17:25:29 +05:30
|
|
|
content: "some other content",
|
|
|
|
format: :markdown,
|
|
|
|
message: "updated page"
|
|
|
|
)
|
2014-09-02 18:07:02 +05:30
|
|
|
@page = subject.pages.first.page
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
|
|
|
destroy_page(@page)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "updates the content of the page" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(@page.raw_data).to eq("some other content")
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "sets the correct commit message" do
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(@page.version.message).to eq("updated page")
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
|
|
|
it 'updates project activity' do
|
2017-09-10 17:25:29 +05:30
|
|
|
subject.update_page(
|
2018-03-17 18:26:18 +05:30
|
|
|
@gitlab_git_wiki_page,
|
2017-09-10 17:25:29 +05:30
|
|
|
content: 'Yet more content',
|
|
|
|
format: :markdown,
|
|
|
|
message: 'Updated page again'
|
|
|
|
)
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
project.reload
|
|
|
|
|
|
|
|
expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
|
|
|
|
expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
|
2015-11-26 14:37:03 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "#delete_page" do
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_examples 'deleting a wiki page' do
|
|
|
|
before do
|
|
|
|
create_page("index", "some content")
|
|
|
|
@page = subject.wiki.page(title: "index")
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it "deletes the page" do
|
|
|
|
subject.delete_page(@page)
|
|
|
|
expect(subject.pages.count).to eq(0)
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'updates project activity' do
|
|
|
|
subject.delete_page(@page)
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
project.reload
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(project.last_activity_at).to be_within(1.minute).of(Time.now)
|
|
|
|
expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.now)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when Gitaly wiki_delete_page is enabled' do
|
|
|
|
it_behaves_like 'deleting a wiki page'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when Gitaly wiki_delete_page is disabled', :skip_gitaly_mock do
|
|
|
|
it_behaves_like 'deleting a wiki page'
|
2015-11-26 14:37:03 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
describe '#create_repo!' do
|
2018-10-15 14:42:47 +05:30
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'creates a repository' do
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(raw_repository.exists?).to eq(false)
|
2016-06-02 11:05:42 +05:30
|
|
|
expect(subject.repository).to receive(:after_create)
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
subject.send(:create_repo!, raw_repository)
|
|
|
|
|
|
|
|
expect(raw_repository.exists?).to eq(true)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe '#ensure_repository' do
|
2018-10-15 14:42:47 +05:30
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'creates the repository if it not exist' do
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(raw_repository.exists?).to eq(false)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(subject).to receive(:create_repo!).and_call_original
|
2017-09-10 17:25:29 +05:30
|
|
|
subject.ensure_repository
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
expect(raw_repository.exists?).to eq(true)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create the repository if it exists' do
|
2018-03-17 18:26:18 +05:30
|
|
|
subject.wiki
|
|
|
|
expect(raw_repository.exists?).to eq(true)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
expect(subject).not_to receive(:create_repo!)
|
|
|
|
|
|
|
|
subject.ensure_repository
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-16 23:09:34 +05:30
|
|
|
describe '#hook_attrs' do
|
|
|
|
it 'returns a hash with values' do
|
|
|
|
expect(subject.hook_attrs).to be_a Hash
|
|
|
|
expect(subject.hook_attrs.keys).to contain_exactly(:web_url, :git_ssh_url, :git_http_url, :path_with_namespace, :default_branch)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
private
|
|
|
|
|
|
|
|
def create_temp_repo(path)
|
|
|
|
FileUtils.mkdir_p path
|
2015-11-26 14:37:03 +05:30
|
|
|
system(*%W(#{Gitlab.config.git.bin_path} init --quiet --bare -- #{path}))
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def remove_temp_repo(path)
|
|
|
|
FileUtils.rm_rf path
|
|
|
|
end
|
|
|
|
|
|
|
|
def commit_details
|
2018-10-15 14:42:47 +05:30
|
|
|
Gitlab::Git::Wiki::CommitDetails.new(user.id, user.username, user.name, user.email, "test commit")
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def create_page(name, content)
|
|
|
|
subject.wiki.write_page(name, :markdown, content, commit_details)
|
|
|
|
end
|
|
|
|
|
|
|
|
def destroy_page(page)
|
2018-03-17 18:26:18 +05:30
|
|
|
subject.delete_page(page, "test commit")
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|