2019-12-26 22:10:19 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
require 'fast_spec_helper'
|
2017-09-10 17:25:29 +05:30
|
|
|
require_relative '../../../../rubocop/cop/migration/hash_index'
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
RSpec.describe RuboCop::Cop::Migration::HashIndex do
|
2017-09-10 17:25:29 +05:30
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
context 'when in migration' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
allow(cop).to receive(:in_migration?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers an offense when creating a hash index' do
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
def change
|
|
|
|
add_index :table, :column, using: :hash
|
|
|
|
^^^^^^^^^^^^ hash indexes should be avoided at all costs[...]
|
|
|
|
end
|
|
|
|
RUBY
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers an offense when creating a concurrent hash index' do
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
def change
|
|
|
|
add_concurrent_index :table, :column, using: :hash
|
|
|
|
^^^^^^^^^^^^ hash indexes should be avoided at all costs[...]
|
|
|
|
end
|
|
|
|
RUBY
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers an offense when creating a hash index using t.index' do
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_offense(<<~RUBY)
|
|
|
|
def change
|
|
|
|
t.index :table, :column, using: :hash
|
|
|
|
^^^^^^^^^^^^ hash indexes should be avoided at all costs[...]
|
|
|
|
end
|
|
|
|
RUBY
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
context 'when outside of migration' do
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'registers no offense' do
|
2021-04-17 20:07:23 +05:30
|
|
|
expect_no_offenses('def change; index :table, :column, using: :hash; end')
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|