2021-11-18 22:05:49 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
# Mock Types
|
|
|
|
MockGoogleOAuth2Credentials = Struct.new(:app_id, :app_secret)
|
|
|
|
|
2021-11-18 22:05:49 +05:30
|
|
|
RSpec.describe Projects::GoogleCloudController do
|
|
|
|
let_it_be(:project) { create(:project, :public) }
|
|
|
|
|
2022-05-07 20:08:51 +05:30
|
|
|
describe 'GET index', :snowplow do
|
2021-11-18 22:05:49 +05:30
|
|
|
let_it_be(:url) { "#{project_google_cloud_index_path(project)}" }
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when a public request is made' do
|
|
|
|
it 'returns not found' do
|
|
|
|
get url
|
2021-11-18 22:05:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2022-05-07 20:08:51 +05:30
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'admin_project_google_cloud!',
|
|
|
|
label: 'access_denied',
|
|
|
|
property: 'invalid_user',
|
|
|
|
project: project,
|
|
|
|
user: nil)
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
|
|
|
end
|
2021-11-18 22:05:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when a project.guest makes request' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
it 'returns not found' do
|
|
|
|
project.add_guest(user)
|
2021-11-18 22:05:49 +05:30
|
|
|
sign_in(user)
|
2021-12-11 22:18:48 +05:30
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2022-05-07 20:08:51 +05:30
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'admin_project_google_cloud!',
|
|
|
|
label: 'access_denied',
|
|
|
|
property: 'invalid_user',
|
|
|
|
project: project,
|
|
|
|
user: user
|
|
|
|
)
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
2021-11-18 22:05:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when project.developer makes request' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
it 'returns not found' do
|
|
|
|
project.add_developer(user)
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2022-05-07 20:08:51 +05:30
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'admin_project_google_cloud!',
|
|
|
|
label: 'access_denied',
|
|
|
|
property: 'invalid_user',
|
|
|
|
project: project,
|
|
|
|
user: user
|
|
|
|
)
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when project.maintainer makes request' do
|
2021-11-18 22:05:49 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
it 'returns successful' do
|
|
|
|
project.add_maintainer(user)
|
2021-11-18 22:05:49 +05:30
|
|
|
sign_in(user)
|
2021-12-11 22:18:48 +05:30
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to be_successful
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
2021-11-18 22:05:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when project.creator makes request' do
|
|
|
|
let(:user) { project.creator }
|
|
|
|
|
|
|
|
it 'returns successful' do
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to be_successful
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
describe 'when authorized user makes request' do
|
|
|
|
let(:user) { project.creator }
|
|
|
|
|
|
|
|
context 'but gitlab instance is not configured for google oauth2' do
|
2022-05-07 20:08:51 +05:30
|
|
|
it 'returns forbidden' do
|
2021-12-11 22:18:48 +05:30
|
|
|
unconfigured_google_oauth2 = MockGoogleOAuth2Credentials.new('', '')
|
|
|
|
allow(Gitlab::Auth::OAuth::Provider).to receive(:config_for)
|
|
|
|
.with('google_oauth2')
|
|
|
|
.and_return(unconfigured_google_oauth2)
|
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
2022-05-07 20:08:51 +05:30
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'google_oauth2_enabled!',
|
|
|
|
label: 'access_denied',
|
|
|
|
extra: { reason: 'google_oauth2_not_configured',
|
|
|
|
config: unconfigured_google_oauth2 },
|
|
|
|
project: project,
|
|
|
|
user: user
|
|
|
|
)
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'but feature flag is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(incubation_5mp_google_cloud: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns not found' do
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2022-05-07 20:08:51 +05:30
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'feature_flag_enabled!',
|
|
|
|
label: 'access_denied',
|
|
|
|
property: 'feature_flag_not_enabled',
|
|
|
|
project: project,
|
|
|
|
user: user
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'but google oauth2 token is not valid' do
|
|
|
|
it 'does not return revoke oauth url' do
|
|
|
|
allow_next_instance_of(GoogleApi::CloudPlatform::Client) do |client|
|
|
|
|
allow(client).to receive(:validate_token).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get url
|
|
|
|
|
|
|
|
expect(response).to be_successful
|
|
|
|
expect_snowplow_event(
|
|
|
|
category: 'Projects::GoogleCloud',
|
|
|
|
action: 'google_cloud#index',
|
|
|
|
label: 'index',
|
|
|
|
extra: {
|
|
|
|
screen: 'home',
|
|
|
|
serviceAccounts: [],
|
|
|
|
createServiceAccountUrl: project_google_cloud_service_accounts_path(project),
|
|
|
|
enableCloudRunUrl: project_google_cloud_deployments_cloud_run_path(project),
|
|
|
|
enableCloudStorageUrl: project_google_cloud_deployments_cloud_storage_path(project),
|
|
|
|
emptyIllustrationUrl: ActionController::Base.helpers.image_path('illustrations/pipelines_empty.svg'),
|
|
|
|
configureGcpRegionsUrl: project_google_cloud_gcp_regions_path(project),
|
|
|
|
gcpRegions: [],
|
|
|
|
revokeOauthUrl: nil
|
|
|
|
},
|
|
|
|
project: project,
|
|
|
|
user: user
|
|
|
|
)
|
2021-12-11 22:18:48 +05:30
|
|
|
end
|
2021-11-18 22:05:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|