2017-08-17 22:00:37 +05:30
|
|
|
# Frontend Development Guidelines
|
|
|
|
|
|
|
|
|
|
This document describes various guidelines to ensure consistency and quality
|
|
|
|
|
across GitLab's frontend team.
|
|
|
|
|
|
|
|
|
|
## Overview
|
|
|
|
|
|
|
|
|
|
GitLab is built on top of [Ruby on Rails][rails] using [Haml][haml] with
|
|
|
|
|
[Hamlit][hamlit]. Be wary of [the limitations that come with using
|
|
|
|
|
Hamlit][hamlit-limits]. We also use [SCSS][scss] and plain JavaScript with
|
|
|
|
|
modern ECMAScript standards supported through [Babel][babel] and ES module
|
|
|
|
|
support through [webpack][webpack].
|
|
|
|
|
|
|
|
|
|
We also utilize [webpack][webpack] to handle the bundling, minification, and
|
|
|
|
|
compression of our assets.
|
|
|
|
|
|
|
|
|
|
Working with our frontend assets requires Node (v4.3 or greater) and Yarn
|
|
|
|
|
(v0.17 or greater). You can find information on how to install these on our
|
|
|
|
|
[installation guide][install].
|
|
|
|
|
|
|
|
|
|
[jQuery][jquery] is used throughout the application's JavaScript, with
|
|
|
|
|
[Vue.js][vue] for particularly advanced, dynamic elements.
|
|
|
|
|
|
2018-03-27 19:54:05 +05:30
|
|
|
We also use [Axios][axios] to handle all of our network requests.
|
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
### Browser Support
|
|
|
|
|
|
|
|
|
|
For our currently-supported browsers, see our [requirements][requirements].
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## Development Process
|
|
|
|
|
|
|
|
|
|
### Share your work early
|
|
|
|
|
1. Before writing code guarantee your vision of the architecture is aligned with
|
|
|
|
|
GitLab's architecture.
|
|
|
|
|
1. Add a diagram to the issue and ask a Frontend Architecture about it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1. Don't take more than one week between starting work on a feature and
|
|
|
|
|
sharing a Merge Request with a reviewer or a maintainer.
|
|
|
|
|
|
|
|
|
|
### Vue features
|
|
|
|
|
1. Follow the steps in [Vue.js Best Practices](vue.md)
|
|
|
|
|
1. Follow the style guide.
|
|
|
|
|
1. Only a handful of people are allowed to merge Vue related features.
|
|
|
|
|
Reach out to one of Vue experts early in this process.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Architecture](architecture.md)
|
|
|
|
|
How we go about making fundamental design decisions in GitLab's frontend team
|
|
|
|
|
or make changes to our frontend development guidelines.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
## [Testing](../testing_guide/frontend_testing.md)
|
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
How we write frontend tests, run the GitLab test suite, and debug test related
|
|
|
|
|
issues.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Design Patterns](design_patterns.md)
|
|
|
|
|
Common JavaScript design patterns in GitLab's codebase.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Vue.js Best Practices](vue.md)
|
|
|
|
|
Vue specific design patterns and practices.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
## [Axios](axios.md)
|
|
|
|
|
Axios specific practices and gotchas.
|
|
|
|
|
|
|
|
|
|
## [Icons](icons.md)
|
|
|
|
|
How we use SVG for our Icons.
|
|
|
|
|
|
2018-03-27 19:54:05 +05:30
|
|
|
## [Components](components.md)
|
|
|
|
|
|
|
|
|
|
How we use UI components.
|
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
---
|
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
## Style Guides
|
|
|
|
|
|
|
|
|
|
### [JavaScript Style Guide](style_guide_js.md)
|
|
|
|
|
|
|
|
|
|
We use eslint to enforce our JavaScript style guides. Our guide is based on
|
|
|
|
|
the excellent [Airbnb][airbnb-js-style-guide] style guide with a few small
|
|
|
|
|
changes.
|
|
|
|
|
|
|
|
|
|
### [SCSS Style Guide](style_guide_scss.md)
|
|
|
|
|
|
|
|
|
|
Our SCSS conventions which are enforced through [scss-lint][scss-lint].
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Performance](performance.md)
|
|
|
|
|
Best practices for monitoring and maximizing frontend performance.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Security](security.md)
|
|
|
|
|
Frontend security practices.
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [Accessibility](accessibility.md)
|
|
|
|
|
Our accessibility standards and resources.
|
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
## [Internationalization (i18n) and Translations](../i18n/externalization.md)
|
|
|
|
|
Frontend internationalization support is described in [this document](../i18n/).
|
|
|
|
|
The [externalization part of the guide](../i18n/externalization.md) explains the helpers/methods available.
|
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
|
[rails]: http://rubyonrails.org/
|
|
|
|
|
[haml]: http://haml.info/
|
|
|
|
|
[hamlit]: https://github.com/k0kubun/hamlit
|
|
|
|
|
[hamlit-limits]: https://github.com/k0kubun/hamlit/blob/master/REFERENCE.md#limitations
|
|
|
|
|
[scss]: http://sass-lang.com/
|
|
|
|
|
[babel]: https://babeljs.io/
|
|
|
|
|
[webpack]: https://webpack.js.org/
|
|
|
|
|
[jquery]: https://jquery.com/
|
|
|
|
|
[vue]: http://vuejs.org/
|
2018-03-27 19:54:05 +05:30
|
|
|
[axios]: https://github.com/axios/axios
|
2017-08-17 22:00:37 +05:30
|
|
|
[airbnb-js-style-guide]: https://github.com/airbnb/javascript
|
|
|
|
|
[scss-lint]: https://github.com/brigade/scss-lint
|
|
|
|
|
[install]: ../../install/installation.md#4-node
|
|
|
|
|
[requirements]: ../../install/requirements.md#supported-web-browsers
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
## [DropLab](droplab/droplab.md)
|
|
|
|
|
Our internal `DropLab` dropdown library.
|
|
|
|
|
|
|
|
|
|
* [DropLab](droplab/droplab.md)
|
|
|
|
|
* [Ajax plugin](droplab/plugins/ajax.md)
|
|
|
|
|
* [Filter plugin](droplab/plugins/filter.md)
|
|
|
|
|
* [InputSetter plugin](droplab/plugins/input_setter.md)
|
