debian-mirror-gitlab/spec/requests/api/todos_spec.rb

415 lines
16 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2016-08-24 12:49:21 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe API::Todos do
2021-08-04 16:29:09 +05:30
include DesignManagementTestHelpers
2020-04-22 19:07:51 +05:30
let_it_be(:group) { create(:group) }
let_it_be(:project_1) { create(:project, :repository, group: group) }
let_it_be(:project_2) { create(:project) }
let_it_be(:author_1) { create(:user) }
let_it_be(:author_2) { create(:user) }
let_it_be(:john_doe) { create(:user, username: 'john_doe') }
2021-08-04 16:29:09 +05:30
let_it_be(:issue) { create(:issue, project: project_1) }
2020-04-22 19:07:51 +05:30
let_it_be(:merge_request) { create(:merge_request, source_project: project_1) }
2021-12-11 22:18:48 +05:30
let_it_be(:alert) { create(:alert_management_alert, project: project_1) }
let_it_be(:alert_todo) { create(:todo, project: project_1, author: john_doe, user: john_doe, target: alert) }
2020-04-22 19:07:51 +05:30
let_it_be(:merge_request_todo) { create(:todo, project: project_1, author: author_2, user: john_doe, target: merge_request) }
2021-08-04 16:29:09 +05:30
let_it_be(:pending_1) { create(:todo, :mentioned, project: project_1, author: author_1, user: john_doe, target: issue) }
let_it_be(:pending_2) { create(:todo, project: project_2, author: author_2, user: john_doe, target: issue) }
2020-04-22 19:07:51 +05:30
let_it_be(:pending_3) { create(:on_commit_todo, project: project_1, author: author_2, user: john_doe) }
2021-08-04 16:29:09 +05:30
let_it_be(:pending_4) { create(:on_commit_todo, project: project_1, author: author_2, user: john_doe, commit_id: 'invalid_id') }
let_it_be(:done) { create(:todo, :done, project: project_1, author: author_1, user: john_doe, target: issue) }
2020-04-22 19:07:51 +05:30
let_it_be(:award_emoji_1) { create(:award_emoji, awardable: merge_request, user: author_1, name: 'thumbsup') }
let_it_be(:award_emoji_2) { create(:award_emoji, awardable: pending_1.target, user: author_1, name: 'thumbsup') }
let_it_be(:award_emoji_3) { create(:award_emoji, awardable: pending_2.target, user: author_2, name: 'thumbsdown') }
before_all do
2018-03-17 18:26:18 +05:30
project_1.add_developer(john_doe)
project_2.add_developer(john_doe)
2016-08-24 12:49:21 +05:30
end
describe 'GET /todos' do
context 'when unauthenticated' do
it 'returns authentication error' do
get api('/todos')
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2016-08-24 12:49:21 +05:30
end
end
context 'when authenticated' do
2020-11-24 15:15:51 +05:30
context 'when invalid params' do
context "invalid action" do
it 'returns 400' do
get api('/todos', john_doe), params: { action: 'InvalidAction' }
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context "invalid state" do
it 'returns 400' do
get api('/todos', john_doe), params: { state: 'InvalidState' }
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context "invalid type" do
it 'returns 400' do
get api('/todos', john_doe), params: { type: 'InvalidType' }
expect(response).to have_gitlab_http_status(:bad_request)
end
end
end
2016-08-24 12:49:21 +05:30
it 'returns an array of pending todos for current user' do
get api('/todos', john_doe)
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
2021-12-11 22:18:48 +05:30
expect(json_response.length).to eq(5)
2016-08-24 12:49:21 +05:30
expect(json_response[0]['id']).to eq(pending_3.id)
expect(json_response[0]['project']).to be_a Hash
expect(json_response[0]['author']).to be_a Hash
expect(json_response[0]['target_type']).to be_present
expect(json_response[0]['target']).to be_a Hash
expect(json_response[0]['target_url']).to be_present
expect(json_response[0]['body']).to be_present
expect(json_response[0]['state']).to eq('pending')
expect(json_response[0]['action_name']).to eq('assigned')
expect(json_response[0]['created_at']).to be_present
2019-07-07 11:18:12 +05:30
expect(json_response[0]['target_type']).to eq('Commit')
expect(json_response[1]['target_type']).to eq('Issue')
2021-08-04 16:29:09 +05:30
expect(json_response[1]['target']['upvotes']).to eq(1)
2019-07-07 11:18:12 +05:30
expect(json_response[1]['target']['downvotes']).to eq(1)
expect(json_response[1]['target']['merge_requests_count']).to eq(0)
expect(json_response[2]['target_type']).to eq('Issue')
expect(json_response[2]['target']['upvotes']).to eq(1)
2021-08-04 16:29:09 +05:30
expect(json_response[2]['target']['downvotes']).to eq(1)
2019-07-07 11:18:12 +05:30
expect(json_response[2]['target']['merge_requests_count']).to eq(0)
expect(json_response[3]['target_type']).to eq('MergeRequest')
# Only issues get a merge request count at the moment
expect(json_response[3]['target']['merge_requests_count']).to be_nil
expect(json_response[3]['target']['upvotes']).to eq(1)
expect(json_response[3]['target']['downvotes']).to eq(0)
2021-12-11 22:18:48 +05:30
expect(json_response[4]['target_type']).to eq('AlertManagement::Alert')
expect(json_response[4]['target']['iid']).to eq(alert.iid)
expect(json_response[4]['target']['title']).to eq(alert.title)
2016-08-24 12:49:21 +05:30
end
2021-08-04 16:29:09 +05:30
context "when current user does not have access to one of the TODO's target" do
it 'filters out unauthorized todos' do
no_access_project = create(:project, :repository, group: group)
no_access_merge_request = create(:merge_request, source_project: no_access_project)
no_access_todo = create(:todo, project: no_access_project, author: author_2, user: john_doe, target: no_access_merge_request)
get api('/todos', john_doe)
2021-12-11 22:18:48 +05:30
expect(json_response.count).to eq(5)
2021-08-04 16:29:09 +05:30
expect(json_response.map { |t| t['id'] }).not_to include(no_access_todo.id, pending_4.id)
end
end
2016-08-24 12:49:21 +05:30
context 'and using the author filter' do
it 'filters based on author_id param' do
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { author_id: author_2.id }
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
2019-07-07 11:18:12 +05:30
expect(json_response.length).to eq(3)
2016-08-24 12:49:21 +05:30
end
end
context 'and using the type filter' do
it 'filters based on type param' do
create(:todo, project: project_1, author: author_2, user: john_doe, target: merge_request)
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { type: 'MergeRequest' }
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
2019-07-07 11:18:12 +05:30
expect(json_response.length).to eq(2)
2016-08-24 12:49:21 +05:30
end
end
context 'and using the state filter' do
it 'filters based on state param' do
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { state: 'done' }
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
expect(json_response.length).to eq(1)
end
end
context 'and using the project filter' do
it 'filters based on project_id param' do
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { project_id: project_2.id }
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
expect(json_response.length).to eq(1)
end
end
2018-11-18 11:00:15 +05:30
context 'and using the group filter' do
it 'filters based on project_id param' do
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { group_id: group.id, sort: :target_id }
2018-11-18 11:00:15 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-11-18 11:00:15 +05:30
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
2021-12-11 22:18:48 +05:30
expect(json_response.length).to eq(4)
2018-11-18 11:00:15 +05:30
end
end
2016-08-24 12:49:21 +05:30
context 'and using the action filter' do
it 'filters based on action param' do
2019-02-15 15:39:39 +05:30
get api('/todos', john_doe), params: { action: 'mentioned' }
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
2016-08-24 12:49:21 +05:30
expect(json_response).to be_an Array
expect(json_response.length).to eq(1)
end
end
end
2019-07-07 11:18:12 +05:30
it 'avoids N+1 queries', :request_store do
2021-08-04 16:29:09 +05:30
create_issue_todo_for(john_doe)
2019-07-07 11:18:12 +05:30
create(:todo, project: project_1, author: author_2, user: john_doe, target: merge_request)
get api('/todos', john_doe)
2021-08-04 16:29:09 +05:30
control1 = ActiveRecord::QueryRecorder.new { get api('/todos', john_doe) }
create_issue_todo_for(john_doe)
create_mr_todo_for(john_doe, project_2)
create(:todo, :mentioned, project: project_1, author: author_1, user: john_doe, target: merge_request)
new_todo = create_mr_todo_for(john_doe)
merge_request_3 = create(:merge_request, :jira_branch, source_project: new_todo.project)
create(:on_commit_todo, project: new_todo.project, author: author_1, user: john_doe, target: merge_request_3)
create(:todo, project: new_todo.project, author: author_2, user: john_doe, target: merge_request_3)
2019-07-07 11:18:12 +05:30
2021-08-04 16:29:09 +05:30
expect { get api('/todos', john_doe) }.not_to exceed_query_limit(control1).with_threshold(4)
control2 = ActiveRecord::QueryRecorder.new { get api('/todos', john_doe) }
2019-07-07 11:18:12 +05:30
2021-08-04 16:29:09 +05:30
create_issue_todo_for(john_doe)
create_issue_todo_for(john_doe, project_1)
create_issue_todo_for(john_doe, project_1)
# Additional query only when target belongs to project from different group
expect { get api('/todos', john_doe) }.not_to exceed_query_limit(control2).with_threshold(1)
2019-07-07 11:18:12 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-07-07 11:18:12 +05:30
end
2020-05-24 23:13:21 +05:30
context 'when there is a Design Todo' do
let!(:design_todo) { create_todo_for_mentioned_in_design }
def create_todo_for_mentioned_in_design
issue = create(:issue, project: project_1)
create(:todo, :mentioned,
user: john_doe,
project: project_1,
target: create(:design, issue: issue),
author: create(:user),
note: create(:note, project: project_1, note: "I am note, hear me roar"))
end
def api_request
get api('/todos', john_doe)
end
before do
2021-08-04 16:29:09 +05:30
enable_design_management
2020-05-24 23:13:21 +05:30
api_request
end
specify do
expect(response).to have_gitlab_http_status(:ok)
end
it 'avoids N+1 queries', :request_store do
control = ActiveRecord::QueryRecorder.new { api_request }
create_todo_for_mentioned_in_design
expect { api_request }.not_to exceed_query_limit(control)
end
it 'includes the Design Todo in the response' do
expect(json_response).to include(
a_hash_including('id' => design_todo.id)
)
end
end
2021-08-04 16:29:09 +05:30
def create_mr_todo_for(user, project = nil)
new_project = project || create(:project, group: create(:group))
new_project.add_developer(user) if project.blank?
new_merge_request = create(:merge_request, source_project: new_project)
create(:todo, project: new_project, author: user, user: user, target: new_merge_request)
end
def create_issue_todo_for(user, project = nil)
new_project = project || create(:project, group: create(:group))
new_project.group.add_developer(user) if project.blank?
issue = create(:issue, project: new_project)
create(:todo, project: new_project, target: issue, author: user, user: user)
end
2016-08-24 12:49:21 +05:30
end
2017-08-17 22:00:37 +05:30
describe 'POST /todos/:id/mark_as_done' do
2016-08-24 12:49:21 +05:30
context 'when unauthenticated' do
it 'returns authentication error' do
2017-08-17 22:00:37 +05:30
post api("/todos/#{pending_1.id}/mark_as_done")
2016-08-24 12:49:21 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2016-08-24 12:49:21 +05:30
end
end
context 'when authenticated' do
it 'marks a todo as done' do
2017-08-17 22:00:37 +05:30
post api("/todos/#{pending_1.id}/mark_as_done", john_doe)
2016-08-24 12:49:21 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2017-08-17 22:00:37 +05:30
expect(json_response['id']).to eq(pending_1.id)
expect(json_response['state']).to eq('done')
2016-08-24 12:49:21 +05:30
expect(pending_1.reload).to be_done
end
2016-09-13 17:45:13 +05:30
it 'updates todos cache' do
expect_any_instance_of(User).to receive(:update_todos_count_cache).and_call_original
2017-08-17 22:00:37 +05:30
post api("/todos/#{pending_1.id}/mark_as_done", john_doe)
2016-09-13 17:45:13 +05:30
end
2018-03-17 18:26:18 +05:30
it 'returns 404 if the todo does not belong to the current user' do
post api("/todos/#{pending_1.id}/mark_as_done", author_1)
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-03-17 18:26:18 +05:30
end
2016-08-24 12:49:21 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'POST /mark_as_done' do
2016-08-24 12:49:21 +05:30
context 'when unauthenticated' do
it 'returns authentication error' do
2017-08-17 22:00:37 +05:30
post api('/todos/mark_as_done')
2016-08-24 12:49:21 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2016-08-24 12:49:21 +05:30
end
end
context 'when authenticated' do
it 'marks all todos as done' do
2017-08-17 22:00:37 +05:30
post api('/todos/mark_as_done', john_doe)
2016-08-24 12:49:21 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:no_content)
2016-08-24 12:49:21 +05:30
expect(pending_1.reload).to be_done
expect(pending_2.reload).to be_done
expect(pending_3.reload).to be_done
end
2016-09-13 17:45:13 +05:30
it 'updates todos cache' do
expect_any_instance_of(User).to receive(:update_todos_count_cache).and_call_original
2017-08-17 22:00:37 +05:30
post api("/todos/mark_as_done", john_doe)
2016-09-13 17:45:13 +05:30
end
2016-08-24 12:49:21 +05:30
end
end
shared_examples 'an issuable' do |issuable_type|
it 'creates a todo on an issuable' do
2017-08-17 22:00:37 +05:30
post api("/projects/#{project_1.id}/#{issuable_type}/#{issuable.iid}/todo", john_doe)
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:created)
2016-08-24 12:49:21 +05:30
expect(json_response['project']).to be_a Hash
expect(json_response['author']).to be_a Hash
expect(json_response['target_type']).to eq(issuable.class.name)
expect(json_response['target']).to be_a Hash
expect(json_response['target_url']).to be_present
expect(json_response['body']).to be_present
expect(json_response['state']).to eq('pending')
expect(json_response['action_name']).to eq('marked')
expect(json_response['created_at']).to be_present
2020-05-24 23:13:21 +05:30
expect(json_response['updated_at']).to be_present
2016-08-24 12:49:21 +05:30
end
it 'returns 304 there already exist a todo on that issuable' do
2021-03-08 18:12:59 +05:30
stub_feature_flags(multiple_todos: false)
2016-08-24 12:49:21 +05:30
create(:todo, project: project_1, author: author_1, user: john_doe, target: issuable)
2017-08-17 22:00:37 +05:30
post api("/projects/#{project_1.id}/#{issuable_type}/#{issuable.iid}/todo", john_doe)
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:not_modified)
2016-08-24 12:49:21 +05:30
end
it 'returns 404 if the issuable is not found' do
2020-04-22 19:07:51 +05:30
unknown_id = 0
post api("/projects/#{project_1.id}/#{issuable_type}/#{unknown_id}/todo", john_doe)
2016-08-24 12:49:21 +05:30
2020-04-22 19:07:51 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2016-08-24 12:49:21 +05:30
end
2017-08-17 22:00:37 +05:30
it 'returns an error if the issuable is not accessible' do
guest = create(:user)
2018-03-17 18:26:18 +05:30
project_1.add_guest(guest)
2017-08-17 22:00:37 +05:30
post api("/projects/#{project_1.id}/#{issuable_type}/#{issuable.iid}/todo", guest)
if issuable_type == 'merge_requests'
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2017-08-17 22:00:37 +05:30
else
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
2016-08-24 12:49:21 +05:30
end
2022-01-26 12:08:38 +05:30
describe 'POST :id/issuable_type/:issuable_id/todo' do
2016-08-24 12:49:21 +05:30
context 'for an issue' do
2021-12-07 22:27:20 +05:30
let_it_be(:issuable) do
create(:issue, :confidential, project: project_1)
end
it_behaves_like 'an issuable', 'issues'
it 'returns an error if the issue author does not have access' do
post api("/projects/#{project_1.id}/issues/#{issuable.iid}/todo", issuable.author)
expect(response).to have_gitlab_http_status(:not_found)
2016-08-24 12:49:21 +05:30
end
end
context 'for a merge request' do
2021-12-07 22:27:20 +05:30
let_it_be(:issuable) do
create(:merge_request, :simple, source_project: project_1)
end
it_behaves_like 'an issuable', 'merge_requests'
it 'returns an error if the merge request author does not have access' do
project_1.add_guest(issuable.author)
post api("/projects/#{project_1.id}/merge_requests/#{issuable.iid}/todo", issuable.author)
expect(response).to have_gitlab_http_status(:forbidden)
2016-08-24 12:49:21 +05:30
end
end
end
end