debian-mirror-gitlab/spec/lib/gitlab/auth/ldap/access_spec.rb

187 lines
4.8 KiB
Ruby
Raw Normal View History

2015-04-26 12:48:37 +05:30
require 'spec_helper'
2018-03-27 19:54:05 +05:30
describe Gitlab::Auth::LDAP::Access do
2018-05-09 12:01:36 +05:30
include LdapHelpers
2017-09-10 17:25:29 +05:30
let(:access) { described_class.new user }
2015-04-26 12:48:37 +05:30
let(:user) { create(:omniauth_user) }
2017-09-10 17:25:29 +05:30
describe '.allowed?' do
it 'updates the users `last_credential_check_at' do
expect(access).to receive(:allowed?) { true }
expect(described_class).to receive(:open).and_yield(access)
expect { described_class.allowed?(user) }
.to change { user.last_credential_check_at }
end
end
2016-08-24 12:49:21 +05:30
describe '#allowed?' do
2015-04-26 12:48:37 +05:30
subject { access.allowed? }
context 'when the user cannot be found' do
2015-09-11 14:41:01 +05:30
before do
2018-03-27 19:54:05 +05:30
allow(Gitlab::Auth::LDAP::Person).to receive(:find_by_dn).and_return(nil)
2015-09-11 14:41:01 +05:30
end
2015-04-26 12:48:37 +05:30
it { is_expected.to be_falsey }
2017-08-17 22:00:37 +05:30
it 'blocks user in GitLab' do
expect(access).to receive(:block_user).with(user, 'does not exist anymore')
2015-12-23 02:04:40 +05:30
access.allowed?
end
2015-04-26 12:48:37 +05:30
end
context 'when the user is found' do
2018-05-09 12:01:36 +05:30
let(:ldap_user) { Gitlab::Auth::LDAP::Person.new(Net::LDAP::Entry.new, 'ldapmain') }
2015-09-11 14:41:01 +05:30
before do
2018-05-09 12:01:36 +05:30
allow(Gitlab::Auth::LDAP::Person).to receive(:find_by_dn).and_return(ldap_user)
2015-09-11 14:41:01 +05:30
end
2015-04-26 12:48:37 +05:30
2015-09-11 14:41:01 +05:30
context 'and the user is disabled via active directory' do
before do
2018-03-27 19:54:05 +05:30
allow(Gitlab::Auth::LDAP::Person).to receive(:disabled_via_active_directory?).and_return(true)
2015-09-11 14:41:01 +05:30
end
2015-04-26 12:48:37 +05:30
it { is_expected.to be_falsey }
2016-06-02 11:05:42 +05:30
it 'blocks user in GitLab' do
2017-08-17 22:00:37 +05:30
expect(access).to receive(:block_user).with(user, 'is disabled in Active Directory')
2015-04-26 12:48:37 +05:30
access.allowed?
end
end
context 'and has no disabled flag in active diretory' do
before do
2018-03-27 19:54:05 +05:30
allow(Gitlab::Auth::LDAP::Person).to receive(:disabled_via_active_directory?).and_return(false)
2015-04-26 12:48:37 +05:30
end
it { is_expected.to be_truthy }
2015-09-11 14:41:01 +05:30
context 'when auto-created users are blocked' do
before do
user.block
2015-09-11 14:41:01 +05:30
end
it 'does not unblock user in GitLab' do
2017-08-17 22:00:37 +05:30
expect(access).not_to receive(:unblock_user)
2015-09-11 14:41:01 +05:30
access.allowed?
2017-08-17 22:00:37 +05:30
2015-09-11 14:41:01 +05:30
expect(user).to be_blocked
expect(user).not_to be_ldap_blocked # this block is handled by omniauth not by our internal logic
2015-09-11 14:41:01 +05:30
end
end
context 'when auto-created users are not blocked' do
2015-09-11 14:41:01 +05:30
before do
user.ldap_block
2015-09-11 14:41:01 +05:30
end
2016-09-13 17:45:13 +05:30
it 'unblocks user in GitLab' do
2017-08-17 22:00:37 +05:30
expect(access).to receive(:unblock_user).with(user, 'is not disabled anymore')
2015-09-11 14:41:01 +05:30
access.allowed?
end
2015-04-26 12:48:37 +05:30
end
end
context 'without ActiveDirectory enabled' do
before do
2018-03-27 19:54:05 +05:30
allow(Gitlab::Auth::LDAP::Config).to receive(:enabled?).and_return(true)
allow_any_instance_of(Gitlab::Auth::LDAP::Config).to receive(:active_directory).and_return(false)
2015-04-26 12:48:37 +05:30
end
it { is_expected.to be_truthy }
2016-06-02 11:05:42 +05:30
context 'when user cannot be found' do
before do
2018-03-27 19:54:05 +05:30
allow(Gitlab::Auth::LDAP::Person).to receive(:find_by_dn).and_return(nil)
2016-06-02 11:05:42 +05:30
end
it { is_expected.to be_falsey }
it 'blocks user in GitLab' do
2017-08-17 22:00:37 +05:30
expect(access).to receive(:block_user).with(user, 'does not exist anymore')
2016-06-02 11:05:42 +05:30
access.allowed?
end
end
context 'when user was previously ldap_blocked' do
before do
user.ldap_block
end
it 'unblocks the user if it exists' do
2017-08-17 22:00:37 +05:30
expect(access).to receive(:unblock_user).with(user, 'is available again')
2016-06-02 11:05:42 +05:30
access.allowed?
end
end
2015-04-26 12:48:37 +05:30
end
end
2018-05-09 12:01:36 +05:30
context 'when the connection fails' do
before do
raise_ldap_connection_error
end
it 'does not block the user' do
access.allowed?
expect(user.ldap_blocked?).to be_falsey
end
it 'denies access' do
expect(access.allowed?).to be_falsey
end
end
2015-04-26 12:48:37 +05:30
end
2017-08-17 22:00:37 +05:30
describe '#block_user' do
before do
user.activate
allow(Gitlab::AppLogger).to receive(:info)
access.block_user user, 'reason'
end
it 'blocks the user' do
expect(user).to be_blocked
expect(user).to be_ldap_blocked
end
it 'logs the reason' do
expect(Gitlab::AppLogger).to have_received(:info).with(
"LDAP account \"123456\" reason, " \
"blocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
end
describe '#unblock_user' do
before do
user.ldap_block
allow(Gitlab::AppLogger).to receive(:info)
access.unblock_user user, 'reason'
end
it 'activates the user' do
expect(user).not_to be_blocked
expect(user).not_to be_ldap_blocked
end
it 'logs the reason' do
Gitlab::AppLogger.info(
"LDAP account \"123456\" reason, " \
"unblocking Gitlab user \"#{user.name}\" (#{user.email})"
)
end
end
2015-04-26 12:48:37 +05:30
end