2016-01-14 18:37:52 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe Banzai::Filter::MilestoneReferenceFilter do
|
2016-01-14 18:37:52 +05:30
|
|
|
include FilterSpecHelper
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:group) { create(:group, :public) }
|
|
|
|
let(:project) { create(:project, :public, group: group) }
|
2016-01-14 18:37:52 +05:30
|
|
|
|
|
|
|
it 'requires project context' do
|
|
|
|
expect { described_class.call('') }.to raise_error(ArgumentError, /:project/)
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'reference parsing' do
|
|
|
|
%w(pre code a style).each do |elem|
|
|
|
|
it "ignores valid references contained inside '#{elem}' element" do
|
|
|
|
exp = act = "<#{elem}>milestone #{reference}</#{elem}>"
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'includes default classes' do
|
|
|
|
doc = reference_filter("Milestone #{reference}")
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('class')).to eq 'gfm gfm-milestone has-tooltip'
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'includes a data-project attribute' do
|
|
|
|
doc = reference_filter("Milestone #{reference}")
|
|
|
|
link = doc.css('a').first
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).to have_attribute('data-project')
|
|
|
|
expect(link.attr('data-project')).to eq project.id.to_s
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'includes a data-milestone attribute' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
link = doc.css('a').first
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).to have_attribute('data-milestone')
|
|
|
|
expect(link.attr('data-milestone')).to eq milestone.id.to_s
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'supports an :only_path context' do
|
|
|
|
doc = reference_filter("Milestone #{reference}", only_path: true)
|
|
|
|
link = doc.css('a').first.attr('href')
|
2016-01-14 18:37:52 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).not_to match %r(https?://)
|
|
|
|
expect(link).to eq urls.milestone_path(milestone)
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'Integer-based references' do
|
2016-01-14 18:37:52 +05:30
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls.milestone_url(milestone)
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
2016-06-02 11:05:42 +05:30
|
|
|
doc = reference_filter("Milestone (#{reference}.)")
|
|
|
|
expect(doc.to_html).to match(%r(\(<a.+>#{milestone.name}</a>\.\)))
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'ignores invalid milestone IIDs' do
|
|
|
|
exp = act = "Milestone #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'String-based single-word references' do
|
2016-06-02 11:05:42 +05:30
|
|
|
let(:reference) { "#{Milestone.reference_prefix}#{milestone.name}" }
|
2016-01-14 18:37:52 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
milestone.update!(name: 'gfm')
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls.milestone_url(milestone)
|
2016-06-02 11:05:42 +05:30
|
|
|
expect(doc.text).to eq 'See gfm'
|
|
|
|
end
|
2016-01-14 18:37:52 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Milestone (#{reference}.)")
|
|
|
|
expect(doc.to_html).to match(%r(\(<a.+>#{milestone.name}</a>\.\)))
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'ignores invalid milestone names' do
|
|
|
|
exp = act = "Milestone #{Milestone.reference_prefix}#{milestone.name.reverse}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'String-based multi-word references in quotes' do
|
2016-06-02 11:05:42 +05:30
|
|
|
let(:reference) { milestone.to_reference(format: :name) }
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
milestone.update!(name: 'gfm references')
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls.milestone_url(milestone)
|
2016-06-02 11:05:42 +05:30
|
|
|
expect(doc.text).to eq 'See gfm references'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Milestone (#{reference}.)")
|
|
|
|
expect(doc.to_html).to match(%r(\(<a.+>#{milestone.name}</a>\.\)))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid milestone names' do
|
|
|
|
exp = act = %(Milestone #{Milestone.reference_prefix}"#{milestone.name.reverse}")
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'referencing a milestone in a link href' do
|
|
|
|
let(:unquoted_reference) { "#{Milestone.reference_prefix}#{milestone.name}" }
|
|
|
|
let(:link_reference) { %Q{<a href="#{unquoted_reference}">Milestone</a>} }
|
|
|
|
|
|
|
|
before do
|
|
|
|
milestone.update!(name: 'gfm')
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
2017-09-10 17:25:29 +05:30
|
|
|
doc = reference_filter("See #{link_reference}")
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls.milestone_url(milestone)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
2017-09-10 17:25:29 +05:30
|
|
|
doc = reference_filter("Milestone (#{link_reference}.)")
|
2016-06-02 11:05:42 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<a.+>Milestone</a>\.\)))
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-project attribute' do
|
2017-09-10 17:25:29 +05:30
|
|
|
doc = reference_filter("Milestone #{link_reference}")
|
2016-01-14 18:37:52 +05:30
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-project')
|
|
|
|
expect(link.attr('data-project')).to eq project.id.to_s
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-milestone attribute' do
|
2017-09-10 17:25:29 +05:30
|
|
|
doc = reference_filter("See #{link_reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-milestone')
|
|
|
|
expect(link.attr('data-milestone')).to eq milestone.id.to_s
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'linking to a milestone as the entire link' do
|
|
|
|
let(:unquoted_reference) { "#{Milestone.reference_prefix}#{milestone.name}" }
|
|
|
|
let(:link) { urls.milestone_url(milestone) }
|
|
|
|
let(:link_reference) { %Q{<a href="#{link}">#{link}</a>} }
|
|
|
|
|
|
|
|
it 'replaces the link text with the milestone reference' do
|
|
|
|
doc = reference_filter("See #{link}")
|
|
|
|
|
|
|
|
expect(doc.css('a').first.text).to eq(unquoted_reference)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-project attribute' do
|
|
|
|
doc = reference_filter("Milestone #{link_reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-project')
|
|
|
|
expect(link.attr('data-project')).to eq project.id.to_s
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-milestone attribute' do
|
|
|
|
doc = reference_filter("See #{link_reference}")
|
2016-01-14 18:37:52 +05:30
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-milestone')
|
|
|
|
expect(link.attr('data-milestone')).to eq milestone.id.to_s
|
|
|
|
end
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'cross-project / cross-namespace complete reference' do
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:namespace) { create(:namespace) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:another_project) { create(:project, :public, namespace: namespace) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:milestone) { create(:milestone, project: another_project) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{another_project.full_path}%#{milestone.iid}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'points to referenced project milestone page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_milestone_url(another_project, milestone)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'link has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq("#{milestone.name} in #{another_project.full_path}")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.text)
|
|
|
|
.to eq("See (#{milestone.name} in #{another_project.full_path}.)")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'escapes the name attribute' do
|
|
|
|
allow_any_instance_of(Milestone).to receive(:title).and_return(%{"></a>whatever<a title="})
|
|
|
|
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq "#{milestone.name} in #{another_project.full_path}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'cross-project / same-namespace complete reference' do
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:namespace) { create(:namespace) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: namespace) }
|
|
|
|
let(:another_project) { create(:project, :public, namespace: namespace) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:milestone) { create(:milestone, project: another_project) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{another_project.full_path}%#{milestone.iid}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
it 'points to referenced project milestone page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_milestone_url(another_project, milestone)
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'link has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq("#{milestone.name} in #{another_project.path}")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.text)
|
|
|
|
.to eq("See (#{milestone.name} in #{another_project.path}.)")
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'escapes the name attribute' do
|
|
|
|
allow_any_instance_of(Milestone).to receive(:title).and_return(%{"></a>whatever<a title="})
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq "#{milestone.name} in #{another_project.path}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
shared_examples 'cross project shorthand reference' do
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:namespace) { create(:namespace) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: namespace) }
|
|
|
|
let(:another_project) { create(:project, :public, namespace: namespace) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:milestone) { create(:milestone, project: another_project) }
|
|
|
|
let(:reference) { "#{another_project.path}%#{milestone.iid}" }
|
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
|
|
|
|
|
|
|
it 'points to referenced project milestone page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_milestone_url(another_project, milestone)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'link has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq("#{milestone.name} in #{another_project.path}")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
doc = reference_filter("See (#{reference}.)")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.text)
|
|
|
|
.to eq("See (#{milestone.name} in #{another_project.path}.)")
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'escapes the name attribute' do
|
|
|
|
allow_any_instance_of(Milestone).to receive(:title).and_return(%{"></a>whatever<a title="})
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
doc = reference_filter("See #{reference}")
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.text)
|
|
|
|
.to eq "#{milestone.name} in #{another_project.path}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_context 'project milestones' do
|
|
|
|
let(:reference) { milestone.to_reference(format: :iid) }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
include_examples 'reference parsing'
|
|
|
|
|
|
|
|
it_behaves_like 'Integer-based references'
|
|
|
|
it_behaves_like 'String-based single-word references'
|
|
|
|
it_behaves_like 'String-based multi-word references in quotes'
|
|
|
|
it_behaves_like 'referencing a milestone in a link href'
|
|
|
|
it_behaves_like 'cross-project / cross-namespace complete reference'
|
|
|
|
it_behaves_like 'cross-project / same-namespace complete reference'
|
|
|
|
it_behaves_like 'cross project shorthand reference'
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
shared_context 'group milestones' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { milestone.to_reference(format: :name) }
|
|
|
|
|
|
|
|
include_examples 'reference parsing'
|
|
|
|
|
|
|
|
it_behaves_like 'String-based single-word references'
|
|
|
|
it_behaves_like 'String-based multi-word references in quotes'
|
|
|
|
it_behaves_like 'referencing a milestone in a link href'
|
|
|
|
|
|
|
|
it 'does not support references by IID' do
|
|
|
|
doc = reference_filter("See #{Milestone.reference_prefix}#{milestone.iid}")
|
|
|
|
|
|
|
|
expect(doc.css('a')).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not support references by link' do
|
|
|
|
doc = reference_filter("See #{urls.milestone_url(milestone)}")
|
|
|
|
|
|
|
|
expect(doc.css('a').first.text).to eq(urls.milestone_url(milestone))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not support cross-project references' do
|
|
|
|
another_group = create(:group)
|
|
|
|
another_project = create(:project, :public, group: group)
|
|
|
|
project_reference = another_project.to_reference(project)
|
|
|
|
|
|
|
|
milestone.update!(group: another_group)
|
|
|
|
|
|
|
|
doc = reference_filter("See #{project_reference}#{reference}")
|
|
|
|
|
|
|
|
expect(doc.css('a')).to be_empty
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context 'group context' do
|
2018-05-09 12:01:36 +05:30
|
|
|
let(:context) { { project: nil, group: create(:group) } }
|
|
|
|
let(:milestone) { create(:milestone, project: project) }
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'links to a valid reference' do
|
|
|
|
reference = "#{project.full_path}%#{milestone.iid}"
|
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
result = reference_filter("See #{reference}", context)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
expect(result.css('a').first.attr('href')).to eq(urls.milestone_url(milestone))
|
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'ignores internal references' do
|
|
|
|
exp = act = "See %#{milestone.iid}"
|
|
|
|
|
|
|
|
expect(reference_filter(act, context).to_html).to eq exp
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when milestone is open' do
|
|
|
|
context 'project milestones' do
|
|
|
|
let(:milestone) { create(:milestone, project: project) }
|
|
|
|
|
|
|
|
include_context 'project milestones'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'group milestones' do
|
|
|
|
let(:milestone) { create(:milestone, group: group) }
|
|
|
|
|
|
|
|
include_context 'group milestones'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when milestone is closed' do
|
|
|
|
context 'project milestones' do
|
|
|
|
let(:milestone) { create(:milestone, :closed, project: project) }
|
|
|
|
|
|
|
|
include_context 'project milestones'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'group milestones' do
|
|
|
|
let(:milestone) { create(:milestone, :closed, group: group) }
|
|
|
|
|
|
|
|
include_context 'group milestones'
|
|
|
|
end
|
|
|
|
end
|
2016-01-14 18:37:52 +05:30
|
|
|
end
|