debian-mirror-gitlab/spec/lib/gitlab/utils/override_spec.rb

239 lines
5.6 KiB
Ruby
Raw Normal View History

2019-12-04 20:38:33 +05:30
# frozen_string_literal: true
2018-11-08 19:23:39 +05:30
require 'fast_spec_helper'
2018-03-17 18:26:18 +05:30
describe Gitlab::Utils::Override do
2018-11-08 19:23:39 +05:30
let(:base) do
Struct.new(:good) do
def self.good
0
end
end
end
2018-03-17 18:26:18 +05:30
let(:derived) { Class.new(base).tap { |m| m.extend described_class } }
let(:extension) { Module.new.tap { |m| m.extend described_class } }
let(:prepending_class) { base.tap { |m| m.prepend extension } }
let(:including_class) { base.tap { |m| m.include extension } }
2018-11-08 19:23:39 +05:30
let(:prepending_class_methods) do
base.tap { |m| m.singleton_class.prepend extension }
end
let(:extending_class_methods) do
base.tap { |m| m.extend extension }
end
2018-03-17 18:26:18 +05:30
let(:klass) { subject }
2019-02-15 15:39:39 +05:30
def good(mod, bad_arity: false, negative_arity: false)
2018-03-17 18:26:18 +05:30
mod.module_eval do
override :good
2019-02-15 15:39:39 +05:30
if bad_arity
def good(num)
end
elsif negative_arity
def good(*args)
super.succ
end
else
def good
super.succ
end
2018-03-17 18:26:18 +05:30
end
end
mod
end
def bad(mod)
mod.module_eval do
override :bad
def bad
true
end
end
mod
end
shared_examples 'checking as intended' do
it 'checks ok for overriding method' do
good(subject)
2018-11-08 19:23:39 +05:30
result = instance.good
2018-03-17 18:26:18 +05:30
expect(result).to eq(1)
described_class.verify!
end
2019-02-15 15:39:39 +05:30
it 'checks ok for overriding method using negative arity' do
good(subject, negative_arity: true)
result = instance.good
expect(result).to eq(1)
described_class.verify!
end
2018-03-17 18:26:18 +05:30
it 'raises NotImplementedError when it is not overriding anything' do
expect do
bad(subject)
2018-11-08 19:23:39 +05:30
instance.bad
described_class.verify!
end.to raise_error(NotImplementedError)
end
2019-02-15 15:39:39 +05:30
it 'raises NotImplementedError when overriding a method with different arity' do
expect do
good(subject, bad_arity: true)
instance.good(1)
described_class.verify!
end.to raise_error(NotImplementedError)
end
2018-11-08 19:23:39 +05:30
end
shared_examples 'checking as intended, nothing was overridden' do
it 'raises NotImplementedError because it is not overriding it' do
expect do
good(subject)
instance.good
described_class.verify!
end.to raise_error(NotImplementedError)
end
it 'raises NotImplementedError when it is not overriding anything' do
expect do
bad(subject)
instance.bad
2018-03-17 18:26:18 +05:30
described_class.verify!
end.to raise_error(NotImplementedError)
end
end
shared_examples 'nothing happened' do
it 'does not complain when it is overriding something' do
good(subject)
2018-11-08 19:23:39 +05:30
result = instance.good
2018-03-17 18:26:18 +05:30
expect(result).to eq(1)
described_class.verify!
end
it 'does not complain when it is not overriding anything' do
bad(subject)
2018-11-08 19:23:39 +05:30
result = instance.bad
2018-03-17 18:26:18 +05:30
expect(result).to eq(true)
described_class.verify!
end
end
before do
# Make sure we're not touching the internal cache
allow(described_class).to receive(:extensions).and_return({})
end
describe '#override' do
2018-11-08 19:23:39 +05:30
context 'when instance is klass.new(0)' do
let(:instance) { klass.new(0) }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when STATIC_VERIFICATION is set' do
before do
stub_env('STATIC_VERIFICATION', 'true')
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when subject is a class' do
subject { derived }
it_behaves_like 'checking as intended'
end
context 'when subject is a module, and class is prepending it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { prepending_class }
it_behaves_like 'checking as intended'
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when subject is a module, and class is including it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { including_class }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
it_behaves_like 'checking as intended, nothing was overridden'
end
2018-03-17 18:26:18 +05:30
end
2018-11-08 19:23:39 +05:30
context 'when STATIC_VERIFICATION is not set' do
before do
stub_env('STATIC_VERIFICATION', nil)
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when subject is a class' do
subject { derived }
it_behaves_like 'nothing happened'
2018-03-17 18:26:18 +05:30
end
2018-11-08 19:23:39 +05:30
context 'when subject is a module, and class is prepending it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { prepending_class }
it_behaves_like 'nothing happened'
2018-03-17 18:26:18 +05:30
end
2018-11-08 19:23:39 +05:30
context 'when subject is a module, and class is including it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { including_class }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
it 'does not complain when it is overriding something' do
good(subject)
result = instance.good
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
expect(result).to eq(0)
described_class.verify!
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
it 'does not complain when it is not overriding anything' do
bad(subject)
result = instance.bad
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
expect(result).to eq(true)
described_class.verify!
end
end
end
2018-03-17 18:26:18 +05:30
end
2018-11-08 19:23:39 +05:30
context 'when instance is klass' do
let(:instance) { klass }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when STATIC_VERIFICATION is set' do
before do
stub_env('STATIC_VERIFICATION', 'true')
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when subject is a module, and class is prepending it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { prepending_class_methods }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
it_behaves_like 'checking as intended'
end
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
context 'when subject is a module, and class is extending it' do
subject { extension }
2019-12-21 20:55:43 +05:30
2018-11-08 19:23:39 +05:30
let(:klass) { extending_class_methods }
it_behaves_like 'checking as intended, nothing was overridden'
end
2018-03-17 18:26:18 +05:30
end
end
end
end